[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042879#comment-17042879
]
Jiayi Liao commented on FLINK-13702:
[~dwysakowicz] [~jark] [~lzljs3620320]
The error still exists
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964797#comment-16964797
]
Jark Wu commented on FLINK-13702:
-
Sounds good to me.
> BaseMapSerializerTest.testDuplicate fails on
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964662#comment-16964662
]
Jingsong Lee commented on FLINK-13702:
--
Hi [~dwysakowicz] [~jark], Let me summarize the current
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964639#comment-16964639
]
Jark Wu commented on FLINK-13702:
-
As discussed with [~lzljs3620320] offline, we will not have lazy
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964605#comment-16964605
]
Jingsong Lee commented on FLINK-13702:
--
[~dwysakowicz] yes, it depends on our CodeGen or runtime
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963982#comment-16963982
]
Dawid Wysakowicz commented on FLINK-13702:
--
I don't know exactly how the {{JoinedRow}} is used
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963955#comment-16963955
]
Jingsong Lee commented on FLINK-13702:
--
> There is one problem with entirely removing the
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963949#comment-16963949
]
Jark Wu commented on FLINK-13702:
-
Regarding removing serializer from BinaryGeneric entirely,
If we want
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963941#comment-16963941
]
Dawid Wysakowicz commented on FLINK-13702:
--
There is one problem with entirely removing the
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963903#comment-16963903
]
Jingsong Lee commented on FLINK-13702:
--
About BinaryGeneric:
I have considered pass type
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963897#comment-16963897
]
Jingsong Lee commented on FLINK-13702:
--
Hi [~dwysakowicz] , I think maybe we don't need to make it
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963894#comment-16963894
]
Jark Wu commented on FLINK-13702:
-
I thought about call {{duplicate}} too, but calling {{duplicate}} for
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963838#comment-16963838
]
Dawid Wysakowicz commented on FLINK-13702:
--
I agree the solution suggested by [~lzljs3620320]
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963812#comment-16963812
]
Jark Wu commented on FLINK-13702:
-
Thanks for the approach. I think it can solve the problem of
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963600#comment-16963600
]
Jingsong Lee commented on FLINK-13702:
--
Thanks [~jark] 's input. It's true that there are multiple
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963031#comment-16963031
]
Dawid Wysakowicz commented on FLINK-13702:
--
I agree with [~jark]. If we ever keep the
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962956#comment-16962956
]
Jark Wu commented on FLINK-13702:
-
Sorry didn't notice the discussion above.
Hi [~lzljs3620320], I
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962953#comment-16962953
]
Jark Wu commented on FLINK-13702:
-
Hi [~dwysakowicz], thanks for looking into this. However, I think
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962943#comment-16962943
]
Jingsong Lee commented on FLINK-13702:
--
I think this Jira is not production bug, it is a test bug.
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962940#comment-16962940
]
Jingsong Lee commented on FLINK-13702:
--
BinaryLazyFormat is designed for single threaded context.
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962936#comment-16962936
]
Dawid Wysakowicz commented on FLINK-13702:
--
What do you mean by ??invoke
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962929#comment-16962929
]
Jingsong Lee commented on FLINK-13702:
--
Thanks [~dwysakowicz], nice analysis, you are right.
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962906#comment-16962906
]
Dawid Wysakowicz commented on FLINK-13702:
--
I had a look at this issue and I think the problem
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907007#comment-16907007
]
Jingsong Lee commented on FLINK-13702:
--
Hi [~jark], TypeSerializer can be not thread safe. CC:
[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906807#comment-16906807
]
Jark Wu commented on FLINK-13702:
-
Could you have a look [~lzljs3620320]? It might because of
25 matches
Mail list logo
