trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589232955
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589168145
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589167127
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589140335
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588809789
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
trystanj commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora merged PR #686:
URL: https://github.com/apache/flink-kubernetes-operator/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369989166
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -332,30 +357,51 @@ protected Map>
1996fanrui commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369887876
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -332,30 +357,51 @@ protected Map>
gyfora commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1776897579
@1996fanrui @mxm I fixed a state store interface method naming error in
1996fanrui commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369811318
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,36 @@ private static
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369777698
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,36 @@ private static
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369776519
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,36 @@ private static
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369771533
##
flink-autoscaler/src/test/java/org/apache/flink/autoscaler/JobVertexScalerTest.java:
##
@@ -75,6 +75,7 @@ public void setup() {
@Test
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369770904
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,36 @@ private static
1996fanrui commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369706833
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,36 @@ private static
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368347405
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368345973
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,31 @@ private static
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368344860
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368342398
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -97,32 +99,30 @@ public CollectedMetricHistory
gyfora commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368341787
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -97,32 +99,30 @@ public CollectedMetricHistory
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365801223
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365800397
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365800397
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##
@@ -154,6 +153,56 @@ private Map
evaluateMetrics(
mxm commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1771297136
I missed that we could scale down again after making the right adjustment
using the observed rate. LGTM apart from the comments on the diffs.
--
This is an automated
gyfora commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1771263621
> If we catch up during the stabilization period, then there is no
overestimation of the true processing rate. I thought this change is to prevent
scenarios where we are
mxm commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1771258357
If we catch up during the stabilization period, then there is no
overestimation of the true processing rate. I thought this change is to prevent
scenarios where we are are
gyfora commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1771237467
> I don't know why we would start collecting already in the stabilization
period. That breaks the contract we have established. We can already collect
metrics during the
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365734089
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##
@@ -151,6 +151,31 @@ private static
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365724745
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -138,15 +138,19 @@ public CollectedMetricHistory
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365595263
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -97,32 +99,30 @@ public CollectedMetricHistory
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365609077
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -97,32 +99,30 @@ public CollectedMetricHistory
mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365558874
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##
@@ -97,32 +99,30 @@ public CollectedMetricHistory
gyfora commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1770625298
> Hi @gyfora , thanks for fix this issue.
>
> IIUC, the root cause of this problem is that Source Task has two threads:
>
> 1. Fetcher thread: fetch data from
1996fanrui commented on PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1770560740
Hi @gyfora , thanks for fix this issue.
IIUC, the root cause of this problem is that Source Task has two threads:
1. Fetcher thread: fetch data from external
38 matches
Mail list logo
