Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-214903475
Hi @dawidwys, thanks for the fast update. I'll have a look at the PR
tomorrow.
The JIRA for Table API outer joins is FLINK-2971. I'll assign it to you.
Thanks!
[
https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259045#comment-15259045
]
ASF GitHub Bot commented on FLINK-2946:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-2971:
-
Assignee: Dawid Wysakowicz
> Add outer joins to the Table API
>
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258912#comment-15258912
]
Konstantin Knauf commented on FLINK-3669:
-
[~aljoscha] Hmpf. You're right. I was actually a little
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1939#issuecomment-214922363
Thanks for the review @vasia. I addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/FLINK-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259202#comment-15259202
]
ASF GitHub Bot commented on FLINK-2828:
---
Github user fhueske commented on the pull request:
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1931
[FLINK-3741] [build] Replace maven-scala-plugin with newer
scala-maven-plugin
I've replaced the older {{maven-scala-plugin}} with the newer
{{scala-maven-plugin}} and ran 10 Travis builds. So
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1930#issuecomment-214694910
Thank @fhueske. Changes look good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1929#discussion_r61062846
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java
---
@@ -0,0 +1,279 @@
Chesnay Schepler created FLINK-3814:
---
Summary: Update code style guide regarding Preconditions
Key: FLINK-3814
URL: https://issues.apache.org/jira/browse/FLINK-3814
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-3809.
--
Resolution: Fixed
Fixed via 4a69f72a3fa3cfc17cdc473a0c45099416a0ecb8
> Missing break in
[
https://issues.apache.org/jira/browse/FLINK-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-3810.
--
Resolution: Fixed
Fixed via 55a88a4bffd5f2ebdae48e5d96d4e9663f0cabdc
> Missing break in
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214683701
I agree. Our terminology is a mess an should be cleaned up. Will do this as
part of my other refactorings.
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257815#comment-15257815
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214683500
Also, I think we should rename the task business classes to accurately
reflect what they are for. But this can be done once the rest of the state
reworking is in.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214683587
ð good to merge, then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257816#comment-15257816
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user aljoscha commented on the pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214686210
Yes, it was introduced to give detailed error message, which were helpful
in the past. We can certainly consolidate this.
---
If your project is set up for it, you can
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/1905#discussion_r61057258
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/pattern/Pattern.scala
---
@@ -0,0 +1,178 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-3756.
Resolution: Fixed
Fixed via 0cf04108f70375d41ebb7c39629db3a081bd2876
> Introduce state hierarchy
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1883
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257861#comment-15257861
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257883#comment-15257883
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257910#comment-15257910
]
ASF GitHub Bot commented on FLINK-3815:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1933
[FLINK-3815] - Replace Guava Preconditions usage in "flink-clients"
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Chesnay Schepler created FLINK-3817:
---
Summary: Remove unused Guava dependency from RocksDB StateBackend
Key: FLINK-3817
URL: https://issues.apache.org/jira/browse/FLINK-3817
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257920#comment-15257920
]
ASF GitHub Bot commented on FLINK-3809:
---
GitHub user zentol opened a pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214680362
I agree that this is duplicated code. As far as I can tell, this was
introduced in order to output different error messages in the savepoint restore
and the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214680409
Also, we'll still call `StateForTask` like that, even though it's more like
an operator state? And `KvStateForTasks` has the s at the end because it is
theoretically
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257802#comment-15257802
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257804#comment-15257804
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257819#comment-15257819
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257831#comment-15257831
]
ASF GitHub Bot commented on FLINK-3708:
---
Github user StefanRRichter commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257832#comment-15257832
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user uce commented on the pull request:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61065029
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/ReplicatingInputFormat.java
---
@@ -133,4 +133,18 @@ public RuntimeContext
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61064993
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/GenericDataSourceBase.java
---
@@ -210,10 +210,12 @@ public void
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1931#issuecomment-214714799
@zentol only `flink-ml` used the outdated `maven-scale-plugin`, no idea
why...
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257939#comment-15257939
]
ASF GitHub Bot commented on FLINK-3741:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257795#comment-15257795
]
ASF GitHub Bot commented on FLINK-3775:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-3775.
Resolution: Fixed
Fixed via 7abf8ef774f14d688213c41b6986ee64aba98740
> Flink Scala shell does not
[
https://issues.apache.org/jira/browse/FLINK-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257837#comment-15257837
]
Till Rohrmann commented on FLINK-3741:
--
I might have found a cure for the problem. I've replaced the
[
https://issues.apache.org/jira/browse/FLINK-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257838#comment-15257838
]
ASF GitHub Bot commented on FLINK-3708:
---
Github user StefanRRichter commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257907#comment-15257907
]
ASF GitHub Bot commented on FLINK-3815:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1932
[FLINK-3815] Replace Guava Preconditions usage in "flink-gelly"
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
[
https://issues.apache.org/jira/browse/FLINK-3818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257925#comment-15257925
]
ASF GitHub Bot commented on FLINK-3818:
---
GitHub user zentol opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257942#comment-15257942
]
ASF GitHub Bot commented on FLINK-3815:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1932#issuecomment-214715290
ð for merging. (I think you can merge all of your recently opened
Preconditions-related PRs right away)
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257793#comment-15257793
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257791#comment-15257791
]
ASF GitHub Bot commented on FLINK-3775:
---
Github user tillrohrmann commented on the pull request:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257953#comment-15257953
]
ASF GitHub Bot commented on FLINK-3809:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257835#comment-15257835
]
Till Rohrmann commented on FLINK-3212:
--
This time the test case
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1930#issuecomment-214696110
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257866#comment-15257866
]
ASF GitHub Bot commented on FLINK-3811:
---
Github user zentol commented on the pull request:
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1929#discussion_r61063235
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java
---
@@ -0,0 +1,279 @@
[
https://issues.apache.org/jira/browse/FLINK-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-3811.
---
Resolution: Fixed
Implemented in 172fcfa1e42f89ad7542d7ba6a88344800550640
> Refactor
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61064281
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java
---
@@ -84,16 +85,25 @@ public void testDataSourceTask() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61064423
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java
---
@@ -84,16 +85,25 @@ public void testDataSourceTask() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1929#discussion_r61065673
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java
---
@@ -0,0 +1,279 @@
Chesnay Schepler created FLINK-3816:
---
Summary: Replace Guava Preconditions usage in flink-clients
Key: FLINK-3816
URL: https://issues.apache.org/jira/browse/FLINK-3816
Project: Flink
Issue
Till Rohrmann created FLINK-3820:
Summary: ScalaShellITCase.testPreventRecreationBatch deadlocks on
Travis
Key: FLINK-3820
URL: https://issues.apache.org/jira/browse/FLINK-3820
Project: Flink
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214672764
Failing test is unrelated. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257769#comment-15257769
]
ASF GitHub Bot commented on FLINK-3756:
---
Github user tillrohrmann commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214678348
Unrelated, but shouldn't we consolidate the code in
`SavepointCoordinator.restoreSavepoint()` and
`CheckpointCoordiantor.restoreLatestCheckpointedState`?
---
If your
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1931#issuecomment-214697826
what about the other modules using scala; should we update them as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257876#comment-15257876
]
ASF GitHub Bot commented on FLINK-3741:
---
Github user zentol commented on the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61064734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -200,6 +209,7 @@ else if (!this.taskCanceled) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61064772
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -192,6 +194,13 @@ else if (!this.taskCanceled) {
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257885#comment-15257885
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257886#comment-15257886
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1934
[FLINK-3817] - Remove unused guava dependency from RocksDb backend
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
[
https://issues.apache.org/jira/browse/FLINK-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257912#comment-15257912
]
ASF GitHub Bot commented on FLINK-3817:
---
GitHub user zentol opened a pull request:
Chesnay Schepler created FLINK-3818:
---
Summary: Remove Guava dependency from flink-gelly-examples
Key: FLINK-3818
URL: https://issues.apache.org/jira/browse/FLINK-3818
Project: Flink
Issue
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1936
[FLINK-3818] Remove Guava dependency from flink-gelly-examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink guava_gelly_examples
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1937
[FLINK-3819] Replace Guava Preconditions usage in flink-gelly-scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Till Rohrmann created FLINK-3813:
Summary: YARNSessionFIFOITCase.testDetachedMode failed on Travis
Key: FLINK-3813
URL: https://issues.apache.org/jira/browse/FLINK-3813
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257881#comment-15257881
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257889#comment-15257889
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257888#comment-15257888
]
ASF GitHub Bot commented on FLINK-3777:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r61065095
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java
---
@@ -255,6 +268,18 @@ public Record readRecord(Record
[
https://issues.apache.org/jira/browse/FLINK-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reassigned FLINK-3810:
---
Assignee: Chesnay Schepler
> Missing break in
[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reassigned FLINK-3809:
---
Assignee: Chesnay Schepler
> Missing break in
Chesnay Schepler created FLINK-3819:
---
Summary: Replace Guava Preconditions usage in flink-gelly-scala
Key: FLINK-3819
URL: https://issues.apache.org/jira/browse/FLINK-3819
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257944#comment-15257944
]
ASF GitHub Bot commented on FLINK-3809:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1935#issuecomment-214715959
Good catch. Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-214883298
ok good to know @uce! Let me get back to it in a couple of weeks and make
it right, now it is a bit impossible to find time.
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258904#comment-15258904
]
ASF GitHub Bot commented on FLINK-3257:
---
Github user senorcarbone commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259486#comment-15259486
]
Austin Ouyang commented on FLINK-1284:
--
Hi [~till.rohrmann],
I've noticed that there's been low
[
https://issues.apache.org/jira/browse/FLINK-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259367#comment-15259367
]
GaoLun commented on FLINK-2220:
---
I wrote test for generictype and the problem still arose. The small fix PR
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1922#issuecomment-214720154
The changes look good to me. I realized we haven't documented graph
checksum in the Gelly guide. Could you please add it before merging? Thanks!
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257984#comment-15257984
]
Vasia Kalavri commented on FLINK-2254:
--
Hi [~ssaumitra],
there has been no activity on this issue for
[
https://issues.apache.org/jira/browse/FLINK-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258028#comment-15258028
]
ASF GitHub Bot commented on FLINK-3799:
---
Github user greghogan commented on the pull request:
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1900#issuecomment-214733082
Hi @greghogan,
I looked at the PR in more detail and I have some thoughts.
First, why do we need a `Translate` class and `Translator` interface? Can't
we simply
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258097#comment-15258097
]
Vasia Kalavri commented on FLINK-3618:
--
I agree. The sooner we make this change the better. Would any
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1938
[FLINK-3821] Reduce Guava usage in flink-java
Removes all Guava usages in non-test files.
-replaced CharSets with StandardCharsets
-added checkElementIndex() method to Flink
[
https://issues.apache.org/jira/browse/FLINK-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258032#comment-15258032
]
ASF GitHub Bot commented on FLINK-3771:
---
Github user vasia commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258076#comment-15258076
]
ASF GitHub Bot commented on FLINK-3771:
---
Github user greghogan commented on a diff in the pull
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1900#discussion_r61083553
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/translate/Translate.java
---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the
1 - 100 of 215 matches
Mail list logo