[jira] [Commented] (FLINK-4997) Extending Window Function Metadata

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691503#comment-15691503 ] ASF GitHub Bot commented on FLINK-4997: --- Github user aljoscha commented on the issue:

[jira] [Updated] (FLINK-5146) Improved resource cleanup in RocksDB keyed state backend

2016-11-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-5146: -- Priority: Blocker (was: Major) > Improved resource cleanup in RocksDB keyed state backend >

[GitHub] flink pull request #2629: [FLINK-4391] Provide support for asynchronous oper...

2016-11-23 Thread bjlovegithub
Github user bjlovegithub commented on a diff in the pull request: https://github.com/apache/flink/pull/2629#discussion_r89424283 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollector.java --- @@ -0,0 +1,103 @@ +/* + *

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691892#comment-15691892 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[GitHub] flink issue #2756: [FLINK-4997] Extending Window Function Metadata

2016-11-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2756 The changes look very good! 👍 I'll rebase on top of the recent changes that introduced new `fold()`/`reduce()` and will also reshuffle/squash the commits a bit to make the history

[jira] [Commented] (FLINK-1536) Graph partitioning operators for Gelly

2016-11-23 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691610#comment-15691610 ] Ivan Mushketyk commented on FLINK-1536: --- Oh, sorry, I didn't mean to type "bipartiate" word there :)

[jira] [Comment Edited] (FLINK-1536) Graph partitioning operators for Gelly

2016-11-23 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691610#comment-15691610 ] Ivan Mushketyk edited comment on FLINK-1536 at 11/23/16 11:11 PM: -- Oh,

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-23 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691858#comment-15691858 ] Liang Chen commented on FLINK-2646: --- Please go ahead, thanks. Sorry, i am a little busy recently. >

[GitHub] flink pull request #:

2016-11-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/commit/da53953e5366185567515d209fcc85d4006f7e8a#commitcomment-19948322 In flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java: In

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692081#comment-15692081 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[jira] [Closed] (FLINK-5000) Rename Methods in ManagedInitializationContext

2016-11-23 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-5000. --- Resolution: Fixed Fix Version/s: 1.2.0 Implemented in

[jira] [Commented] (FLINK-4541) Support for SQL NOT IN operator

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692468#comment-15692468 ] ASF GitHub Bot commented on FLINK-4541: --- Github user AlexanderShoshin commented on the issue:

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

2016-11-23 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Hi, Fabian. I've made all the corrections. One thing I didn't understand - are we going to allow the case of !joinCondition.isEqui in DataSetSingleRowCrossRule? I also

[GitHub] flink pull request #2629: [FLINK-4391] Provide support for asynchronous oper...

2016-11-23 Thread bjlovegithub
Github user bjlovegithub commented on a diff in the pull request: https://github.com/apache/flink/pull/2629#discussion_r89431529 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollectorBuffer.java --- @@ -0,0 +1,453 @@ +/*

[jira] [Closed] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-2608. - Resolution: Fixed Had to unarchive the 1.0.0 version temporarily because this had been

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r89282258 --- Diff: pom.xml --- @@ -93,7 +93,7 @@ under the License. 1C true log4j-test.properties - -Xms256m

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r89284243 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/pom.xml --- @@ -197,9 +196,7 @@ under the License.

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r89282667 --- Diff: pom.xml --- @@ -996,10 +996,9 @@ under the License. ${flink.reuseForks}

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r89284270 --- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml --- @@ -50,9 +49,7 @@ under the License.

[jira] [Commented] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689549#comment-15689549 ] ASF GitHub Bot commented on FLINK-2608: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2608: -- Fix Version/s: (was: 1.0.0) > Arrays.asList(..) does not work with

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689614#comment-15689614 ] ASF GitHub Bot commented on FLINK-5092: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689615#comment-15689615 ] ASF GitHub Bot commented on FLINK-5092: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689612#comment-15689612 ] ASF GitHub Bot commented on FLINK-5092: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689613#comment-15689613 ] ASF GitHub Bot commented on FLINK-5092: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689611#comment-15689611 ] ASF GitHub Bot commented on FLINK-5092: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2629: [FLINK-4391] Provide support for asynchronous oper...

2016-11-23 Thread bjlovegithub
Github user bjlovegithub commented on a diff in the pull request: https://github.com/apache/flink/pull/2629#discussion_r89289895 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollectorBuffer.java --- @@ -0,0 +1,453 @@ +/*

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689709#comment-15689709 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689706#comment-15689706 ] Kostas Kloudas commented on FLINK-2646: --- Can I take the issue? It seems inactive for the last year

[jira] [Commented] (FLINK-5143) Add EXISTS to list of supported operators

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689734#comment-15689734 ] ASF GitHub Bot commented on FLINK-5143: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #2853: [FLINK-5143] [table] Add EXISTS to list of support...

2016-11-23 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2853 [FLINK-5143] [table] Add EXISTS to list of supported operators Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[GitHub] flink pull request #2854: [typo] fix toString() of ContinuousEventTimeTrigge...

2016-11-23 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2854 [typo] fix toString() of ContinuousEventTimeTrigger You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink master Alternatively you can review

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689841#comment-15689841 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2553: [FLINK-4686] [table] Add possibility to get column names

2016-11-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2553 Thanks @wuchong. I think we can convert the modified ITCases to TableTestBase tests. I will try it and merge this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #2851: [FLINK-5124] [table] Support more temporal arithme...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689530#comment-15689530 ] ASF GitHub Bot commented on FLINK-2608: --- Github user mxm commented on the issue:

[jira] [Created] (FLINK-5142) Resource leak in CheckpointCoordinator

2016-11-23 Thread Frank Lauterwald (JIRA)
Frank Lauterwald created FLINK-5142: --- Summary: Resource leak in CheckpointCoordinator Key: FLINK-5142 URL: https://issues.apache.org/jira/browse/FLINK-5142 Project: Flink Issue Type: Bug

[GitHub] flink issue #2623: [FLINK-2608] Updated Twitter Chill version.

2016-11-23 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2623 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689629#comment-15689629 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689638#comment-15689638 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89283859 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689634#comment-15689634 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89283319 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89276062 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689633#comment-15689633 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689632#comment-15689632 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689635#comment-15689635 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689636#comment-15689636 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689640#comment-15689640 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689641#comment-15689641 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89275211 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89282863 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java ---

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689642#comment-15689642 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689631#comment-15689631 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689639#comment-15689639 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89275454 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java ---

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689637#comment-15689637 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689630#comment-15689630 ] ASF GitHub Bot commented on FLINK-4280: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89284541 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---

[jira] [Commented] (FLINK-4712) Implementing ranking predictions for ALS

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689765#comment-15689765 ] ASF GitHub Bot commented on FLINK-4712: --- Github user thvasilo commented on the issue:

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-23 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2838 Hello Gabor, I like the idea of having a RankingScore, it seems like having that hierarchy with Score, RankingScore and PairWiseScore gives us the flexibility we need to include ranking

[jira] [Updated] (FLINK-4941) Show ship strategy in web interface

2016-11-23 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4941: -- Fix Version/s: 1.2.0 > Show ship strategy in web interface >

[jira] [Commented] (FLINK-4941) Show ship strategy in web interface

2016-11-23 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689818#comment-15689818 ] Robert Metzger commented on FLINK-4941: --- This has been fixed for 1.2 in

[jira] [Commented] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689835#comment-15689835 ] ASF GitHub Bot commented on FLINK-5075: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2840: [FLINK-4832] Count/Sum 0 elements

2016-11-23 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/2840#discussion_r89277461 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -157,4 +161,41 @@ class

[jira] [Reopened] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-2608: --- > Arrays.asList(..) does not work with CollectionInputFormat >

[GitHub] flink pull request #2855: Add Tests in StateBackendTestBase that verify Defa...

2016-11-23 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2855 Add Tests in StateBackendTestBase that verify Default-Value Behaviour The tests were not checking whether all backends exhibit the same behaviour when it comes to default values. This changes none

[jira] [Commented] (FLINK-5126) Remove Checked Exceptions from State Interfaces

2016-11-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689800#comment-15689800 ] Stephan Ewen commented on FLINK-5126: - Not sure about that. They were added there for a purpose. Why

[jira] [Updated] (FLINK-5105) Improve ReduceState: value put into ReducingState should always be a copy

2016-11-23 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-5105: - Issue Type: Improvement (was: Bug) > Improve ReduceState: value put into ReducingState should

[GitHub] flink pull request #2623: [FLINK-2608] Updated Twitter Chill version.

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2629: [FLINK-4391] Provide support for asynchronous oper...

2016-11-23 Thread bjlovegithub
Github user bjlovegithub commented on a diff in the pull request: https://github.com/apache/flink/pull/2629#discussion_r89291235 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollectorBuffer.java --- @@ -0,0 +1,453 @@ +/*

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689724#comment-15689724 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689779#comment-15689779 ] Stephan Ewen commented on FLINK-2646: - [~kkl0u] Please go ahead! > Rich functions should provide a

[GitHub] flink issue #2854: [typo] fix toString() of ContinuousEventTimeTrigger

2016-11-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2854 +1, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-5142) Resource leak in CheckpointCoordinator

2016-11-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689792#comment-15689792 ] Stephan Ewen commented on FLINK-5142: - Thanks for reporting and diagnosing that. I'll have a look at

[GitHub] flink issue #2768: [FLINK-5023][FLINK-5024] Add SimpleStateDescriptor to cla...

2016-11-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2768 @shixiaogang Thanks for the swift update! The changes look very good now though I found one last thing that could be problematic. This is changing the behaviour of `FoldingState` when it comes to

[jira] [Assigned] (FLINK-5142) Resource leak in CheckpointCoordinator

2016-11-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-5142: --- Assignee: Stephan Ewen > Resource leak in CheckpointCoordinator >

[jira] [Commented] (FLINK-5128) Get Kafka partitions in FlinkKafkaProducer only if a partitioner is set

2016-11-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689796#comment-15689796 ] Stephan Ewen commented on FLINK-5128: - Sounds like a good idea, +1 > Get Kafka partitions in

[jira] [Commented] (FLINK-5023) Add get() method in State interface

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689795#comment-15689795 ] ASF GitHub Bot commented on FLINK-5023: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2822: [FLINK-5075] [kinesis] Make Kinesis consumer fail-proof t...

2016-11-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2822 Makes sense. +1 to this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Resolved] (FLINK-5124) Support more temporal arithmetic

2016-11-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-5124. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 4653ad388b05b3ba7e37982bb8af09e7fcbed6be.

[jira] [Commented] (FLINK-5124) Support more temporal arithmetic

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689458#comment-15689458 ] ASF GitHub Bot commented on FLINK-5124: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2732: [FLINK-4272] Create a JobClient for job control an...

2016-11-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2732#discussion_r89283731 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/JobClient.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689661#comment-15689661 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689751#comment-15689751 ] ASF GitHub Bot commented on FLINK-4391: --- Github user bjlovegithub commented on a diff in the pull

[GitHub] flink issue #2819: [FLINK-4961] [ml] SGD for Matrix Factorization (WIP)

2016-11-23 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2819 Hello @gaborhermann, I really like the idea of introducing a `MatrixFactorization` interface that we can then use for different specialized optimization algorithms. For the question I'm

[jira] [Created] (FLINK-5144) Error while applying rule AggregateJoinTransposeRule

2016-11-23 Thread Timo Walther (JIRA)
Timo Walther created FLINK-5144: --- Summary: Error while applying rule AggregateJoinTransposeRule Key: FLINK-5144 URL: https://issues.apache.org/jira/browse/FLINK-5144 Project: Flink Issue Type:

[GitHub] flink issue #2623: [FLINK-2608] Updated Twitter Chill version.

2016-11-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2623 @mxm @chermenin Can we please do a followup to this, given that it is already merged? The tests in `GroupReduceITCase` need to be replaced by proper targeted unit tests. Sorry

[jira] [Commented] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689820#comment-15689820 ] ASF GitHub Bot commented on FLINK-2608: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4272) Create a JobClient for job control and monitoring

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689598#comment-15689598 ] ASF GitHub Bot commented on FLINK-4272: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Created] (FLINK-5143) Add EXISTS to list of supported operators

2016-11-23 Thread Timo Walther (JIRA)
Timo Walther created FLINK-5143: --- Summary: Add EXISTS to list of supported operators Key: FLINK-5143 URL: https://issues.apache.org/jira/browse/FLINK-5143 Project: Flink Issue Type: Bug

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89275697 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-11-23 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @mxm Thank you for review. I ran into some issues with collecting coverage data. I am going to do additional tests and come back to you. --- If your project is set up for it, you can reply

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89284524 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89274682 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java ---

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89276937 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka010Fetcher.java ---

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89274555 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka010ITCase.java --- @@ -131,6

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689628#comment-15689628 ] ASF GitHub Bot commented on FLINK-5092: --- Github user BorisOsipov commented on the issue:

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89150327 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka010FetcherTest.java --- @@

[GitHub] flink pull request #2509: [FLINK-4280][kafka-connector] Explicit start posit...

2016-11-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2509#discussion_r89275431 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka09ITCase.java --- @@ -110,6

  1   2   3   4   >