[
https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895624#comment-15895624
]
ASF GitHub Bot commented on FLINK-5824:
---
Github user shijinkui commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895620#comment-15895620
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on the issue:
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3470
@fhueske sounds great. I updated the PR. Please take a look. I have add
non-retractable and retractable aggregates for MIN and MAX. And add a flag
parameter via
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2767
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895631#comment-15895631
]
ASF GitHub Bot commented on FLINK-4988:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2804
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895630#comment-15895630
]
ASF GitHub Bot commented on FLINK-5067:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895633#comment-15895633
]
ASF GitHub Bot commented on FLINK-4988:
---
Github user rmetzger commented on the issue:
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3468
Good changes. `ConfigConstants.DEFAULT_CHARSET` change to
`ConfigConstants.UTF_8 ` may be more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2767
I closed the PR manually using another commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-5067.
---
Resolution: Fixed
Assignee: Andrey Melentyev
Fix Version/s: 1.3.0
Resolved in
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3438
In addition to throwing an exception, we should also expose
`element.hasTimestamp()` to offer our users a clean way of checking for
timestamps.
Lets see what @uce or other reviewers think about
[
https://issues.apache.org/jira/browse/FLINK-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Che Wei reassigned FLINK-4817:
--
Assignee: Wei-Che Wei
> Checkpoint Coordinator should be called to restore state with a
[
https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895720#comment-15895720
]
Wei-Che Wei commented on FLINK-4816:
Hi [~ram_krish]
How about make the return value in
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3314
The change looks good to merge in my opinion.
@tzulitai can you also have a quick look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895723#comment-15895723
]
ASF GitHub Bot commented on FLINK-3679:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895722#comment-15895722
]
ASF GitHub Bot commented on FLINK-3679:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r104227652
--- Diff: docs/dev/connectors/kafka.md ---
@@ -146,6 +146,10 @@ The Flink Kafka Consumer needs to know how to turn the
binary data in Kafka into
[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895737#comment-15895737
]
ASF GitHub Bot commented on FLINK-4460:
---
Github user rmetzger commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3438
I think the discussion of timestamps and additional interfaces is
orthogonal to this PR: `KeyedProcessOperator` is a renaming of the pre-existing
`ProcessOperator` and the new `ProcessOperator` is
[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895742#comment-15895742
]
ASF GitHub Bot commented on FLINK-4460:
---
Github user aljoscha commented on the issue:
Jayson Minard created FLINK-5964:
Summary: Change TypeSerializers to allow construction of immutable
types
Key: FLINK-5964
URL: https://issues.apache.org/jira/browse/FLINK-5964
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895667#comment-15895667
]
Jayson Minard edited comment on FLINK-5964 at 3/4/17 1:11 PM:
--
This isn't
[
https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Che Wei reassigned FLINK-4816:
--
Assignee: Wei-Che Wei
> Executions failed from "DEPLOYING" should retain restored checkpoint
[
https://issues.apache.org/jira/browse/FLINK-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895648#comment-15895648
]
Steve Loughran commented on FLINK-5706:
---
Stefan, I don't think you appreciate how hard it is to do
[
https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895675#comment-15895675
]
ASF GitHub Bot commented on FLINK-4714:
---
GitHub user tony810430 opened a pull request:
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/3474
[FLINK-4714] [runtime] [streaming] Set task state to RUNNING after state
has been restored
The changes in this PR are
- add `open()` method in `AbstractInvokable` to let the invokable
[
https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Che Wei reassigned FLINK-4816:
--
Assignee: (was: Wei-Che Wei)
> Executions failed from "DEPLOYING" should retain restored
[
https://issues.apache.org/jira/browse/FLINK-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895667#comment-15895667
]
Jayson Minard commented on FLINK-5964:
--
This isn't just about Immutable types, its really about
Github user mylog00 commented on the issue:
https://github.com/apache/flink/pull/3270
Hi @rmetzger, i delete example for Kafka v0.8 and left only for Kafka v0.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895757#comment-15895757
]
ASF GitHub Bot commented on FLINK-5965:
---
GitHub user csokol opened a pull request:
GitHub user csokol opened a pull request:
https://github.com/apache/flink/pull/3475
[FLINK-5965] Typo on DropWizard wrappers
This PR fixes two small typos in the metrics doc:
* `DropWizardHistogramWrapper` should be `DropwizardHistogramWrapper`
*
[
https://issues.apache.org/jira/browse/FLINK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895758#comment-15895758
]
ASF GitHub Bot commented on FLINK-4286:
---
Github user mylog00 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895770#comment-15895770
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user sunjincheng121 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895769#comment-15895769
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user sunjincheng121 commented on a diff in the pull
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104290767
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
@@ -87,47 +89,67 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104290608
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
---
@@ -0,0 +1,103 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895771#comment-15895771
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user sunjincheng121 commented on a diff in the pull
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104292001
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala
---
@@ -0,0 +1,87 @@
Francisco Sokol created FLINK-5965:
--
Summary: Typo on DropWizard wrappers
Key: FLINK-5965
URL: https://issues.apache.org/jira/browse/FLINK-5965
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895648#comment-15895648
]
Steve Loughran edited comment on FLINK-5706 at 3/4/17 6:24 PM:
---
Stefan, I
[
https://issues.apache.org/jira/browse/FLINK-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895808#comment-15895808
]
Steve Loughran commented on FLINK-5706:
---
I should add that my current stance with using S3 as a
Github user shaoxuan-wang closed the pull request at:
https://github.com/apache/flink/pull/3464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3464
Sure @fhueske, this PR is closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896065#comment-15896065
]
ASF GitHub Bot commented on FLINK-5955:
---
Github user shaoxuan-wang closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895874#comment-15895874
]
ASF GitHub Bot commented on FLINK-5909:
---
Github user vasia commented on the issue:
Github user vasia commented on the issue:
https://github.com/apache/flink/pull/3434
Hi @greghogan, thank you for the PR.
I didn't spot anything that needs fixing, but I'm wondering what's the
motivation to add these interfaces. I see how `toVerboseString()` is useful,
but
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895912#comment-15895912
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895920#comment-15895920
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895923#comment-15895923
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895910#comment-15895910
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895908#comment-15895908
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895913#comment-15895913
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895919#comment-15895919
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895914#comment-15895914
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895921#comment-15895921
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895917#comment-15895917
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895922#comment-15895922
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895907#comment-15895907
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895906#comment-15895906
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298390
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -148,12 +161,24 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298146
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -23,10 +23,11 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104298822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
---
@@ -0,0 +1,103 @@
+/*
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298400
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -165,9 +190,9 @@ class
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895909#comment-15895909
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895911#comment-15895911
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895915#comment-15895915
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895916#comment-15895916
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895918#comment-15895918
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895925#comment-15895925
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895924#comment-15895924
]
ASF GitHub Bot commented on FLINK-5963:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104298833
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
@@ -87,47 +89,67 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104298836
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala
---
@@ -0,0 +1,87 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895993#comment-15895993
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on a diff in the pull
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301092
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104302135
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -36,14 +36,23 @@
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896029#comment-15896029
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-5855:
--
Description:
{code}
handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104303912
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -49,13 +50,25 @@
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896056#comment-15896056
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on a diff in the pull
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3470
@fhueske Thanks for the review. I have addressed all your comments and
updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896063#comment-15896063
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on the issue:
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301102
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895995#comment-15895995
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user fhueske commented on a diff in the pull
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301147
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896059#comment-15896059
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on a diff in the pull
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104304129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -137,6 +146,15 @@
[
https://issues.apache.org/jira/browse/FLINK-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896066#comment-15896066
]
ASF GitHub Bot commented on FLINK-5955:
---
Github user shaoxuan-wang commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896000#comment-15896000
]
ASF GitHub Bot commented on FLINK-5956:
---
Github user shaoxuan-wang commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayson Minard updated FLINK-5964:
-
Affects Version/s: 1.1.4
> Change TypeSerializers to allow construction of immutable types
>
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104297801
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104296481
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298418
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -556,7 +566,9 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298555
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -36,14 +36,23 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298360
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -67,9 +80,9 @@ abstract
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104297285
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -290,6 +317,19 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298605
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298517
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -36,14 +36,23 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104298261
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -49,13 +50,25 @@ abstract
1 - 100 of 120 matches
Mail list logo
