[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897090#comment-15897090 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r104388593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,168 @@ +/* + *

[jira] [Commented] (FLINK-5431) time format for akka status

[ https://issues.apache.org/jira/browse/FLINK-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897104#comment-15897104 ] ASF GitHub Bot commented on FLINK-5431: --- Github user tonycox commented on the issue:

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 @fhueske @KurtYoung @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-5481) Simplify Row creation

[ https://issues.apache.org/jira/browse/FLINK-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897102#comment-15897102 ] ASF GitHub Bot commented on FLINK-5481: --- Github user tonycox commented on the issue:

[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3297 @zentol What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897103#comment-15897103 ] ASF GitHub Bot commented on FLINK-3850: --- Github user tonycox commented on the issue:

[jira] [Commented] (FLINK-5645) IOMetrics transfer through ExecGraph does not work for failed jobs

[ https://issues.apache.org/jira/browse/FLINK-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897135#comment-15897135 ] ASF GitHub Bot commented on FLINK-5645: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104394065 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,166 @@ +/* + *

[GitHub] flink pull request #3377: [FLINK-5645] Store accumulators/metrics for cancel...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3377#discussion_r104394092 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -1311,6 +1311,19 @@ public boolean

[GitHub] flink issue #3377: [FLINK-5645] Store accumulators/metrics for canceled/fail...

Github user uce commented on the issue: https://github.com/apache/flink/pull/3377 Thanks for addressing Tills comments. I think this is good to merge now. Could you go ahead and do it? --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897179#comment-15897179 ] ASF GitHub Bot commented on FLINK-5824: --- Github user shijinkui commented on the issue:

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897189#comment-15897189 ] ASF GitHub Bot commented on FLINK-5824: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5706) Implement Flink's own S3 filesystem

[ https://issues.apache.org/jira/browse/FLINK-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897209#comment-15897209 ] Steve Loughran commented on FLINK-5706: --- If you look at where object stores are most trouble in the

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897282#comment-15897282 ] ASF GitHub Bot commented on FLINK-5846: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897280#comment-15897280 ] ASF GitHub Bot commented on FLINK-5846: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3445#discussion_r104413339 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java --- @@ -0,0 +1,243 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897283#comment-15897283 ] ASF GitHub Bot commented on FLINK-5846: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3445#discussion_r104412655 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPRescalingTest.java --- @@ -345,7 +345,8 @@ private void

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3445#discussion_r104413190 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java --- @@ -0,0 +1,243 @@ +/* + * Licensed to

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3445#discussion_r104412825 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java --- @@ -73,7 +73,8 @@ public Integer getKey(Event

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3445#discussion_r104413873 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java --- @@ -73,7 +73,8 @@ public Integer getKey(Event

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897281#comment-15897281 ] ASF GitHub Bot commented on FLINK-5846: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5846) CEP: make the operators backwards compatible.

[ https://issues.apache.org/jira/browse/FLINK-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897284#comment-15897284 ] ASF GitHub Bot commented on FLINK-5846: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink issue #3438: [FLINK-4460] Allow ProcessFunction on non-keyed streams

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3438 @uce There is some documentation that says that `ProcessFunction` is only available on keyed streams. I'll change that. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897185#comment-15897185 ] ASF GitHub Bot commented on FLINK-4460: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3438: [FLINK-4460] Allow ProcessFunction on non-keyed st...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3438#discussion_r104399614 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java --- @@ -556,6 +558,60 @@ public ExecutionConfig

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897191#comment-15897191 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai commented on the issue:

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104401325 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java --- @@ -0,0 +1,63 @@ +/* +

[GitHub] flink issue #3476: [FLINK-4022] [kafka] Partition and topic pattern discover...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3476 Seems like some Kafka tests are failing .. looking into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104401203 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -92,7 +92,12 @@ under the License. - +

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104413666 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala --- @@ -115,12

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897278#comment-15897278 ] ASF GitHub Bot commented on FLINK-5956: --- Github user shaoxuan-wang commented on a diff in the pull

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897275#comment-15897275 ] ASF GitHub Bot commented on FLINK-3347: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104411239 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala --- @@ -321,12 +317,11 @@

[GitHub] flink issue #3438: [FLINK-4460] Allow ProcessFunction on non-keyed streams

Github user uce commented on the issue: https://github.com/apache/flink/pull/3438 @rmetzger @aljoscha I would agree with Aljoscha that your point is independent of this PR. Is there an issue for 2.0 to track this? --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-5706) Implement Flink's own S3 filesystem

[ https://issues.apache.org/jira/browse/FLINK-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897097#comment-15897097 ] Stephan Ewen commented on FLINK-5706: - [~steve_l] Thanks for joining the discussion and for sharing

[GitHub] flink pull request #3363: [backport] [FLINK-3347] [akka] Add QuarantineMonit...

Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897289#comment-15897289 ] ASF GitHub Bot commented on FLINK-4714: --- Github user tony810430 commented on the issue:

[jira] [Closed] (FLINK-5957) Remove `getAccumulatorType` method from build-in `AggregateFunction`

[ https://issues.apache.org/jira/browse/FLINK-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-5957. -- Resolution: Won't Fix > Remove `getAccumulatorType` method from build-in `AggregateFunction` >

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r104387054 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala --- @@ -1101,6 +1101,45 @@ class

[jira] [Commented] (FLINK-5957) Remove `getAccumulatorType` method from build-in `AggregateFunction`

[ https://issues.apache.org/jira/browse/FLINK-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897081#comment-15897081 ] sunjincheng commented on FLINK-5957: [~fhueske] Sounds good. close this JIAR. > Remove

[jira] [Commented] (FLINK-5918) port range support for config taskmanager.rpc.port

[ https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897092#comment-15897092 ] ASF GitHub Bot commented on FLINK-5918: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3416: [FLINK-5918] [runtime] port range support for conf...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3416#discussion_r104387798 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -720,5 +722,55 @@ object AkkaUtils { if

[jira] [Created] (FLINK-5970) Job-/TaskManagerStartupTest may run indefinitely

Chesnay Schepler created FLINK-5970: --- Summary: Job-/TaskManagerStartupTest may run indefinitely Key: FLINK-5970 URL: https://issues.apache.org/jira/browse/FLINK-5970 Project: Flink Issue

[GitHub] flink issue #3468: [FLINK-5824] Fix String/byte conversions without explicit...

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3468 I'm in favor of using ```ConfigConstants.DEFAULT_CHARSET```. Using ```ConfigConstants.UTF_8``` does not imply in any way that this is the default that anyone should use; it would be equivalent to

[jira] [Commented] (FLINK-5909) Interface for GraphAlgorithm results

[ https://issues.apache.org/jira/browse/FLINK-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897271#comment-15897271 ] ASF GitHub Bot commented on FLINK-5909: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3434 @vasia, thinking again on `AnalyticResult`, as an empty interface I could simply replace with `GraphAnalytic` with `GraphAnalytic

[GitHub] flink issue #3363: [backport] [FLINK-3347] [akka] Add QuarantineMonitor whic...

Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3363 Rebasing this PR on the latest release-1.2 branch. If Travis passes, then I'll merge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897072#comment-15897072 ] ASF GitHub Bot commented on FLINK-3347: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897086#comment-15897086 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104387807 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -92,7 +92,12 @@ under the License. - +

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897094#comment-15897094 ] ASF GitHub Bot commented on FLINK-4565: --- Github user DmytroShkvyra commented on a diff in the pull

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

Github user DmytroShkvyra commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r104389045 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala --- @@ -1101,6 +1101,45 @@

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104390901 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala --- @@ -72,37 +72,34 @@

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104376293 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala --- @@ -137,6 +146,15 @@ abstract

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104392189 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MinAggFunctionWithRetract.scala --- @@ -72,37 +72,34 @@

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104392251 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MinAggFunctionWithRetract.scala --- @@ -115,12 +112,28

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104392040 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala --- @@ -115,12 +112,28

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897144#comment-15897144 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897149#comment-15897149 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #3406: [flink-5568] [Table API & SQL]Introduce interface for cat...

Github user beyond1920 commented on the issue: https://github.com/apache/flink/pull/3406 @fhueske, thanks for your review. I changed the pr based on your suggestions, except for one point. About adding the version field to ExternalCatalogCompatible, could we define tableType is

[jira] [Commented] (FLINK-3414) Add Scala API for CEP's pattern definition

[ https://issues.apache.org/jira/browse/FLINK-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897272#comment-15897272 ] Dawid Wysakowicz commented on FLINK-3414: - Hi [~ivan.mushketyk] Do you still want to work on it

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2870#discussion_r104393386 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala --- @@ -1101,6 +1101,45 @@ class

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897129#comment-15897129 ] ASF GitHub Bot commented on FLINK-4565: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104394062 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumWithRetractAggFunction.scala --- @@ -0,0 +1,201 @@

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897148#comment-15897148 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897145#comment-15897145 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897146#comment-15897146 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104389792 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala --- @@ -321,12 +317,11 @@ class

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897150#comment-15897150 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897147#comment-15897147 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3478: Flink 4816 Executions failed from "DEPLOYING" shou...

GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/3478 Flink 4816 Executions failed from "DEPLOYING" should retain restored checkpoint information Thanks for contributing to Apache Flink. Before you open your pull request, please take the following

[GitHub] flink issue #3363: [backport] [FLINK-3347] [akka] Add QuarantineMonitor whic...

Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3363 Travis passed locally: https://travis-ci.org/tillrohrmann/flink/builds/208150099. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3470#discussion_r104413472 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala --- @@ -72,37

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897276#comment-15897276 ] ASF GitHub Bot commented on FLINK-5956: --- Github user shaoxuan-wang commented on a diff in the pull

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897277#comment-15897277 ] ASF GitHub Bot commented on FLINK-5956: --- Github user shaoxuan-wang commented on a diff in the pull

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897286#comment-15897286 ] ASF GitHub Bot commented on FLINK-3347: --- Github user tillrohrmann closed the pull request at:

[jira] [Created] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

Aljoscha Krettek created FLINK-5969: --- Summary: Add savepoint backwards compatibility tests from 1.2 to 1.3 Key: FLINK-5969 URL: https://issues.apache.org/jira/browse/FLINK-5969 Project: Flink

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897082#comment-15897082 ] ASF GitHub Bot commented on FLINK-4565: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-5645) IOMetrics transfer through ExecGraph does not work for failed jobs

[ https://issues.apache.org/jira/browse/FLINK-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897138#comment-15897138 ] ASF GitHub Bot commented on FLINK-5645: --- Github user uce commented on the issue:

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3474 I would suggest to do the change differently. Right now, all the task logic is pretty complex as it is, and this makes it even more complex. My suggestion would be to 1. Change the

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897151#comment-15897151 ] ASF GitHub Bot commented on FLINK-4714: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3468: [FLINK-5824] Fix String/byte conversions without explicit...

Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3468 As your current replacement with `ConfigConstants.DEFAULT_CHARSET`, it's better for setting other charsets. UTF_8 has clear semantics. If we'll never change the default charset utf_8 to other

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3474 Hi @StephanEwen This suggestion seems to use constructor to set `Environment` instead of using `setEnvironment(env)` method and may not need it any more. Use the constructor to

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3479 Thanks @sjwiesman! I'll have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104282451 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java --- @@ -0,0 +1,162

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104282413 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java --- @@ -0,0 +1,162

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104283268 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/StreamAggregator.java --- @@ -0,0 +1,23 @@

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

Github user vasia commented on the issue: https://github.com/apache/flink/pull/3434 Does `AnalyticResult` also need a method like `toVerboseString()`? Could we replace both with a e.g. `Result` type? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r104436518 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java --- @@ -32,6 +32,10 @@ public static final

[jira] [Commented] (FLINK-5931) Make Flink highly available even if defaultFS is unavailable

[ https://issues.apache.org/jira/browse/FLINK-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897351#comment-15897351 ] Stephan Ewen commented on FLINK-5931: - Currently, Flink-on-YARN stores critical files in HDFS, like

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897390#comment-15897390 ] ASF GitHub Bot commented on FLINK-4714: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897365#comment-15897365 ] ASF GitHub Bot commented on FLINK-5778: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897409#comment-15897409 ] ASF GitHub Bot commented on FLINK-5929: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104428922 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java --- @@ -0,0

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104282631 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java --- @@ -0,0 +1,162

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897448#comment-15897448 ] ASF GitHub Bot commented on FLINK-5929: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897468#comment-15897468 ] ASF GitHub Bot commented on FLINK-4714: --- Github user tony810430 commented on the issue:

  1   2   3   4   5   >