[
https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544391#comment-16544391
]
ASF GitHub Bot commented on FLINK-9675:
---
GitHub user zhangminglei opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9675:
--
Labels: filesystem pull-request-available (was: filesystem)
> Avoid
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/6335
[FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream
## What is the purpose of the change
Avoid using FileInputStream/FileOutputStream because they rely on
finalizers (before Java
[
https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544400#comment-16544400
]
ASF GitHub Bot commented on FLINK-9758:
---
Github user Myasuka commented on the issue:
Github user Myasuka commented on the issue:
https://github.com/apache/flink/pull/6260
@dawidwys thanks for your suggestion, I have already refactor code with a
helper method to create the continuous-monitoring function.
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6323
Thank you @pnowojski. I hope I could address all your comments. I will
clean the commit history and improve the commit messages during merging.
---
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544075#comment-16544075
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507424
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -85,6 +86,9 @@ public
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507463
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
---
@@ -97,14 +97,34 @@ private void start() {
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544085#comment-16544085
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Congxian Qiu reassigned FLINK-8995:
---
Assignee: Congxian Qiu
> Add a test operator with keyed state that uses custom, stateful
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544072#comment-16544072
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user twalthr commented on the issue:
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507864
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open() {
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544099#comment-16544099
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6332
Thanks for the review @pnowojski. I agree that we should support `flink-cli
< query01.sql` or `echo "INSERT INTO bar SELECT * FROM foo" | flink-cli`.
However, I would move this to a separate issue
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544076#comment-16544076
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544082#comment-16544082
]
ASF GitHub Bot commented on FLINK-9407:
---
Github user sagarl commented on a diff in the pull
Github user sagarl commented on a diff in the pull request:
https://github.com/apache/flink/pull/6075#discussion_r200217627
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/OrcFileWriter.java
---
@@ -0,0 +1,252 @@
Github user sagarl commented on a diff in the pull request:
https://github.com/apache/flink/pull/6075#discussion_r200217021
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/OrcFileWriter.java
---
@@ -0,0 +1,252 @@
[
https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544083#comment-16544083
]
ASF GitHub Bot commented on FLINK-9407:
---
Github user sagarl commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507930
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -354,6 +398,23 @@ private void
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507962
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,14 +341,46 @@ public
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544086#comment-16544086
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544087#comment-16544087
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user twalthr commented on a diff in the pull
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6333
[FLINK-9489] Checkpoint timers as part of managed keyed state instead of
raw keyed state
## What is the purpose of the change
This PR integrates priority queue state (timers) with
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544091#comment-16544091
]
ASF GitHub Bot commented on FLINK-9489:
---
GitHub user StefanRRichter opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544092#comment-16544092
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user StefanRRichter commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9489:
--
Labels: pull-request-available (was: )
> Checkpoint timers as part of managed keyed state
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6333
CC @tillrohrmann
---
[
https://issues.apache.org/jira/browse/FLINK-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544221#comment-16544221
]
Congxian Qiu commented on FLINK-9764:
-
I ran the test in my laptop more than 1,000 times, but didn't
[
https://issues.apache.org/jira/browse/FLINK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Congxian Qiu reassigned FLINK-8995:
---
Assignee: (was: Congxian Qiu)
> Add a test operator with keyed state that uses custom,
[
https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544192#comment-16544192
]
ASF GitHub Bot commented on FLINK-5232:
---
Github user yanghua commented on the issue:
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6334
hi @tillrohrmann I tried to fix this issue based on your suggestion in the
jira. But there seems a little question, I want to consult you.
The question is about the ActorSystem, you
[
https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544183#comment-16544183
]
ASF GitHub Bot commented on FLINK-5232:
---
GitHub user yanghua opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-5232:
--
Labels: pull-request-available (was: )
> Add a Thread default uncaught exception handler on
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6334
[FLINK-5232] Add a Thread default uncaught exception handler on the
JobManager
## What is the purpose of the change
*This pull request Add a Thread default uncaught exception handler on
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544256#comment-16544256
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544258#comment-16544258
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544259#comment-16544259
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544257#comment-16544257
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202516863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
---
@@ -264,6 +265,42 @@ public void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519024
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSnapshotRestoreWrapper.java
---
@@ -0,0 +1,102 @@
+/*
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202518473
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
---
@@ -63,54 +72,46 @@ public
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517181
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
@@ -85,10 +85,10 @@ public int compare(T o1,
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202519256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -446,8 +485,10 @@ public String toString() {
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -305,6 +351,6 @@ private void
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544262#comment-16544262
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544261#comment-16544261
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544260#comment-16544260
]
ASF GitHub Bot commented on FLINK-9489:
---
Github user sihuazhou commented on a diff in the pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520415
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -173,55 +180,92 @@ public void open() {
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544273#comment-16544273
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user pnowojski commented on a diff in the pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520454
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
---
@@ -354,6 +398,23 @@ private void
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544272#comment-16544272
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user pnowojski commented on a diff in the pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202520618
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,14 +341,46 @@ public
[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544277#comment-16544277
]
ASF GitHub Bot commented on FLINK-8858:
---
Github user pnowojski commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544279#comment-16544279
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user pnowojski commented on a diff in the pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202520938
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
---
@@ -16,14 +16,14 @@
* limitations
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521122
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358 @@
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521212
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala
---
@@ -18,143 +18,358 @@
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544291#comment-16544291
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user pnowojski commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544289#comment-16544289
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user pnowojski commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544290#comment-16544290
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user pnowojski commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544288#comment-16544288
]
ASF GitHub Bot commented on FLINK-8558:
---
Github user pnowojski commented on a diff in the pull
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202520986
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java
---
@@ -51,16 +51,10 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202521065
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFormatFactory.scala
---
@@ -16,42 +16,17 @@
*
66 matches
Mail list logo
