[GitHub] [flink] FaxianZhao opened a new pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align

2019-04-24 Thread GitBox
FaxianZhao opened a new pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align URL: https://github.com/apache/flink/pull/8248 ## What is the purpose of the change JDBCOoutputFormat and JDBCAppendTableSink float behavior is not al

[GitHub] [flink] flinkbot commented on issue #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align

2019-04-24 Thread GitBox
flinkbot commented on issue #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align URL: https://github.com/apache/flink/pull/8248#issuecomment-486095320 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the c

[jira] [Commented] (FLINK-12298) Make column functions accept custom Range class rather than Expression

2019-04-24 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824860#comment-16824860 ] sunjincheng commented on FLINK-12298: - Hi Dawid, Thanks for mentioning the typesafe

[jira] [Comment Edited] (FLINK-12298) Make column functions accept custom Range class rather than Expression

2019-04-24 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824860#comment-16824860 ] sunjincheng edited comment on FLINK-12298 at 4/24/19 7:09 AM:

[GitHub] [flink] Kejian-Li opened a new pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co…

2019-04-24 Thread GitBox
Kejian-Li opened a new pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co… URL: https://github.com/apache/flink/pull/8249 …rrepsond to other class files. ## What is the purpose of the change Change the name of variable log ino LOG

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-24 Thread GitBox
eaglewatcherwb commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r277975059 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/Sche

[GitHub] [flink] flinkbot commented on issue #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co…

2019-04-24 Thread GitBox
flinkbot commented on issue #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co… URL: https://github.com/apache/flink/pull/8249#issuecomment-486099289 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-12303) Scala 2.12 lambdas does not work in event classes inside streams.

2019-04-24 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matěj Novotný updated FLINK-12303: -- Priority: Major (was: Minor) > Scala 2.12 lambdas does not work in event classes inside strea

[jira] [Updated] (FLINK-12303) Scala 2.12 lambdas does not work in event classes inside streams.

2019-04-24 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matěj Novotný updated FLINK-12303: -- Description: When you use lambdas inside event classes used in streams it does work in Scala

[jira] [Updated] (FLINK-12303) Scala 2.12 lambdas does not work in event classes inside streams.

2019-04-24 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matěj Novotný updated FLINK-12303: -- Description: When you use lambdas inside event classes used in streams it does work in Scala

[jira] [Updated] (FLINK-12306) Change the name of variable "log" to upper case "LOG"

2019-04-24 Thread Zi Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zi Li updated FLINK-12306: -- Summary: Change the name of variable "log" to upper case "LOG" (was: Change the name of variable "log" to Upp

[jira] [Created] (FLINK-12310) shade user facing common libraries in flink-connector-hive

2019-04-24 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12310: Summary: shade user facing common libraries in flink-connector-hive Key: FLINK-12310 URL: https://issues.apache.org/jira/browse/FLINK-12310 Project: Flink Issue Type

[jira] [Updated] (FLINK-12310) shade user facing common libraries in flink-connector-hive

2019-04-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12310: - Description: As discussed with Stephan and Timo, we will need to shade user facing common libraries in f

[GitHub] [flink] bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#issuecomment-486110194 As discussed with @StephanEwen and @twalthr , we will need

[GitHub] [flink] bowenli86 edited a comment on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
bowenli86 edited a comment on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#issuecomment-486110194 As discussed with @StephanEwen and @twalthr , we wi

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824888#comment-16824888 ] vinoyang commented on FLINK-11935: -- [~walterddr] [~twalthr] What do you think about thi

[jira] [Created] (FLINK-12311) Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-24 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12311: --- Summary: Add base python framework and Add Scan, Projection, and Filter operator support Key: FLINK-12311 URL: https://issues.apache.org/jira/browse/FLINK-12311 Project

[jira] [Created] (FLINK-12312) Remove CLI command for rescaling

2019-04-24 Thread Gary Yao (JIRA)
Gary Yao created FLINK-12312: Summary: Remove CLI command for rescaling Key: FLINK-12312 URL: https://issues.apache.org/jira/browse/FLINK-12312 Project: Flink Issue Type: Sub-task Compo

[jira] [Assigned] (FLINK-12311) Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-24 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-12311: - Assignee: Wei Zhong > Add base python framework and Add Scan, Projection, and Filter operator

[jira] [Commented] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-24 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824898#comment-16824898 ] aitozi commented on FLINK-12113: Can we enable the recursive clean in ClosureCleaner#cle

[jira] [Commented] (FLINK-12297) Clean the closure for OutputTags in PatternStream

2019-04-24 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824899#comment-16824899 ] aitozi commented on FLINK-12297: Hi, [~SleePy][~dawidwys] As I mentioned in [FLINK-1211

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-24 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278004424 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogFunct

[jira] [Commented] (FLINK-12298) Make column functions accept custom Range class rather than Expression

2019-04-24 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824901#comment-16824901 ] Dawid Wysakowicz commented on FLINK-12298: -- # I agree other api methods have si

[jira] [Assigned] (FLINK-12297) Clean the closure for OutputTags in PatternStream

2019-04-24 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aitozi reassigned FLINK-12297: -- Assignee: aitozi > Clean the closure for OutputTags in PatternStream > --

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486121026 Thanks a lot for the review @sorahn. I'll do one final pass over the change to decide whether we can merge it as-is. -

[GitHub] [flink] zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-24 Thread GitBox
zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486122618 @tillrohrmann For point 2, I think either we keep `IN_TESTS` or we just always ship yarn-site.xml no matter it

[GitHub] [flink] tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486123512 Hmm, isn't the problem that we never call `SnapshotDirectory#mkdirs` on the returned temp

[GitHub] [flink] zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-24 Thread GitBox
zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486124198 @tillrohrmann I have updated the PR. Now the only difference between test code and production code is in `Abs

[jira] [Created] (FLINK-12313) SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable

2019-04-24 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-12313: --- Summary: SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable Key: FLINK-12313 URL: https://issues.apache.org/jira/browse/FLINK-12313

[jira] [Updated] (FLINK-12313) SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable

2019-04-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-12313: Issue Type: Bug (was: Test) > SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronou

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486124991 Looks like this change sets up some husky git commit hooks: ``` [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ flink-runti

[GitHub] [flink] rmetzger commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#discussion_r278015235 ## File path: flink-runtime-web/src/main/resources/META-INF/NOTICE ## @@ -6,35 +6,22 @@ The Apache Soft

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-24 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278015563 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogFunct

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-24 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278015563 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogFunct

[GitHub] [flink] dawidwys closed pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-24 Thread GitBox
dawidwys closed pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062 This is an automated message from the Apache Git Service. To

[GitHub] [flink] tillrohrmann commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486129451 Ok, what about the following approach: When we start the `YarnMiniCluster` we extract the `YarnCon

[jira] [Commented] (FLINK-12219) Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-24 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824919#comment-16824919 ] lamber-ken commented on FLINK-12219: right. > Yarn application can't stop when flin

[GitHub] [flink] wuchong commented on issue #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner

2019-04-24 Thread GitBox
wuchong commented on issue #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner URL: https://github.com/apache/flink/pull/8234#issuecomment-486130113 Merging... This is an automated m

[GitHub] [flink] link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-24 Thread GitBox
link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486130063 @tillrohrmann I think the `SnapshotDirectory` is not created on purpose, and it would be crea

[jira] [Commented] (FLINK-12247) fix NPE when writing an archive file to a FileSystem

2019-04-24 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824921#comment-16824921 ] lamber-ken commented on FLINK-12247: ok. > fix NPE when writing an archive file to

[GitHub] [flink] zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-24 Thread GitBox
zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-486130374 I have updated the codes for reviews. @zentol @azagrebin --

[GitHub] [flink] link3280 edited a comment on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-24 Thread GitBox
link3280 edited a comment on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486130063 @tillrohrmann I think the `SnapshotDirectory` is left not created on purpose, and it w

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486132644 For the licenses, I propose the following: 1. We keep all the existing licensing information, because we keep the existing (old) UI

[jira] [Updated] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12296: -- Fix Version/s: 1.8.1 1.9.0 1.7.3 > Data loss silently in

[GitHub] [flink] asfgit closed pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner

2019-04-24 Thread GitBox
asfgit closed pull request #8234: [FLINK-12288] [table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner URL: https://github.com/apache/flink/pull/8234 This is an automated message from the Apache Git Service

[jira] [Updated] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12296: -- Priority: Blocker (was: Critical) > Data loss silently in RocksDBStateBackend when more than

[jira] [Commented] (FLINK-12298) Make column functions accept custom Range class rather than Expression

2019-04-24 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824929#comment-16824929 ] Hequn Cheng commented on FLINK-12298: - [~dawidwys] Hi, I think it's good to make our

[jira] [Resolved] (FLINK-12288) Bump Calcite dependency to 1.19.0 in blink planner

2019-04-24 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-12288. - Resolution: Resolved Fix Version/s: 1.9.0 Resolved in 1.9.0: b4a3738d06886265fab3ba797b87810688f2

[jira] [Closed] (FLINK-12288) Bump Calcite dependency to 1.19.0 in blink planner

2019-04-24 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12288. --- > Bump Calcite dependency to 1.19.0 in blink planner > -- > >

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486136017 This is what I propose to append to the NOTICE file: https://gist.github.com/rmetzger/f145f7308c5f22dcd8a5cd98d3fc1f58 -

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486136525 Looks like the old version UI is broken: ![image](https://user-images.githubusercontent.com/89049/56647167-48d14780-6681-11e9-9a4d-

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824945#comment-16824945 ] Stefan Richter commented on FLINK-12296: I guess this is one remaining relic fro

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486138844 Selecting a metric triggers a warning in the console: ![image](https://user-images.githubusercontent.com/89049/56647687-27249000-66

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486140486 Accessing checkpoints of a failed job fails: ![image](https://user-images.githubusercontent.com/89049/56648065-e24d2900-6682-11e9-9

[GitHub] [flink] Leeviiii commented on issue #8200: [FLINK-11614] [docs-zh] Translate the "Configuring Dependencies" page into Chinese

2019-04-24 Thread GitBox
Leev commented on issue #8200: [FLINK-11614] [docs-zh] Translate the "Configuring Dependencies" page into Chinese URL: https://github.com/apache/flink/pull/8200#issuecomment-486142558 ok @wuchong I have clean the branch as what you said. ---

[GitHub] [flink] zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-24 Thread GitBox
zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486142784 Agree that we need to deprecate/refactor `YarnTestBase` which is too complicated (1000 LOC just for unit test)

[jira] [Commented] (FLINK-11614) Translate the "Configuring Dependencies" page into Chinese

2019-04-24 Thread YangFei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824957#comment-16824957 ] YangFei commented on FLINK-11614: - I have cleaned the branch as what your comments said,

[GitHub] [flink] wuchong commented on issue #8200: [FLINK-11614] [docs-zh] Translate the "Configuring Dependencies" page into Chinese

2019-04-24 Thread GitBox
wuchong commented on issue #8200: [FLINK-11614] [docs-zh] Translate the "Configuring Dependencies" page into Chinese URL: https://github.com/apache/flink/pull/8200#issuecomment-486144267 Thanks @Leev , it looks good now. I will find time to review it then. -

[jira] [Created] (FLINK-12314) Translate "Types Serializationn" into Chinese

2019-04-24 Thread YangFei (JIRA)
YangFei created FLINK-12314: --- Summary: Translate "Types Serializationn" into Chinese Key: FLINK-12314 URL: https://issues.apache.org/jira/browse/FLINK-12314 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-12314) Translate "Types Serializationn" into Chinese

2019-04-24 Thread YangFei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YangFei updated FLINK-12314: Component/s: Documentation > Translate "Types Serializationn" into Chinese > -

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486148111 I think the problem is rather that accessing the Checkpoints tab is not possible at all :( -

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486148582 The timeline information shown is somehow off: ![image](https://user-images.githubusercontent.com/89049/56649798-1e35bd80-6686-11e9-884

[GitHub] [flink] dawidwys commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-24 Thread GitBox
dawidwys commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#issuecomment-486148786 Hi @hequn8128, I think the fix(0b33b9472fa48376b70a716e39d35d6e609d1709) is unnecessary, I forgot to commit a change init

[GitHub] [flink] lamber-ken opened a new pull request #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem

2019-04-24 Thread GitBox
lamber-ken opened a new pull request #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem URL: https://github.com/apache/flink/pull/8250 ## What is the purpose of the change if a flink-job reaches the max attempt count, the flink job will write an a

[GitHub] [flink] sorahn commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
sorahn commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486153027 > What are the hooks needed for? We use the git hooks to for linting and code formatting. But both `husky` and `lint-staged` should b

[jira] [Updated] (FLINK-11247) Fix DESCRIBE command to support catalog tables

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11247: --- Labels: pull-request-available (was: ) > Fix DESCRIBE command to support catalog tables > -

[GitHub] [flink] flinkbot commented on issue #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem

2019-04-24 Thread GitBox
flinkbot commented on issue #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem URL: https://github.com/apache/flink/pull/8250#issuecomment-486153229 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] zentol commented on a change in pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#discussion_r278045586 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/task

[jira] [Created] (FLINK-12315) SynchronousCheckpointITCase deadlocks on Travis

2019-04-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12315: Summary: SynchronousCheckpointITCase deadlocks on Travis Key: FLINK-12315 URL: https://issues.apache.org/jira/browse/FLINK-12315 Project: Flink Issue

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486156136 Hi @rmetzger , it seems some thing get wrong when merge the latest `old-version` flink dashboard into this pr, I will check and fix it to

[jira] [Created] (FLINK-12316) JDBCFullTest fails on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12316: Summary: JDBCFullTest fails on Java 9 Key: FLINK-12316 URL: https://issues.apache.org/jira/browse/FLINK-12316 Project: Flink Issue Type: Sub-task

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486157125 >> What are the hooks needed for? > We use the git hooks to for linting and code formatting. But both husky and lint-staged should

[GitHub] [flink] vthinkxie commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#discussion_r278050499 ## File path: flink-runtime-web/src/main/resources/META-INF/NOTICE ## @@ -6,35 +6,22 @@ The Apache Sof

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486160366 > > > What are the hooks needed for? > > > We use the git hooks to for linting and code formatting. But both husky and lint-staged

[jira] [Created] (FLINK-12317) SynchronousCheckpointITCase fails on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12317: Summary: SynchronousCheckpointITCase fails on Java 9 Key: FLINK-12317 URL: https://issues.apache.org/jira/browse/FLINK-12317 Project: Flink Issue Typ

[jira] [Created] (FLINK-12318) TimestampITCase deadlocks on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12318: Summary: TimestampITCase deadlocks on Java 9 Key: FLINK-12318 URL: https://issues.apache.org/jira/browse/FLINK-12318 Project: Flink Issue Type: Sub-t

[jira] [Updated] (FLINK-12317) SynchronousCheckpointITCase fails on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12317: - Description: https://travis-ci.org/apache/flink/builds/523415198 {code} 13:41:36.650 [ER

[jira] [Closed] (FLINK-12315) SynchronousCheckpointITCase deadlocks on Travis

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12315. Resolution: Duplicate > SynchronousCheckpointITCase deadlocks on Travis >

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486175944 Awesome, thank you! Once all my items are addressed, I'll re-run the blackduck report (to account for the dependencies moved to dev

[GitHub] [flink] zhijiangW commented on a change in pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-24 Thread GitBox
zhijiangW commented on a change in pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#discussion_r278070586 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/t

[jira] [Updated] (FLINK-12274) Fix documentation to enable Queryable State

2019-04-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-12274: --- Component/s: Runtime / Queryable State > Fix documentation to enable Queryable State > -

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825034#comment-16825034 ] Congxian Qiu(klion26) commented on FLINK-12296: --- [~srichter]  from what [~

[GitHub] [flink] twalthr commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-24 Thread GitBox
twalthr commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r278074006 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/factories/Strea

[GitHub] [flink] Kejian-Li closed pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co…

2019-04-24 Thread GitBox
Kejian-Li closed pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co… URL: https://github.com/apache/flink/pull/8249 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] yanghua commented on issue #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem

2019-04-24 Thread GitBox
yanghua commented on issue #8250: [FLINK-11247][runtime] fix NPE when writing the archive json file to FileSystem URL: https://github.com/apache/flink/pull/8250#issuecomment-486183479 Hi @lamber-ken I believe you wrote a wrong JIRA ID, right? ---

[GitHub] [flink] Kejian-Li opened a new pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co…

2019-04-24 Thread GitBox
Kejian-Li opened a new pull request #8249: [FLINK-12306][runtime] Change the name of variable log into LOG to co… URL: https://github.com/apache/flink/pull/8249 …rrepsond to other class files. ## What is the purpose of the change Change the name of variable log ino LOG

[GitHub] [flink] wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-24 Thread GitBox
wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r278079881 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/factories/Strea

[jira] [Closed] (FLINK-12318) TimestampITCase deadlocks on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12318. Resolution: Duplicate Fix Version/s: (was: 1.9.0) Underlying cause is identical

[GitHub] [flink] asfgit closed pull request #8195: [FLINK-11915][core] Fix miscalculation of DataInputViewStream.skip

2019-04-24 Thread GitBox
asfgit closed pull request #8195: [FLINK-11915][core] Fix miscalculation of DataInputViewStream.skip URL: https://github.com/apache/flink/pull/8195 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-11915. --- Resolution: Fixed Fix Version/s: 1.8.1 1.7.3 Fixed via 1.9.0: 8a17

[jira] [Updated] (FLINK-12260) Slot allocation failure by taskmanager registration timeout and race

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12260: -- Priority: Critical (was: Major) > Slot allocation failure by taskmanager registration timeout

[jira] [Updated] (FLINK-12316) JDBCFullTest fails on Java 9

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12316: --- Labels: pull-request-available (was: ) > JDBCFullTest fails on Java 9 > ---

[jira] [Commented] (FLINK-2147) Approximate calculation of frequencies in data streams

2019-04-24 Thread Felipe Oliveira Gutierrez (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825067#comment-16825067 ] Felipe Oliveira Gutierrez commented on FLINK-2147: -- Hi [~aljoscha], [~ti

[GitHub] [flink] zentol opened a new pull request #8251: [FLINK-12316][jdbc] Relax assertions

2019-04-24 Thread GitBox
zentol opened a new pull request #8251: [FLINK-12316][jdbc] Relax assertions URL: https://github.com/apache/flink/pull/8251 ## What is the purpose of the change Relaxes the exception message assertion in `JDBCFullTest#testEnrichedClassCastException` such that it works under java 8 a

[GitHub] [flink] tillrohrmann commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486195678 My proposal would be to explicitly add the `yarn-site.xml` to the set of files which are being shipped v

[GitHub] [flink] flinkbot commented on issue #8251: [FLINK-12316][jdbc] Relax assertions

2019-04-24 Thread GitBox
flinkbot commented on issue #8251: [FLINK-12316][jdbc] Relax assertions URL: https://github.com/apache/flink/pull/8251#issuecomment-486195162 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use t

[GitHub] [flink] zentol opened a new pull request #8252: [FLINK-12317][runtime] Ensure maximum size is larger than core size

2019-04-24 Thread GitBox
zentol opened a new pull request #8252: [FLINK-12317][runtime] Ensure maximum size is larger than core size URL: https://github.com/apache/flink/pull/8252 ## What is the purpose of the change Fixes an issue in the `BlockingCallMonitoringThreadPool` where the pool core size may be s

[GitHub] [flink] tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486197805 Maybe but then there is something wrong with the logic because we check that the `localBa

[jira] [Updated] (FLINK-12317) SynchronousCheckpointITCase fails on Java 9

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12317: --- Labels: pull-request-available (was: ) > SynchronousCheckpointITCase fails on Java 9 >

[GitHub] [flink] flinkbot commented on issue #8252: [FLINK-12317][runtime] Ensure maximum size is larger than core size

2019-04-24 Thread GitBox
flinkbot commented on issue #8252: [FLINK-12317][runtime] Ensure maximum size is larger than core size URL: https://github.com/apache/flink/pull/8252#issuecomment-486197825 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

  1   2   3   4   >