[jira] [Commented] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825187#comment-16825187 ] Chesnay Schepler commented on FLINK-10984: -- {{flink-shaded-hadoop2-uber}} moved to flink-shaded

[GitHub] [flink] tillrohrmann commented on issue #8196: [FLINK-12065][e2e] Ignore reflection access warnings

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8196: [FLINK-12065][e2e] Ignore reflection access warnings URL: https://github.com/apache/flink/pull/8196#issuecomment-486261979 @flinkbot approve all This is an automated message from the

[jira] [Updated] (FLINK-12321) Supports sub-plan reuse

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12321: --- Labels: pull-request-available (was: ) > Supports sub-plan reuse > ---

[GitHub] [flink] flinkbot commented on issue #8253: [FLINK-12321] [table-planner-blink] Supports sub-plan reuse

2019-04-24 Thread GitBox
flinkbot commented on issue #8253: [FLINK-12321] [table-planner-blink] Supports sub-plan reuse URL: https://github.com/apache/flink/pull/8253#issuecomment-486264451 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] vthinkxie commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#discussion_r278153235 ## File path: flink-runtime-web/web-dashboard/old-version/index.html ## @@ -43,17 +43,17 @@

[jira] [Closed] (FLINK-12065) E2E tests fail due to illegal-access warning on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12065. Resolution: Fixed Fix Version/s: 1.9.0 master:

[GitHub] [flink] flinkbot commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-24 Thread GitBox
flinkbot commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486275844 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot.

[GitHub] [flink] bd2019us commented on issue #8167: [FLINK-12187][Examples] Bug fixes, Use BufferedWriter in a loop instead of FileWriter

2019-04-24 Thread GitBox
bd2019us commented on issue #8167: [FLINK-12187][Examples] Bug fixes, Use BufferedWriter in a loop instead of FileWriter URL: https://github.com/apache/flink/pull/8167#issuecomment-486413059 Hi @rmetzger , could you please kindly help to review the code change? Thanks.

[GitHub] [flink] flinkbot commented on issue #8260: [FLINK-12312][runtime] Remove CLI command for rescaling

2019-04-24 Thread GitBox
flinkbot commented on issue #8260: [FLINK-12312][runtime] Remove CLI command for rescaling URL: https://github.com/apache/flink/pull/8260#issuecomment-486415039 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] GJL opened a new pull request #8260: [FLINK-12312][runtime] Remove CLI command for rescaling

2019-04-24 Thread GitBox
GJL opened a new pull request #8260: [FLINK-12312][runtime] Remove CLI command for rescaling URL: https://github.com/apache/flink/pull/8260 ## What is the purpose of the change *See

[jira] [Updated] (FLINK-12312) Remove CLI command for rescaling

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12312: --- Labels: pull-request-available (was: ) > Remove CLI command for rescaling >

[jira] [Updated] (FLINK-11477) Define catalog entries in SQL client YAML file and handle the creation and registration of those entries

2019-04-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-11477: - Description: As the configuration for SQL client, the YAML file currently allows one to register tables

[jira] [Updated] (FLINK-11477) Define catalog entries in SQL client YAML file and handle the creation and registration of those entries

2019-04-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-11477: - Fix Version/s: 1.9.0 > Define catalog entries in SQL client YAML file and handle the creation and >

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278119510 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278128490 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278121922 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278128959 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278123792 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278125127 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278128159 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278128763 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278123332 ## File path:

[GitHub] [flink] sorahn commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
sorahn commented on a change in pull request #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#discussion_r278146070 ## File path: flink-runtime-web/web-dashboard/old-version/index.html ## @@ -43,17 +43,17 @@

[GitHub] [flink] tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers URL: https://github.com/apache/flink/pull/7856#discussion_r278145083 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers URL: https://github.com/apache/flink/pull/7856#discussion_r278145356 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers URL: https://github.com/apache/flink/pull/7856#discussion_r278144852 ## File path:

[jira] [Updated] (FLINK-12247) fix NPE when writing an archive file to a FileSystem

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12247: --- Labels: pull-request-available (was: ) > fix NPE when writing an archive file to a

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825199#comment-16825199 ] Congxian Qiu(klion26) commented on FLINK-12296: --- [~srichter] I first implemented as you

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486260932 @sorahn and I have looked into this, and the problem is probably that `@angular-devkit/build-angular` became a regular dependency (it

[GitHub] [flink] asfgit closed pull request #8250: [FLINK-12247][runtime] fix NPE when writing the archive json file to FileSystem

2019-04-24 Thread GitBox
asfgit closed pull request #8250: [FLINK-12247][runtime] fix NPE when writing the archive json file to FileSystem URL: https://github.com/apache/flink/pull/8250 This is an automated message from the Apache Git Service. To

[jira] [Resolved] (FLINK-12247) fix NPE when writing an archive file to a FileSystem

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-12247. --- Resolution: Fixed Fixed via 191b9dff2f3faf281a77e211c6ef47243d6a9e8d > fix NPE when

[GitHub] [flink] tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task URL: https://github.com/apache/flink/pull/8210#discussion_r278177592 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task URL: https://github.com/apache/flink/pull/8210#discussion_r278177012 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task URL: https://github.com/apache/flink/pull/8210#discussion_r278175765 ## File path:

[jira] [Created] (FLINK-12323) Remove legacy ActorGateway implementations

2019-04-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-12323: - Summary: Remove legacy ActorGateway implementations Key: FLINK-12323 URL: https://issues.apache.org/jira/browse/FLINK-12323 Project: Flink Issue Type:

[GitHub] [flink] zhijiangW commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-24 Thread GitBox
zhijiangW commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers URL: https://github.com/apache/flink/pull/7856#discussion_r278195613 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-24 Thread GitBox
zhijiangW commented on a change in pull request #7856: [FLINK-11776][coordination] Refactor to simplify the process of scheduleOrUpdateConsumers URL: https://github.com/apache/flink/pull/7856#discussion_r278195897 ## File path:

[jira] [Updated] (FLINK-12323) Remove legacy ActorGateway implementations

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12323: --- Labels: pull-request-available (was: ) > Remove legacy ActorGateway implementations >

[GitHub] [flink] flinkbot commented on issue #8256: [FLINK-12323] Remove legacy ActorGateway based interface implementations

2019-04-24 Thread GitBox
flinkbot commented on issue #8256: [FLINK-12323] Remove legacy ActorGateway based interface implementations URL: https://github.com/apache/flink/pull/8256#issuecomment-486303776 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486245448 These licenses have been added: ```diff 0a1,3 > @angular-devkit/architect 0.13.6 : MIT License > @angular-devkit/build-angular

[jira] [Updated] (FLINK-12317) BlockingCallMonitoringThreadPool fails on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12317: - Summary: BlockingCallMonitoringThreadPool fails on Java 9 (was:

[jira] [Updated] (FLINK-12324) Remove legacy ActorGateway interface

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12324: --- Labels: pull-request-available (was: ) > Remove legacy ActorGateway interface >

[GitHub] [flink] tillrohrmann opened a new pull request #8257: [FLINK-12324] Remove legacy ActorGateway interface

2019-04-24 Thread GitBox
tillrohrmann opened a new pull request #8257: [FLINK-12324] Remove legacy ActorGateway interface URL: https://github.com/apache/flink/pull/8257 ## What is the purpose of the change This PR is based on #8256. This PR removes the legacy ActorGateway and all its implementations.

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486225655 Hi @rmetzger I have fixed the bugs below - [x] timeline display error when job running - [x] checkpoints tab error - [x]

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486227689 Thanks a lot. I'll do another review. This is an automated message from

[jira] [Updated] (FLINK-12321) Supports sub-plan reuse

2019-04-24 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12321: --- Issue Type: New Feature (was: Bug) > Supports sub-plan reuse > --- > >

[jira] [Created] (FLINK-12321) Supports sub-plan reuse

2019-04-24 Thread godfrey he (JIRA)
godfrey he created FLINK-12321: -- Summary: Supports sub-plan reuse Key: FLINK-12321 URL: https://issues.apache.org/jira/browse/FLINK-12321 Project: Flink Issue Type: Bug Components:

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486268124 Can we make the rendering always left to right? This is an automated

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486269238 The new UI doesn't show the failure message for failed checkpoints:

[GitHub] [flink] vthinkxie edited a comment on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie edited a comment on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486271940 > +1 the old UI works again! > > * timeline is fixed > > Is it possible that the rendering of job graph's is not

[jira] [Updated] (FLINK-12219) Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12219: --- Labels: pull-request-available (was: ) > Yarn application can't stop when flink job failed

[GitHub] [flink] lamber-ken opened a new pull request #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-24 Thread GitBox
lamber-ken opened a new pull request #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254 ## What is the purpose of the change In our flink(1.6.3) product env, I often encounter a

[GitHub] [flink] tillrohrmann commented on issue #8211: [FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph()

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8211: [FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph() URL: https://github.com/apache/flink/pull/8211#issuecomment-486281324 @flinkbot approve all This is an automated

[jira] [Assigned] (FLINK-12322) Remove legacy ActorTaskManagerGateway

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12322: - Assignee: Till Rohrmann > Remove legacy ActorTaskManagerGateway >

[jira] [Created] (FLINK-12322) Remove legacy ActorTaskManagerGateway

2019-04-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-12322: - Summary: Remove legacy ActorTaskManagerGateway Key: FLINK-12322 URL: https://issues.apache.org/jira/browse/FLINK-12322 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-12322) Remove legacy ActorTaskManagerGateway

2019-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12322: --- Labels: pull-request-available (was: ) > Remove legacy ActorTaskManagerGateway >

[GitHub] [flink] tillrohrmann opened a new pull request #8255: [FLINK-12322] Remove legacy ActorTaskManagerGateway

2019-04-24 Thread GitBox
tillrohrmann opened a new pull request #8255: [FLINK-12322] Remove legacy ActorTaskManagerGateway URL: https://github.com/apache/flink/pull/8255 ## What is the purpose of the change Remove legacy `ActorTaskManagerGateway` ## Verifying this change This change is a

[jira] [Updated] (FLINK-12324) Remove legacy ActorGateway interface

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12324: -- Summary: Remove legacy ActorGateway interface (was: Remove ActorGateway interface) > Remove

[jira] [Updated] (FLINK-12324) Remove legacy ActorGateway interface

2019-04-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12324: -- Description: Remove the legacy {{ActorGateway}} interface. (was: Remove the {{ActorGateway}}

[GitHub] [flink] flinkbot commented on issue #8257: [FLINK-12324] Remove legacy ActorGateway interface

2019-04-24 Thread GitBox
flinkbot commented on issue #8257: [FLINK-12324] Remove legacy ActorGateway interface URL: https://github.com/apache/flink/pull/8257#issuecomment-486307605 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-04-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825138#comment-16825138 ] Stefan Richter commented on FLINK-12296: [~klion26] In general I think it is a good idea to

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486236061 Somehow the number of dependencies is exploded from 360 to 930. Is that a bug in Blackduck? I was expecting the number to go down, not

[GitHub] [flink] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-24 Thread GitBox
Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-486236033 Hey @becketqin I've pushed code which replaces the

[GitHub] [flink] xuefuz commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

2019-04-24 Thread GitBox
xuefuz commented on a change in pull request #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog URL: https://github.com/apache/flink/pull/8222#discussion_r278136197 ## File path:

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486247719 I'm not scanning dev dependencies: ``` 2019-04-24 15:26:05 INFO [main] --- Preparation for extraction 2019-04-24 15:26:05 INFO

[GitHub] [flink] zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#discussion_r278145548 ## File path: flink-dist/pom.xml ## @@ -399,23 +399,6 @@ under the License.

[GitHub] [flink] zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#discussion_r278145464 ## File path: flink-dist/pom.xml ## @@ -428,9 +411,6 @@ under the License.

[GitHub] [flink] zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#discussion_r278144744 ## File path: flink-connectors/flink-connector-filesystem/pom.xml ## @@ -52,8 +52,8 @@ under the

[GitHub] [flink] zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-24 Thread GitBox
zentol commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#discussion_r278146562 ## File path: pom.xml ## @@ -234,7 +233,7 @@ under the License.

[GitHub] [flink] zentol merged pull request #8196: [FLINK-12065][e2e] Ignore reflection access warnings

2019-04-24 Thread GitBox
zentol merged pull request #8196: [FLINK-12065][e2e] Ignore reflection access warnings URL: https://github.com/apache/flink/pull/8196 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] godfreyhe opened a new pull request #8253: [FLINK-12321] [table-planner-blink] Supports sub-plan reuse

2019-04-24 Thread GitBox
godfreyhe opened a new pull request #8253: [FLINK-12321] [table-planner-blink] Supports sub-plan reuse URL: https://github.com/apache/flink/pull/8253 ## What is the purpose of the change *Supports sub-plan reuse* ## Brief change log - *Add RelDigestUtil to

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486266737 +1 the old UI works again! + timeline is fixed Is it possible that the rendering of job graph's is not deterministic? In the

[jira] [Created] (FLINK-12324) Remove ActorGateway interface

2019-04-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-12324: - Summary: Remove ActorGateway interface Key: FLINK-12324 URL: https://issues.apache.org/jira/browse/FLINK-12324 Project: Flink Issue Type: Sub-task

[GitHub] [flink] EugeneYushin commented on issue #8187: [FLINK-12197] [Formats] Avro row deser for Confluent binary format

2019-04-24 Thread GitBox
EugeneYushin commented on issue #8187: [FLINK-12197] [Formats] Avro row deser for Confluent binary format URL: https://github.com/apache/flink/pull/8187#issuecomment-486265038 @dawidwys thanks for the suggestion, I've added required changes. Can you please take a look one more time?

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486265106 > @sorahn and I have looked into this, and the problem is probably that `@angular-devkit/build-angular` became a regular dependency (it

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486271940 > +1 the old UI works again! > > * timeline is fixed > > Is it possible that the rendering of job graph's is not

[GitHub] [flink] vthinkxie edited a comment on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie edited a comment on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486271940 > +1 the old UI works again! > > * timeline is fixed > > Is it possible that the rendering of job graph's is not

[GitHub] [flink] vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
vthinkxie commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486273100 > The new UI doesn't show the failure message for failed checkpoints: >

[GitHub] [flink] zentol merged pull request #8216: [hotfix][tests] Replace deprecated option key with its successor

2019-04-24 Thread GitBox
zentol merged pull request #8216: [hotfix][tests] Replace deprecated option key with its successor URL: https://github.com/apache/flink/pull/8216 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] zentol commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory

2019-04-24 Thread GitBox
zentol commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory URL: https://github.com/apache/flink/pull/8219#issuecomment-486280385 This is not the correct fix imo. So, the message is logged as WARN on purpose since we've had cases in the past where this

[jira] [Updated] (FLINK-12317) BlockingCallMonitoringThreadPool fails on Java 9

2019-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12317: - Description: The {{BlockingCallMonitoringThreadPool}} modifies the core/maximum pool

[GitHub] [flink] rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard

2019-04-24 Thread GitBox
rmetzger commented on issue #8016: [FLINK-10705][web]: Rework Flink Web Dashboard URL: https://github.com/apache/flink/pull/8016#issuecomment-486289927 Thanks @sorahn for the update. It brought the number of dependencies down to 135 :)

[GitHub] [flink] flinkbot commented on issue #8255: [FLINK-12322] Remove legacy ActorTaskManagerGateway

2019-04-24 Thread GitBox
flinkbot commented on issue #8255: [FLINK-12322] Remove legacy ActorTaskManagerGateway URL: https://github.com/apache/flink/pull/8255#issuecomment-486293244 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] tillrohrmann opened a new pull request #8256: [FLINK-12323] Remove legacy ActorGateway based interface implementations

2019-04-24 Thread GitBox
tillrohrmann opened a new pull request #8256: [FLINK-12323] Remove legacy ActorGateway based interface implementations URL: https://github.com/apache/flink/pull/8256 ## What is the purpose of the change Remove ActorGatewayCheckpointResponder Remove

[GitHub] [flink] tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly…

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly… URL: https://github.com/apache/flink/pull/8158#discussion_r278207278 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly…

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly… URL: https://github.com/apache/flink/pull/8158#discussion_r278209255 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly…

2019-04-24 Thread GitBox
tillrohrmann commented on a change in pull request #8158: [FLINK-12131][runtime] Adjust IntermediateResult/IntermediateResultPartition status properly… URL: https://github.com/apache/flink/pull/8158#discussion_r278206431 ## File path:

[jira] [Updated] (FLINK-12302) fix the wrong finalStatus of yarn application when job not finished

2019-04-24 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-12302: --- Summary: fix the wrong finalStatus of yarn application when job not finished (was: fix the

[GitHub] [flink] bowenli86 commented on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

2019-04-24 Thread GitBox
bowenli86 commented on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog URL: https://github.com/apache/flink/pull/8222#issuecomment-486341814 To summarize changes I made so far: - make CatalogPartitionSpec its own

[jira] [Commented] (FLINK-12126) Make relaxed rescaling behaviour accessible in REST interface

2019-04-24 Thread Joshua Schneider (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825319#comment-16825319 ] Joshua Schneider commented on FLINK-12126: -- [~gjy] No, we use it in a research prototype. >

[GitHub] [flink] bowenli86 edited a comment on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

2019-04-24 Thread GitBox
bowenli86 edited a comment on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog URL: https://github.com/apache/flink/pull/8222#issuecomment-486341814 Thanks for your reivew @JingsongLi @wuchong @xuefuz @zjffdu . To summarize

[GitHub] [flink] bowenli86 commented on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog

2019-04-24 Thread GitBox
bowenli86 commented on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog URL: https://github.com/apache/flink/pull/8222#issuecomment-486342677 @flinkbot attention @KurtYoung

[GitHub] [flink] Xeli edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-24 Thread GitBox
Xeli edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-486236033 Hey @becketqin I've pushed code which replaces the

[GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-24 Thread GitBox
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278242153 ## File path:

[GitHub] [flink] Aitozi opened a new pull request #8258: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-04-24 Thread GitBox
Aitozi opened a new pull request #8258: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8258 ## What is the purpose of the change ClosureCleaner is used to clean the implicit `this$x` point to the outer class in the user

[GitHub] [flink] uce commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory

2019-04-24 Thread GitBox
uce commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory URL: https://github.com/apache/flink/pull/8219#issuecomment-486309240 I agree with @zentol. This is an automated message from the

[GitHub] [flink] tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-24 Thread GitBox
tillrohrmann commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486331017 Implicitly relying on the fact that someone else has created the directory is dangerous

[jira] [Commented] (FLINK-10713) RestartIndividualStrategy does not restore state

2019-04-24 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825345#comment-16825345 ] Yun Tang commented on FLINK-10713: -- [~kisimple] It has been nearly three months since you take the

[GitHub] [flink] bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-04-24 Thread GitBox
bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#issuecomment-486335458 @flinkbot attention @dawidwys

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-24 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825347#comment-16825347 ] Rong Rong commented on FLINK-11935: --- My feeling is that we should find out why Julian datetime *epoch

  1   2   3   4   >