[jira] [Assigned] (FLINK-29313) Some config overrides are ignored when set under spec.flinkConfiguration

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-29313: -- Assignee: Gyula Fora > Some config overrides are ignored when set under

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974074196 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/TestingResultPartitionProvider.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-19 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606542#comment-17606542 ] Xingbo Huang commented on FLINK-29315: -- [~mapohl] Ok. I will reach out them for help. >

[GitHub] [flink-kubernetes-operator] csviri commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
csviri commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974124231 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
morhidi commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974159882 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Comment Edited] (FLINK-29328) 【Flink is having problems using the status expiration setting】

2022-09-19 Thread Jason (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606514#comment-17606514 ] Jason edited comment on FLINK-29328 at 9/19/22 9:53 AM: Yanfei Lei Thanks for

[GitHub] [flink] flinkbot commented on pull request #20854: [BP-1.16][FLINK-29148][docs][sql-gateway][hive] Add SQL Gateway docs

2022-09-19 Thread GitBox
flinkbot commented on PR #20854: URL: https://github.com/apache/flink/pull/20854#issuecomment-1250808494 ## CI report: * 700ec0ecd4f6b667ef7f0abc00f70c699700128f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-14055) Add advanced function DDL syntax "USING JAR"

2022-09-19 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-14055: -- Release Note: In 1.16, we introduced the `CREATE FUNCTION ... USING JAR` syntax to support the

[GitHub] [flink-table-store] MOBIN-F commented on pull request #290: [FLINK-29252]Support create table-store table with 'connector'='table-store'

2022-09-19 Thread GitBox
MOBIN-F commented on PR #290: URL: https://github.com/apache/flink-table-store/pull/290#issuecomment-1250850715 > > @JingsongLi @liyubin117 @SteNicholas I think it's more straightforward to create tables using a connector approach, like Hudi/Iceberg, and now Delta is also

[GitHub] [flink-table-store] JingsongLi closed pull request #245: [WIP] Introduce full-compaction changelog producer

2022-09-19 Thread GitBox
JingsongLi closed pull request #245: [WIP] Introduce full-compaction changelog producer URL: https://github.com/apache/flink-table-store/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-19 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r974159354 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java:

[jira] [Comment Edited] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606628#comment-17606628 ] Chesnay Schepler edited comment on FLINK-29235 at 9/19/22 2:50 PM: ---

[jira] [Commented] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606628#comment-17606628 ] Chesnay Schepler commented on FLINK-29235: -- Mind you that the CVE likely doesn't apply because

[jira] [Updated] (FLINK-29313) Some config overrides are ignored when set under spec.flinkConfiguration

2022-09-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29313: --- Labels: pull-request-available (was: ) > Some config overrides are ignored when set under

[GitHub] [flink] wuchong opened a new pull request, #20856: [BP-1.16][FLINK-29025][docs] add docs for Hive dialect

2022-09-19 Thread GitBox
wuchong opened a new pull request, #20856: URL: https://github.com/apache/flink/pull/20856 This is a cherry-pick back to release-1.16 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zjureel commented on pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on PR #19380: URL: https://github.com/apache/flink/pull/19380#issuecomment-1250823961 Hi @KarmaGYZ @pnowojski Thanks for your reviews and I'm very sorry for updating this PR so late. I have rebased the code from master and updated the codes in the PR via your

[jira] [Comment Edited] (FLINK-6755) Allow triggering Checkpoints through command line client

2022-09-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458438#comment-17458438 ] Piotr Nowojski edited comment on FLINK-6755 at 9/19/22 10:19 AM: - The

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606540#comment-17606540 ] Matthias Pohl commented on FLINK-29315: --- [~hxb] could you access the custom CI workers that are

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #292: [FLINK-29278] BINARY type is not supported in table store

2022-09-19 Thread GitBox
JingsongLi commented on code in PR #292: URL: https://github.com/apache/flink-table-store/pull/292#discussion_r974118665 ## flink-table-store-common/src/test/java/org/apache/flink/table/store/format/FileStatsExtractorTestBase.java: ## @@ -128,6 +129,9 @@ private Object

[jira] [Closed] (FLINK-28810) Introduce write.skip-compaction to skip compaction on write

2022-09-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28810. Resolution: Fixed master: fc73a0bc4427741b41cb4b15e75c2dba363b97fb > Introduce

[GitHub] [flink-table-store] JingsongLi merged pull request #262: [FLINK-28810] Introduce write.skip-compaction to skip compaction on write

2022-09-19 Thread GitBox
JingsongLi merged PR #262: URL: https://github.com/apache/flink-table-store/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-29334) StateHandleStore#releaseAndTryRemoveAll is not used and can be removed

2022-09-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-29334: - Summary: StateHandleStore#releaseAndTryRemoveAll is not used and can be removed Key: FLINK-29334 URL: https://issues.apache.org/jira/browse/FLINK-29334 Project:

[jira] [Commented] (FLINK-28766) UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileException

2022-09-19 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606586#comment-17606586 ] Anton Kalashnikov commented on FLINK-28766: --- [~martijnvisser], I will take a look >

[jira] [Assigned] (FLINK-28766) UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileException

2022-09-19 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-28766: - Assignee: Anton Kalashnikov > UnalignedCheckpointStressITCase.runStressTest

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code

2022-09-19 Thread GitBox
morhidi commented on code in PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#discussion_r974255685 ## examples/kubernetes-client-examples/README.MD: ## @@ -0,0 +1,48 @@ + + +# Flink Kubernetes Client Code Example + +## Overview + +This is an

[jira] [Commented] (FLINK-29093) LookupJoinITCase failed with InternalCompilerException

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606611#comment-17606611 ] Jark Wu commented on FLINK-29093: -

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974072849 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestNotifierTimeout.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974072694 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java: ## @@ -104,12 +192,40 @@ public void shutdown() {

[jira] [Commented] (FLINK-29330) Provide better logs of MiniCluster shutdown procedure

2022-09-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606539#comment-17606539 ] Matthias Pohl commented on FLINK-29330: --- I guess, it's a good idea. The shutdown logic is hard to

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
morhidi commented on PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#issuecomment-1250859590 Hi @SteNicholas, if we stick with the current fabric8 version I don't see any problems merging this PR with the upcoming FOv1.2 release. -- This is an automated

[jira] [Created] (FLINK-29333) Flink SQL Planner Module doesn't read config from flink-conf.yaml

2022-09-19 Thread Dhananjay Badaya (Jira)
Dhananjay Badaya created FLINK-29333: Summary: Flink SQL Planner Module doesn't read config from flink-conf.yaml Key: FLINK-29333 URL: https://issues.apache.org/jira/browse/FLINK-29333 Project:

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #369: [FLINK-29256] Add docs for k8s operator webhook

2022-09-19 Thread GitBox
gyfora merged PR #369: URL: https://github.com/apache/flink-kubernetes-operator/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] lsyldliu commented on pull request #20652: [FLINK-22315][table] Support add/modify column/constraint/watermark for ALTER TABLE statement

2022-09-19 Thread GitBox
lsyldliu commented on PR #20652: URL: https://github.com/apache/flink/pull/20652#issuecomment-1250904811 > Hi @lsyldliu, do you have time to take a look? Thanks for your contribution, I will review it as soon as possible. -- This is an automated message from the Apache Git Service.

[jira] [Created] (FLINK-29335) OperatorSubtaskState swallows exception

2022-09-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-29335: - Summary: OperatorSubtaskState swallows exception Key: FLINK-29335 URL: https://issues.apache.org/jira/browse/FLINK-29335 Project: Flink Issue Type:

[jira] [Closed] (FLINK-29209) Fail to connect HiveServer endpoint with TProtocolException

2022-09-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-29209. Resolution: Not A Problem > Fail to connect HiveServer endpoint with TProtocolException >

[jira] [Commented] (FLINK-28766) UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileException

2022-09-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606589#comment-17606589 ] Martijn Visser commented on FLINK-28766: Thanks [~akalashnikov] >

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
morhidi commented on PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#issuecomment-1250988273 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] wuchong commented on pull request #20630: [FLINK-29023][docs][table] Updating Jar statement document

2022-09-19 Thread GitBox
wuchong commented on PR #20630: URL: https://github.com/apache/flink/pull/20630#issuecomment-1251074156 The failed cases are tracked by FLINK-29315 and FLINK-29093. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Assigned] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-29235: Assignee: Chesnay Schepler > CVE-2022-25857 on flink-shaded >

[jira] [Commented] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606626#comment-17606626 ] Chesnay Schepler commented on FLINK-29235: -- I guess so. > CVE-2022-25857 on flink-shaded >

[GitHub] [flink] stevenzwu commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-19 Thread GitBox
stevenzwu commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r974416546 ## flink-tests/src/test/java/org/apache/flink/api/connector/source/lib/util/RateLimitedSourceReaderITCase.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
SteNicholas commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974146152 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Closed] (FLINK-29256) Docs for k8s operator webhook

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29256. -- Resolution: Fixed merged to main 1b2b0f3d5dd519fd6c9ea191e4b353679bc7312e > Docs for k8s operator

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
SteNicholas commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974184645 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[GitHub] [flink-kubernetes-operator] jeesmon commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-19 Thread GitBox
jeesmon commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r974199626 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -180,10 +180,6 @@ private

[GitHub] [flink-kubernetes-operator] csviri commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
csviri commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974199023 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Updated] (FLINK-29261) Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils

2022-09-19 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-29261: -- Summary: Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils (was: Consider using

[jira] [Closed] (FLINK-29332) Flink SQL Planner Module doesn't read config from flink-conf.yaml

2022-09-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-29332. -- Resolution: Duplicate > Flink SQL Planner Module doesn't read config from flink-conf.yaml >

[jira] [Closed] (FLINK-29148) Add docs for SQL Gateway

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-29148. --- Resolution: Fixed > Add docs for SQL Gateway > > > Key:

[jira] [Comment Edited] (FLINK-29148) Add docs for SQL Gateway

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606524#comment-17606524 ] Jark Wu edited comment on FLINK-29148 at 9/19/22 2:11 PM: -- Fixed in - master:

[jira] [Closed] (FLINK-29023) Updating Jar statement document

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-29023. --- Fix Version/s: 1.17.0 Assignee: dalongliu Resolution: Fixed Fixed in - master:

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-19 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r974351472 ## flink-tests/src/test/java/org/apache/flink/api/connector/source/lib/DataGeneratorSourceITCase.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #371: [FLINK-29313] Observe spec should include latest operator configs + improved test coverage

2022-09-19 Thread GitBox
gyfora opened a new pull request, #371: URL: https://github.com/apache/flink-kubernetes-operator/pull/371 ## What is the purpose of the change This PR improves the logic of the observe configuration to avoid problems with juggling operator specific confg between the new and deployed

[GitHub] [flink] wuchong commented on pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-19 Thread GitBox
wuchong commented on PR #20696: URL: https://github.com/apache/flink/pull/20696#issuecomment-1251131456 LGTM. I added 4 commits to adjust the page order anduse dash-case ("hive-compatibility") instead of camelCase ("hiveComptibility") in URL and remove "alias" front matter. -- This is

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #371: [FLINK-29313] Observe spec should include latest operator configs + improved test coverage

2022-09-19 Thread GitBox
gyfora commented on PR #371: URL: https://github.com/apache/flink-kubernetes-operator/pull/371#issuecomment-1251131290 cc @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974066032 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java: ## @@ -243,6 +246,22 @@ public void

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974073780 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java: ## @@ -101,6 +105,55 @@ public void

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974073974 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestServerHandler.java: ## @@ -88,10 +88,8 @@ protected void

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974073384 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -451,6 +451,14 @@ public class NettyShuffleEnvironmentOptions {

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974073559 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkSequenceViewReader.java: ## @@ -40,6 +45,30 @@ void requestSubpartitionView( int

[jira] [Updated] (FLINK-29233) Flink Kubernetes Operator example/kustomize not running

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29233: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Flink Kubernetes Operator example/kustomize

[jira] [Created] (FLINK-29336) SubtaskState#discardState swallows exceptions

2022-09-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-29336: - Summary: SubtaskState#discardState swallows exceptions Key: FLINK-29336 URL: https://issues.apache.org/jira/browse/FLINK-29336 Project: Flink Issue Type:

[GitHub] [flink] flinkbot commented on pull request #20855: [FLINK-29337][hive] Fix fail to use Hive Dialect for non-hive table

2022-09-19 Thread GitBox
flinkbot commented on PR #20855: URL: https://github.com/apache/flink/pull/20855#issuecomment-1250960061 ## CI report: * 7d7b0bb51d4d6a0471ced9ba38bfdf23a75824c2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code

2022-09-19 Thread GitBox
morhidi commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1251032990 LGTM, some wording suggestions added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code

2022-09-19 Thread GitBox
morhidi commented on code in PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#discussion_r974256567 ## examples/kubernetes-client-examples/README.MD: ## @@ -0,0 +1,48 @@ + + +# Flink Kubernetes Client Code Example + +## Overview + +This is an

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606613#comment-17606613 ] Jark Wu commented on FLINK-29315: -

[jira] [Commented] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606618#comment-17606618 ] Martijn Visser commented on FLINK-29235: [~chesnay] Should this be fixed before Flink 1.16? >

[jira] [Closed] (FLINK-14055) Add advanced function DDL syntax "USING JAR"

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-14055. --- Resolution: Fixed > Add advanced function DDL syntax "USING JAR" >

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
gyfora merged PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wuchong commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-19 Thread GitBox
wuchong commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r974354109 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +-

[GitHub] [flink] wuchong commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-19 Thread GitBox
wuchong commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r974354501 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +-

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
morhidi commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974107970 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Created] (FLINK-29337) Fix fail to use HiveDialect for non-hive table

2022-09-19 Thread luoyuxia (Jira)
luoyuxia created FLINK-29337: Summary: Fix fail to use HiveDialect for non-hive table Key: FLINK-29337 URL: https://issues.apache.org/jira/browse/FLINK-29337 Project: Flink Issue Type: Bug

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-19 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r974346595 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GatedRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-19 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r974346238 ## flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReaderContext.java: ## @@ -63,4 +63,11 @@ public interface SourceReaderContext { * @see

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #365: [FLINK-29257] Clarify description of SAVEPOINT upgrade mode

2022-09-19 Thread GitBox
gyfora commented on code in PR #365: URL: https://github.com/apache/flink-kubernetes-operator/pull/365#discussion_r974378675 ## docs/content/docs/custom-resource/job-management.md: ## @@ -98,8 +98,8 @@ The `upgradeMode` setting controls both the stop and restore mechanisms as

[jira] [Updated] (FLINK-29131) Kubernetes operator webhook can use hostPort

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29131: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Kubernetes operator webhook can use hostPort

[jira] [Updated] (FLINK-27273) Support both configMap and zookeeper based HA data clean up

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27273: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Support both configMap and zookeeper based HA

[jira] [Updated] (FLINK-27281) Improve stability conditions for rollback logic

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27281: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Improve stability conditions for rollback

[jira] [Updated] (FLINK-26972) Support spot instance in Flink Kubernetes operator

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-26972: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Support spot instance in Flink Kubernetes

[jira] [Updated] (FLINK-27190) Revisit error handling in main reconcile() loop

2022-09-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27190: --- Fix Version/s: (was: kubernetes-operator-1.2.0) > Revisit error handling in main reconcile()

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
SteNicholas commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974183418 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Updated] (FLINK-29337) Fix fail to use HiveDialect for non-hive table

2022-09-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29337: --- Labels: pull-request-available (was: ) > Fix fail to use HiveDialect for non-hive table >

[jira] [Updated] (FLINK-26606) CompletedCheckpoints that failed to be discarded are not stored in the CompletedCheckpointStore

2022-09-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-26606: -- Priority: Major (was: Critical) > CompletedCheckpoints that failed to be discarded are not

[GitHub] [flink] luoyuxia opened a new pull request, #20855: [FLINK-29337][hive] Fix fail to use Hive Dialect for non-hive table

2022-09-19 Thread GitBox
luoyuxia opened a new pull request, #20855: URL: https://github.com/apache/flink/pull/20855 ## What is the purpose of the change Ti fix the failure for the query with non-hive table in Hive dialect. ## Brief change log // todo: ## Verifying this change

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-19 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r974285814 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -180,10 +180,6 @@ private

[jira] [Updated] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-29315: Fix Version/s: 1.16.0 1.17.0 > HDFSTest#testBlobServerRecovery fails on CI >

[GitHub] [flink] wuchong merged pull request #20630: [FLINK-29023][docs][table] Updating Jar statement document

2022-09-19 Thread GitBox
wuchong merged PR #20630: URL: https://github.com/apache/flink/pull/20630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-19 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r974320992 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GatedRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot commented on pull request #20856: [BP-1.16][FLINK-29025][docs] add docs for Hive dialect

2022-09-19 Thread GitBox
flinkbot commented on PR #20856: URL: https://github.com/apache/flink/pull/20856#issuecomment-1251149181 ## CI report: * 2c0a744075586d6cac0e9c5043fc1960a2cee590 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #262: [FLINK-28810] Introduce write.skip-compaction to skip compaction on write

2022-09-19 Thread GitBox
JingsongLi commented on code in PR #262: URL: https://github.com/apache/flink-table-store/pull/262#discussion_r974060913 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyCompactManager.java: ## @@ -58,10 +59,9 @@ public

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974068841 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkSequenceViewReader.java: ## @@ -40,6 +45,30 @@ void requestSubpartitionView( int

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974068347 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java: ## @@ -79,8 +128,47 @@ public ResultSubpartitionView

[GitHub] [flink] zjureel commented on a diff in pull request #19380: [FLINK-25055][runtime] Support listen and notify mechanism for partition request

2022-09-19 Thread GitBox
zjureel commented on code in PR #19380: URL: https://github.com/apache/flink/pull/19380#discussion_r974068617 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java: ## @@ -104,12 +192,40 @@ public void shutdown() {

[jira] [Commented] (FLINK-27530) FLIP-227: Support overdraft buffer

2022-09-19 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606530#comment-17606530 ] fanrui commented on FLINK-27530: Hi [~godfreyhe] , as I understand, [~pnowojski]  has written the

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
morhidi commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974107812 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Commented] (FLINK-29330) Provide better logs of MiniCluster shutdown procedure

2022-09-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606545#comment-17606545 ] Chesnay Schepler commented on FLINK-29330: -- > I noticed that we do not use

[jira] [Created] (FLINK-29332) Flink SQL Planner Module doesn't read config from flink-conf.yaml

2022-09-19 Thread Dhananjay Badaya (Jira)
Dhananjay Badaya created FLINK-29332: Summary: Flink SQL Planner Module doesn't read config from flink-conf.yaml Key: FLINK-29332 URL: https://issues.apache.org/jira/browse/FLINK-29332 Project:

[GitHub] [flink-kubernetes-operator] csviri commented on a diff in pull request #362: [FLINK-28574] Bump the JOSDK version to 3.2.1

2022-09-19 Thread GitBox
csviri commented on code in PR #362: URL: https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974168823 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java: ## @@ -113,6 +113,9 @@ private void

[jira] [Commented] (FLINK-26606) CompletedCheckpoints that failed to be discarded are not stored in the CompletedCheckpointStore

2022-09-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606582#comment-17606582 ] Matthias Pohl commented on FLINK-26606: --- Lowering priority from {{CRITICAL}} to {{Major}} because

  1   2   3   >