[jira] [Updated] (FLINK-29763) TaskManager heatbeat timeout exception in Github CI for python tests

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29763: --- Labels: test-stability (was: ) > TaskManager heatbeat timeout exception in Github CI for py

[jira] [Commented] (FLINK-28985) support create table like view

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624233#comment-17624233 ] Martijn Visser commented on FLINK-28985: [~godfreyhe] WDYT? > support create ta

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #412: [hotfix] Set the default helm image repo

2022-10-26 Thread GitBox
gyfora commented on PR #412: URL: https://github.com/apache/flink-kubernetes-operator/pull/412#issuecomment-1291594234 The content of the Helm Values.yaml in the working branch is intended to use it with your local operator image. I don't think we should set this to the apache repo..

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #407: [FLINK-29713] Kubernetes operator should restart failed jobs

2022-10-26 Thread GitBox
gyfora commented on code in PR #407: URL: https://github.com/apache/flink-kubernetes-operator/pull/407#discussion_r1005299938 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -253,4 +281,14 @

[GitHub] [flink] MartijnVisser commented on pull request #21048: [FLINK-29624][Common][Connector][Filesystem] Upgrade commons-lang3 to 3.12.0

2022-10-26 Thread GitBox
MartijnVisser commented on PR #21048: URL: https://github.com/apache/flink/pull/21048#issuecomment-1291601116 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink-kubernetes-operator] pvary commented on a diff in pull request #407: [FLINK-29713] Kubernetes operator should restart failed jobs

2022-10-26 Thread GitBox
pvary commented on code in PR #407: URL: https://github.com/apache/flink-kubernetes-operator/pull/407#discussion_r1005314178 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -253,4 +281,14 @@

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #413: [do not merge][hotfix] Disable docker buildkit in CI build

2022-10-26 Thread GitBox
gyfora opened a new pull request, #413: URL: https://github.com/apache/flink-kubernetes-operator/pull/413 Attempt at debugging flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] snuyanzin commented on pull request #21153: [hotfix][runtime] Remove private methods

2022-10-26 Thread GitBox
snuyanzin commented on PR #21153: URL: https://github.com/apache/flink/pull/21153#issuecomment-1291623141 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-26 Thread GitBox
gyfora commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1291626292 +1 for having a more concise stacktrace (as a String). This will greately reduce the json size and will make it much more human readable and easier to use. If we lat

[jira] [Updated] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Decuq updated FLINK-29759: Description: Hello, I would like to use LEFT JOIN in order to implement a non blocking jo

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 8:02 AM: ---

[jira] [Commented] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq commented on FLINK-29759: - [~luoyuxia] not the same nullability

[GitHub] [flink-table-store] zhuangchong opened a new pull request, #334: Add maven wrapper

2022-10-26 Thread GitBox
zhuangchong opened a new pull request, #334: URL: https://github.com/apache/flink-table-store/pull/334 Add maven wrapper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 8:12 AM: ---

[jira] [Commented] (FLINK-29674) Apache Kafka Connector‘s “ setBounded” not valid

2022-10-26 Thread hongcha (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624290#comment-17624290 ] hongcha commented on FLINK-29674: - [~martijnvisser] [~coderap] I looked at the part of t

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624291#comment-17624291 ] Martijn Visser commented on FLINK-24119: [~mason6345] Do you have the bandwidth

[jira] [Commented] (FLINK-29758) Serialization issue with enum

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624293#comment-17624293 ] Alexandre Decuq commented on FLINK-29758: - [~martijnvisser] Ok thanks for your q

[GitHub] [flink] liuyongvs commented on pull request #21157: [FLINK-29479][python][hotfix] Fix the testPythonSystemEnvEnabled in PythonOptionsTest

2022-10-26 Thread GitBox
liuyongvs commented on PR #21157: URL: https://github.com/apache/flink/pull/21157#issuecomment-1291672432 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink-table-store] JingsongLi commented on pull request #334: Add maven wrapper

2022-10-26 Thread GitBox
JingsongLi commented on PR #334: URL: https://github.com/apache/flink-table-store/pull/334#issuecomment-1291675343 Thanks @zhuangchong for the contribution, do you have a detailed context? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink] HuangXingBo closed pull request #21157: [FLINK-29479][python][hotfix] Fix the testPythonSystemEnvEnabled in PythonOptionsTest

2022-10-26 Thread GitBox
HuangXingBo closed pull request #21157: [FLINK-29479][python][hotfix] Fix the testPythonSystemEnvEnabled in PythonOptionsTest URL: https://github.com/apache/flink/pull/21157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] waywtdcc opened a new pull request, #21158: [FLINK-28985][table]sql like statement supports views

2022-10-26 Thread GitBox
waywtdcc opened a new pull request, #21158: URL: https://github.com/apache/flink/pull/21158 …types ## What is the purpose of the change *Support language: create table like * ## Brief change log *Support language: create table like * ## Verifying t

[GitHub] [flink] waywtdcc closed pull request #21078: [FLINK-28985][planner]sql like statement supports views

2022-10-26 Thread GitBox
waywtdcc closed pull request #21078: [FLINK-28985][planner]sql like statement supports views URL: https://github.com/apache/flink/pull/21078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] waywtdcc closed pull request #21158: [FLINK-28985][table]sql like statement supports views

2022-10-26 Thread GitBox
waywtdcc closed pull request #21158: [FLINK-28985][table]sql like statement supports views URL: https://github.com/apache/flink/pull/21158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink-kubernetes-operator] darenwkt commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-26 Thread GitBox
darenwkt commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1291703643 Hi @morhidi, I have updated the stackTrace to be a string and added a ConfigOption to limit the length of the stackTrace string. Regarding the concern on de

[GitHub] [flink] waywtdcc opened a new pull request, #21159: [FLINK-28985][table]sql like statement supports views

2022-10-26 Thread GitBox
waywtdcc opened a new pull request, #21159: URL: https://github.com/apache/flink/pull/21159 ## What is the purpose of the change *Support language: create table like view, in jira :https://issues.apache.org/jira/projects/FLINK/issues/FLINK-28985* ## Brief change lo

[jira] [Updated] (FLINK-16419) Avoid to recommit transactions which are known committed successfully to Kafka upon recovery

2022-10-26 Thread Yordan Pavlov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yordan Pavlov updated FLINK-16419: -- Attachment: tm0-transaction.log > Avoid to recommit transactions which are known committed suc

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
gaborgsomogyi opened a new pull request, #21160: URL: https://github.com/apache/flink/pull/21160 ## What is the purpose of the change `HadoopModule` is quite complex and contains reflection which can be simplified. In this PR I've made this simplification keeping the original functio

[GitHub] [flink] flinkbot commented on pull request #21159: [FLINK-28985][table]create table statement supports create table like view

2022-10-26 Thread GitBox
flinkbot commented on PR #21159: URL: https://github.com/apache/flink/pull/21159#issuecomment-1291718082 ## CI report: * f5c9eb1583a8faef6cbb53b08d78a53230a36194 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29761) Simplify HadoopModule

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29761: --- Labels: pull-request-available security (was: security) > Simplify HadoopModule > -

[jira] [Commented] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624312#comment-17624312 ] Alexandre Decuq commented on FLINK-29759: - [~martijnvisser] I tried also to set

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624312#comment-17624312 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 8:59 AM: ---

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 9:03 AM: ---

[jira] [Created] (FLINK-29765) SQL query not executing properly

2022-10-26 Thread Aqib Mehmood (Jira)
Aqib Mehmood created FLINK-29765: Summary: SQL query not executing properly Key: FLINK-29765 URL: https://issues.apache.org/jira/browse/FLINK-29765 Project: Flink Issue Type: Bug Affects

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 9:04 AM: ---

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 9:05 AM: ---

[GitHub] [flink] flinkbot commented on pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
flinkbot commented on PR #21160: URL: https://github.com/apache/flink/pull/21160#issuecomment-1291728233 ## CI report: * 6d3989d4e4ea6bbe429b0f8d6b358c360fbe261e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-29759) Cast type in LEFT JOIN

2022-10-26 Thread Alexandre Decuq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624282#comment-17624282 ] Alexandre Decuq edited comment on FLINK-29759 at 10/26/22 9:06 AM: ---

[GitHub] [flink] snuyanzin opened a new pull request, #21161: [FLINK-25546][flink-connector-base][JUnit5 Migration] Module: flink-connector-base

2022-10-26 Thread GitBox
snuyanzin opened a new pull request, #21161: URL: https://github.com/apache/flink/pull/21161 ## What is the purpose of the change Migrate flink-connector-base module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9b

[jira] [Updated] (FLINK-25546) [JUnit5 Migration] Module: flink-connector-base

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25546: --- Labels: pull-request-available starter (was: starter) > [JUnit5 Migration] Module: flink-co

[GitHub] [flink] wanglijie95 opened a new pull request, #21162: [FLINK-29665][runtime] Support flexible subpartion range division

2022-10-26 Thread GitBox
wanglijie95 opened a new pull request, #21162: URL: https://github.com/apache/flink/pull/21162 ## What is the purpose of the change Support flexible subpartion range division ## Verifying this change Add some tests ## Does this pull request potentially affect one of the fo

[jira] [Updated] (FLINK-29665) Support flexible subpartition range divisions

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29665: --- Labels: pull-request-available (was: ) > Support flexible subpartition range divisions > --

[jira] [Updated] (FLINK-29765) SQL query not executing properly

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29765: --- Priority: Major (was: Blocker) > SQL query not executing properly > ---

[jira] [Updated] (FLINK-29765) SQL query not executing properly

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29765: --- Component/s: Table SQL / Planner > SQL query not executing properly > --

[jira] [Commented] (FLINK-29765) SQL query not executing properly

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624313#comment-17624313 ] Martijn Visser commented on FLINK-29765: [~godfreyhe] [~jark] WDYT? > SQL quer

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
gaborgsomogyi commented on code in PR #21160: URL: https://github.com/apache/flink/pull/21160#discussion_r1005425742 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -69,71 +60,34 @@ public void install() throws SecurityInstallExc

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
gaborgsomogyi commented on code in PR #21160: URL: https://github.com/apache/flink/pull/21160#discussion_r1005428465 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -69,71 +60,34 @@ public void install() throws SecurityInstallExc

[GitHub] [flink] flinkbot commented on pull request #21161: [FLINK-25546][flink-connector-base][JUnit5 Migration] Module: flink-connector-base

2022-10-26 Thread GitBox
flinkbot commented on PR #21161: URL: https://github.com/apache/flink/pull/21161#issuecomment-1291746389 ## CI report: * 055a599e7aa15cbba481dab85aeeb2d9f5112ee7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21162: [FLINK-29665][runtime] Support flexible subpartion range division

2022-10-26 Thread GitBox
flinkbot commented on PR #21162: URL: https://github.com/apache/flink/pull/21162#issuecomment-1291747391 ## CI report: * a90c3f20d260ec8f0b9b3ecee2aedec908ff04d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-19358) HA should not always use jobid 0000000000

2022-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624314#comment-17624314 ] Martijn Visser commented on FLINK-19358: [~gvijay452] It would a breaking change

[jira] [Commented] (FLINK-16419) Avoid to recommit transactions which are known committed successfully to Kafka upon recovery

2022-10-26 Thread Yordan Pavlov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624315#comment-17624315 ] Yordan Pavlov commented on FLINK-16419: --- Let me try to provide some more info on h

[GitHub] [flink] Myasuka merged pull request #20860: [FLINK-29347] [runtime] Fix ByteStreamStateHandle#read return -1 when read count is 0

2022-10-26 Thread GitBox
Myasuka merged PR #20860: URL: https://github.com/apache/flink/pull/20860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Updated] (FLINK-29347) Failed to restore from list state with empty protobuf object

2022-10-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-29347: - Fix Version/s: 1.17.0 > Failed to restore from list state with empty protobuf object > -

[jira] [Resolved] (FLINK-29347) Failed to restore from list state with empty protobuf object

2022-10-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-29347. -- Resolution: Fixed merged in master: db46d434820e8cd964ea97ab2396d8dc9b43ad9f ... d3c7fc9be6aa13872fa2

[GitHub] [flink] Myasuka merged pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-26 Thread GitBox
Myasuka merged PR #20965: URL: https://github.com/apache/flink/pull/20965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Resolved] (FLINK-29244) Add metric lastMaterializationDuration to ChangelogMaterializationMetricGroup

2022-10-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-29244. -- Fix Version/s: 1.17.0 Resolution: Fixed merged in master: de5409afbb003b108518ac5cc2e5ba215063c

[GitHub] [flink] 1996fanrui commented on pull request #21149: [FLINK-29527][format] Make unknownFieldsIndices work for single ParquetReader

2022-10-26 Thread GitBox
1996fanrui commented on PR #21149: URL: https://github.com/apache/flink/pull/21149#issuecomment-1291765606 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] fsk119 commented on a diff in pull request #20652: [FLINK-22315][table] Support add/modify column/constraint/watermark for ALTER TABLE statement

2022-10-26 Thread GitBox
fsk119 commented on code in PR #20652: URL: https://github.com/apache/flink/pull/20652#discussion_r1005314845 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -408,6 +408,336 @@ class TableEnvironmentTest { tab

[jira] [Updated] (FLINK-29244) Add metric lastMaterializationDuration to ChangelogMaterializationMetricGroup

2022-10-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-29244: - Fix Version/s: 1.16.1 > Add metric lastMaterializationDuration to ChangelogMaterializationMetricGroup >

[jira] [Commented] (FLINK-29244) Add metric lastMaterializationDuration to ChangelogMaterializationMetricGroup

2022-10-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624329#comment-17624329 ] Yun Tang commented on FLINK-29244: -- merged in release-1.16: 969967c160bf13a3948df941c4b

[GitHub] [flink-docker] HuangXingBo closed pull request #137: Add GPG key for 1.16.0 release

2022-10-26 Thread GitBox
HuangXingBo closed pull request #137: Add GPG key for 1.16.0 release URL: https://github.com/apache/flink-docker/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [flink] snuyanzin commented on a diff in pull request #18927: [FLINK-26390] Use try resourses for CliClient#executeFile

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #18927: URL: https://github.com/apache/flink/pull/18927#discussion_r1005475075 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -702,14 +698,14 @@ private void closeTerminal() { }

[GitHub] [flink] wangyang0918 commented on pull request #21145: [FLINK-29749][client] flink info commands support dynamic properties.

2022-10-26 Thread GitBox
wangyang0918 commented on PR #21145: URL: https://github.com/apache/flink/pull/21145#issuecomment-1291794197 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #332: [FLINK-29294] Introduce a CompactRewriter for full compaction

2022-10-26 Thread GitBox
JingsongLi commented on code in PR #332: URL: https://github.com/apache/flink-table-store/pull/332#discussion_r1005473806 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/FullChangelogMergeTreeCompactRewriter.java: ## @@ -0,0 +1,135 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #18927: [FLINK-26390] Use try resourses for CliClient#executeFile

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #18927: URL: https://github.com/apache/flink/pull/18927#discussion_r1005475075 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -702,14 +698,14 @@ private void closeTerminal() { }

[GitHub] [flink] snuyanzin commented on a diff in pull request #18927: [FLINK-26390] Use try resourses for CliClient#executeFile

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #18927: URL: https://github.com/apache/flink/pull/18927#discussion_r1005475075 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -702,14 +698,14 @@ private void closeTerminal() { }

[GitHub] [flink] steveloughran commented on a diff in pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
steveloughran commented on code in PR #21160: URL: https://github.com/apache/flink/pull/21160#discussion_r1005501511 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -69,71 +60,34 @@ public void install() throws SecurityInstallExc

[GitHub] [flink] steveloughran commented on a diff in pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
steveloughran commented on code in PR #21160: URL: https://github.com/apache/flink/pull/21160#discussion_r1005503883 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -69,71 +60,34 @@ public void install() throws SecurityInstallExc

[GitHub] [flink] snuyanzin commented on a diff in pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #19897: URL: https://github.com/apache/flink/pull/19897#discussion_r1005519182 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDeSerializationSchemaTest.java: ## @@ -40,7 +40,7 @@ import static org.assertj.core.api.A

[jira] [Assigned] (FLINK-26390) InputStream is not closed at CliClient#executeFile

2022-10-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-26390: - Assignee: Sergey Nuyanzin > InputStream is not closed at CliClient#executeFile > --

[GitHub] [flink] carloscastrojumo commented on a diff in pull request #20982: [FLINK-29539] [Deployment/Kubernetes] dnsPolicy in FlinkPod is not overridable

2022-10-26 Thread GitBox
carloscastrojumo commented on code in PR #20982: URL: https://github.com/apache/flink/pull/20982#discussion_r1005523142 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesJobManagerFactoryTest.java: ## @@ -468,4 +468,37 @@ void testSetJobM

[GitHub] [flink-table-store] zhuangchong commented on pull request #334: Add maven wrapper

2022-10-26 Thread GitBox
zhuangchong commented on PR #334: URL: https://github.com/apache/flink-table-store/pull/334#issuecomment-1291847927 > Thanks @zhuangchong for the contribution, do you have a detailed context? ok, added. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] snuyanzin commented on pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

2022-10-26 Thread GitBox
snuyanzin commented on PR #19897: URL: https://github.com/apache/flink/pull/19897#issuecomment-1291851895 thanks for addressing comments I noticed that there is a bunch of classes still relying on junit4 `org.apache.flink.formats.csv.CsvFileCompactionITCase` `org.apache.flink.formats

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-26 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624367#comment-17624367 ] Salva commented on FLINK-29480: --- Thanks for your reply [~leonard] [~renqs] ! Sure, I'm gla

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #329: [FLINK-28157] Table Store Hive Reader supports Hive3

2022-10-26 Thread GitBox
JingsongLi commented on code in PR #329: URL: https://github.com/apache/flink-table-store/pull/329#discussion_r1005534682 ## docs/content/docs/engines/build.md: ## @@ -50,6 +50,12 @@ You can find Flink 1.15 bundled jar in `./flink-table-store-dist/target/flink-ta To build wi

[GitHub] [flink] gaborgsomogyi commented on pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-26 Thread GitBox
gaborgsomogyi commented on PR #21160: URL: https://github.com/apache/flink/pull/21160#issuecomment-1291861702 @steveloughran So if I understand correctly it would be better to use the original UGI calls instead of the other APIs because: * The ticket cache part has major differences *

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #164: [FLINK-29115] Improve quickstart documents

2022-10-26 Thread GitBox
lindong28 commented on code in PR #164: URL: https://github.com/apache/flink-ml/pull/164#discussion_r1005520306 ## docs/content/docs/development/build-and-install.md: ## @@ -61,9 +61,13 @@ from the root directory of Flink ML: ./flink-ml-dist/target/flink-ml-*-bin/flink-ml*/ ``

[GitHub] [flink-docker] HuangXingBo closed pull request #138: Update Dockerfiles for 1.16.0 release

2022-10-26 Thread GitBox
HuangXingBo closed pull request #138: Update Dockerfiles for 1.16.0 release URL: https://github.com/apache/flink-docker/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29737) Support DataGen on waveform function

2022-10-26 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624376#comment-17624376 ] yuzelin commented on FLINK-29737: - Thanks for your idea. I have some points about this f

[GitHub] [flink] wangyang0918 commented on a diff in pull request #20982: [FLINK-29539] [Deployment/Kubernetes] dnsPolicy in FlinkPod is not overridable

2022-10-26 Thread GitBox
wangyang0918 commented on code in PR #20982: URL: https://github.com/apache/flink/pull/20982#discussion_r1005550293 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/DecoratorWithPodTemplateTestBase.java: ## @@ -215,4 +215,18 @@ void testMainCon

[GitHub] [flink-table-store] JingsongLi merged pull request #334: Add maven wrapper

2022-10-26 Thread GitBox
JingsongLi merged PR #334: URL: https://github.com/apache/flink-table-store/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] wangyang0918 commented on a diff in pull request #20982: [FLINK-29539] [Deployment/Kubernetes] dnsPolicy in FlinkPod is not overridable

2022-10-26 Thread GitBox
wangyang0918 commented on code in PR #20982: URL: https://github.com/apache/flink/pull/20982#discussion_r1005554023 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/DecoratorWithPodTemplateTestBase.java: ## @@ -215,4 +215,18 @@ void testMainCon

[GitHub] [flink] wangyang0918 merged pull request #21145: [FLINK-29749][client] flink info commands support dynamic properties.

2022-10-26 Thread GitBox
wangyang0918 merged PR #21145: URL: https://github.com/apache/flink/pull/21145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] wangyang0918 commented on pull request #21145: [FLINK-29749][client] flink info commands support dynamic properties.

2022-10-26 Thread GitBox
wangyang0918 commented on PR #21145: URL: https://github.com/apache/flink/pull/21145#issuecomment-1291887688 @liuyongvs Could you please create a backport PR for release-1.15 and release-1.16? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (FLINK-29749) flink info command support dynamic properties

2022-10-26 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-29749: -- Fix Version/s: 1.15.3 1.16.1 > flink info command support dynamic properties >

[GitHub] [flink-table-store] JingsongLi merged pull request #326: [FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks

2022-10-26 Thread GitBox
JingsongLi merged PR #326: URL: https://github.com/apache/flink-table-store/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Closed] (FLINK-29702) Add merge tree reader and writer micro benchmarks

2022-10-26 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29702. Fix Version/s: table-store-0.3.0 Assignee: Shammon Resolution: Fixed master: 8af95

[GitHub] [flink] Myasuka commented on pull request #20917: [doc][hotfix] Refine code examples in data_stream_api

2022-10-26 Thread GitBox
Myasuka commented on PR #20917: URL: https://github.com/apache/flink/pull/20917#issuecomment-1291899565 @liuml07 Please refine the commit message to `[hotfix][doc] Refine code examples in data_stream_api ` before I merge this PR. -- This is an automated message from the Apache Git Service

[jira] [Created] (FLINK-29766) Speculative execution supports hybrid shuffle mode.

2022-10-26 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-29766: -- Summary: Speculative execution supports hybrid shuffle mode. Key: FLINK-29766 URL: https://issues.apache.org/jira/browse/FLINK-29766 Project: Flink Issue Type: I

[jira] [Created] (FLINK-29767) Adaptive batch scheduler supports hybrid shuffle

2022-10-26 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-29767: -- Summary: Adaptive batch scheduler supports hybrid shuffle Key: FLINK-29767 URL: https://issues.apache.org/jira/browse/FLINK-29767 Project: Flink Issue Type: Sub-

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1005571712 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java: ## @@ -79,7 +79,8 @@ */ @SuppressWarnings("

[jira] [Updated] (FLINK-29766) Speculative execution supports hybrid shuffle mode.

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29766: --- Labels: Umbrella (was: ) > Speculative execution supports hybrid shuffle mode. > --

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-10-26 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1005571712 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java: ## @@ -79,7 +79,8 @@ */ @SuppressWarnings("

[jira] [Updated] (FLINK-29766) Speculative execution supports hybrid shuffle mode

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29766: --- Summary: Speculative execution supports hybrid shuffle mode (was: Speculative execution supports hy

[jira] [Updated] (FLINK-29766) Speculative execution should also work in hybrid shuffle mode

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29766: --- Summary: Speculative execution should also work in hybrid shuffle mode (was: Speculative execution

[jira] [Commented] (FLINK-14317) make hadoop history server logs accessible through flink ui

2022-10-26 Thread Adrian Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624394#comment-17624394 ] Adrian Zhong commented on FLINK-14317: -- The code is not suitable for common users,

[jira] [Created] (FLINK-29768) Hybrid shuffle supports the update of ResultPartition information

2022-10-26 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-29768: -- Summary: Hybrid shuffle supports the update of ResultPartition information Key: FLINK-29768 URL: https://issues.apache.org/jira/browse/FLINK-29768 Project: Flink

[jira] [Updated] (FLINK-29768) Hybrid shuffle supports the update of ResultPartition information

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29768: --- Affects Version/s: 1.17.0 > Hybrid shuffle supports the update of ResultPartition information >

[jira] [Updated] (FLINK-29768) Hybrid shuffle supports the update of ResultPartition information

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29768: --- Component/s: Runtime / Coordination > Hybrid shuffle supports the update of ResultPartition informat

[jira] [Updated] (FLINK-29767) Adaptive batch scheduler supports hybrid shuffle

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29767: --- Affects Version/s: 1.17.0 > Adaptive batch scheduler supports hybrid shuffle > -

[jira] [Updated] (FLINK-29767) Adaptive batch scheduler supports hybrid shuffle

2022-10-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29767: --- Component/s: Runtime / Coordination > Adaptive batch scheduler supports hybrid shuffle > ---

  1   2   3   >