[jira] [Assigned] (FLINK-3077) Add "version" command to CliFrontend for showing the version of the installation

2015-11-27 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel reassigned FLINK-3077: -- Assignee: Sachin Goel > Add "version" command to CliFrontend for showing the version of the >

[GitHub] flink pull request: [FLINK-3071] Add asynchronous state materializ...

2015-11-27 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1417 [FLINK-3071] Add asynchronous state materialization thread This also adds a test for asynchronous state handles. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3071) Add asynchronous materialization thread

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030053#comment-15030053 ] ASF GitHub Bot commented on FLINK-3071: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3074] Add config option to start YARN A...

2015-11-27 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1416 [FLINK-3074] Add config option to start YARN AM on port range You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink3074

[jira] [Commented] (FLINK-3074) Make ApplicationMaster/JobManager akka port configurable

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030035#comment-15030035 ] ASF GitHub Bot commented on FLINK-3074: --- GitHub user rmetzger opened a pull request:

[jira] [Assigned] (FLINK-3056) Show bytes sent/received as MBs/GB and so on in web interface

2015-11-27 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel reassigned FLINK-3056: -- Assignee: Sachin Goel > Show bytes sent/received as MBs/GB and so on in web interface >

[GitHub] flink pull request: [FLINK-3071] Add asynchronous state materializ...

2015-11-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1417#issuecomment-160175731 I also tested this on a cluster with Kafka and very large state. The backups and kafka I/O were running along smoothly and concurrently. The state was big enough for

[jira] [Commented] (FLINK-3071) Add asynchronous materialization thread

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030050#comment-15030050 ] ASF GitHub Bot commented on FLINK-3071: --- GitHub user aljoscha opened a pull request:

[jira] [Resolved] (FLINK-3082) Confusing error about ManualTimestampSourceFunction

2015-11-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3082. - Resolution: Fixed Fix Version/s: 0.10.2 1.0.0 Fixed in - 1.0 via

[jira] [Closed] (FLINK-3082) Confusing error about ManualTimestampSourceFunction

2015-11-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3082. --- > Confusing error about ManualTimestampSourceFunction >

[jira] [Assigned] (FLINK-3085) Move State Backend Initialization from "registerInputOutput()" to "invoke()"

2015-11-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-3085: --- Assignee: Stephan Ewen > Move State Backend Initialization from "registerInputOutput()" to

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-11-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1243#discussion_r46040790 --- Diff:

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029802#comment-15029802 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2961] [table] Add support for basic typ...

2015-11-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1322#issuecomment-160129102 Looks good now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Created] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-3088: Summary: WritableSerializer cannot copy writable object Key: FLINK-3088 URL: https://issues.apache.org/jira/browse/FLINK-3088 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-3073) Activate streaming mode by default

2015-11-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029808#comment-15029808 ] Aljoscha Krettek commented on FLINK-3073: - +1 > Activate streaming mode by default >

[jira] [Commented] (FLINK-2961) Add support for basic type Date in Table API

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029821#comment-15029821 ] ASF GitHub Bot commented on FLINK-2961: --- Github user aljoscha commented on the pull request:

[jira] [Created] (FLINK-3089) OperatorState timeout

2015-11-27 Thread Niels Basjes (JIRA)
Niels Basjes created FLINK-3089: --- Summary: OperatorState timeout Key: FLINK-3089 URL: https://issues.apache.org/jira/browse/FLINK-3089 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-3082) Confusing error about ManualTimestampSourceFunction

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029783#comment-15029783 ] ASF GitHub Bot commented on FLINK-3082: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3082] Fixed confusing error about an in...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3085) Move State Backend Initialization from "registerInputOutput()" to "invoke()"

2015-11-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029819#comment-15029819 ] Aljoscha Krettek commented on FLINK-3085: - I also have some work in progress here:

[jira] [Commented] (FLINK-3087) Table API do not support multi count in aggregation.

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029935#comment-15029935 ] ASF GitHub Bot commented on FLINK-3087: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3087] [Table-API] support multi count i...

2015-11-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1414#issuecomment-160153032 Hi, the reason it was implemented as it was is to eliminate common subexpressions. For example, if you wrote: ``` select(a.count, b.count) ```

[GitHub] flink pull request: [FLINK-3087] [Table-API] support multi count i...

2015-11-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1414#issuecomment-160153085 It's good that you found the problem and added a test. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-3087) Table API do not support multi count in aggregation.

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029936#comment-15029936 ] ASF GitHub Bot commented on FLINK-3087: --- Github user aljoscha commented on the pull request:

[jira] [Commented] (FLINK-2988) Cannot load DataSet[Row] from CSV file

2015-11-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029767#comment-15029767 ] Aljoscha Krettek commented on FLINK-2988: - I think adding support to {{TableEnvironment}} is the

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029868#comment-15029868 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-11-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1243#issuecomment-160141917 This currently only works when checkpointing is turned on. If checkpointing is turned off, not only the number of queued messages will grow unbounded, but also the messages

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029881#comment-15029881 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on the pull request:

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029886#comment-15029886 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-11-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1243#discussion_r46048074 --- Diff:

[jira] [Closed] (FLINK-3046) Integrate the Either Java type with the TypeExtractor

2015-11-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-3046. --- Resolution: Fixed Fix Version/s: 1.0.0 Fixed via f73a12e728431d87065f7d0082380a527df39e44 >

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029901#comment-15029901 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3046) Integrate the Either Java type with the TypeExtractor

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029898#comment-15029898 ] ASF GitHub Bot commented on FLINK-3046: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-11-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1243#issuecomment-160146335 I'm creating a unit test for the source which mocks the RabbitMQ classes. I would like to merge your pull request with a few changes for both the fault-tolerant and the

[jira] [Updated] (FLINK-3025) Flink Kafka consumer may get stuck due to Kafka/Zookeeper client bug

2015-11-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3025: -- Fix Version/s: (was: 0.10.1) > Flink Kafka consumer may get stuck due to Kafka/Zookeeper

[jira] [Updated] (FLINK-3003) Add container allocation timeout to YARN CLI

2015-11-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3003: -- Fix Version/s: (was: 0.10.1) > Add container allocation timeout to YARN CLI >

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029914#comment-15029914 ] ASF GitHub Bot commented on FLINK-3088: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1415 [FLINK-3088] [serialization] Fix copy method of TypeSerializers which use Kryo Some TypeSerializer, WritableSerializer, ValueSerializer, and AvroSerializer, and comparators,

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46052833 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java --- @@ -96,27 +93,38 @@ public T createInstance() {

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029941#comment-15029941 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029946#comment-15029946 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1415#issuecomment-160155150 I'm wondering whether we could encapsulate the added functionality into a separate method to avoid code duplication? --- If your project is set up for it, you can

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029947#comment-15029947 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46053211 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java --- @@ -96,27 +93,38 @@ public T createInstance() {

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029950#comment-15029950 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46053491 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/ValueComparator.java --- @@ -63,7 +66,22 @@ public int hash(T record) {

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46053720 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java --- @@ -96,27 +93,38 @@ public T createInstance() {

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029954#comment-15029954 ] ASF GitHub Bot commented on FLINK-3088: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46053991 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java --- @@ -96,27 +93,38 @@ public T createInstance() {

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029959#comment-15029959 ] ASF GitHub Bot commented on FLINK-3088: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029964#comment-15029964 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029963#comment-15029963 ] ASF GitHub Bot commented on FLINK-3088: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1415#issuecomment-160157635 It's true that currently the code is duplicated. I'll correct it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1415#discussion_r46054173 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java --- @@ -96,27 +93,38 @@ public T createInstance() {

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029969#comment-15029969 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-11-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1243#discussion_r46054711 --- Diff:

[jira] [Assigned] (FLINK-3071) Add asynchronous materialization thread

2015-11-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3071: --- Assignee: Aljoscha Krettek (was: Stephan Ewen) > Add asynchronous materialization

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1415#issuecomment-160159053 Thanks for reviewing @rmetzger. Addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029972#comment-15029972 ] ASF GitHub Bot commented on FLINK-3088: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

2015-11-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1406#issuecomment-160159242 Thank you for the review. I'll merge it to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029977#comment-15029977 ] ASF GitHub Bot commented on FLINK-3054: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029974#comment-15029974 ] ASF GitHub Bot commented on FLINK-3054: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

2015-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2015-11-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3054. --- Resolution: Fixed Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/09ea3dd0 >

[GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...

2015-11-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1415#issuecomment-160159614 Nice, thank you. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3088) WritableSerializer cannot copy writable object

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029979#comment-15029979 ] ASF GitHub Bot commented on FLINK-3088: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3081] Properly stop periodic Kafka comm...

2015-11-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1410#issuecomment-160159990 Thank you for the review. I'll merge to master and 0.10.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3081) Kafka Periodic Offset Committer does not properly terminate on canceling

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029981#comment-15029981 ] ASF GitHub Bot commented on FLINK-3081: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-160100311 I'd volunteer as a shepherd of this PR. @mjsax I'll review your PR at the latest next week. Sorry for the long period of inactivity from my side. --- If

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029702#comment-15029702 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46033582 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java --- @@ -72,7 +71,7 @@ public static

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029733#comment-15029733 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46033705 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java --- @@ -70,7 +70,7 @@ public static void

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46033750 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCount.java --- @@ -64,7 +63,7 @@ public static

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46033770 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountPojo.java --- @@ -71,7 +70,7 @@ public

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029735#comment-15029735 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46033787 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountWithNames.java --- @@ -75,7 +74,7 @@ public

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029738#comment-15029738 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029740#comment-15029740 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029739#comment-15029739 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46034951 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java --- @@ -193,24 +189,22 @@ public void

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029751#comment-15029751 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[jira] [Closed] (FLINK-3051) Define a maximum number of concurrent inflight checkpoints

2015-11-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3051. --- > Define a maximum number of concurrent inflight checkpoints >

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029753#comment-15029753 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46035118 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java --- @@ -265,12 +264,12 @@ public void testOpen() throws

[jira] [Resolved] (FLINK-3051) Define a maximum number of concurrent inflight checkpoints

2015-11-27 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3051. - Resolution: Fixed Fixed via 55fd5f32d7ef0292a01192ab08456fae49b91791 > Define a maximum number

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029755#comment-15029755 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...

2015-11-27 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r46035298 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java --- @@ -224,7 +224,7 @@ static synchronized

[jira] [Commented] (FLINK-3046) Integrate the Either Java type with the TypeExtractor

2015-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029757#comment-15029757 ] ASF GitHub Bot commented on FLINK-3046: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...

2015-11-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1393#issuecomment-160109895 Looks good, has tests, Travis passes +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as