[jira] [Commented] (FLINK-4516) ResourceManager leadership election

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448237#comment-15448237 ] ASF GitHub Bot commented on FLINK-4516: --- Github user beyond1920 commented on a diff

[GitHub] flink pull request #2427: [FLINK-4516] [cluster management]leader election o...

2016-08-29 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/2427#discussion_r76738145 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerHATest.java --- @@ -0,0 +1,86 @@ +/* + * License

[GitHub] flink pull request #2439: update storm verion to 1.0.0 in flink-storm and fl...

2016-08-29 Thread liuyuzhong
GitHub user liuyuzhong opened a pull request: https://github.com/apache/flink/pull/2439 update storm verion to 1.0.0 in flink-storm and flink-storm-examples This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450 Because Apache Storm

[jira] [Commented] (FLINK-4450) update storm version to 1.0.0

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448204#comment-15448204 ] ASF GitHub Bot commented on FLINK-4450: --- GitHub user liuyuzhong opened a pull reques

[jira] [Comment Edited] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-08-29 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448024#comment-15448024 ] Jark Wu edited comment on FLINK-4469 at 8/30/16 4:51 AM: - Agree wi

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-08-29 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448024#comment-15448024 ] Jark Wu commented on FLINK-4469: Agree with that. Using a collector will be more user-frie

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2305 Hi @aljoscha @StephanEwen , this issue has been blocked for some days. It would be great, if you can have a look again ? --- If your project is set up for it, you can reply to this email and hav

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448012#comment-15448012 ] ASF GitHub Bot commented on FLINK-4271: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-4484) FLIP-10: Unify Savepoints and Checkpoints

2016-08-29 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448004#comment-15448004 ] ramkrishna.s.vasudevan commented on FLINK-4484: --- I can help out in the sub t

[jira] [Commented] (FLINK-4363) Implement TaskManager basic startup of all components in java

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447911#comment-15447911 ] ASF GitHub Bot commented on FLINK-4363: --- Github user wangzhijiang999 commented on th

[GitHub] flink issue #2400: [FLINK-4363] Implement TaskManager basic startup of all c...

2016-08-29 Thread wangzhijiang999
Github user wangzhijiang999 commented on the issue: https://github.com/apache/flink/pull/2400 @mxm , I have created the FLINK-4505 for TaskExecutorFactory issue. As you mentioned, it should be an abstract class and provide an abstract method maybe called 'createAndStartTaskExecutor()'

[jira] [Commented] (FLINK-4363) Implement TaskManager basic startup of all components in java

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447907#comment-15447907 ] ASF GitHub Bot commented on FLINK-4363: --- Github user wangzhijiang999 commented on th

[GitHub] flink issue #2400: [FLINK-4363] Implement TaskManager basic startup of all c...

2016-08-29 Thread wangzhijiang999
Github user wangzhijiang999 commented on the issue: https://github.com/apache/flink/pull/2400 @mxm, I already push my changes and solve the conflicts based on the new flip-6 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447903#comment-15447903 ] ASF GitHub Bot commented on FLINK-4068: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-08-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2102 Thanks @twalthr . This issue is more complex than I expected before. I will try to update this PR in next days. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-4375) Introduce rpc protocols implemented by job manager

2016-08-29 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447770#comment-15447770 ] Wenlong Lyu commented on FLINK-4375: the definition will be split into special interac

[jira] [Closed] (FLINK-4375) Introduce rpc protocols implemented by job manager

2016-08-29 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenlong Lyu closed FLINK-4375. -- Resolution: Invalid > Introduce rpc protocols implemented by job manager > -

[jira] [Commented] (FLINK-1914) Wrong FS while starting YARN session without correct HADOOP_HOME

2016-08-29 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447480#comment-15447480 ] Neelesh Srinivas Salian commented on FLINK-1914: Can I work on this JIRA,

[jira] [Commented] (FLINK-2247) Improve the way memory is reported in the web frontend

2016-08-29 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447477#comment-15447477 ] Neelesh Srinivas Salian commented on FLINK-2247: Hi [~tvas], please let me

[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-08-29 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447356#comment-15447356 ] Neelesh Srinivas Salian commented on FLINK-3999: Thank you [~ggevay]. Will

[jira] [Commented] (FLINK-4245) Metric naming improvements

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446747#comment-15446747 ] ASF GitHub Bot commented on FLINK-4245: --- Github user zentol commented on the issue:

[GitHub] flink issue #2418: [FLINK-4245] JMXReporter exposes all defined variables

2016-08-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2418 Well this won't be pretty. The problem lies with the "name" check we have to do since we mustn't modify the underlying map, since it belongs to the metric groups. As you showed in your exampl

[jira] [Closed] (FLINK-4531) Thread.stop() is deprecated

2016-08-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4531. --- > Thread.stop() is deprecated > --- > > Key: FLINK-4531 >

[jira] [Resolved] (FLINK-4531) Thread.stop() is deprecated

2016-08-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler resolved FLINK-4531. - Resolution: Won't Fix > Thread.stop() is deprecated > --- > >

[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446540#comment-15446540 ] ASF GitHub Bot commented on FLINK-4528: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2436: [FLINK-4528] [rpc] Marks main thread execution methods in...

2016-08-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2436 I think that the `RpcEndpoint` should keep the control over which components have access to its main thread and which not. Furthermore, limiting the access to protected does not prohibit other c

[jira] [Created] (FLINK-4531) Thread.stop() is deprecated

2016-08-29 Thread Ted Yu (JIRA)
Ted Yu created FLINK-4531: - Summary: Thread.stop() is deprecated Key: FLINK-4531 URL: https://issues.apache.org/jira/browse/FLINK-4531 Project: Flink Issue Type: Bug Reporter: Ted Yu

[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446448#comment-15446448 ] ASF GitHub Bot commented on FLINK-4528: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2436: [FLINK-4528] [rpc] Marks main thread execution met...

2016-08-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2436#discussion_r76645756 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutorToResourceManagerConnection.java --- @@ -93,22 +94,24 @@ pub

[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446425#comment-15446425 ] ASF GitHub Bot commented on FLINK-4528: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2436: [FLINK-4528] [rpc] Marks main thread execution methods in...

2016-08-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2436 I am not sure I agree with this change. There are cases when another class logically belongs to the RPC endpoint (such as a connection utility). Being able to access the RPC execution con

[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446421#comment-15446421 ] ASF GitHub Bot commented on FLINK-4528: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2436: [FLINK-4528] [rpc] Marks main thread execution met...

2016-08-29 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2436#discussion_r76643397 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutorToResourceManagerConnection.java --- @@ -93,22 +94,24 @@ publ

[jira] [Commented] (FLINK-3950) Add Meter Metric Type

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446417#comment-15446417 ] ASF GitHub Bot commented on FLINK-3950: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2374: [FLINK-3950] Add Meter Metric Type

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2374 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4361) Replace Scala Futures

2016-08-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446392#comment-15446392 ] Till Rohrmann commented on FLINK-4361: -- I'm not sure whether it's worth the effort to

[jira] [Updated] (FLINK-4436) Unclosed DataOutputBuffer in Utils#setTokensFor()

2016-08-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4436: -- Description: {code} DataOutputBuffer dob = new DataOutputBuffer(); credentials.writeTokenStorageToStream

[GitHub] flink pull request #2423: [FLINK-4486] detached YarnSession: wait until clus...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4439) Error message KafkaConsumer08 when all 'bootstrap.servers' are invalid

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446324#comment-15446324 ] ASF GitHub Bot commented on FLINK-4439: --- Github user gheo21 commented on the issue:

[jira] [Resolved] (FLINK-4495) Running multiple jobs on yarn (without yarn-session)

2016-08-29 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-4495. --- Resolution: Duplicate Fix Version/s: 1.1.2 1.2.0 Should be r

[jira] [Closed] (FLINK-4526) ApplicationClient: remove redundant proxy messages

2016-08-29 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-4526. - Resolution: Fixed master: 31c88a564a8eda263aedada0da671357d1a6f524 release-1.1: f7ec1efb32

[jira] [Closed] (FLINK-4488) Prevent cluster shutdown after job execution for non-detached jobs

2016-08-29 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-4488. - Resolution: Fixed master: 87114cd2aaf78de2114d1ea4ab7bd2b57494d716 release-1.1: 28da995494

[jira] [Resolved] (FLINK-4486) JobManager not fully running when yarn-session.sh finishes

2016-08-29 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-4486. --- Resolution: Fixed master: ab1df63c3fd419c23631f3b55b506e6fdf3cb72f release-1.1: 4cdeb1

[jira] [Commented] (FLINK-4488) Prevent cluster shutdown after job execution for non-detached jobs

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446320#comment-15446320 ] ASF GitHub Bot commented on FLINK-4488: --- Github user asfgit closed the pull request

[GitHub] flink issue #2397: [FLINK-4439] Validate 'bootstrap.servers' config in flink...

2016-08-29 Thread gheo21
Github user gheo21 commented on the issue: https://github.com/apache/flink/pull/2397 @StephanEwen pull request updated, please have a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (FLINK-4486) JobManager not fully running when yarn-session.sh finishes

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446322#comment-15446322 ] ASF GitHub Bot commented on FLINK-4486: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-4526) ApplicationClient: remove redundant proxy messages

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446321#comment-15446321 ] ASF GitHub Bot commented on FLINK-4526: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2437: [FLINK-4526][yarn] remove redundant proxy messages

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2419: [FLINK-4488] only automatically shutdown clusters ...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2419 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-4525) Drop the "eager split pre-assignment" code paths

2016-08-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4525. --- > Drop the "eager split pre-assignment" code paths > > >

[jira] [Resolved] (FLINK-4525) Drop the "eager split pre-assignment" code paths

2016-08-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4525. - Resolution: Fixed Fixed via 578e80e3c161601d22760ef2ea0e52e6ae963786 > Drop the "eager split pre-

[jira] [Commented] (FLINK-4485) Finished jobs in yarn session fill /tmp filesystem

2016-08-29 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446231#comment-15446231 ] Maximilian Michels commented on FLINK-4485: --- Thanks for the update. That's very

[jira] [Commented] (FLINK-4055) EventTimeWindowCheckpointingITCase.testPreAggregatedSlidingTimeWindow fails on Travis

2016-08-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446226#comment-15446226 ] Till Rohrmann commented on FLINK-4055: -- It happened again: https://s3.amazonaws.com/

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446201#comment-15446201 ] ASF GitHub Bot commented on FLINK-1984: --- Github user mxm commented on the issue:

[jira] [Created] (FLINK-4530) Generalize TaskExecutorToResourceManagerConnection to be reusable

2016-08-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4530: Summary: Generalize TaskExecutorToResourceManagerConnection to be reusable Key: FLINK-4530 URL: https://issues.apache.org/jira/browse/FLINK-4530 Project: Flink

[GitHub] flink issue #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1)

2016-08-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2315 Thank you so much for your contribution @EronWright! Looking forward to see the Mesos integration in Flink grow :) --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446195#comment-15446195 ] ASF GitHub Bot commented on FLINK-1984: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4439) Error message KafkaConsumer08 when all 'bootstrap.servers' are invalid

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446162#comment-15446162 ] ASF GitHub Bot commented on FLINK-4439: --- Github user gheo21 commented on the issue:

[GitHub] flink issue #2397: [FLINK-4439] Validate 'bootstrap.servers' config in flink...

2016-08-29 Thread gheo21
Github user gheo21 commented on the issue: https://github.com/apache/flink/pull/2397 @StephanEwen I will submit shortly an update then you can take a look. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446154#comment-15446154 ] ASF GitHub Bot commented on FLINK-4496: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2434: [FLINK-4496] Refactor the TimeServiceProvider to take a T...

2016-08-29 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2434 I had comments about introducing an interface for the asynchronous excepts, other than that and @rmetzger's comment this looks good. I like the addition of the `TimeProviderTest`. 👍 --- If you

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446151#comment-15446151 ] ASF GitHub Bot commented on FLINK-4496: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-08-29 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2434#discussion_r76625434 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OneInputStreamOperatorTestHarness.java --- @@ -98,7 +99,7 @@ public OneInputSt

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446144#comment-15446144 ] ASF GitHub Bot commented on FLINK-4496: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-08-29 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2434#discussion_r76624854 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -28,15 +31,22 @@ */

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446140#comment-15446140 ] ASF GitHub Bot commented on FLINK-4496: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-08-29 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2434#discussion_r76624448 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java ---

[jira] [Commented] (FLINK-4485) Finished jobs in yarn session fill /tmp filesystem

2016-08-29 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446104#comment-15446104 ] Niels Basjes commented on FLINK-4485: - I didn't change that setting. In the web UI I s

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446101#comment-15446101 ] ASF GitHub Bot commented on FLINK-1984: --- Github user mxm commented on the issue:

[GitHub] flink issue #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1)

2016-08-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2315 Fixing the errors and trying to rebase your changes on top of the latest master now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446098#comment-15446098 ] ASF GitHub Bot commented on FLINK-1984: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2315: [FLINK-1984] Integrate Flink with Apache Mesos (T1...

2016-08-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2315#discussion_r76621116 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredJobManager.scala --- @@ -0,0 +1,172 @@ +/* --- End diff --

[GitHub] flink issue #2432: [FLINK-4514][kinesis-connector] Handle unexpected Expired...

2016-08-29 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2432 I think a check for the interval to be lower than 5 minutes is sufficient. Setting the limit to 4.5 min seems to be a bit too strict. You never know if some advanced users want to cover a very speci

[jira] [Commented] (FLINK-4514) ExpiredIteratorException in Kinesis Consumer on long catch-ups to head of stream

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446086#comment-15446086 ] ASF GitHub Bot commented on FLINK-4514: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2432: [FLINK-4514][kinesis-connector] Handle unexpected ...

2016-08-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2432#discussion_r76620194 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@

[jira] [Commented] (FLINK-4529) Move JobMaster, TaskExecutor and ResourceManager out of the rpc package

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446064#comment-15446064 ] ASF GitHub Bot commented on FLINK-4529: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2438: [FLINK-4529] [flip-6] Move TaskExecutor, JobMaster...

2016-08-29 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2438 [FLINK-4529] [flip-6] Move TaskExecutor, JobMaster and ResourceManager out of the rpc package The TaskExecutor, the JobMaster and the ResourceManager were still contained in the rpc packag

[jira] [Commented] (FLINK-4527) Drop the "flinkAccumulators" from the Execution

2016-08-29 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446061#comment-15446061 ] Ivan Mushketyk commented on FLINK-4527: --- Hi [~StephanEwen], Does this mean that acc

[jira] [Commented] (FLINK-4514) ExpiredIteratorException in Kinesis Consumer on long catch-ups to head of stream

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446048#comment-15446048 ] ASF GitHub Bot commented on FLINK-4514: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2432: [FLINK-4514][kinesis-connector] Handle unexpected ...

2016-08-29 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2432#discussion_r76617364 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@

[jira] [Commented] (FLINK-4514) ExpiredIteratorException in Kinesis Consumer on long catch-ups to head of stream

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446044#comment-15446044 ] ASF GitHub Bot commented on FLINK-4514: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2432: [FLINK-4514][kinesis-connector] Handle unexpected Expired...

2016-08-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2432 The latest commit sets the check to be less than 5 minutes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[jira] [Commented] (FLINK-4363) Implement TaskManager basic startup of all components in java

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446040#comment-15446040 ] ASF GitHub Bot commented on FLINK-4363: --- Github user mxm commented on the issue:

[GitHub] flink issue #2400: [FLINK-4363] Implement TaskManager basic startup of all c...

2016-08-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2400 @wangzhijiang999 Could you port your changes to the new flip-6 branch? We can then go ahead and merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appea

[jira] [Commented] (FLINK-4526) ApplicationClient: remove redundant proxy messages

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446003#comment-15446003 ] ASF GitHub Bot commented on FLINK-4526: --- GitHub user mxm opened a pull request:

[jira] [Commented] (FLINK-4514) ExpiredIteratorException in Kinesis Consumer on long catch-ups to head of stream

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446017#comment-15446017 ] ASF GitHub Bot commented on FLINK-4514: --- Github user rmetzger commented on the issue

[GitHub] flink issue #2433: docs: fixed timestamp extractor documentation Java exampl...

2016-08-29 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2433 Thank you for the fix. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[jira] [Created] (FLINK-4529) Move JobMaster, TaskExecutor and ResourceManager out of the rpc package

2016-08-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4529: Summary: Move JobMaster, TaskExecutor and ResourceManager out of the rpc package Key: FLINK-4529 URL: https://issues.apache.org/jira/browse/FLINK-4529 Project: Flink

[GitHub] flink pull request #2433: docs: fixed timestamp extractor documentation Java...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2437: [FLINK-4526][yarn] remove redundant proxy messages

2016-08-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2437 [FLINK-4526][yarn] remove redundant proxy messages Merging this with #2423 with #2419. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLI

[GitHub] flink issue #2031: FLINK-3967 - Flink Sink for Rethink Db

2016-08-29 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2031 Hi @mans2singh, I'm happy to hear that you are interested in contributing the code to Bahir. You can just fork the bahir-flink repo and create a folder similar to the existing connectors

[jira] [Commented] (FLINK-3967) Provide RethinkDB Sink for Flink

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445995#comment-15445995 ] ASF GitHub Bot commented on FLINK-3967: --- Github user rmetzger commented on the issue

[GitHub] flink issue #2102: [FLINK-4068] [tableAPI] Move constant computations out of...

2016-08-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2102 @wuchong I have added symbols recently. So functions like `TRIM` are now called correctly. If you like you could update this PR. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445976#comment-15445976 ] ASF GitHub Bot commented on FLINK-4528: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445978#comment-15445978 ] Robert Metzger commented on FLINK-4496: --- What's the reasoning behind this change? >

[GitHub] flink pull request #2436: [FLINK-4528] [rpc] Marks main thread execution met...

2016-08-29 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2436 [FLINK-4528] [rpc] Marks main thread execution methods in RpcEndpoint as protected The main thread execution methods should not be exposed to the outside world of the `RpcEndpoint`, because th

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445974#comment-15445974 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445966#comment-15445966 ] ASF GitHub Bot commented on FLINK-4496: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-08-29 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2434#discussion_r76612209 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -57,4 +67,49 @@ public void shu

  1   2   3   >