[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

2017-11-27 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4748 Thanks for merging! ---

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268278#comment-16268278 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 Already submit the codes for the missed comments, @NicoK ---

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268222#comment-16268222 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r153405989 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java --- @@ -224,17 +224,9 @@ public void registerTask(Task t

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268209#comment-16268209 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4552 @NicoK , thanks for focusing on the last PR. I am supposed to divide this into two separate ones as you said. But I am afraid some current tests may fail if I only modify and enable the cre

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268193#comment-16268193 ] ASF GitHub Bot commented on FLINK-7468: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4559: [FLINK-7468][network] Implement sender backlog logic for ...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4559 @zentol , the failure travis seems no related with my codes. Do I need to restart the travis to pass the tests before merging this PR? ---

[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @NicoK , I updated the codes for the above comments. ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268186#comment-16268186 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on the issu

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268180#comment-16268180 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153401374 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -283,10 +283,13 @@ public Stri

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-27 Thread Aegeaner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268127#comment-16268127 ] Aegeaner commented on FLINK-8139: - know it, we can get the type class. > Check for proper

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268126#comment-16268126 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-27 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 `mvn clean verify -pl flink-clients`, No dependency problems found. > [INFO] --- maven-dependency-plugin:3.0.2:analyze-only (analyze) @ flink-clients_2.11 --- > [INFO] No dependency proble

[GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...

2017-11-27 Thread Aegeaner
Github user Aegeaner commented on the issue: https://github.com/apache/flink/pull/5065 @twalthr But when registering a table/TableSource, we only got a `TableSchema`, which is an array of `TypeInformation` ? How should I check the instances of values? ---

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268123#comment-16268123 ] ASF GitHub Bot commented on FLINK-8139: --- Github user Aegeaner commented on the issue

[jira] [Closed] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-8142. - Resolution: Implemented master: f2b804a7479dcba7980dd68a445635f4ac2198c0 > Cleanup reference to deprecate

[jira] [Closed] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-7967. - Resolution: Implemented master: fae83c0b0c0a711d5d0f9de0b95fb6b703c4f912 > Deprecate Hadoop specific Flin

[jira] [Closed] (FLINK-8105) Removed unnecessary null check

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-8105. - Resolution: Implemented master: 3561222c5d6c7cee79f8c5872f32227632135c48 > Removed unnecessary null check

[jira] [Updated] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-7967: -- Fix Version/s: 1.5.0 > Deprecate Hadoop specific Flink configuration options > -

[GitHub] flink pull request #5034: [FLINK-8105][minor] Removed unnecessary null check

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5034 ---

[jira] [Commented] (FLINK-8105) Removed unnecessary null check

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268037#comment-16268037 ] ASF GitHub Bot commented on FLINK-8105: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268035#comment-16268035 ] ASF GitHub Bot commented on FLINK-8142: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4946: [FLINK-7967] [config] Deprecate Hadoop specific Fl...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4946 ---

[GitHub] flink pull request #4748: [hotfix][tests] Use G1GC for tests

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4748 ---

[GitHub] flink pull request #5067: [FLINK-8142][config] Cleanup reference to deprecat...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5067 ---

[jira] [Commented] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268036#comment-16268036 ] ASF GitHub Bot commented on FLINK-7967: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8155) Class org.apache.hadoop.yarn.client.RequestHedgingRMFailoverProxyProvider not found

2017-11-27 Thread jiesen.li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268013#comment-16268013 ] jiesen.li commented on FLINK-8155: -- no no no,same problem,I tried many versions about 1.3

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-27 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267995#comment-16267995 ] Xingcan Cui commented on FLINK-8158: Hi [~hequn8128], there's a document about the str

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-27 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267990#comment-16267990 ] Hequn Cheng commented on FLINK-8158: [~fhueske] [~xccui] hi, Moreover I am confused ab

[jira] [Updated] (FLINK-8158) Rowtime window inner join emits late data

2017-11-27 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-8158: --- Attachment: screenshot-1xxx.png > Rowtime window inner join emits late data >

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267973#comment-16267973 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-27 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r153378748 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void addExc

[GitHub] flink issue #5045: [hotfix][docs] Review of concepts docs for grammar and cl...

2017-11-27 Thread ChrisChinchilla
Github user ChrisChinchilla commented on the issue: https://github.com/apache/flink/pull/5045 Changes pushed. ---

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-27 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r153374829 --- Diff: docs/concepts/runtime.md --- @@ -74,10 +74,10 @@ To control how many tasks a worker accepts, a worker has so called **task slots* Each

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-27 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r153374312 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch applicat

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-27 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/5063 @fhueske Thanks a lot for your comments. Definitely agree with you on the motivation of punctuated watermark. But in practice, there are many cases there is no watermark information in the source data

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267921#comment-16267921 ] ASF GitHub Bot commented on FLINK-8144: --- Github user dianfu commented on the issue:

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267816#comment-16267816 ] ASF GitHub Bot commented on FLINK-7636: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOptTable,...

2017-11-27 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4681 Hi @beyond1920, I would like to apply your refactoring for the next release 1.5.0. However, we touched quite a few files for the refactoring of the `TableSource` interface in Flink 1.4.0. Can you reb

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267762#comment-16267762 ] ASF GitHub Bot commented on FLINK-8144: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-27 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5063 A punctuated watermark assigner can emit `null` instead of a watermark. So using a punctuated watermark assigner does not mean that for each event a watermark must be emitted. The motivation for punc

[jira] [Updated] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-11-27 Thread Cristian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cristian updated FLINK-8162: Description: When reading from Kinesis streams, one of the most valuable metrics is "MillisBehindLatest" (s

[jira] [Created] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-11-27 Thread Cristian (JIRA)
Cristian created FLINK-8162: --- Summary: Kinesis Connector to report millisBehindLatest metric Key: FLINK-8162 URL: https://issues.apache.org/jira/browse/FLINK-8162 Project: Flink Issue Type: Improve

[jira] [Updated] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-8126: -- Fix Version/s: 1.4.0 > Update and fix checkstyle > - > > Key: FL

[jira] [Closed] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-8126. - Resolution: Fixed 1.4: 4eae418b410c928b8e4b7893c1f5b9c48a5e3228 > Update and fix checkstyle > ---

[jira] [Reopened] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan reopened FLINK-8126: --- > Update and fix checkstyle > - > > Key: FLINK-8126 >

[jira] [Commented] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267406#comment-16267406 ] ASF GitHub Bot commented on FLINK-8142: --- Github user greghogan commented on the issu

[GitHub] flink issue #5067: [FLINK-8142][config] Cleanup reference to deprecated cons...

2017-11-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5067 +1; merging ... ---

[GitHub] flink issue #5047: Code refine of WordWithCount

2017-11-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5047 Do we still want to make this change since the PR is now only adding a single comment? ---

[jira] [Commented] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267309#comment-16267309 ] ASF GitHub Bot commented on FLINK-8126: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5061: [hotfix] [docs] Update checkstyle version in docum...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5061 ---

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5091 [FLINK-7956] [flip6] Add support for queued scheduling with slot sharing to SlotPool ## What is the purpose of the change This commit adds support for queued scheduling with slot shari

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267135#comment-16267135 ] ASF GitHub Bot commented on FLINK-7956: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267112#comment-16267112 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267111#comment-16267111 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267113#comment-16267113 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267109#comment-16267109 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267110#comment-16267110 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153261175 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -152,6 +170,26 @@ public void channelRead

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153266186 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -539,4 +542,60 @@ static CloseRequest readFrom(@Supp

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153269318 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -283,10 +283,13 @@ public String t

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153258008 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -88,6 +98,15 @@ void cancelRequestFor(Inp

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153263139 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -274,4 +313,49 @@ private void decodeBuff

[jira] [Commented] (FLINK-8089) Fulfil slot requests with unused offered slots

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267101#comment-16267101 ] ASF GitHub Bot commented on FLINK-8089: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5090: [FLINK-8089] Also check for other pending slot req...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5090 [FLINK-8089] Also check for other pending slot requests in SlotPool#offerSlot ## What is the purpose of the change Not only check for a slot request with the right allocation id but al

[jira] [Commented] (FLINK-8088) Bind logical slots to their request id instead of the slot allocation id

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267094#comment-16267094 ] ASF GitHub Bot commented on FLINK-8088: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5089: [FLINK-8088] Associate logical slots with the slot...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5089 [FLINK-8088] Associate logical slots with the slot request id ## What is the purpose of the change Before, logical slots like the `SimpleSlot` and `SharedSlot` where associated to the

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267088#comment-16267088 ] ASF GitHub Bot commented on FLINK-8087: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5088 [FLINK-8087] Decouple Slot from AllocatedSlot ## What is the purpose of the change This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the r

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5087 [FLINK-8085] Thin out LogicalSlot interface ## What is the purpose of the change Remove isCanceled, isReleased method and decouple logical slot from Execution by introducing a Payl

[jira] [Commented] (FLINK-8085) Thin out the LogicalSlot interface

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267082#comment-16267082 ] ASF GitHub Bot commented on FLINK-8085: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-8078) Decouple Execution from actual slot implementation

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267070#comment-16267070 ] ASF GitHub Bot commented on FLINK-8078: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5086: [FLINK-8078] Introduce LogicalSlot interface

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5086 [FLINK-8078] Introduce LogicalSlot interface ## What is the purpose of the change The LogicalSlot interface decouples the task deployment from the actual slot implementation which at t

[jira] [Commented] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-11-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267051#comment-16267051 ] Ted Yu commented on FLINK-7642: --- Over in hbase, we use 2.20.1 . SUREFIRE-1255 has been inac

[jira] [Commented] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267037#comment-16267037 ] Greg Hogan commented on FLINK-7642: --- Please stop adding and removing a blank line from t

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267030#comment-16267030 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r153253247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void addExclusi

[jira] [Commented] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267023#comment-16267023 ] ASF GitHub Bot commented on FLINK-8161: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5085: [FLINK-8161] [tests] Harden YARNSessionCapacitySch...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5085 [FLINK-8161] [tests] Harden YARNSessionCapacitySchedulerITCase ## What is the purpose of the change Add "Remote connection to [null] failed with java.nio.channels.NotYetConnectedExcept

[jira] [Created] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2017-11-27 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8161: Summary: Flakey YARNSessionCapacitySchedulerITCase on Travis Key: FLINK-8161 URL: https://issues.apache.org/jira/browse/FLINK-8161 Project: Flink Issue Type:

[GitHub] flink pull request #:

2017-11-27 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/c940d5eff9897796625a696ed2989aed52c39ebd#commitcomment-25875079 In tools/releasing/create_source_release.sh: In tools/releasing/create_source_release.sh on line 60: maybe we should have a w

[jira] [Commented] (FLINK-7717) Port TaskManagerMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267007#comment-16267007 ] ASF GitHub Bot commented on FLINK-7717: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5081: [FLINK-7717][flip6] Migrate TaskManagerMetricsHand...

2017-11-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5081#discussion_r153243460 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/TaskManagerMetricsHandler.java --- @@ -0,0 +1,64 @@ +/* + * Lice

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266992#comment-16266992 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153241166 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java --- @@ -0,0 +1,195 @@ +/* + * License

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266984#comment-16266984 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r152985049 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java --- @@ -224,17 +224,9 @@ public void registerTask(Task task)

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266966#comment-16266966 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266965#comment-16266965 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153234962 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -190,6 +199,11 @@ public static TaskManag

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153235421 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java --- @@ -510,6 +512,13 @@ private stati

[jira] [Closed] (FLINK-8154) JobSubmissionClientActor submited job,but there is no connection to a JobManager

2017-11-27 Thread Gregory Melekh (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Melekh closed FLINK-8154. - Resolution: Not A Problem > JobSubmissionClientActor submited job,but there is no connection to a

[jira] [Commented] (FLINK-8154) JobSubmissionClientActor submited job,but there is no connection to a JobManager

2017-11-27 Thread Gregory Melekh (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266949#comment-16266949 ] Gregory Melekh commented on FLINK-8154: --- Ohhh...You are right... I should create hea

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266940#comment-16266940 ] ASF GitHub Bot commented on FLINK-7499: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4581 Still failing with some checkstyle violations in `ResultPartition.java` ---

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266871#comment-16266871 ] ASF GitHub Bot commented on FLINK-8090: --- Github user aljoscha commented on the issue

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-27 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5032 We could check based on the state descriptor. ---

  1   2   >