[jira] [Commented] (FLINK-9511) Implement TTL config

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538030#comment-16538030 ] ASF GitHub Bot commented on FLINK-9511: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #6277: [FLINK-9511] Implement TTL config

2018-07-09 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/6277#discussion_r201216406 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java --- @@ -93,4 +97,82 @@ public Time getTtl() {

[GitHub] flink issue #6290: [Flink-9691] [Kinesis Connector] Attempt to call getRecor...

2018-07-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/6290 +1, LGTM ---

[jira] [Commented] (FLINK-9380) Failing end-to-end tests should not clean up logs

2018-07-09 Thread Deepak Sharma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537880#comment-16537880 ] Deepak Sharma commented on FLINK-9380: -- [~florianschmidt], [~till.rohrmann], the CI build is

[jira] [Commented] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-07-09 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537834#comment-16537834 ] Jamie Grier commented on FLINK-9691: https://github.com/apache/flink/pull/6290 > Modify run loop in

[jira] [Updated] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-07-09 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Grier updated FLINK-9691: --- Affects Version/s: 1.5.0 1.4.2 > Modify run loop in Kinesis ShardConsumer to

[GitHub] flink pull request #6290: [Flink-9691] [Kinesis Connector] Attempt to call g...

2018-07-09 Thread jgrier
GitHub user jgrier opened a pull request: https://github.com/apache/flink/pull/6290 [Flink-9691] [Kinesis Connector] Attempt to call getRecords() at correct frequency. ## What is the purpose of the change The purpose of this change is to make the Kinesis connector

[jira] [Created] (FLINK-9786) Publish Python libraries to pypi

2018-07-09 Thread Jakob Homan (JIRA)
Jakob Homan created FLINK-9786: -- Summary: Publish Python libraries to pypi Key: FLINK-9786 URL: https://issues.apache.org/jira/browse/FLINK-9786 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-9616) DatadogHttpReporter fails to be created due to missing shaded dependency

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537743#comment-16537743 ] ASF GitHub Bot commented on FLINK-9616: --- Github user addisonj commented on the issue:

[jira] [Commented] (FLINK-9616) DatadogHttpReporter fails to be created due to missing shaded dependency

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537744#comment-16537744 ] ASF GitHub Bot commented on FLINK-9616: --- Github user addisonj closed the pull request at:

[GitHub] flink pull request #6183: [FLINK-9616][metrics] Fix datadog to include shade...

2018-07-09 Thread addisonj
Github user addisonj closed the pull request at: https://github.com/apache/flink/pull/6183 ---

[GitHub] flink issue #6183: [FLINK-9616][metrics] Fix datadog to include shaded deps

2018-07-09 Thread addisonj
Github user addisonj commented on the issue: https://github.com/apache/flink/pull/6183 This is fixed by #6191 ---

[jira] [Closed] (FLINK-9616) DatadogHttpReporter fails to be created due to missing shaded dependency

2018-07-09 Thread Addison Higham (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Addison Higham closed FLINK-9616. - Resolution: Duplicate > DatadogHttpReporter fails to be created due to missing shaded dependency

[jira] [Commented] (FLINK-9693) Possible memory leak in jobmanager retaining archived checkpoints

2018-07-09 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537514#comment-16537514 ] Steven Zhen Wu commented on FLINK-9693: --- [~till.rohrmann] is it possible to generate a patch for

[jira] [Commented] (FLINK-9380) Failing end-to-end tests should not clean up logs

2018-07-09 Thread Deepak Sharma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537507#comment-16537507 ] Deepak Sharma commented on FLINK-9380: -- [~florianschmidt]: I made some changes today but the ci

[jira] [Commented] (FLINK-9380) Failing end-to-end tests should not clean up logs

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537482#comment-16537482 ] ASF GitHub Bot commented on FLINK-9380: --- GitHub user deepaks4077 opened a pull request:

[jira] [Updated] (FLINK-9380) Failing end-to-end tests should not clean up logs

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9380: -- Labels: pull-request-available test-stability (was: test-stability) > Failing end-to-end

[GitHub] flink pull request #6289: [FLINK-9380]: Modified end to end test runner scri...

2018-07-09 Thread deepaks4077
GitHub user deepaks4077 opened a pull request: https://github.com/apache/flink/pull/6289 [FLINK-9380]: Modified end to end test runner script to stop deleting logs if tests fail ## What is the purpose of the change This pull request modifies a couple of end to end test

[jira] [Commented] (FLINK-9783) Failed to execute a flink 1.5.0 application on Yarn which written in Scala

2018-07-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537447#comment-16537447 ] Gary Yao commented on FLINK-9783: - The cause is {noformat} Caused by: java.io.IOException: Could not

[jira] [Commented] (FLINK-9784) Inconsistent use of 'static' in AsyncIOExample.java

2018-07-09 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537200#comment-16537200 ] vinoyang commented on FLINK-9784: - [~nekrassov] it seems you have no contribute permission.

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537171#comment-16537171 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi closed the pull request at:

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537170#comment-16537170 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6224 Got it, Thanks for your explanation ;-). I will close this PR. ---

[GitHub] flink pull request #6224: [FLINK-9687]Delay the state fetch only when the tr...

2018-07-09 Thread Aitozi
Github user Aitozi closed the pull request at: https://github.com/apache/flink/pull/6224 ---

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537146#comment-16537146 ] ASF GitHub Bot commented on FLINK-9687: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/6224 Unfortunately, we cannot distinguish between cleanup timers and other timers. In fact, in the case where we have `allowed lateness = 0` the one timer is both a normal timer and a cleanup timer.

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537142#comment-16537142 ] ASF GitHub Bot commented on FLINK-9750: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201059374 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java --- @@ -0,0 +1,297 @@ +/* + *

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537144#comment-16537144 ] ASF GitHub Bot commented on FLINK-9750: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201059444 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java --- @@ -0,0 +1,297 @@ +/* + *

[jira] [Commented] (FLINK-9276) Improve error message when TaskManager fails

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537140#comment-16537140 ] ASF GitHub Bot commented on FLINK-9276: --- Github user yanghua commented on the issue:

[jira] [Updated] (FLINK-9276) Improve error message when TaskManager fails

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9276: -- Labels: pull-request-available (was: ) > Improve error message when TaskManager fails >

[GitHub] flink issue #5954: [FLINK-9276] Improve error message when TaskManager fails

2018-07-09 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5954 @zentol @tillrohrmann @aljoscha this PR takes a long time and has conflicts (I have rebased recently), hope for it could be merged as soon as possible. ---

[jira] [Commented] (FLINK-9276) Improve error message when TaskManager fails

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537141#comment-16537141 ] ASF GitHub Bot commented on FLINK-9276: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5954: [FLINK-9276] Improve error message when TaskManager fails

2018-07-09 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5954 @zentol @tillrohrmann @aljoscha this PR takes a long time and has conflicts (I have rebased recently), hope for it could be merged as soon as possible. ---

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537136#comment-16537136 ] ASF GitHub Bot commented on FLINK-9750: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201058746 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java --- @@ -0,0 +1,297 @@ +/* + *

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537133#comment-16537133 ] ASF GitHub Bot commented on FLINK-9750: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201058329 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java --- @@ -0,0 +1,297 @@ +/* + *

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537116#comment-16537116 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6224 Get it, this change indeed will lead to the situation you mentioned. > What are the cases where this change leads to an improvement I just read code and think the order is not suitable.

[jira] [Commented] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2018-07-09 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537101#comment-16537101 ] Dawid Wysakowicz commented on FLINK-8161: - I am closing it as I could not reproduce it. Moreover

[jira] [Resolved] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2018-07-09 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-8161. - Resolution: Fixed > Flakey YARNSessionCapacitySchedulerITCase on Travis >

[jira] [Comment Edited] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2018-07-09 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537101#comment-16537101 ] Dawid Wysakowicz edited comment on FLINK-8161 at 7/9/18 3:50 PM: - I am

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537077#comment-16537077 ] ASF GitHub Bot commented on FLINK-9687: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/6224 No, the motivation was different but the effect of the change is the same, I think. With this change, you can get into a situation where `Trigger.onEventTime()` returns `FIRE` and there is

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537062#comment-16537062 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537069#comment-16537069 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537072#comment-16537072 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537060#comment-16537060 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537068#comment-16537068 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537061#comment-16537061 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537071#comment-16537071 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537070#comment-16537070 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537063#comment-16537063 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537067#comment-16537067 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537064#comment-16537064 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537065#comment-16537065 ] ASF GitHub Bot commented on FLINK-9486: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201019320 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -37,10 +62,22 @@ /**

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201019266 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -37,10 +62,22 @@ /**

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201015311 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestPriorityQueueSetFactory.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016908 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201017209 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201015258 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestPriorityQueueSetFactory.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201013962 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityQueueSetFactory.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016373 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016655 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201014333 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -102,6 +105,21 @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201017540 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6276: [FLINK-9486] Introduce TimerState in keyed state b...

2018-07-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6276#discussion_r201016952 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537057#comment-16537057 ] ASF GitHub Bot commented on FLINK-9750: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537058#comment-16537058 ] ASF GitHub Bot commented on FLINK-9750: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201042618 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java --- @@ -0,0 +1,397 @@ +/*

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r201042180 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java --- @@ -0,0 +1,397 @@ +/*

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537048#comment-16537048 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6224 Hi, @aljoscha I read the PR of https://issues.apache.org/jira/browse/FLINK-5363, i think it is not a same thing with this PR. You meant to get `TriggerResult` no matter the window content is

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537042#comment-16537042 ] ASF GitHub Bot commented on FLINK-9687: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-07-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/6224 I think the reasons at that time where: - it changes the semantics of Triggers - You can get into a situation where you call `Trigger.onEventTime()`, the `Trigger` returns `FIRE` or

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537014#comment-16537014 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537001#comment-16537001 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537005#comment-16537005 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537029#comment-16537029 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537028#comment-16537028 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537003#comment-16537003 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537026#comment-16537026 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537027#comment-16537027 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537012#comment-16537012 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536999#comment-16536999 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537017#comment-16537017 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537018#comment-16537018 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537025#comment-16537025 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537006#comment-16537006 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537011#comment-16537011 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537008#comment-16537008 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536997#comment-16536997 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537021#comment-16537021 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537004#comment-16537004 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537024#comment-16537024 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537015#comment-16537015 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces...

2018-07-09 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r201030190 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/sources/TestWildcardFormatTableFactory.scala --- @@ -0,0 +1,56 @@ +/*

  1   2   3   4   >