[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-14 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#discussion_r334777068 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/pa

[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-14 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#discussion_r334774864 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/

[GitHub] [flink] flinkbot commented on issue #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread GitBox
flinkbot commented on issue #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking URL: https://github.com/apache/flink/pull/9903#issuecomment-542062958 ## CI report: * 0347aef574de3733bd6c263c41bb2d163a235d33 : UNKNOWN B

[GitHub] [flink] flinkbot commented on issue #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment

2019-10-14 Thread GitBox
flinkbot commented on issue #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment URL: https://github.com/apache/flink/pull/9902#issuecomment-542062879 ## CI report: * efdb2ad3942939590bbb0203ab04bae5fec634a9 : UNKNOWN Bot commands

[GitHub] [flink] GJL edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
GJL edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542059526 Sorry I closed the wrong PR. I meant to close #9819. --

[GitHub] [flink] GJL closed pull request #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
GJL closed pull request #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9819 This is an automated message from the Apache Gi

[GitHub] [flink] GJL commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
GJL commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542059526 Sorry I closed the wrong PR. This

[GitHub] [flink] zhuzhurk opened a new pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk opened a new pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901 ## What is the purpose of the change This PR is to annotate MiniCluster tests with AlsoRunWithSched

[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-14 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#discussion_r334770737 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/pa

[GitHub] [flink] flinkbot commented on issue #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread GitBox
flinkbot commented on issue #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking URL: https://github.com/apache/flink/pull/9903#issuecomment-542058799 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] KarmaGYZ commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-10-14 Thread GitBox
KarmaGYZ commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-542058347 Thanks for addressing the comments. I have reviewed latest version. +1 for merging.

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14394: --- Labels: pull-request-available (was: ) > Remove unnecessary interface method BufferProvider

[jira] [Resolved] (FLINK-14246) Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao resolved FLINK-14246. -- Resolution: Fixed > Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG >

[jira] [Closed] (FLINK-14246) Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao closed FLINK-14246. > Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG > --

[GitHub] [flink] zhijiangW opened a new pull request #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread GitBox
zhijiangW opened a new pull request #9903: [FLINK-14394][network] Remove unnecessary interface method BufferProvider#requestBufferBlocking URL: https://github.com/apache/flink/pull/9903 ## What is the purpose of the change * Currently `BufferProvider#requestBufferBlocking` method is

[jira] [Commented] (FLINK-14246) Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951645#comment-16951645 ] Gary Yao commented on FLINK-14246: -- 1.10: 34379182d63991baf9672c48842f06316d541170 eee2

[GitHub] [flink] GJL closed pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
GJL closed pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901 This is an automated message from the Apache Git Servi

[GitHub] [flink] xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r334743444 ## File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.ja

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-14394: - Description: Currently BufferProvider#requestBufferBlocking method is only used for unit tests, so we co

[GitHub] [flink] flinkbot commented on issue #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment

2019-10-14 Thread GitBox
flinkbot commented on issue #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment URL: https://github.com/apache/flink/pull/9902#issuecomment-542055081 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Assigned] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang reassigned FLINK-14394: Assignee: zhijiang > Remove unnecessary interface method BufferProvider#requestBufferBlocking > -

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-14394: - Priority: Minor (was: Major) > Remove unnecessary interface method BufferProvider#requestBufferBlocking

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-14394: - Summary: Remove unnecessary interface method BufferProvider#requestBufferBlocking (was: Remove unnecess

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-14394: - Fix Version/s: 1.10.0 > Remove unnecessary interface method BufferProvider#requestBufferBlocking > -

[jira] [Updated] (FLINK-14394) Remove unnecessary interface method BufferProvider#requestBufferBlocking

2019-10-14 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-14394: - Component/s: Runtime / Network > Remove unnecessary interface method BufferProvider#requestBufferBlockin

[jira] [Created] (FLINK-14394) Remove unnecessary notifySubpartitionConsumed method from view reader

2019-10-14 Thread zhijiang (Jira)
zhijiang created FLINK-14394: Summary: Remove unnecessary notifySubpartitionConsumed method from view reader Key: FLINK-14394 URL: https://issues.apache.org/jira/browse/FLINK-14394 Project: Flink

[jira] [Updated] (FLINK-14363) Prevent vertex from being affected by outdated deployment (SchedulerNG)

2019-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14363: --- Labels: pull-request-available (was: ) > Prevent vertex from being affected by outdated dep

[GitHub] [flink] zhuzhurk opened a new pull request #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment

2019-10-14 Thread GitBox
zhuzhurk opened a new pull request #9902: [FLINK-14363][runtime] Prevent vertex from being affected by outdated deployment URL: https://github.com/apache/flink/pull/9902 ## What is the purpose of the change DefaultScheduler currently will cancel latest execution of a vertex when

[GitHub] [flink] flinkbot edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542033375 ## CI report: * 425be90e410ed2b8c2065d1a299a75d79fa66aaf : FAILURE [Build](

[GitHub] [flink] flinkbot edited a comment on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9900#issuecomment-542033352 ## CI report: * a69bbc4f6eb0eac5509a989ebd5a4f31d8b028d6 : FAILURE [Build](h

[jira] [Updated] (FLINK-14363) Prevent vertex from being affected by outdated deployment (SchedulerNG)

2019-10-14 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-14363: Description: DefaultScheduler currently will cancel latest execution of a vertex when the vertex version

[jira] [Updated] (FLINK-14363) Prevent vertex from being affected by outdated deployment (SchedulerNG)

2019-10-14 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-14363: Summary: Prevent vertex from being affected by outdated deployment (SchedulerNG) (was: No need to cancel

[GitHub] [flink] flinkbot edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542033375 ## CI report: * 425be90e410ed2b8c2065d1a299a75d79fa66aaf : PENDING [Build](

[GitHub] [flink] flinkbot commented on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot commented on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9900#issuecomment-542033352 ## CI report: * a69bbc4f6eb0eac5509a989ebd5a4f31d8b028d6 : UNKNOWN Bot co

[GitHub] [flink] flinkbot commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542033375 ## CI report: * 425be90e410ed2b8c2065d1a299a75d79fa66aaf : UNKNOWN Bot c

[jira] [Commented] (FLINK-14359) Create a module called flink-sql-connector-hbase to shade HBase

2019-10-14 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951583#comment-16951583 ] Zheng Hu commented on FLINK-14359: -- When I'm running a testing sql query in my standalo

[GitHub] [flink] flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-539968272 ## CI report: * 372923b25d5fa8376fc40b18e2bf024

[GitHub] [flink] flinkbot commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot commented on issue #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901#issuecomment-542027738 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] wuchong commented on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-14 Thread GitBox
wuchong commented on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-542027336 Is it passed now? https://travis-ci.com/flink-ci/flink/builds/13162

[GitHub] [flink] zhuzhurk opened a new pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk opened a new pull request #9901: [FLINK-14365][tests] Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9901 ## What is the purpose of the change This PR is to annotate MiniCluster tests with AlsoRunWithSched

[GitHub] [flink] flinkbot commented on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot commented on issue #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9900#issuecomment-542026880 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] zhuzhurk opened a new pull request #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk opened a new pull request #9900: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9900 ## What is the purpose of the change This PR is to annotate all MiniCluster tests with AlsoRunWithSc

[jira] [Updated] (FLINK-14366) Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14366: --- Labels: pull-request-available (was: ) > Annotate MiniCluster tests in flink-tests with Als

[GitHub] [flink] zhuzhurk closed pull request #9899: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk closed pull request #9899: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9899 This is an automated message from the Apache Git S

[GitHub] [flink] flinkbot commented on issue #9899: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot commented on issue #9899: [FLINK-14366][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9899#issuecomment-542025659 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[jira] [Updated] (FLINK-14365) Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14365: --- Labels: pull-request-available (was: ) > Annotate MiniCluster tests in core modules with Al

[GitHub] [flink] zhuzhurk opened a new pull request #9899: [FLINK-14365][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk opened a new pull request #9899: [FLINK-14365][tests] Annotate MiniCluster tests in flink-tests with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9899 ## What is the purpose of the change This PR is to annotate all MiniCluster tests with AlsoRunWithSc

[GitHub] [flink] flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions. URL: https://github.com/apache/flink/pull/9886#issuecomment-541326107 ## CI report: * e431c1c28a35dd86e60a0892ff0e0d15b8da7245 : FAILURE [Build](https://trav

[GitHub] [flink] zhijiangW commented on issue #9895: [FLINK-12576][docs, metrics] Document that input pool usage metrics ignore LocalInputChannels

2019-10-14 Thread GitBox
zhijiangW commented on issue #9895: [FLINK-12576][docs,metrics] Document that input pool usage metrics ignore LocalInputChannels URL: https://github.com/apache/flink/pull/9895#issuecomment-542023635 @pnowojski do you think we should merge it also into FLINK-1.9.0? -

[GitHub] [flink] flinkbot edited a comment on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9819#issuecomment-536429067 ## CI report: * 94653a90b144e39f05a3e86de50225a0d538fed0 : SUCCESS [

[GitHub] [flink] zhijiangW merged pull request #9895: [FLINK-12576][docs, metrics] Document that input pool usage metrics ignore LocalInputChannels

2019-10-14 Thread GitBox
zhijiangW merged pull request #9895: [FLINK-12576][docs,metrics] Document that input pool usage metrics ignore LocalInputChannels URL: https://github.com/apache/flink/pull/9895 This is an automated message from the Apache Gi

[GitHub] [flink] flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig URL: https://github.com/apache/flink/pull/9797#issuecomment-536255105 ## CI report: * 17be7faf6d9c7dd26408c0649491c9401e65f866 : FAILURE [

[GitHub] [flink] zhijiangW commented on issue #9895: [FLINK-12576][docs, metrics] Document that input pool usage metrics ignore LocalInputChannels

2019-10-14 Thread GitBox
zhijiangW commented on issue #9895: [FLINK-12576][docs,metrics] Document that input pool usage metrics ignore LocalInputChannels URL: https://github.com/apache/flink/pull/9895#issuecomment-542023174 Sorry for the misleading, and my last memory for updating html files was for the case of op

[GitHub] [flink] flinkbot edited a comment on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector URL: https://github.com/apache/flink/pull/8871#issuecomment-515875442 ## CI report: * 4deb818b520abd9d839824bbb800a1a9c9deb841 : FAILURE [Build](https://travi

[jira] [Commented] (FLINK-14360) Flink on yarn should support obtain delegation tokens of multi hdfs namespaces

2019-10-14 Thread Shen Yinjie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951530#comment-16951530 ] Shen Yinjie commented on FLINK-14360: - [~azagrebin]Agree with you .RBF routers' toke

[GitHub] [flink] xintongsong commented on issue #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on issue #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#issuecomment-542018219 Thanks for the review, @azagrebin. I'm not sure about the idea of mapping legacy fields to the new on

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334736805 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecut

[GitHub] [flink] yanghua commented on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-10-14 Thread GitBox
yanghua commented on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector URL: https://github.com/apache/flink/pull/8871#issuecomment-542016437 @aljoscha I have tried to bump Kafka client version, but met some issue. Ping for helping. ---

[GitHub] [flink] flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions. URL: https://github.com/apache/flink/pull/9886#issuecomment-541326107 ## CI report: * e431c1c28a35dd86e60a0892ff0e0d15b8da7245 : FAILURE [Build](https://trav

[GitHub] [flink] flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-539968272 ## CI report: * 372923b25d5fa8376fc40b18e2bf024

[GitHub] [flink] flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig URL: https://github.com/apache/flink/pull/9797#issuecomment-536255105 ## CI report: * 17be7faf6d9c7dd26408c0649491c9401e65f866 : FAILURE [

[GitHub] [flink] openinx commented on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect

2019-10-14 Thread GitBox
openinx commented on issue #9866: [FLINK-14349][hbase] Create a Connector Descriptor for HBase so that user can connect HBase by TableEnvironment#connect URL: https://github.com/apache/flink/pull/9866#issuecomment-542012729 @flinkbot run travis @wuchong , seems the previous flinkbot did

[jira] [Updated] (FLINK-14365) Annotate MiniCluster tests in core modules with AlsoRunWithSchedulerNG

2019-10-14 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-14365: Description: This task is to annotate MiniCluster tests with AlsoRunWithSchedulerNG in flink core modules

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334732819 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterfra

[GitHub] [flink] TisonKun commented on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient

2019-10-14 Thread GitBox
TisonKun commented on issue #9820: [FLINK-14290] Decouple plan translation from job execution/ClusterClient URL: https://github.com/apache/flink/pull/9820#issuecomment-542012604 Thanks for your update @aljoscha ☕️ nice work! I think FLINK-14263 has been addressed as a side effect of

[jira] [Commented] (FLINK-10672) Task stuck while writing output to flink

2019-10-14 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951507#comment-16951507 ] Yun Gao commented on FLINK-10672: - Hi [~angoenka], very sorry for the long delay because

[jira] [Updated] (FLINK-14392) Introduce JobClient API(FLIP-74)

2019-10-14 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-14392: -- Component/s: (was: Command Line Client) > Introduce JobClient API(FLIP-74) > -

[jira] [Updated] (FLINK-10672) Task stuck while writing output to flink

2019-10-14 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-10672: Attachment: 0.14_all_jobs.jpg > Task stuck while writing output to flink > ---

[jira] [Created] (FLINK-14393) add an option to enable/disable cancel job in web ui

2019-10-14 Thread Yadong Xie (Jira)
Yadong Xie created FLINK-14393: -- Summary: add an option to enable/disable cancel job in web ui Key: FLINK-14393 URL: https://issues.apache.org/jira/browse/FLINK-14393 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions. URL: https://github.com/apache/flink/pull/9886#issuecomment-541326107 ## CI report: * e431c1c28a35dd86e60a0892ff0e0d15b8da7245 : FAILURE [Build](https://trav

[jira] [Updated] (FLINK-14392) Introduce JobClient API(FLIP-74)

2019-10-14 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-14392: -- Issue Type: New Feature (was: Task) > Introduce JobClient API(FLIP-74) >

[jira] [Updated] (FLINK-14392) Introduce JobClient API(FLIP-74)

2019-10-14 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-14392: -- Issue Type: Task (was: New Feature) > Introduce JobClient API(FLIP-74) >

[jira] [Created] (FLINK-14392) Introduce JobClient API(FLIP-74)

2019-10-14 Thread Zili Chen (Jira)
Zili Chen created FLINK-14392: - Summary: Introduce JobClient API(FLIP-74) Key: FLINK-14392 URL: https://issues.apache.org/jira/browse/FLINK-14392 Project: Flink Issue Type: New Feature

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334730673 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterfra

[GitHub] [flink] flinkbot edited a comment on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9819#issuecomment-536429067 ## CI report: * 94653a90b144e39f05a3e86de50225a0d538fed0 : SUCCESS [

[GitHub] [flink] klion26 commented on a change in pull request #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-14 Thread GitBox
klion26 commented on a change in pull request #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile URL: https://github.com/apache/flink/pull/9889#discussion_r334730113 ## File path: docs/dev/libs/state_processor_api.md ## @@ -238,9 +238,11 @

[GitHub] [flink] flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9797: [FLINK-14059][core] Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig URL: https://github.com/apache/flink/pull/9797#issuecomment-536255105 ## CI report: * 17be7faf6d9c7dd26408c0649491c9401e65f866 : FAILURE [

[GitHub] [flink] klion26 commented on a change in pull request #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-14 Thread GitBox
klion26 commented on a change in pull request #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile URL: https://github.com/apache/flink/pull/9889#discussion_r334730018 ## File path: docs/dev/libs/state_processor_api.md ## @@ -256,9 +258,11 @

[GitHub] [flink] WeiZhong94 commented on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.

2019-10-14 Thread GitBox
WeiZhong94 commented on issue #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions. URL: https://github.com/apache/flink/pull/9886#issuecomment-542007260 @hequn8128 Thanks for your review! I have addressed most of your comments except the uncertain one. Ple

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334728535 ## File path: flink-dist/src/main/flink-bin/bin/taskmanager.sh ## @@

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334728390 ## File path: flink-dist/src/main/flink-bin/bin/config.sh ## @@ -783

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334727581 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJ

[GitHub] [flink] zhuzhurk commented on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG

2019-10-14 Thread GitBox
zhuzhurk commented on issue #9819: [FLINK-14246][runtime] Annotate all MiniCluster tests in flink-runtime with AlsoRunWithSchedulerNG URL: https://github.com/apache/flink/pull/9819#issuecomment-542004091 @flinkbot run travis

[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334726479 ## File path: flink-dist/src/test/bin/getTmResourceConfigsAndJvmParamsFromBas

[jira] [Closed] (FLINK-14201) SQL supports redis sink connector

2019-10-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-14201. --- Resolution: Duplicate > SQL supports redis sink connector > - > >

[jira] [Commented] (FLINK-14201) SQL supports redis sink connector

2019-10-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951476#comment-16951476 ] Jark Wu commented on FLINK-14201: - Thanks [~xcyu], you can enrich the description with h

[jira] [Commented] (FLINK-11203) FunctionContext of AggregateFunction will not be initialized for window GroupBy

2019-10-14 Thread hailong wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951466#comment-16951466 ] hailong wang commented on FLINK-11203: --  Hi, [~hequn8128], can we do this according

[GitHub] [flink] yanghua commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support

2019-10-14 Thread GitBox
yanghua commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-541996415 > I had a cursory glance at this. The code seems fine, because it's basically the ES 6 code. I have some general comments: > > * I don't

[GitHub] [flink] yanghua commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support

2019-10-14 Thread GitBox
yanghua commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-541993639 @aljoscha Thanks for helping me to review this PR and finish this work. This is an

[jira] [Commented] (FLINK-14201) SQL supports redis sink connector

2019-10-14 Thread Xiaochuan Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951434#comment-16951434 ] Xiaochuan Yu commented on FLINK-14201: -- [~jark] , I created issue in Bahir and copi

[GitHub] [flink] flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-531808855 ## CI report: * 62ad65e31df8f36747991513ab89504126758af6 : CANCELED [Build](https://travis-ci.com/flin

[GitHub] [flink] flinkbot edited a comment on issue #9388: [FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me…

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9388: [FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me… URL: https://github.com/apache/flink/pull/9388#issuecomment-519262671 ## CI report: * b436eede6dd0213a0e33f9469cde96bb260dab78 : CANCELED [Build](https://travis-ci.co

[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032 ## CI report: * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE [Build](htt

[GitHub] [flink] Xeli commented on issue #9388: [FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me…

2019-10-14 Thread GitBox
Xeli commented on issue #9388: [FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me… URL: https://github.com/apache/flink/pull/9388#issuecomment-541854271 @becketqin as you've looked at the pubsub code the most: Would you be so kind to have a look at this PR? We can then c

[GitHub] [flink] flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-515870480 ## CI report: * de863750b7262d091d2e7dd82767b8f9b2e2c52a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/bui

[GitHub] [flink] flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-531808855 ## CI report: * 62ad65e31df8f36747991513ab89504126758af6 : CANCELED [Build](https://travis-ci.com/flin

[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032 ## CI report: * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE [Build](htt

[jira] [Comment Edited] (FLINK-14171) Add 'SHOW USER FUNCTIONS' support in SQL CLI

2019-10-14 Thread Ashwin Sinha (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950881#comment-16950881 ] Ashwin Sinha edited comment on FLINK-14171 at 10/14/19 6:12 PM: --

[GitHub] [flink] azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334548624 ## File path: flink-dist/src/main/flink-bin/bin/taskmanager.sh ## @@ -

[GitHub] [flink] azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

2019-10-14 Thread GitBox
azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334537165 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJav

  1   2   3   4   5   >