[GitHub] [flink] hililiwei commented on a change in pull request #17106: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-10-06 Thread GitBox
hililiwei commented on a change in pull request #17106: URL: https://github.com/apache/flink/pull/17106#discussion_r723857343 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousProcessingTimeTrigger.java ## @@ -74,6

[jira] [Updated] (FLINK-10) [GitHub] Hybrid HashJoin's spilling doesn't work in iterations

2021-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10: Labels: github-import pull-request-available (was: github-import) > [GitHub] Hybrid HashJoin's

[GitHub] [flink-ml] gaoyunhaii opened a new pull request #17: [FLINK-10][iteration] Support the checkpoints for the iteration.

2021-10-06 Thread GitBox
gaoyunhaii opened a new pull request #17: URL: https://github.com/apache/flink-ml/pull/17 This PR implements the checkpoint mechanism for the iteration. The target of the checkpoint mechanism is to ensure 1. The record processing is consistent with the state, which is the same to the

[GitHub] [flink] flinkbot commented on pull request #17422: [FLINK-9432] Enable EXTRACT for DECADE, ISODOW, ISOYEAR

2021-10-06 Thread GitBox
flinkbot commented on pull request #17422: URL: https://github.com/apache/flink/pull/17422#issuecomment-937329360 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] snuyanzin opened a new pull request #17422: [FLINK-9432] Enable EXTRACT for DECADE, ISODOW, ISOYEAR

2021-10-06 Thread GitBox
snuyanzin opened a new pull request #17422: URL: https://github.com/apache/flink/pull/17422 ## What is the purpose of the change This introduces support for `EXTRACT` of `DECADE`, `ISODOW`, `ISOYEAR` in SQL. ## Verifying this change This change added tests in

[GitHub] [flink-statefun] sjwiesman commented on pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog

2021-10-06 Thread GitBox
sjwiesman commented on pull request #273: URL: https://github.com/apache/flink-statefun/pull/273#issuecomment-937327204 I'll fix the header while merging, grazi! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog

2021-10-06 Thread GitBox
igalshilman commented on a change in pull request #273: URL: https://github.com/apache/flink-statefun/pull/273#discussion_r723750424 ## File path: statefun-flink/statefun-flink-core/src/test/java/org/apache/flink/statefun/flink/core/metrics/NonNegativeCounterTest.java ## @@

[jira] [Updated] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24464: --- Labels: pull-request-available (was: ) > Metrics sometimes report negative backlog >

[GitHub] [flink-statefun] sjwiesman opened a new pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog

2021-10-06 Thread GitBox
sjwiesman opened a new pull request #273: URL: https://github.com/apache/flink-statefun/pull/273 The backlog metric sometimes reports a negative value. This is because the current count is stored in an in-memory variable, while the value used to decrement the count as the backlog clears

[jira] [Assigned] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman reassigned FLINK-24464: Assignee: Seth Wiesman > Metrics sometimes report negative backlog >

[jira] [Updated] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-24464: - Affects Version/s: statefun-3.1.0 > Metrics sometimes report negative backlog >

[jira] [Updated] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-24464: - Description: As reported

[jira] [Updated] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-24464: - Description: As report

[jira] [Created] (FLINK-24464) Metrics sometimes report negative backlog

2021-10-06 Thread Seth Wiesman (Jira)
Seth Wiesman created FLINK-24464: Summary: Metrics sometimes report negative backlog Key: FLINK-24464 URL: https://issues.apache.org/jira/browse/FLINK-24464 Project: Flink Issue Type:

[GitHub] [flink] snuyanzin closed pull request #6614: [FLINK-9432] [table] Support extract timeunit: DECADE, EPOCH, ISODOW, ISOYEAR…

2021-10-06 Thread GitBox
snuyanzin closed pull request #6614: URL: https://github.com/apache/flink/pull/6614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin commented on pull request #6614: [FLINK-9432] [table] Support extract timeunit: DECADE, EPOCH, ISODOW, ISOYEAR…

2021-10-06 Thread GitBox
snuyanzin commented on pull request #6614: URL: https://github.com/apache/flink/pull/6614#issuecomment-937270898 I will close this PR and create a new one as there are from one side to many merge conflicts and from another calcite was updated to 1.2x since the time the PR was created.

[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17350: URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692 ## CI report: * 0a0cd972b9e8406a06ead5f7e9c8fd161340a625 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17421: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17421: URL: https://github.com/apache/flink/pull/17421#issuecomment-936487343 ## CI report: * ae7002347cdaa4796cfeb31447e7e23a4c8afba4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17420: [BP-1.14][FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17420: URL: https://github.com/apache/flink/pull/17420#issuecomment-936432980 ## CI report: * 4f7e5f28283ac875dcfd6bd910bcb88dcfe9ea6a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17253: [FLINK-24182][task] Do not interrupt tasks/operators that are already closing

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17253: URL: https://github.com/apache/flink/pull/17253#issuecomment-917975072 ## CI report: * e5add9718e596daed70f9d8e252dcac895e163c0 UNKNOWN * 97512904fc61c38a9479271f223c83161f0bf06e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17350: URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692 ## CI report: * 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17350: URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692 ## CI report: * 94928a167b2a189c2b3a20bbf5205fdcb016065f Azure:

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-10-06 Thread GitBox
slinkydeveloper commented on a change in pull request #17350: URL: https://github.com/apache/flink/pull/17350#discussion_r723486705 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java ## @@ -331,7 +338,7 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17421: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17421: URL: https://github.com/apache/flink/pull/17421#issuecomment-936487343 ## CI report: * ae7002347cdaa4796cfeb31447e7e23a4c8afba4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17253: [FLINK-24182][task] Do not interrupt tasks/operators that are already closing

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17253: URL: https://github.com/apache/flink/pull/17253#issuecomment-917975072 ## CI report: * e5add9718e596daed70f9d8e252dcac895e163c0 UNKNOWN * 2f21d0ef8954a0be614974e313c8af9f7ae9a2b1 Azure:

[GitHub] [flink] flinkbot commented on pull request #17421: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
flinkbot commented on pull request #17421: URL: https://github.com/apache/flink/pull/17421#issuecomment-936487343 ## CI report: * ae7002347cdaa4796cfeb31447e7e23a4c8afba4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17420: [BP-1.14][FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17420: URL: https://github.com/apache/flink/pull/17420#issuecomment-936432980 ## CI report: * 4f7e5f28283ac875dcfd6bd910bcb88dcfe9ea6a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17253: [FLINK-24182][task] Do not interrupt tasks/operators that are already closing

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17253: URL: https://github.com/apache/flink/pull/17253#issuecomment-917975072 ## CI report: * e5add9718e596daed70f9d8e252dcac895e163c0 UNKNOWN * 2f21d0ef8954a0be614974e313c8af9f7ae9a2b1 Azure:

[GitHub] [flink-benchmarks] dawidwys commented on a change in pull request #34: [hotfix] Increase warmup iterations and iterations in CheckpointingTimeBenchmark

2021-10-06 Thread GitBox
dawidwys commented on a change in pull request #34: URL: https://github.com/apache/flink-benchmarks/pull/34#discussion_r723371474 ## File path: src/main/java/org/apache/flink/benchmark/CheckpointingTimeBenchmark.java ## @@ -285,7 +282,7 @@ protected int

[GitHub] [flink-benchmarks] dawidwys commented on a change in pull request #34: [hotfix] Increase warmup iterations and iterations in CheckpointingTimeBenchmark

2021-10-06 Thread GitBox
dawidwys commented on a change in pull request #34: URL: https://github.com/apache/flink-benchmarks/pull/34#discussion_r723367230 ## File path: src/main/java/org/apache/flink/benchmark/CheckpointingTimeBenchmark.java ## @@ -285,7 +282,7 @@ protected int

[GitHub] [flink] flinkbot commented on pull request #17421: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
flinkbot commented on pull request #17421: URL: https://github.com/apache/flink/pull/17421#issuecomment-936441482 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] rudikershaw commented on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
rudikershaw commented on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-936438843 Build is passing and documentation has been updated. Marking as `Ready for review`. FYI @flinkbot. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #17420: [BP-1.14][FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-10-06 Thread GitBox
flinkbot commented on pull request #17420: URL: https://github.com/apache/flink/pull/17420#issuecomment-936432980 ## CI report: * 4f7e5f28283ac875dcfd6bd910bcb88dcfe9ea6a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN * c927b47bfa5c357b49ba0404077823ade9ca123e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17253: [FLINK-24182][task] Do not interrupt tasks/operators that are already closing

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17253: URL: https://github.com/apache/flink/pull/17253#issuecomment-917975072 ## CI report: * 9afa220db7bec69bb2cc92787beec266af00f7c2 Azure:

[GitHub] [flink] fapaul opened a new pull request #17421: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
fapaul opened a new pull request #17421: URL: https://github.com/apache/flink/pull/17421 Unchanged backport of #17406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (FLINK-24463) job_name of metric does not support Chinese

2021-10-06 Thread macdoor615 (Jira)
macdoor615 created FLINK-24463: -- Summary: job_name of metric does not support Chinese Key: FLINK-24463 URL: https://issues.apache.org/jira/browse/FLINK-24463 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #17420: [BP-1.14][FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-10-06 Thread GitBox
flinkbot commented on pull request #17420: URL: https://github.com/apache/flink/pull/17420#issuecomment-936335208 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink-benchmarks] pnowojski commented on a change in pull request #34: [hotfix] Increase warmup iterations and iterations in CheckpointingTimeBenchmark

2021-10-06 Thread GitBox
pnowojski commented on a change in pull request #34: URL: https://github.com/apache/flink-benchmarks/pull/34#discussion_r723331461 ## File path: src/main/java/org/apache/flink/benchmark/CheckpointingTimeBenchmark.java ## @@ -285,7 +282,7 @@ protected int

[GitHub] [flink] fapaul opened a new pull request #17420: [BP-1.14][FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-10-06 Thread GitBox
fapaul opened a new pull request #17420: URL: https://github.com/apache/flink/pull/17420 Unchanged backport of #17367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17419: URL: https://github.com/apache/flink/pull/17419#issuecomment-936009567 ## CI report: * cfbc2918576e98b21f46dad6786059b7260e9b5d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201 ## CI report: * 40d0ddf22fd951d13e3569deea11bf531a84183b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17253: [FLINK-24182][task] Do not interrupt tasks/operators that are already closing

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17253: URL: https://github.com/apache/flink/pull/17253#issuecomment-917975072 ## CI report: * 9afa220db7bec69bb2cc92787beec266af00f7c2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17418: URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331 ## CI report: * e024d45525bab4b921aab787984f0f2a0654b1ed Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17363: URL: https://github.com/apache/flink/pull/17363#issuecomment-927758743 ## CI report: * 9b43b01e84d828b0dd6f1f121ffc736df8760743 UNKNOWN * bee7c870c5607a28c2d2a652601e8efa5b92458d Azure:

[jira] [Created] (FLINK-24462) Refactor casting rules in a similar fashion to DataStructureConverter

2021-10-06 Thread Francesco Guardiani (Jira)
Francesco Guardiani created FLINK-24462: --- Summary: Refactor casting rules in a similar fashion to DataStructureConverter Key: FLINK-24462 URL: https://issues.apache.org/jira/browse/FLINK-24462

[jira] [Assigned] (FLINK-24461) TableResult#print() should use internal data types

2021-10-06 Thread Francesco Guardiani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Guardiani reassigned FLINK-24461: --- Assignee: Francesco Guardiani > TableResult#print() should use internal

[jira] [Created] (FLINK-24461) TableResult#print() should use internal data types

2021-10-06 Thread Francesco Guardiani (Jira)
Francesco Guardiani created FLINK-24461: --- Summary: TableResult#print() should use internal data types Key: FLINK-24461 URL: https://issues.apache.org/jira/browse/FLINK-24461 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #17416: [FLINK-24459] Performance improvement of file sink

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17416: URL: https://github.com/apache/flink/pull/17416#issuecomment-935728533 ## CI report: * 0807e52c248da31b34470447184d5d7ebbff189b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201 ## CI report: * 73b096561e14afe09109be5cf053430efadaca7e Azure:

[GitHub] [flink] twalthr commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-10-06 Thread GitBox
twalthr commented on a change in pull request #17350: URL: https://github.com/apache/flink/pull/17350#discussion_r723166638 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java ## @@ -39,7 +39,8 @@

[jira] [Comment Edited] (FLINK-16504) Add a AWS DynamoDB sink

2021-10-06 Thread Yuri Gusev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424894#comment-17424894 ] Yuri Gusev edited comment on FLINK-16504 at 10/6/21, 11:54 AM: --- Awesome,

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17419: URL: https://github.com/apache/flink/pull/17419#issuecomment-936009567 ## CI report: * cfbc2918576e98b21f46dad6786059b7260e9b5d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17407: [FLINK-16504][dynamodb connector] DynamoDB batch connector

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17407: URL: https://github.com/apache/flink/pull/17407#issuecomment-933030338 ## CI report: * 8787c343b615602c989fa793e0f4687ef40e530c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17400: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17400: URL: https://github.com/apache/flink/pull/17400#issuecomment-931731823 ## CI report: * bcebecad254e48c19e44bb402f1cd20685cbe066 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201 ## CI report: * 73b096561e14afe09109be5cf053430efadaca7e Azure:

[jira] [Commented] (FLINK-24459) Performance improvement of file sink on Nexmark

2021-10-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424951#comment-17424951 ] Martijn Visser commented on FLINK-24459: [~trushev] Thanks for the report and metrics. I'll

[jira] [Assigned] (FLINK-24459) Performance improvement of file sink on Nexmark

2021-10-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-24459: -- Assignee: Alexander Trushev > Performance improvement of file sink on Nexmark >

[jira] [Assigned] (FLINK-24409) Kafka topics with periods in their names generate a constant stream of errors

2021-10-06 Thread Alexander Preuss (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Preuss reassigned FLINK-24409: Assignee: Alexander Preuss > Kafka topics with periods in their names generate a

[GitHub] [flink] flinkbot commented on pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread GitBox
flinkbot commented on pull request #17419: URL: https://github.com/apache/flink/pull/17419#issuecomment-936009567 ## CI report: * cfbc2918576e98b21f46dad6786059b7260e9b5d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure:

[GitHub] [flink] flinkbot commented on pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread GitBox
flinkbot commented on pull request #17419: URL: https://github.com/apache/flink/pull/17419#issuecomment-935974041 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24460) Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24460: --- Labels: pull-request-available (was: ) > Rocksdb Iterator Error Handling Improvement >

[GitHub] [flink] victorunique opened a new pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

2021-10-06 Thread GitBox
victorunique opened a new pull request #17419: URL: https://github.com/apache/flink/pull/17419 ## What is the purpose of the change In FLINK-9373, we introduced RocksIteratorWrapper which was a wrapper around RocksIterator to check the iterator status for all the methods. At that

[GitHub] [flink] flinkbot edited a comment on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17418: URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331 ## CI report: * e024d45525bab4b921aab787984f0f2a0654b1ed Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17363: URL: https://github.com/apache/flink/pull/17363#issuecomment-927758743 ## CI report: * c12f95b1907cb375af2f3da22d59cba25e7fe01c Azure:

[GitHub] [flink] matriv commented on pull request #15744: [FLINK-22113][table-planner-blink] Implement the column uniqueness checking for TableSourceTable

2021-10-06 Thread GitBox
matriv commented on pull request #15744: URL: https://github.com/apache/flink/pull/15744#issuecomment-935904382 @xuguangheng Thank you for your effort! - Overall it looks good, please rebase with master to get the new layout of the modules - Please replace the deprecated

[GitHub] [flink] flinkbot commented on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

2021-10-06 Thread GitBox
flinkbot commented on pull request #17418: URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331 ## CI report: * e024d45525bab4b921aab787984f0f2a0654b1ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17363: URL: https://github.com/apache/flink/pull/17363#issuecomment-927758743 ## CI report: * c12f95b1907cb375af2f3da22d59cba25e7fe01c Azure:

[jira] [Commented] (FLINK-16504) Add a AWS DynamoDB sink

2021-10-06 Thread Yuri Gusev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424894#comment-17424894 ] Yuri Gusev commented on FLINK-16504: Awesome, thanks [~dannycranmer]. Reached to Zichen in the other

[jira] [Commented] (FLINK-24456) Support bounded offset in the Kafka table connector

2021-10-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424883#comment-17424883 ] Martijn Visser commented on FLINK-24456: [~wheat9] Thanks for opening the ticket! Can and do you

[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17363: URL: https://github.com/apache/flink/pull/17363#issuecomment-927758743 ## CI report: * c12f95b1907cb375af2f3da22d59cba25e7fe01c Azure:

[GitHub] [flink] flinkbot commented on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

2021-10-06 Thread GitBox
flinkbot commented on pull request #17418: URL: https://github.com/apache/flink/pull/17418#issuecomment-935857450 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24446) Casting from STRING to TIMESTAMP_LTZ looses fractional seconds

2021-10-06 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Trivyzas updated FLINK-24446: Summary: Casting from STRING to TIMESTAMP_LTZ looses fractional seconds (was: Casting

[jira] [Commented] (FLINK-24229) [FLIP-171] DynamoDB implementation of Async Sink

2021-10-06 Thread Yuri Gusev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424872#comment-17424872 ] Yuri Gusev commented on FLINK-24229: Hi [~CrynetLogistics], Did you start working on this

[jira] [Updated] (FLINK-24421) Casting from a string to a DATE and TIME allows incomplete strings

2021-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24421: --- Labels: pull-request-available (was: ) > Casting from a string to a DATE and TIME allows

[GitHub] [flink] matriv opened a new pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

2021-10-06 Thread GitBox
matriv opened a new pull request #17418: URL: https://github.com/apache/flink/pull/17418 ## What is the purpose of the change Following calcite-avatica behaviour, fix the behaviour of parsing string into unix time when the string is incomplete, missing 1 or both `:` time units

[GitHub] [flink] fapaul commented on a change in pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
fapaul commented on a change in pull request #17363: URL: https://github.com/apache/flink/pull/17363#discussion_r723035131 ## File path: flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSink.java ## @@

[jira] [Closed] (FLINK-24393) Add tests for all currently supported cast combinations

2021-10-06 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-24393. Fix Version/s: 1.15.0 Resolution: Fixed Fixed in master:

[GitHub] [flink] twalthr closed pull request #17396: [FLINK-24393][test] Add CAST tests for type combinations

2021-10-06 Thread GitBox
twalthr closed pull request #17396: URL: https://github.com/apache/flink/pull/17396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

2021-10-06 Thread GitBox
flinkbot commented on pull request #17417: URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208 ## CI report: * 8ab98b74160adc6c2508b77bbb3b1380acf69567 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17416: [FLINK-24459] Performance improvement of file sink

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17416: URL: https://github.com/apache/flink/pull/17416#issuecomment-935728533 ## CI report: * 0807e52c248da31b34470447184d5d7ebbff189b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17400: [FLINK-24432][rocksdb] RocksIteratorWrapper.seekToLast() logic typo

2021-10-06 Thread GitBox
flinkbot edited a comment on pull request #17400: URL: https://github.com/apache/flink/pull/17400#issuecomment-931731823 ## CI report: * 747e6cb8314b0922f23bfba73d2f94dae5bb910e Azure:

[GitHub] [flink] AHeise commented on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

2021-10-06 Thread GitBox
AHeise commented on pull request #17413: URL: https://github.com/apache/flink/pull/17413#issuecomment-935781079 Merged into master and 1.14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] AHeise merged pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

2021-10-06 Thread GitBox
AHeise merged pull request #17413: URL: https://github.com/apache/flink/pull/17413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-24405) KafkaWriterITCase.testLingeringTransaction fails on azure

2021-10-06 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424851#comment-17424851 ] Arvid Heise commented on FLINK-24405: - Merged into master as

[GitHub] [flink] AHeise merged pull request #17406: [FLINK-24405][tests] Introduce util to reliably drain all messages from a kafka topic

2021-10-06 Thread GitBox
AHeise merged pull request #17406: URL: https://github.com/apache/flink/pull/17406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-20928) KafkaSourceReaderTest.testOffsetCommitOnCheckpointComplete:189->pollUntil:270 » Timeout

2021-10-06 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424849#comment-17424849 ] Arvid Heise commented on FLINK-20928: - Merged into master as

[GitHub] [flink] AHeise commented on pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout

2021-10-06 Thread GitBox
AHeise commented on pull request #17342: URL: https://github.com/apache/flink/pull/17342#issuecomment-935773079 Thank you very much for the contribution. I merged it into master. Could you please create backport PRs? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] AHeise merged pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout

2021-10-06 Thread GitBox
AHeise merged pull request #17342: URL: https://github.com/apache/flink/pull/17342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise commented on a change in pull request #17106: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-10-06 Thread GitBox
AHeise commented on a change in pull request #17106: URL: https://github.com/apache/flink/pull/17106#discussion_r723015486 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousProcessingTimeTrigger.java ## @@ -74,6

[GitHub] [flink] AHeise commented on pull request #16940: [FLINK-23914][connector/testing-framework] Improve logging and error message in testing framework

2021-10-06 Thread GitBox
AHeise commented on pull request #16940: URL: https://github.com/apache/flink/pull/16940#issuecomment-935757418 Looks good already. Can you rebase on master and I'd do a final pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] AHeise commented on a change in pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
AHeise commented on a change in pull request #17363: URL: https://github.com/apache/flink/pull/17363#discussion_r723012465 ## File path: flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSink.java ## @@

[GitHub] [flink] AHeise commented on a change in pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on the unified sink (FLIP-143)

2021-10-06 Thread GitBox
AHeise commented on a change in pull request #17363: URL: https://github.com/apache/flink/pull/17363#discussion_r723011641 ## File path: flink-connectors/flink-connector-elasticsearch7/src/test/java/org/apache/flink/connector/elasticsearch/sink/TestProcessor.java ## @@ -0,0

[jira] [Updated] (FLINK-24455) FallbackAkkaRpcSystemLoader should check for maven errors

2021-10-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24455: - Issue Type: Improvement (was: Bug) > FallbackAkkaRpcSystemLoader should check for

  1   2   >