[jira] [Commented] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498408#comment-17498408 ] Aitozi commented on FLINK-26377: Get it ! > Extract Reconciler interface >

[jira] [Commented] (FLINK-26139) Improve JobStatus tracking and handle different job states

2022-02-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498406#comment-17498406 ] Gyula Fora commented on FLINK-26139: I think it makes sense to have FAILED/FINISHED/CANCELLED

[jira] [Commented] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498404#comment-17498404 ] Gyula Fora commented on FLINK-26377: We will need to add something like mode later for

[jira] [Assigned] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-26377: -- Assignee: Aitozi > Extract Reconciler interface > > >

[jira] [Comment Edited] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498393#comment-17498393 ] Aitozi edited comment on FLINK-26377 at 2/26/22, 7:01 AM: -- I have the same

[jira] [Comment Edited] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498393#comment-17498393 ] Aitozi edited comment on FLINK-26377 at 2/26/22, 7:01 AM: -- I have the same

[jira] [Updated] (FLINK-26356) Revisit the create of RestClusterClient

2022-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26356: --- Labels: pull-request-available (was: ) > Revisit the create of RestClusterClient >

[jira] [Comment Edited] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498393#comment-17498393 ] Aitozi edited comment on FLINK-26377 at 2/26/22, 6:35 AM: -- I have the same

[jira] [Commented] (FLINK-26356) Revisit the create of RestClusterClient

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498402#comment-17498402 ] Aitozi commented on FLINK-26356: I have some misunderstand before, since the operator will always be

[GitHub] [flink] RocMarshal commented on a change in pull request #18655: [FLINK-25799] [docs] Translate table/filesystem.md page into Chinese.

2022-02-25 Thread GitBox
RocMarshal commented on a change in pull request #18655: URL: https://github.com/apache/flink/pull/18655#discussion_r815266179 ## File path: docs/content.zh/docs/connectors/table/filesystem.md ## @@ -43,37 +42,36 @@ CREATE TABLE MyUserTable ( part_name1 INT, part_name2

[jira] [Commented] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498393#comment-17498393 ] Aitozi commented on FLINK-26377: I have the same sense to extract common reconciler interface. We can

[GitHub] [flink] v-qiunan commented on pull request #18915: [FLINK-26351][k8s/web ui] After scaling a flink task running on k8s, …

2022-02-25 Thread GitBox
v-qiunan commented on pull request #18915: URL: https://github.com/apache/flink/pull/18915#issuecomment-1051563337 @rmetzger Would you like to review this pr? Thanks for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * f05ce63942799088c610bb1f63ea69855c492611 Azure:

[GitHub] [flink] shenzhu commented on pull request #17793: [FLINK-21565][Table SQL/API] Support more integer types in TIMESTAMPADD

2022-02-25 Thread GitBox
shenzhu commented on pull request #17793: URL: https://github.com/apache/flink/pull/17793#issuecomment-1051367428 > apache/flink@3ebe919 Hey @beyond1920 , thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * ead489f563d702c6feb263a66b0cb4a23e9692e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * ead489f563d702c6feb263a66b0cb4a23e9692e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * 7bf6f8d95e9b8b95533acf1a4542e56e71e19949 Azure:

[jira] [Created] (FLINK-26379) First message produced via Flink Kafka Connector is slow

2022-02-25 Thread Ragu Krishnamurthy (Jira)
Ragu Krishnamurthy created FLINK-26379: -- Summary: First message produced via Flink Kafka Connector is slow Key: FLINK-26379 URL: https://issues.apache.org/jira/browse/FLINK-26379 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * 383db615c8dd2017b58b12f9705700c1017d162c Azure:

[jira] [Updated] (FLINK-26378) [pysdk] caller's address isn't set to None properly when a message is coming from an ingress

2022-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26378: --- Labels: pull-request-available (was: ) > [pysdk] caller's address isn't set to None

[GitHub] [flink-statefun] igalshilman opened a new pull request #305: [FLINK-26378][sdk][py] Set caller to None for ingress messages.

2022-02-25 Thread GitBox
igalshilman opened a new pull request #305: URL: https://github.com/apache/flink-statefun/pull/305 This PR makes sure that the caller's address would be None for messages that are coming from an ingress. Previously, calling `context.caller`, for ingress messages would return an

[jira] [Created] (FLINK-26378) caller's address isn't set to None properly when a message is coming from an ingress

2022-02-25 Thread Igal Shilman (Jira)
Igal Shilman created FLINK-26378: Summary: caller's address isn't set to None properly when a message is coming from an ingress Key: FLINK-26378 URL: https://issues.apache.org/jira/browse/FLINK-26378

[jira] [Updated] (FLINK-26378) [pysdk] caller's address isn't set to None properly when a message is coming from an ingress

2022-02-25 Thread Igal Shilman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igal Shilman updated FLINK-26378: - Summary: [pysdk] caller's address isn't set to None properly when a message is coming from an

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * ead489f563d702c6feb263a66b0cb4a23e9692e0 Azure:

[jira] [Created] (FLINK-26377) Extract Reconciler interface

2022-02-25 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-26377: -- Summary: Extract Reconciler interface Key: FLINK-26377 URL: https://issues.apache.org/jira/browse/FLINK-26377 Project: Flink Issue Type: Sub-task

[GitHub] [flink] flinkbot edited a comment on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1047490231 ## CI report: * 74aea8329e1cfa728c8ff07cde3c92971e0a556d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * 4d20c285ada88052e56d5293d69091ae088b53f7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18924: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterReques

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18924: URL: https://github.com/apache/flink/pull/18924#issuecomment-1051002690 ## CI report: * bc7a8b64a529bbeb7c1fb69beb2addbad85d6d39 Azure:

[GitHub] [flink-statefun] galenwarren commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
galenwarren commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r815047718 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[GitHub] [flink-statefun] galenwarren commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
galenwarren commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r815047718 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[GitHub] [flink] flinkbot edited a comment on pull request #18923: [FLINK-26373][connector/kinesis] Renaming KinesisDataStreams module to KinesisStreams

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18923: URL: https://github.com/apache/flink/pull/18923#issuecomment-1050968682 ## CI report: * 6c2aca5f32b63d163696bbd3bf9bbe2cee47784d Azure:

[jira] [Closed] (FLINK-26375) Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread Igal Shilman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igal Shilman closed FLINK-26375. Resolution: Fixed Fixed at 788417d2198b9eb382bbaeabb96dd81e4c04aa21. > Fix Statefun Golang SDK

[GitHub] [flink-statefun] igalshilman merged pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
igalshilman merged pull request #304: URL: https://github.com/apache/flink-statefun/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-26375) Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread Igal Shilman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igal Shilman reassigned FLINK-26375: Assignee: Galen Warren > Fix Statefun Golang SDK to return nil from Context.Caller when

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
igalshilman commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r815035076 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[GitHub] [flink] XComp commented on a change in pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
XComp commented on a change in pull request #18901: URL: https://github.com/apache/flink/pull/18901#discussion_r814977189 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStore.java ## @@ -69,13 +75,82 @@ * the

[GitHub] [flink] JingGe commented on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
JingGe commented on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1051114530 Thanks @fapaul for the feedback. Commit messages have been updated. Please help merging the PR. Many thanks! -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-26314) StreamingCompactingFileSinkITCase.testFileSink failed on azure

2022-02-25 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498263#comment-17498263 ] Ahmed Hamdy commented on FLINK-26314: - Same issue here.

[GitHub] [flink] flinkbot edited a comment on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1050053238 ## CI report: * fc7fd2650d7e7c37eda8f28645ab7e410fbf149a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * a066d5c0c3ac2047312484c62daff4fd395e2df9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * f9832db0e8de0646ec82c877041c9df9878d371c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * Unknown: [CANCELED](TBD) * ead489f563d702c6feb263a66b0cb4a23e9692e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * a066d5c0c3ac2047312484c62daff4fd395e2df9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * f9832db0e8de0646ec82c877041c9df9878d371c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * d3d6c2eb1ed64b15f57c4324a2d6710602661923 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * Unknown: [CANCELED](TBD) * 8a84fe01079fcedabdb867a7d7a775f03b22eb49 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #17922: URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429 ## CI report: * c1d3a50d01717a714c92f63b928c5e84e975ec67 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * a066d5c0c3ac2047312484c62daff4fd395e2df9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * f9832db0e8de0646ec82c877041c9df9878d371c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * d3d6c2eb1ed64b15f57c4324a2d6710602661923 Azure:

[GitHub] [flink] CrynetLogistics commented on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
CrynetLogistics commented on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1051077913 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-26373) Rename flink-connector-aws-kinesis-data-streams module to flink-connector-aws-kinesis-streams

2022-02-25 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-26373: -- Affects Version/s: (was: 1.15.0) > Rename flink-connector-aws-kinesis-data-streams module

[jira] [Assigned] (FLINK-26373) Rename flink-connector-aws-kinesis-data-streams module to flink-connector-aws-kinesis-streams

2022-02-25 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-26373: - Assignee: Ahmed Hamdy > Rename flink-connector-aws-kinesis-data-streams module to >

[jira] [Updated] (FLINK-26373) Rename flink-connector-aws-kinesis-data-streams module to flink-connector-aws-kinesis-streams

2022-02-25 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-26373: -- Fix Version/s: 1.15.0 > Rename flink-connector-aws-kinesis-data-streams module to >

[GitHub] [flink] flinkbot edited a comment on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * a066d5c0c3ac2047312484c62daff4fd395e2df9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * 8c4bf4f52280c8815a706bd6d83a9a618a66c2c9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * d3d6c2eb1ed64b15f57c4324a2d6710602661923 Azure:

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:29 PM: -

[GitHub] [flink] dmvk commented on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
dmvk commented on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1051048972 Thanks for the review @XComp. I've incorporated findings from your comments and the offline discussion, PTAL cc @wangyang0918 - if you want to take a look as well it would

[GitHub] [flink] flinkbot commented on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot commented on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051046922 ## CI report: * a066d5c0c3ac2047312484c62daff4fd395e2df9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18923: [FLINK-26373][connector/kinesis] Renaming KinesisDataStreams module to KinesisStreams

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18923: URL: https://github.com/apache/flink/pull/18923#issuecomment-1050968682 ## CI report: * Unknown: [CANCELED](TBD) * 6c2aca5f32b63d163696bbd3bf9bbe2cee47784d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * 8c4bf4f52280c8815a706bd6d83a9a618a66c2c9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1047490231 ## CI report: * 3a0e7348b507fe416a2cbbc12ba8c2bc5a6a701f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * d3d6c2eb1ed64b15f57c4324a2d6710602661923 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18923: [FLINK-26373][connector/kinesis] Renaming KinesisDataStreams module to KinesisStreams

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18923: URL: https://github.com/apache/flink/pull/18923#issuecomment-1050968682 ## CI report: * 397a62e71aa481241d1ef5bfd7d4b2d6e7271d57 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * 8c4bf4f52280c8815a706bd6d83a9a618a66c2c9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1047490231 ## CI report: * 3a0e7348b507fe416a2cbbc12ba8c2bc5a6a701f Azure:

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:12 PM: -

[GitHub] [flink-statefun] galenwarren commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
galenwarren commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r814945656 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:10 PM: -

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:10 PM: -

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:09 PM: -

[GitHub] [flink] flinkbot commented on pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
flinkbot commented on pull request #18925: URL: https://github.com/apache/flink/pull/18925#issuecomment-1051034806 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver edited comment on FLINK-26374 at 2/25/22, 5:07 PM: -

[GitHub] [flink] vahmed-hamdy commented on pull request #18923: [FLINK-26373][connector/kinesis] Renaming KinesisDataStreams module to KinesisStreams

2022-02-25 Thread GitBox
vahmed-hamdy commented on pull request #18923: URL: https://github.com/apache/flink/pull/18923#issuecomment-1051032251 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-26374) JSON_OBJECT may throw NullPointerException on nullable column

2022-02-25 Thread Jonathan A Weaver (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498215#comment-17498215 ] Jonathan A Weaver commented on FLINK-26374: --- I'm the OP. I did a little more experimentation

[jira] [Updated] (FLINK-25217) FLIP-190: Support Version Upgrades for Table API & SQL Programs

2022-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25217: --- Labels: pull-request-available (was: ) > FLIP-190: Support Version Upgrades for Table API

[GitHub] [flink] matriv opened a new pull request #18925: [FLINK-25217][table-planner] Replace TableConfig with PlannerConfig in FlinkContext

2022-02-25 Thread GitBox
matriv opened a new pull request #18925: URL: https://github.com/apache/flink/pull/18925 ## What is the purpose of the change Replace `TableConfig` with `PlannerConfig` in `FlinkContext` so that all consumers get the merged config (executor config + table config) instead of just

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * Unknown: [CANCELED](TBD) * 8a84fe01079fcedabdb867a7d7a775f03b22eb49 Azure:

[jira] [Created] (FLINK-26376) Replace TableConfig with PlannerConfig in PlannerContext

2022-02-25 Thread Marios Trivyzas (Jira)
Marios Trivyzas created FLINK-26376: --- Summary: Replace TableConfig with PlannerConfig in PlannerContext Key: FLINK-26376 URL: https://issues.apache.org/jira/browse/FLINK-26376 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #18924: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterReques

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18924: URL: https://github.com/apache/flink/pull/18924#issuecomment-1051002690 ## CI report: * bc7a8b64a529bbeb7c1fb69beb2addbad85d6d39 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18922: [BP-1.13][FLINK-26285] Fixes an inconsistency

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18922: URL: https://github.com/apache/flink/pull/18922#issuecomment-1050831490 ## CI report: * 977c807373b0de3edad1a32077adbefe69727bfc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18921: [BP-1.14][FLINK-26285] Fixes an inconsistency

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18921: URL: https://github.com/apache/flink/pull/18921#issuecomment-1050825489 ## CI report: * 5defcd2c8f801e28568be29fc6530c0995df Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18901: [FLINK-26286][kuberentes] Introduce idempotent KubernetesStateHandleS…

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18901: URL: https://github.com/apache/flink/pull/18901#issuecomment-1048885323 ## CI report: * 8c4bf4f52280c8815a706bd6d83a9a618a66c2c9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1047490231 ## CI report: * 3a0e7348b507fe416a2cbbc12ba8c2bc5a6a701f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * d3d6c2eb1ed64b15f57c4324a2d6710602661923 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * Unknown: [CANCELED](TBD) * 8a84fe01079fcedabdb867a7d7a775f03b22eb49 UNKNOWN Bot commands The @flinkbot bot supports the

[GitHub] [flink] XComp commented on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
XComp commented on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1051008394 > I did another minor refactoring in order to be consistent with the changes of https://github.com/apache/flink/pull/18901 (see

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
igalshilman commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r814916549 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #304: [FLINK-26375][statefun-golang-sdk] Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread GitBox
igalshilman commented on a change in pull request #304: URL: https://github.com/apache/flink-statefun/pull/304#discussion_r814915931 ## File path: statefun-sdk-go/v3/pkg/statefun/handler.go ## @@ -225,11 +225,10 @@ func (h *handler) invoke(ctx context.Context, toFunction

[GitHub] [flink] flinkbot commented on pull request #18924: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRec

2022-02-25 Thread GitBox
flinkbot commented on pull request #18924: URL: https://github.com/apache/flink/pull/18924#issuecomment-1051002690 ## CI report: * bc7a8b64a529bbeb7c1fb69beb2addbad85d6d39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18913: [FLINK-26331] Make cleanup retry strategy configurable similar to how the task restart is configurable

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18913: URL: https://github.com/apache/flink/pull/18913#issuecomment-1050153597 ## CI report: * 53171bba4c3b6ac6ac484a994133327dac34e324 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1050053238 ## CI report: * a2c9f439e9958d5b1c81623a63da92b8b2997d9a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18908: [FLINK-26075][table-api][table-planner] Persist and use node configuration

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18908: URL: https://github.com/apache/flink/pull/18908#issuecomment-1049835023 ## CI report: * fcc0de03e2a17e730d72323f84d886e3b3c27c84 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18765: [FLINK-26134][docs] Added table with Checkpoint/Savepoint guarantees …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18765: URL: https://github.com/apache/flink/pull/18765#issuecomment-1039315828 ## CI report: * 1a32563b7691d8e8d795fd1adbbc830d283fd3d3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18869: [FLINK-26284] Introduces mark-for-deletion state in ZooKeeperStateHandleStore

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18869: URL: https://github.com/apache/flink/pull/18869#issuecomment-1047490231 ## CI report: * 019b9ff579a762353f2b2cfb79b9700679b2925d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-25 Thread GitBox
flinkbot edited a comment on pull request #18651: URL: https://github.com/apache/flink/pull/18651#issuecomment-1031863806 ## CI report: * Unknown: [CANCELED](TBD) * 79feeefea042c1e7bb6a70df48c94de6d2e1ffc7 UNKNOWN Bot commands The @flinkbot bot supports the

[GitHub] [flink] flinkbot commented on pull request #18924: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRec

2022-02-25 Thread GitBox
flinkbot commented on pull request #18924: URL: https://github.com/apache/flink/pull/18924#issuecomment-1050989631 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-26375) Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26375: --- Labels: pull-request-available (was: ) > Fix Statefun Golang SDK to return nil from

[jira] [Commented] (FLINK-26375) Fix Statefun Golang SDK to return nil from Context.Caller when there is no caller

2022-02-25 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498194#comment-17498194 ] Galen Warren commented on FLINK-26375: -- PR created: [[FLINK-26375][statefun-golang-sdk] Fix

  1   2   3   4   5   >