[jira] [Created] (FLINK-27860) List the CSS/docs dependencies in the NOTICE

2022-05-31 Thread Yang Wang (Jira)
Yang Wang created FLINK-27860: - Summary: List the CSS/docs dependencies in the NOTICE Key: FLINK-27860 URL: https://issues.apache.org/jira/browse/FLINK-27860 Project: Flink Issue Type: Bug

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1143141982 @Aitozi I fixed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886332488 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -653,7 +655,10 @@ public

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-05-31 Thread GitBox
zhuzhurk commented on code in PR #19653: URL: https://github.com/apache/flink/pull/19653#discussion_r886323585 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImpl.java: ## @@ -120,6 +125,26 @@ public Collection

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1143133417 @Sushant20 The operator intentionally doesn't support restoring from arbitrary savepoints "on-the-fly" to avoid confusion in terms of what savepoint will actually be used

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886327997 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -640,8 +642,8 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886324137 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -197,6 +197,12 @@ private

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886323405 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/SavepointUtils.java: ## @@ -17,40 +17,146 @@ package

[GitHub] [flink-kubernetes-operator] Sushant20 commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
Sushant20 commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1143124527 @gyfora Related question: If periodic savepoint is enabled, how do we restore the job with specific savepoint path as part of native integration operator? There is

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886321792 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-05-31 Thread GitBox
zhuzhurk commented on code in PR #19653: URL: https://github.com/apache/flink/pull/19653#discussion_r886299714 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobIntermediateDatasetReuseTest.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] fsk119 commented on pull request #19741: [FLINK-27794][connector/jdbc] The primary key obtained from MySQL is incorrect by using MysqlCatalog

2022-05-31 Thread GitBox
fsk119 commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1143083598 Hi, guys. I push to my repo about how to reproduce the problem[1]. @dusukang I think you can add a similar test. [1]

[GitHub] [flink] luoyuxia commented on pull request #19851: [FLINK-20765][table-planner]The nullability of result for boolean expression in ScalarOperatorGens should be compatible with the return type

2022-05-31 Thread GitBox
luoyuxia commented on PR #19851: URL: https://github.com/apache/flink/pull/19851#issuecomment-1143080865 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-27835) Introduce LeafPredicate interface and children method in Predicate

2022-05-31 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-27835: Assignee: Caizhi Weng > Introduce LeafPredicate interface and children method in

[GitHub] [flink] fsk119 commented on pull request #19847: [FLINK-27683][table-planner] Fix SQL hints can't work with targetColumns

2022-05-31 Thread GitBox
fsk119 commented on PR #19847: URL: https://github.com/apache/flink/pull/19847#issuecomment-1143078834 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #143: [FLINK-27835] Introduce LeafPredicate interface and children method in Predicate

2022-05-31 Thread GitBox
JingsongLi commented on code in PR #143: URL: https://github.com/apache/flink-table-store/pull/143#discussion_r886278203 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/And.java: ## @@ -20,57 +20,40 @@ import

[GitHub] [flink] flinkbot commented on pull request #19858: [FLINK-27859][hive] Hive dialect should support create table whose name begins with digits

2022-05-31 Thread GitBox
flinkbot commented on PR #19858: URL: https://github.com/apache/flink/pull/19858#issuecomment-1143057098 ## CI report: * 6beb30bc4f29fb104668b410ae62c1c58fa09b6b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27859) Hive dialect should support create table whose name begins with digits

2022-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27859: --- Labels: pull-request-available (was: ) > Hive dialect should support create table whose

[GitHub] [flink] luoyuxia opened a new pull request, #19858: [FLINK-27859][hive] Hive dialect should support create table whose name begins with digits

2022-05-31 Thread GitBox
luoyuxia opened a new pull request, #19858: URL: https://github.com/apache/flink/pull/19858 ## What is the purpose of the change To enable create table whose name begins with digits when using Hive dialect. ## Brief change log Not to convert table's name to

[jira] [Updated] (FLINK-27859) Hive dialect should support create table whose name begins with digits

2022-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-27859: - Summary: Hive dialect should support create table whose name begins with digits (was: Hive dialect

[jira] [Commented] (FLINK-27848) ZooKeeperLeaderElectionDriver keeps writing leader information, using up zxid

2022-05-31 Thread Guo Weijie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544668#comment-17544668 ] Guo Weijie commented on FLINK-27848: Hi [~xtsong] , I have prepared a pull request for this ticket,

[GitHub] [flink] 1996fanrui commented on pull request #19781: Just for test : output buffer aligned to uc

2022-05-31 Thread GitBox
1996fanrui commented on PR #19781: URL: https://github.com/apache/flink/pull/19781#issuecomment-1143042921 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-27859) Hive dialect should support create table that begins with digits

2022-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-27859: Summary: Hive dialect should support create table that begins with digits Key: FLINK-27859 URL: https://issues.apache.org/jira/browse/FLINK-27859 Project: Flink

[GitHub] [flink] wangyang0918 merged pull request #19848: [hotfix][doc] fix typo and enlarge image

2022-05-31 Thread GitBox
wangyang0918 merged PR #19848: URL: https://github.com/apache/flink/pull/19848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wangyang0918 commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image

2022-05-31 Thread GitBox
wangyang0918 commented on code in PR #19848: URL: https://github.com/apache/flink/pull/19848#discussion_r886252080 ## docs/content/docs/deployment/overview.md: ## @@ -183,7 +183,7 @@ Flink can execute applications in one of three ways: -{{< img class="img-fluid"

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544662#comment-17544662 ] Xintong Song commented on FLINK-27722: -- Thanks [~martijnvisser]. +1 to open up the Flink Slack

[jira] [Updated] (FLINK-27858) Hive source support filter push down for parquet format

2022-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-27858: - Description: Can move on after finish [FLINK-16952|https://issues.apache.org/jira/browse/FLINK-16952]

[jira] [Updated] (FLINK-27858) Hive source support filter push down for parquet format

2022-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-27858: - Description: Can move on after finish FLINK-17778   was: Can move on after finish FLINK-17778 | |  

[jira] [Updated] (FLINK-27858) Hive source support filter push down for parquet format

2022-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-27858: - Fix Version/s: 1.16.0 > Hive source support filter push down for parquet format >

[jira] [Updated] (FLINK-27858) Hive source support filter push down for parquet format

2022-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-27858: - Description: Can move on after finish FLINK-17778 | |   > Hive source support filter push down for

[jira] [Created] (FLINK-27858) Hive source support filter push down for parquet format

2022-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-27858: Summary: Hive source support filter push down for parquet format Key: FLINK-27858 URL: https://issues.apache.org/jira/browse/FLINK-27858 Project: Flink Issue Type:

[jira] [Created] (FLINK-27857) Hive source support filter push down for orc format

2022-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-27857: Summary: Hive source support filter push down for orc format Key: FLINK-27857 URL: https://issues.apache.org/jira/browse/FLINK-27857 Project: Flink Issue Type:

[GitHub] [flink] luoyuxia commented on pull request #19851: [FLINK-20765][table-planner]The nullability of result for boolean expression in ScalarOperatorGens should be compatible with the return type

2022-05-31 Thread GitBox
luoyuxia commented on PR #19851: URL: https://github.com/apache/flink/pull/19851#issuecomment-1142931567 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
Aitozi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886216711 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -640,8 +642,8 @@ public

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
Aitozi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886221893 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -653,7 +655,10 @@ public

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
Aitozi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886202321 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-kubernetes-operator] zeus1ammon commented on pull request #246: [FLINK-27788] Adding annotation to k8 operator Pod

2022-05-31 Thread GitBox
zeus1ammon commented on PR #246: URL: https://github.com/apache/flink-kubernetes-operator/pull/246#issuecomment-1142688556 > @zeus1ammon do you think it would make sense to add labels too if you are touching this anyway? As labels are cosmetic and not functional like annotation (at

[GitHub] [flink-kubernetes-operator] zeus1ammon commented on a diff in pull request #246: [FLINK-27788] Adding annotation to k8 operator Pod

2022-05-31 Thread GitBox
zeus1ammon commented on code in PR #246: URL: https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r886158707 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -34,6 +34,12 @@ spec: {{- include "flink-operator.selectorLabels" .

[GitHub] [flink-kubernetes-operator] zeus1ammon commented on a diff in pull request #246: [FLINK-27788] Adding annotation to k8 operator Pod

2022-05-31 Thread GitBox
zeus1ammon commented on code in PR #246: URL: https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r886152921 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -30,6 +30,9 @@ image: rbac: create: true +operatorPodDeployment: Review Comment: it

[GitHub] [flink] flinkbot commented on pull request #19857: Flink 24960 fix race condition test

2022-05-31 Thread GitBox
flinkbot commented on PR #19857: URL: https://github.com/apache/flink/pull/19857#issuecomment-1142654933 ## CI report: * 90a833e5dbed3f1d4a1dccecc51b8e6de7c88e6c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 1996fanrui commented on pull request #19781: Just for test : output buffer aligned to uc

2022-05-31 Thread GitBox
1996fanrui commented on PR #19781: URL: https://github.com/apache/flink/pull/19781#issuecomment-1142651977 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-27856) Adding pod template without spec crashes job manager

2022-05-31 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27856: --- Affects Version/s: kubernetes-operator-1.0.0 > Adding pod template without spec crashes job manager

[jira] [Updated] (FLINK-27856) Adding pod template without spec crashes job manager

2022-05-31 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27856: --- Fix Version/s: kubernetes-operator-1.1.0 (was: 1.14.4) > Adding pod template

[jira] [Created] (FLINK-27856) Adding pod template without spec crashes job manager

2022-05-31 Thread Jeesmon Jacob (Jira)
Jeesmon Jacob created FLINK-27856: - Summary: Adding pod template without spec crashes job manager Key: FLINK-27856 URL: https://issues.apache.org/jira/browse/FLINK-27856 Project: Flink Issue

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1142428887 > @morhidi I wasn't planning on changing the history logic, that would also be a breaking change compared to previous versions so it would need transformation logic to

[jira] [Updated] (FLINK-27855) Job Manager fails to recover with S3 storage and HA enabled

2022-05-31 Thread Sushant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant updated FLINK-27855: Description: Flink version: 1.15  with Native Integration K8s operator mode:

[jira] [Updated] (FLINK-27855) Job Manager fails to recover with S3 storage and HA enabled

2022-05-31 Thread Sushant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant updated FLINK-27855: Description: Flink version: 1.15  Steps to replicate 1. Enable HA and mention S3 recovery path in flink

[jira] [Updated] (FLINK-27855) Job Manager fails to recover with S3 storage and HA enabled

2022-05-31 Thread Sushant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant updated FLINK-27855: Description: Flink version: 1.15  Steps to replicate 1. Enable HA and mention S3 path in flink

[jira] [Updated] (FLINK-27855) Job Manager fails to recover with S3 storage and HA enabled

2022-05-31 Thread Sushant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant updated FLINK-27855: Description: Flink version: 1.15  Steps to replicate 1. Enable HA and mention S3 path in flink

[jira] [Created] (FLINK-27855) Job Manager fails to recover with S3 storage and HA enabled

2022-05-31 Thread Sushant (Jira)
Sushant created FLINK-27855: --- Summary: Job Manager fails to recover with S3 storage and HA enabled Key: FLINK-27855 URL: https://issues.apache.org/jira/browse/FLINK-27855 Project: Flink Issue

[GitHub] [flink] jeromatron commented on pull request #19680: [FLINK-27457] Implement flush() logic in Cassandra output formats

2022-05-31 Thread GitBox
jeromatron commented on PR #19680: URL: https://github.com/apache/flink/pull/19680#issuecomment-1142382894 I just wanted to say thank you @echauchot and @zentol for all the work on this and the other patch for https://issues.apache.org/jira/browse/FLINK-26824. Those using Flink with more

[GitHub] [flink] 1996fanrui commented on pull request #19781: Just for test : output buffer aligned to uc

2022-05-31 Thread GitBox
1996fanrui commented on PR #19781: URL: https://github.com/apache/flink/pull/19781#issuecomment-1142344521 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-27839) org.apache.flink.kafka.shaded.org.apache.kafka.common.errors.InterruptException

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544489#comment-17544489 ] Martijn Visser commented on FLINK-27839: [~lijixiang] These type of errors usually imply some

[jira] [Commented] (FLINK-27840) org.apache.flink.kafka.shaded.org.apache.kafka.common.errors.DisconnectException

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544488#comment-17544488 ] Martijn Visser commented on FLINK-27840: [~lijixiang] These type of errors usually imply some

[jira] [Closed] (FLINK-27841) RocksDB cache miss increase in 1.15

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27841. -- Resolution: Information Provided [~Feifan Wang] Thanks for opening the ticket. As you can see

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544482#comment-17544482 ] Martijn Visser commented on FLINK-27722: I agree. Are we already OK with opening up the Flink

[jira] [Assigned] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-27291: -- Assignee: Cason > Translate the "List of Data Types" section of "Data Types" in to

[jira] [Commented] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2022-05-31 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544479#comment-17544479 ] Martijn Visser commented on FLINK-27291: [~casonPig] Thanks for volunteering, I've assigned the

[GitHub] [flink] metaswirl commented on pull request #19855: [FLINK-24960][yarn-tests] show eventual failure due to race condition

2022-05-31 Thread GitBox
metaswirl commented on PR #19855: URL: https://github.com/apache/flink/pull/19855#issuecomment-1142327826 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1142326848 @morhidi I wasn't planning on changing the history logic, that would also be a breaking change compared to previous versions so it would need transformation logic to make

[GitHub] [flink] flinkbot commented on pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-05-31 Thread GitBox
flinkbot commented on PR #19856: URL: https://github.com/apache/flink/pull/19856#issuecomment-1142324089 ## CI report: * fb8f1460b2b931a2e2975596736fed2186f107f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27854) Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27854: --- Labels: pull-request-available (was: ) > Refactor FlinkImageBuilder and 

[GitHub] [flink] afedulov opened a new pull request, #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-05-31 Thread GitBox
afedulov opened a new pull request, #19856: URL: https://github.com/apache/flink/pull/19856 ## What is the purpose of the change FlinkImageBuilder and FlinkContainerBuilder are tightly coupled with using flink-dist to create Flink images on the flight. Some configuration is

[jira] [Created] (FLINK-27854) Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-05-31 Thread Alexander Fedulov (Jira)
Alexander Fedulov created FLINK-27854: - Summary: Refactor FlinkImageBuilder and FlinkContainerBuilder Key: FLINK-27854 URL: https://issues.apache.org/jira/browse/FLINK-27854 Project: Flink

[jira] [Assigned] (FLINK-27854) Refactor FlinkImageBuilder and FlinkContainerBuilder

2022-05-31 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov reassigned FLINK-27854: - Assignee: Alexander Fedulov > Refactor FlinkImageBuilder and 

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1142302043 @gyfora I was comparing the savepoint history with the ones on the dashboard. Does it make sense to display it the same way e.g. latest on top, human readable timestamp?

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1142295834 @morhidi I ran into this issue also with the disposal. I think it's unrelated to my change this is what prompted me to try to improve the dispose logic a little. I will

[GitHub] [flink] JingGe commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image

2022-05-31 Thread GitBox
JingGe commented on code in PR #19848: URL: https://github.com/apache/flink/pull/19848#discussion_r885794542 ## docs/content/docs/deployment/overview.md: ## @@ -183,7 +183,7 @@ Flink can execute applications in one of three ways: -{{< img class="img-fluid" width="80%"

[GitHub] [flink] flinkbot commented on pull request #19855: [FLINK-24960][yarn-tests] show eventual failure due to race condition

2022-05-31 Thread GitBox
flinkbot commented on PR #19855: URL: https://github.com/apache/flink/pull/19855#issuecomment-1142290744 ## CI report: * 0b49325ad1b0411fc26bddc82137cbe571ae66f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#issuecomment-1142279072 Hitting this locally after a while, doesn't seem to be related to the current change```2022-05-31 17:07:55,479 o.a.f.k.o.o.SavepointObserver [INFO ]

[GitHub] [flink] deadwind4 commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

2022-05-31 Thread GitBox
deadwind4 commented on PR #19802: URL: https://github.com/apache/flink/pull/19802#issuecomment-1142278758 I need to make the CI auto-install different dev-requirements.txt in the python 3.6 version. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885774741 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885771756 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885762773 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[jira] [Created] (FLINK-27853) FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-31 Thread xuyang (Jira)
xuyang created FLINK-27853: -- Summary: FLIP-229: Introduces Join Hint for Flink SQL Batch Job Key: FLINK-27853 URL: https://issues.apache.org/jira/browse/FLINK-27853 Project: Flink Issue Type: New

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885753975 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885753975 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-table-store] ajian2002 commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-31 Thread GitBox
ajian2002 commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r885750661 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateMergeFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
gyfora commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885742939 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885725325 ## docs/layouts/shortcodes/generated/kubernetes_operator_config_configuration.html: ## @@ -74,6 +74,12 @@ Duration The

[jira] [Assigned] (FLINK-27792) WindowDistinctAggregateITCase. testTumbleWindow_Rollup failed with InterruptedException

2022-05-31 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-27792: -- Assignee: Atri Sharma > WindowDistinctAggregateITCase. testTumbleWindow_Rollup

[jira] [Assigned] (FLINK-27765) TaskManagerProcessFailureBatchRecoveryITCase.testTaskManagerProcessFailure failed with FlinkJobNotFoundException

2022-05-31 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-27765: -- Assignee: Atri Sharma >

[jira] [Commented] (FLINK-15736) Support Java 17 (LTS)

2022-05-31 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544413#comment-17544413 ] Robert Metzger commented on FLINK-15736: [~chesnay] what's the status of this ticket? Are there

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #249: [FLINK-26179] Support for periodic savepoints

2022-05-31 Thread GitBox
morhidi commented on code in PR #249: URL: https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r885689686 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java: ## @@ -163,4 +163,12 @@

[GitHub] [flink] afedulov commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
afedulov commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885664820 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainerTestEnvironment.java: ## @@ -27,61

[GitHub] [flink] 1996fanrui commented on pull request #19499: [FLINK-26762][network] Add the overdraft buffer in ResultPartition

2022-05-31 Thread GitBox
1996fanrui commented on PR #19499: URL: https://github.com/apache/flink/pull/19499#issuecomment-1142154056 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] alpreu commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
alpreu commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885635059 ## flink-end-to-end-tests/flink-end-to-end-tests-elasticsearch7/src/test/resources/log4j2-test.properties: ## @@ -17,7 +17,7 @@

[GitHub] [flink] wangyang0918 commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image

2022-05-31 Thread GitBox
wangyang0918 commented on code in PR #19848: URL: https://github.com/apache/flink/pull/19848#discussion_r885621851 ## docs/content/docs/deployment/overview.md: ## @@ -183,7 +183,7 @@ Flink can execute applications in one of three ways: -{{< img class="img-fluid"

[jira] [Created] (FLINK-27852) Contribute k8s operator to OperatorHub

2022-05-31 Thread Jira
Márton Balassi created FLINK-27852: -- Summary: Contribute k8s operator to OperatorHub Key: FLINK-27852 URL: https://issues.apache.org/jira/browse/FLINK-27852 Project: Flink Issue Type:

[GitHub] [flink] alpreu commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
alpreu commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885612787 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainerTestEnvironment.java: ## @@ -9,14 +9,14

[GitHub] [flink] alpreu commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
alpreu commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885611357 ## flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/resources/log4j2-test.properties: ## @@ -18,7 +18,7 @@ # Set root logger level to OFF to not

[GitHub] [flink] alpreu commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
alpreu commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885608422 ## flink-end-to-end-tests/flink-end-to-end-tests-common-elasticsearch/src/main/java/org/apache/flink/streaming/tests/ElasticsearchSinkE2ECaseBase.java: ## @@ -55,8

[GitHub] [flink] alpreu commented on a diff in pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

2022-05-31 Thread GitBox
alpreu commented on code in PR #19854: URL: https://github.com/apache/flink/pull/19854#discussion_r885608797 ## flink-end-to-end-tests/flink-end-to-end-tests-common-elasticsearch/src/main/java/org/apache/flink/streaming/tests/ElasticsearchSinkE2ECaseBase.java: ## @@ -55,8

[GitHub] [flink] RocMarshal commented on pull request #19741: [FLINK-27794][connector/jdbc] The primary key obtained from MySQL is incorrect by using MysqlCatalog

2022-05-31 Thread GitBox
RocMarshal commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1142100626 Thanks @dusukang for the driving this and @fsk119 ping. +1 to me to fix it. But I'm not sure whether the current fix is compatible with different versions of MySQL. Would you

[jira] [Commented] (FLINK-27794) The primary key obtained from MySQL is incorrect by using MysqlCatalog

2022-05-31 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544366#comment-17544366 ] RocMarshal commented on FLINK-27794: Thanks [~dusukang] for the reporting it and [~martijnvisser]

[GitHub] [flink] flinkbot commented on pull request #19854: WIP: FlinkImageBuilder from snapshot

2022-05-31 Thread GitBox
flinkbot commented on PR #19854: URL: https://github.com/apache/flink/pull/19854#issuecomment-1142082718 ## CI report: * d41fa5975eb7d7e600981dc2dc212c7fb3542c25 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-31 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r885565159 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateMergeFunction.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] [flink] luoyuxia closed pull request #18453: [FLINK-25562][hive] add detail explanation about bundled hive jar to …

2022-05-31 Thread GitBox
luoyuxia closed pull request #18453: [FLINK-25562][hive] add detail explanation about bundled hive jar to … URL: https://github.com/apache/flink/pull/18453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #19853: [FLINK-27848][runtime] Fix the problem that ZooKeeperLeaderElectionDr…

2022-05-31 Thread GitBox
flinkbot commented on PR #19853: URL: https://github.com/apache/flink/pull/19853#issuecomment-1142050586 ## CI report: * 371b1d3fe8f72d3d9ba73cdf0db0e4c40cc216ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27848) ZooKeeperLeaderElectionDriver keeps writing leader information, using up zxid

2022-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27848: --- Labels: pull-request-available (was: ) > ZooKeeperLeaderElectionDriver keeps writing

  1   2   >