[GitHub] [flink] lsyldliu commented on pull request #17654: [FLINK-24614][Connectors/PARQUET] Add Complex types support for parquet reader

2022-06-18 Thread GitBox
lsyldliu commented on PR #17654: URL: https://github.com/apache/flink/pull/17654#issuecomment-1159608614 Due to @meetjunsu had not respond for a long time, I will take over it. Thanks for @meetjunsu contribution. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] xinbinhuang commented on pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2022-06-18 Thread GitBox
xinbinhuang commented on PR #17873: URL: https://github.com/apache/flink/pull/17873#issuecomment-1159608446 @twalthr Thank you so much for providing the context. I agree that change fields or remove fields (i.e. change the name) should be extra careful. How about adding a new field? I

[jira] [Commented] (FLINK-28021) Add FLIP-33 metrics to FileSystem connector

2022-06-18 Thread Shubham Bansal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556023#comment-17556023 ] Shubham Bansal commented on FLINK-28021: [~jingge] I looked at the code and understood what is

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #269: [FLINK-27688] Add pluggable FlinkResourceListener interface

2022-06-18 Thread GitBox
gyfora commented on code in PR #269: URL: https://github.com/apache/flink-kubernetes-operator/pull/269#discussion_r900951149 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/listener/ListenerUtils.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] [flink] 1996fanrui commented on pull request #19993: [FLINK-28077][checkpoint] Fix the bug that tasks get stuck during cancellation in ChannelStateWriteRequestExecutorImpl

2022-06-18 Thread GitBox
1996fanrui commented on PR #19993: URL: https://github.com/apache/flink/pull/19993#issuecomment-1159477055 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-28117) More metrics for FileSource

2022-06-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-28117: Affects Version/s: 1.16.0 > More metrics for FileSource > --- > >

[jira] [Updated] (FLINK-28117) More metrics for FileSource

2022-06-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-28117: Component/s: Connectors / FileSystem Runtime / Metrics > More metrics for FileSource >

[jira] [Created] (FLINK-28117) More metrics for FileSource

2022-06-18 Thread Jing Ge (Jira)
Jing Ge created FLINK-28117: --- Summary: More metrics for FileSource Key: FLINK-28117 URL: https://issues.apache.org/jira/browse/FLINK-28117 Project: Flink Issue Type: Improvement

[GitHub] [flink-kubernetes-operator] tweise commented on a diff in pull request #269: [FLINK-27688] Add pluggable FlinkResourceListener interface

2022-06-18 Thread GitBox
tweise commented on code in PR #269: URL: https://github.com/apache/flink-kubernetes-operator/pull/269#discussion_r900884753 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/listener/ListenerUtils.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] [flink-kubernetes-operator] tweise commented on a diff in pull request #269: [FLINK-27688] Add pluggable FlinkResourceListener interface

2022-06-18 Thread GitBox
tweise commented on code in PR #269: URL: https://github.com/apache/flink-kubernetes-operator/pull/269#discussion_r900884502 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/listener/ListenerUtils.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-28101) YARNHighAvailabilityITCase failed on azure

2022-06-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555906#comment-17555906 ] Jing Ge commented on FLINK-28101: - closed because of duplication, please refer to FLINK-27667 for more

[jira] [Commented] (FLINK-28107) Support id of document is null

2022-06-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555905#comment-17555905 ] Jing Ge commented on FLINK-28107: - [~ana4] please find the external ES connector repo:

[jira] [Commented] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555903#comment-17555903 ] Jing Ge commented on FLINK-28116: - Thanks for reporting this. Flink need a more generic way to handle

[GitHub] [flink] lsyldliu commented on pull request #20003: [FLINK-28080][runtime] Introduce MutableURLClassLoader as parent class of FlinkUserClassLoader and SafetyNetWrapperClassLoader

2022-06-18 Thread GitBox
lsyldliu commented on PR #20003: URL: https://github.com/apache/flink/pull/20003#issuecomment-1159453217 > You can just take whatever classloader you have (e.g., the Flink CL), and create a new FlinkUserCodeClassLoader with that CL as a parent and specify the jar via the urls parameter.

[jira] [Commented] (FLINK-28060) Kafka Commit on checkpointing fails repeatedly after a broker restart

2022-06-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555896#comment-17555896 ] Martijn Visser commented on FLINK-28060: Fixed in master:

[GitHub] [flink] MartijnVisser merged pull request #19994: [FLINK-28060][Connector/Kafka] Updated Kafka Clients to 3.1.1

2022-06-18 Thread GitBox
MartijnVisser merged PR #19994: URL: https://github.com/apache/flink/pull/19994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-28110) Table Store Hive Reader supports projection pushdown

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555878#comment-17555878 ] xingyuan cheng edited comment on FLINK-28110 at 6/18/22 10:39 AM: --

[GitHub] [flink] 1996fanrui commented on a diff in pull request #19993: [FLINK-28077][checkpoint] Fix the bug that tasks get stuck during cancellation in ChannelStateWriteRequestExecutorImpl

2022-06-18 Thread GitBox
1996fanrui commented on code in PR #19993: URL: https://github.com/apache/flink/pull/19993#discussion_r900807989 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java: ## @@ -98,6 +98,9 @@ static ChannelStateWriteRequest

[GitHub] [flink] 1996fanrui commented on a diff in pull request #19993: [FLINK-28077][checkpoint] Fix the bug that tasks get stuck during cancellation in ChannelStateWriteRequestExecutorImpl

2022-06-18 Thread GitBox
1996fanrui commented on code in PR #19993: URL: https://github.com/apache/flink/pull/19993#discussion_r900803080 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java: ## @@ -109,6 +112,9 @@ static ChannelStateWriteRequest

[jira] [Commented] (FLINK-28110) Table Store Hive Reader supports projection pushdown

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555881#comment-17555881 ] xingyuan cheng commented on FLINK-28110: I will try to perfect this feature > Table Store Hive

[jira] [Comment Edited] (FLINK-28110) Table Store Hive Reader supports projection pushdown

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555878#comment-17555878 ] xingyuan cheng edited comment on FLINK-28110 at 6/18/22 10:13 AM: --

[jira] [Comment Edited] (FLINK-28110) Table Store Hive Reader supports projection pushdown

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555878#comment-17555878 ] xingyuan cheng edited comment on FLINK-28110 at 6/18/22 10:12 AM: --

[jira] [Commented] (FLINK-28110) Table Store Hive Reader supports projection pushdown

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555878#comment-17555878 ] xingyuan cheng commented on FLINK-28110: Maybe we need to use

[GitHub] [flink] flinkbot commented on pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format

2022-06-18 Thread GitBox
flinkbot commented on PR #20016: URL: https://github.com/apache/flink/pull/20016#issuecomment-1159410389 ## CI report: * 83ee6c72efbdbc39f12e2847b43a4565b70f877d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27857) Hive source support filter push down for orc format

2022-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27857: --- Labels: pull-request-available (was: ) > Hive source support filter push down for orc

[GitHub] [flink] luoyuxia opened a new pull request, #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format

2022-06-18 Thread GitBox
luoyuxia opened a new pull request, #20016: URL: https://github.com/apache/flink/pull/20016 ## What is the purpose of the change Make hive source support filter push down for orc format ## Brief change log - Make HiveTableSource implement `SupportsFilterPushDown`

[GitHub] [flink] 1996fanrui commented on a diff in pull request #19993: [FLINK-28077][checkpoint] Fix the bug that tasks get stuck during cancellation in ChannelStateWriteRequestExecutorImpl

2022-06-18 Thread GitBox
1996fanrui commented on code in PR #19993: URL: https://github.com/apache/flink/pull/19993#discussion_r900755285 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java: ## @@ -98,6 +98,9 @@ static ChannelStateWriteRequest

[jira] [Commented] (FLINK-27792) InterruptedException thrown by ChannelStateWriterImpl

2022-06-18 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555864#comment-17555864 ] fanrui commented on FLINK-27792: Hi [~chesnay]  [~pnowojski] . Sorry for introducing this issue, I'm

[jira] [Updated] (FLINK-27792) InterruptedException thrown by ChannelStateWriterImpl

2022-06-18 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanrui updated FLINK-27792: --- Attachment: image-2022-06-18-16-42-13-669.png > InterruptedException thrown by ChannelStateWriterImpl >

[jira] [Updated] (FLINK-27792) InterruptedException thrown by ChannelStateWriterImpl

2022-06-18 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanrui updated FLINK-27792: --- Attachment: image-2022-06-18-16-42-46-283.png > InterruptedException thrown by ChannelStateWriterImpl >

[GitHub] [flink] flinkbot commented on pull request #20015: [FLINK-28011][hive] HiveSource should get partitions in batch instead of getting partition one by one

2022-06-18 Thread GitBox
flinkbot commented on PR #20015: URL: https://github.com/apache/flink/pull/20015#issuecomment-1159398835 ## CI report: * 7d52086ccc9b658988e1908d34f1d175035c27d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27792) InterruptedException thrown by ChannelStateWriterImpl

2022-06-18 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fanrui updated FLINK-27792: --- Attachment: image-2022-06-18-16-39-54-402.png > InterruptedException thrown by ChannelStateWriterImpl >

[jira] [Updated] (FLINK-28011) Optimize getAllPartitions in HiveSource

2022-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28011: --- Labels: pull-request-available (was: ) > Optimize getAllPartitions in HiveSource >

[GitHub] [flink] luoyuxia opened a new pull request, #20015: [FLINK-28011][hive] HiveSource should get partitions in batch instead of getting partition one by one

2022-06-18 Thread GitBox
luoyuxia opened a new pull request, #20015: URL: https://github.com/apache/flink/pull/20015 ## What is the purpose of the change Make HiveSouce get partitions in batch instead of getting one by one, which is time consuming. ## Brief change log - First get all

[jira] [Updated] (FLINK-27708) Add background compaction task for append-only table when ingesting.

2022-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27708: --- Labels: pull-request-available (was: ) > Add background compaction task for append-only

[GitHub] [flink-table-store] complone opened a new pull request, #164: [FLINK-27708] Add background compaction task for append-only table when ingesting.

2022-06-18 Thread GitBox
complone opened a new pull request, #164: URL: https://github.com/apache/flink-table-store/pull/164 Related to FLINK-27708 Add background compaction task for append-only table when ingesting. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (FLINK-28021) Add FLIP-33 metrics to FileSystem connector

2022-06-18 Thread Shubham Bansal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555861#comment-17555861 ] Shubham Bansal edited comment on FLINK-28021 at 6/18/22 8:26 AM: -

[jira] [Commented] (FLINK-28021) Add FLIP-33 metrics to FileSystem connector

2022-06-18 Thread Shubham Bansal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555861#comment-17555861 ] Shubham Bansal commented on FLINK-28021: Thanks. Taking a look.       > Add FLIP-33 metrics to

[GitHub] [flink] flinkbot commented on pull request #20014: [FLINK-26979][table-planner] Correct the race condition on transformation node id

2022-06-18 Thread GitBox
flinkbot commented on PR #20014: URL: https://github.com/apache/flink/pull/20014#issuecomment-1159393589 ## CI report: * 413ff339da9dbcad6329da5134c27fbbf7bc05bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-26979) JsonFunctionsITCase.test failed on azure

2022-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26979: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] shba24 opened a new pull request, #20014: [FLINK-26979][table-planner] Correct the race condition on transformation node id

2022-06-18 Thread GitBox
shba24 opened a new pull request, #20014: URL: https://github.com/apache/flink/pull/20014 ## What is the purpose of the change Fix the race condition on node id of transformation when test execution happens in parallel ## Brief change log - *Correct the race condition

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-18 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900711478 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -504,8 +522,11 @@ private void

[jira] [Commented] (FLINK-27708) Add background compaction task for append-only table when ingesting.

2022-06-18 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555851#comment-17555851 ] xingyuan cheng commented on FLINK-27708: I want to try to do this work. There are some studies

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-18 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900707375 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/AbstractFineGrainedSlotManagerITCase.java: ## @@ -752,4 +753,76 @@ public void

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-18 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900706727 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -504,8 +522,11 @@ private void

[jira] [Comment Edited] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-18 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1732#comment-1732 ] Biao Geng edited comment on FLINK-27667 at 6/18/22 6:36 AM: hi

[jira] [Comment Edited] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-18 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1732#comment-1732 ] Biao Geng edited comment on FLINK-27667 at 6/18/22 6:34 AM: hi

[jira] [Commented] (FLINK-28103) Job cancelling api returns 404 when job is actually running

2022-06-18 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555843#comment-17555843 ] David commented on FLINK-28103: --- [~chesnay] PATCH is supported neither in Java (HttpURLConnection) nor in

[jira] [Commented] (FLINK-28103) Job cancelling api returns 404 when job is actually running

2022-06-18 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555842#comment-17555842 ] David commented on FLINK-28103: --- [~martijnvisser] I'll try that next week > Job cancelling api returns

[GitHub] [flink] MartijnVisser commented on pull request #19994: [FLINK-28060][Connector/Kafka] Updated Kafka Clients to 3.1.1

2022-06-18 Thread GitBox
MartijnVisser commented on PR #19994: URL: https://github.com/apache/flink/pull/19994#issuecomment-1159371183 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific