[GitHub] [flink] mas-chen commented on a diff in pull request #20475: [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink

2022-10-12 Thread GitBox
mas-chen commented on code in PR #20475: URL: https://github.com/apache/flink/pull/20475#discussion_r994178677 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -398,6 +407,11 @@ private void

[jira] [Updated] (FLINK-29611) Fix flaky tests in CoBroadcastWithNonKeyedOperatorTest

2022-10-12 Thread Sopan Phaltankar (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sopan Phaltankar updated FLINK-29611: - Description: The test

[jira] [Updated] (FLINK-29612) Extract changelog files out of DataFileMeta#extraFiles

2022-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29612: --- Labels: pull-request-available (was: ) > Extract changelog files out of

[GitHub] [flink-table-store] tsreaper opened a new pull request, #316: [FLINK-29612] Extract changelog files out of DataFileMeta#extraFiles

2022-10-12 Thread GitBox
tsreaper opened a new pull request, #316: URL: https://github.com/apache/flink-table-store/pull/316 Currently changelog files are stored as extra files in `DataFileMeta`. However for the full compaction changelog we're about to introduce, it cannot be added as extra files because their

[jira] [Created] (FLINK-29612) Extract changelog files out of DataFileMeta#extraFiles

2022-10-12 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29612: --- Summary: Extract changelog files out of DataFileMeta#extraFiles Key: FLINK-29612 URL: https://issues.apache.org/jira/browse/FLINK-29612 Project: Flink Issue

[jira] [Updated] (FLINK-29611) Fix flaky tests in CoBroadcastWithNonKeyedOperatorTest

2022-10-12 Thread Sopan Phaltankar (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sopan Phaltankar updated FLINK-29611: - Description: The test

[jira] [Created] (FLINK-29611) Fix flaky tests in CoBroadcastWithNonKeyedOperatorTest

2022-10-12 Thread Sopan Phaltankar (Jira)
Sopan Phaltankar created FLINK-29611: Summary: Fix flaky tests in CoBroadcastWithNonKeyedOperatorTest Key: FLINK-29611 URL: https://issues.apache.org/jira/browse/FLINK-29611 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21043: Update datastream_tutorial.md

2022-10-12 Thread GitBox
flinkbot commented on PR #21043: URL: https://github.com/apache/flink/pull/21043#issuecomment-1276994446 ## CI report: * 0bd76544b8806a10f266ebaffbc184f34edb2b31 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] junjie1209 opened a new pull request, #21043: Update datastream_tutorial.md

2022-10-12 Thread GitBox
junjie1209 opened a new pull request, #21043: URL: https://github.com/apache/flink/pull/21043 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[jira] [Updated] (FLINK-25205) Optimize SinkUpsertMaterializer

2022-10-12 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-25205: - Fix Version/s: 1.17.0 > Optimize SinkUpsertMaterializer > --- > >

[jira] [Assigned] (FLINK-25205) Optimize SinkUpsertMaterializer

2022-10-12 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-25205: Assignee: lincoln lee > Optimize SinkUpsertMaterializer >

[GitHub] [flink] flinkbot commented on pull request #21042: Flink 29590 hive3

2022-10-12 Thread GitBox
flinkbot commented on PR #21042: URL: https://github.com/apache/flink/pull/21042#issuecomment-1276968219 ## CI report: * d27b08165bbdfdc6c7aec35f4d83a429ac62b63c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] zjureel commented on pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2022-10-12 Thread GitBox
zjureel commented on PR #313: URL: https://github.com/apache/flink-table-store/pull/313#issuecomment-1276966383 > Hi @zjureel can you do some benchmark to verify the improvement? Hi @JingsongLi It's a good idea and I like it. I find there's a `flink-table-store-benchmark` project in

[GitHub] [flink] luoyuxia opened a new pull request, #21042: Flink 29590 hive3

2022-10-12 Thread GitBox
luoyuxia opened a new pull request, #21042: URL: https://github.com/apache/flink/pull/21042 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] luoyuxia closed pull request #20907: Flink 29337 hive3

2022-10-12 Thread GitBox
luoyuxia closed pull request #20907: Flink 29337 hive3 URL: https://github.com/apache/flink/pull/20907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] luoyuxia closed pull request #21020: Hive fix

2022-10-12 Thread GitBox
luoyuxia closed pull request #21020: Hive fix URL: https://github.com/apache/flink/pull/21020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-28128) Create e2e test for spark reader

2022-10-12 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28128. Assignee: Shammon Resolution: Fixed > Create e2e test for spark reader >

[GitHub] [flink-table-store] JingsongLi merged pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-12 Thread GitBox
JingsongLi merged PR #314: URL: https://github.com/apache/flink-table-store/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21041: fix(sec): upgrade com.google.guava:guava to 30.0-jre

2022-10-12 Thread GitBox
flinkbot commented on PR #21041: URL: https://github.com/apache/flink/pull/21041#issuecomment-1276957240 ## CI report: * 6d0754ff9f9915f9bba2f772801132c334aa2033 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-web] JingsongLi merged pull request #571: Release Flink Table Store 0.2.1

2022-10-12 Thread GitBox
JingsongLi merged PR #571: URL: https://github.com/apache/flink-web/pull/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] leletan commented on pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-12 Thread GitBox
leletan commented on PR #20852: URL: https://github.com/apache/flink/pull/20852#issuecomment-1276935626 @zentol Thanks for the detailed feedbacks, really appreciated them! I should have addressed all the comments in this round. Please take another look when you have a chance. -- This

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-12 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r994043353 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointTriggerHandlers.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-12 Thread Jiale Tan (Jira)
Jiale Tan created FLINK-29610: - Summary: Infinite timeout is used in SavepointHandlers calls to RestfulGateway Key: FLINK-29610 URL: https://issues.apache.org/jira/browse/FLINK-29610 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21040: [FLINK-29486][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway

2022-10-12 Thread GitBox
flinkbot commented on PR #21040: URL: https://github.com/apache/flink/pull/21040#issuecomment-1276929337 ## CI report: * 0216638dc7fe0d32ffef260bd43a8f1e9abc0ecc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993463151 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java: ## @@ -54,9 +53,15 @@ public

[GitHub] [flink] yuzelin opened a new pull request, #21040: [FLINK-29486][sql-client] Implement a new ClientResult for Sql

2022-10-12 Thread GitBox
yuzelin opened a new pull request, #21040: URL: https://github.com/apache/flink/pull/21040 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] lsyldliu commented on pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format

2022-10-12 Thread GitBox
lsyldliu commented on PR #20016: URL: https://github.com/apache/flink/pull/20016#issuecomment-1276917202 @luoyuxia Can you help rebase the latest master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] luoyuxia commented on pull request #21026: [FLINK-29590][hive] fix literal issue in Hive dialect

2022-10-12 Thread GitBox
luoyuxia commented on PR #21026: URL: https://github.com/apache/flink/pull/21026#issuecomment-1276917121 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] lsyldliu commented on pull request #16211: [FLINK-16952][Connectors/Parquet] Parquet file format support filter push down.

2022-10-12 Thread GitBox
lsyldliu commented on PR #16211: URL: https://github.com/apache/flink/pull/16211#issuecomment-1276916499 @luoyuxia Can you help rebase the latest branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-12 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993950327 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-12 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993941510 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.xml: ## @@ -76,12 +75,11 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-12 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993950327 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-12 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993941510 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.xml: ## @@ -76,12 +75,11 @@

[jira] [Commented] (FLINK-27344) FLIP-222: Support full job lifecycle statements in SQL client

2022-10-12 Thread Alexey Leonov-Vendrovskiy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616698#comment-17616698 ] Alexey Leonov-Vendrovskiy commented on FLINK-27344: --- Hi all, +*System*+ stored

[jira] [Commented] (FLINK-29608) 使用 pyflink1.17dev datastream 经过reduce 后 add_sink(FlinkKafkaProducer()) 有问题

2022-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616695#comment-17616695 ] Martijn Visser commented on FLINK-29608: [~zyfeiyu] If you can translate the ticket, I will

[jira] [Closed] (FLINK-29608) 使用 pyflink1.17dev datastream 经过reduce 后 add_sink(FlinkKafkaProducer()) 有问题

2022-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-29608. -- Resolution: Invalid > 使用 pyflink1.17dev datastream 经过reduce 后

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2022-10-12 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616627#comment-17616627 ] Ferenc Csaky commented on FLINK-25343: -- Was that validated before that when the test fails what the

[jira] [Updated] (FLINK-29401) Improve observer structure

2022-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29401: --- Labels: pull-request-available (was: ) > Improve observer structure >

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #400: [FLINK-29401] Refactor observer structure

2022-10-12 Thread GitBox
gyfora commented on PR #400: URL: https://github.com/apache/flink-kubernetes-operator/pull/400#issuecomment-1276529737 cc @morhidi @gaborgsomogyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #400: [FLINK-29401] Refactor observer structure

2022-10-12 Thread GitBox
gyfora opened a new pull request, #400: URL: https://github.com/apache/flink-kubernetes-operator/pull/400 ## What is the purpose of the change The goal is to create a shared observer hierarchy for all Flink resources and factor out the common bits to base classes in a similar way how

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-12 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r993738316 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointTriggerStatusHeaders.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot commented on pull request #21039: [DO_NOT_MERGE][FLINK-25343][hbase-tests] Fix flaky test in HBaseConnectorITCase

2022-10-12 Thread GitBox
flinkbot commented on PR #21039: URL: https://github.com/apache/flink/pull/21039#issuecomment-1276513698 ## CI report: * 3b7b65a0aec3eee7ddd96fa61fd8c06ee47b6ac6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2022-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25343: --- Labels: pull-request-available stale-assigned test-stability (was: stale-assigned

[GitHub] [flink] ferenc-csaky opened a new pull request, #21039: [DO_NOT_MERGE][FLINK-25343][hbase-tests] Fix flaky test in HBaseConnectorITCase

2022-10-12 Thread GitBox
ferenc-csaky opened a new pull request, #21039: URL: https://github.com/apache/flink/pull/21039 ## What is the purpose of the change TODO ## Brief change log TODO ## Verifying this change This change is a trivial rework / code cleanup without any test

[GitHub] [flink] kosigz closed pull request #21024: Unpin cloudpickle

2022-10-12 Thread GitBox
kosigz closed pull request #21024: Unpin cloudpickle URL: https://github.com/apache/flink/pull/21024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] kosigz commented on pull request #21024: Unpin cloudpickle

2022-10-12 Thread GitBox
kosigz commented on PR #21024: URL: https://github.com/apache/flink/pull/21024#issuecomment-1276471102 Wrong repo. This should be against the Lyft fork.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-12 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r993681403 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -298,6 +303,27 @@ private JobGraph createJobGraph() {

[GitHub] [flink] sap1ens commented on pull request #20475: [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink

2022-10-12 Thread GitBox
sap1ens commented on PR #20475: URL: https://github.com/apache/flink/pull/20475#issuecomment-1276450517 @PatrickRen thanks for reminding me about that, I kicked off the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-12 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r993681403 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -298,6 +303,27 @@ private JobGraph createJobGraph() {

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-12 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r993677013 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -298,6 +303,27 @@ private JobGraph createJobGraph() {

[jira] [Updated] (FLINK-29548) Remove deprecated MiniClusterResource

2022-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29548: - Summary: Remove deprecated MiniClusterResource (was: Remove deprecated class files of

[jira] [Updated] (FLINK-29548) Remove deprecated MiniClusterResource

2022-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29548: - Issue Type: Technical Debt (was: Improvement) > Remove deprecated MiniClusterResource

[jira] [Closed] (FLINK-29548) Remove deprecated class files of the 'flink-test-utils' module.

2022-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29548. Release Note: The deprecated MiniClusterResource in flink-test-utils has been removed.

[GitHub] [flink] zentol merged pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.

2022-10-12 Thread GitBox
zentol merged PR #20989: URL: https://github.com/apache/flink/pull/20989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #394: [FLINK-29394] Add observe Flink job health

2022-10-12 Thread GitBox
gaborgsomogyi commented on PR #394: URL: https://github.com/apache/flink-kubernetes-operator/pull/394#issuecomment-1276402549 Updated PR description to reflect latest code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #394: [FLINK-29394] Add observe Flink job health

2022-10-12 Thread GitBox
gaborgsomogyi commented on PR #394: URL: https://github.com/apache/flink-kubernetes-operator/pull/394#issuecomment-1276398075 I've retested it manually and works fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] kristoffSC commented on pull request #20979: [FLINK-29509] Set proper subtaskId and numberOfSubtasks on CheckpointCommittableManagerImpl during recovery/deserialization.

2022-10-12 Thread GitBox
kristoffSC commented on PR #20979: URL: https://github.com/apache/flink/pull/20979#issuecomment-1276386158 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] kristoffSC commented on pull request #21029: [FLINK-29509] Set proper subtaskId and numberOfSubtasks on CheckpointCommittableManagerImpl during recovery/deserialization.

2022-10-12 Thread GitBox
kristoffSC commented on PR #21029: URL: https://github.com/apache/flink/pull/21029#issuecomment-1276385366 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #394: [FLINK-29394] Add observe Flink job health

2022-10-12 Thread GitBox
gaborgsomogyi commented on code in PR #394: URL: https://github.com/apache/flink-kubernetes-operator/pull/394#discussion_r993617128 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -272,6

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #394: [FLINK-29394] Add observe Flink job health

2022-10-12 Thread GitBox
gaborgsomogyi commented on code in PR #394: URL: https://github.com/apache/flink-kubernetes-operator/pull/394#discussion_r993616745 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobHealthChecker.java: ## @@ -0,0 +1,130 @@

[GitHub] [flink] echauchot commented on pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on PR #21037: URL: https://github.com/apache/flink/pull/21037#issuecomment-1276320564 > What is the exception that you? Is it the assertion error about the final job state? Why not just allow both canceled & finished? While testing an incorrect bounded source that

[GitHub] [flink] echauchot commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21037: URL: https://github.com/apache/flink/pull/21037#discussion_r993500768 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -462,11 +477,18 @@

[GitHub] [flink] MartijnVisser commented on pull request #20170: [FLINK-28405][Connector/Kafka] Update Confluent Platform images used for testing to v7.2.2

2022-10-12 Thread GitBox
MartijnVisser commented on PR #20170: URL: https://github.com/apache/flink/pull/20170#issuecomment-1276309598 @zentol Can I get one more look at this one too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] MartijnVisser commented on a diff in pull request #20955: [FLINK-29502][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.4

2022-10-12 Thread GitBox
MartijnVisser commented on code in PR #20955: URL: https://github.com/apache/flink/pull/20955#discussion_r993568474 ## flink-filesystems/flink-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE: ## @@ -32,6 +32,8 @@ This project bundles the following dependencies under the

[GitHub] [flink-table-store] zjureel commented on pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-12 Thread GitBox
zjureel commented on PR #314: URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1276273061 @JingsongLi Thanks for your comments, and I have updated the codes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-29570) Bump org.jsoup:jsoup to v1.15.3

2022-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29570. Fix Version/s: 1.17.0 Resolution: Fixed master:

[GitHub] [flink] zentol merged pull request #20736: Bump jsoup from 1.14.2 to 1.15.3 in /flink-docs

2022-10-12 Thread GitBox
zentol merged PR #20736: URL: https://github.com/apache/flink/pull/20736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-12 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-29609: -- Summary: Clean up jobmanager deployment on suspend after recording savepoint info Key: FLINK-29609 URL: https://issues.apache.org/jira/browse/FLINK-29609 Project: Flink

[GitHub] [flink] echauchot commented on a diff in pull request #21035: [FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21035: URL: https://github.com/apache/flink/pull/21035#discussion_r993466238 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -448,7 +451,7 @@

[GitHub] [flink-web] XComp commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-12 Thread GitBox
XComp commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r993507797 ## _posts/2022-10-10-1.16-announcement.md: ## @@ -0,0 +1,401 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.16" +subtitle: "" +date:

[GitHub] [flink] echauchot commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21037: URL: https://github.com/apache/flink/pull/21037#discussion_r993503365 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -462,11 +477,18 @@

[jira] [Commented] (FLINK-25205) Optimize SinkUpsertMaterializer

2022-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616441#comment-17616441 ] lincoln lee commented on FLINK-25205: - [~lzljs3620320] can you assign it to me? I'd like to try to

[GitHub] [flink] echauchot commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21037: URL: https://github.com/apache/flink/pull/21037#discussion_r993503365 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -462,11 +477,18 @@

[GitHub] [flink] echauchot commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21037: URL: https://github.com/apache/flink/pull/21037#discussion_r993500768 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -462,11 +477,18 @@

[jira] [Commented] (FLINK-29607) Simplify controller flow by introducing FlinkControllerContext

2022-10-12 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616435#comment-17616435 ] Matyas Orhidi commented on FLINK-29607: --- +1 this is a great idea > Simplify controller flow by

[GitHub] [flink] kristoffSC commented on pull request #20979: [FLINK-29509] Set proper subtaskId and numberOfSubtasks on CheckpointCommittableManagerImpl during recovery/deserialization.

2022-10-12 Thread GitBox
kristoffSC commented on PR #20979: URL: https://github.com/apache/flink/pull/20979#issuecomment-1276202112 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] echauchot commented on a diff in pull request #21035: [FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot commented on code in PR #21035: URL: https://github.com/apache/flink/pull/21035#discussion_r993466238 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -448,7 +451,7 @@

[GitHub] [flink] flinkbot commented on pull request #21038: [FLINK-26726][bp-1.15][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers

2022-10-12 Thread GitBox
flinkbot commented on PR #21038: URL: https://github.com/apache/flink/pull/21038#issuecomment-1276177128 ## CI report: * 3d383e663e63ea2a70c5b64b5593a6191f2adce4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993463151 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java: ## @@ -54,9 +53,15 @@ public

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993462724 ## docs/layouts/shortcodes/generated/core_configuration.html: ## @@ -170,6 +170,12 @@ MemorySize Memory page size. +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r991985956 ## docs/layouts/shortcodes/generated/core_configuration.html: ## @@ -170,6 +170,12 @@ MemorySize Memory page size. +

[GitHub] [flink] zentol commented on a diff in pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-10-12 Thread GitBox
zentol commented on code in PR #21012: URL: https://github.com/apache/flink/pull/21012#discussion_r993456043 ## flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java: ## @@ -90,7 +90,6 @@ static void setup(@TempDir File

[GitHub] [flink] flinkbot commented on pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
flinkbot commented on PR #21037: URL: https://github.com/apache/flink/pull/21037#issuecomment-1276166901 ## CI report: * 4505e0c5d6384a7faadb84d98b7339bf9527 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol commented on a diff in pull request #21035: [FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
zentol commented on code in PR #21035: URL: https://github.com/apache/flink/pull/21035#discussion_r993453532 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -448,7 +451,7 @@

[GitHub] [flink] zoucao opened a new pull request, #21038: [FLINK-26726][bp-1.15][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers

2022-10-12 Thread GitBox
zoucao opened a new pull request, #21038: URL: https://github.com/apache/flink/pull/21038 ## What is the purpose of the change backport of https://github.com/apache/flink/pull/19250 ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob

[jira] [Commented] (FLINK-29608) 使用 pyflink1.17dev datastream 经过reduce 后 add_sink(FlinkKafkaProducer()) 有问题

2022-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616415#comment-17616415 ] Martijn Visser commented on FLINK-29608: [~zyfeiyu] Can you please translate your ticket to

[jira] [Updated] (FLINK-29608) 使用 pyflink1.17dev datastream 经过reduce 后 add_sink(FlinkKafkaProducer()) 有问题

2022-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29608: --- Affects Version/s: (was: shaded-16.0) > 使用 pyflink1.17dev datastream 经过reduce 后

[jira] [Updated] (FLINK-29605) Create a bounded version of SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29605: --- Labels: pull-request-available (was: ) > Create a bounded version of

[GitHub] [flink] zentol commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
zentol commented on code in PR #21037: URL: https://github.com/apache/flink/pull/21037#discussion_r993448262 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java: ## @@ -462,11 +477,18 @@

[jira] [Commented] (FLINK-21708) CloserCleaner warning

2022-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616412#comment-17616412 ] Chesnay Schepler commented on FLINK-21708: -- [~tapan_halani] It's not possible to hide this

[GitHub] [flink] fapaul commented on pull request #21029: [FLINK-29509] Set proper subtaskId and numberOfSubtasks on CheckpointCommittableManagerImpl during recovery/deserialization.

2022-10-12 Thread GitBox
fapaul commented on PR #21029: URL: https://github.com/apache/flink/pull/21029#issuecomment-1276155740 flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] echauchot opened a new pull request, #21037: [FLINK-29563] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
echauchot opened a new pull request, #21037: URL: https://github.com/apache/flink/pull/21037 ## What is the purpose of the change Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics Based on [timeout

[jira] [Commented] (FLINK-21708) CloserCleaner warning

2022-10-12 Thread Tapan Halani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616407#comment-17616407 ] Tapan Halani commented on FLINK-21708: -- [~rmetzger] I am a newbie to flink, and I am trying to

[jira] [Commented] (FLINK-29606) Dynamic Execution Environment

2022-10-12 Thread Hamid EL MAAZOUZ (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616405#comment-17616405 ] Hamid EL MAAZOUZ commented on FLINK-29606: -- [~martijnvisser] Thanks for the info, I will move

[GitHub] [flink] flinkbot commented on pull request #21036: [FLINK-26726][bp-1.16][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers

2022-10-12 Thread GitBox
flinkbot commented on PR #21036: URL: https://github.com/apache/flink/pull/21036#issuecomment-1276126918 ## CI report: * d691b5727738e5997c4c4c20f6127fd8986e69ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zoucao opened a new pull request, #21036: [FLINK-26726][bp-1.16][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers

2022-10-12 Thread GitBox
zoucao opened a new pull request, #21036: URL: https://github.com/apache/flink/pull/21036 ## What is the purpose of the change backport of https://github.com/apache/flink/pull/19250 ## Brief change log *(for example:)* - *The TaskInfo is stored in the

[GitHub] [flink] flinkbot commented on pull request #21035: [FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

2022-10-12 Thread GitBox
flinkbot commented on PR #21035: URL: https://github.com/apache/flink/pull/21035#issuecomment-1276101855 ## CI report: * 56c44bd4e3ef6ed5e3e65d12079f1fd257c3cc57 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21034: [FLINK-29337][hive] Fix fail to query non-hive table in Hive dialect

2022-10-12 Thread GitBox
flinkbot commented on PR #21034: URL: https://github.com/apache/flink/pull/21034#issuecomment-1276101525 ## CI report: * 114c25904da642623aaeb783403e59523056873e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29337) Fix fail to query non-hive table in Hive dialect

2022-10-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616391#comment-17616391 ] luoyuxia commented on FLINK-29337: -- [~jark] Yes. I have opened the pr

[jira] [Updated] (FLINK-29563) SourceTestSuiteBase#testSourceMetrics enters an infinite waiting loop in case the number of records counter is wrong

2022-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29563: --- Labels: pull-request-available (was: ) > SourceTestSuiteBase#testSourceMetrics enters an

  1   2   3   >