[jira] [Comment Edited] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-28 Thread Jiale Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625989#comment-17625989 ] Jiale Tan edited comment on FLINK-29610 at 10/29/22 3:56 AM: - [~gaoyunhaii]

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-28 Thread Jiale Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625989#comment-17625989 ] Jiale Tan commented on FLINK-29610: --- [~gaoyunhaii] I am curious what is the difference between

[GitHub] [flink] flinkbot commented on pull request #21191: [FLINK-29610] [flink-runtime]: Use rest time out instead of RpcUtils.INF_TIMEOUT Infinite timeout in SavepointHandlers and CheckpointHandler

2022-10-28 Thread GitBox
flinkbot commented on PR #21191: URL: https://github.com/apache/flink/pull/21191#issuecomment-1295714841 ## CI report: * 3ff4778e0690f75a96f05ec1e4b1d8f9c9489be1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29610: --- Labels: pull-request-available (was: ) > Infinite timeout is used in SavepointHandlers

[GitHub] [flink] leletan opened a new pull request, #21191: [FLINK-29610] [flink-runtime]: Use rest time out instead of RpcUtils.INF_TIMEOUT Infinite timeout in SavepointHandlers and CheckpointHandler

2022-10-28 Thread GitBox
leletan opened a new pull request, #21191: URL: https://github.com/apache/flink/pull/21191 ## What is the purpose of the change This pull request makes SavepointHandlers and CheckpointHandlers call to RestfulGateway using timeout from their ancestor `LeaderRetrievalHandler`,

[GitHub] [flink] 1996fanrui commented on pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-28 Thread GitBox
1996fanrui commented on PR #21131: URL: https://github.com/apache/flink/pull/21131#issuecomment-1295684218 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-29398) Utilize Rack Awareness in Flink Consumer

2022-10-28 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625972#comment-17625972 ] Mason Chen commented on FLINK-29398: Hi [~jeremy.degroot] I also implemented something similarly

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625971#comment-17625971 ] Mason Chen commented on FLINK-29480: I also think this is a good idea and can help take a look at

[GitHub] [flink] flinkbot commented on pull request #21190: [FLINK-24119] [Connectors/Kafka] set offsets.topic.replication.factor to 1

2022-10-28 Thread GitBox
flinkbot commented on PR #21190: URL: https://github.com/apache/flink/pull/21190#issuecomment-1295674484 ## CI report: * 0a865edab156b6a1fc10b4ff26d2056a3a81989d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625970#comment-17625970 ] Mason Chen commented on FLINK-24119: I took a look and it does seem to be Kafka container issue. I

[GitHub] [flink] mas-chen opened a new pull request, #21190: [FLINK-24119] [Connectors/Kafka] set offsets.topic.replication.factor to 1

2022-10-28 Thread GitBox
mas-chen opened a new pull request, #21190: URL: https://github.com/apache/flink/pull/21190 ## What is the purpose of the change Resolving test instability ## Brief change log * set offsets.topic.replication.factor to 1 in Kafka container ## Verifying this change

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-10-28 Thread Kevin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625932#comment-17625932 ] Kevin Li commented on FLINK-29572: -- Hi, Xintong, thanks for your help first. However, this is not some

[jira] [Commented] (FLINK-29794) Flink Operator Need to Include Cause for Exceptions If Possible

2022-10-28 Thread Zhou Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625922#comment-17625922 ] Zhou Jiang commented on FLINK-29794: (y) So we'll grep current Exceptions, and add cause if that's

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-28 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1295483454 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-28 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1295483171 > One small tip, do not rebase/force-pushing before the reviewer asks you because this will make the reviewer hard to do incremental review. Sorry, my bad, I was advised to

[GitHub] [flink] qingwei91 commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-28 Thread GitBox
qingwei91 commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1008502626 ## flink-connectors/flink-connector-jdbc/src/test/resources/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.xml: ## @@ -51,4 +51,22 @@

[jira] [Commented] (FLINK-29794) Flink Operator Need to Include Cause for Exceptions If Possible

2022-10-28 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625913#comment-17625913 ] Gyula Fora commented on FLINK-29794: I agree with the suggestion, but I think this is general good

[jira] [Created] (FLINK-29794) Flink Operator Need to Include Cause for Exceptions If Possible

2022-10-28 Thread Zhou Jiang (Jira)
Zhou Jiang created FLINK-29794: -- Summary: Flink Operator Need to Include Cause for Exceptions If Possible Key: FLINK-29794 URL: https://issues.apache.org/jira/browse/FLINK-29794 Project: Flink

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread GitBox
mbalassi commented on code in PR #417: URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008457144 ## flink-kubernetes-operator/pom.xml: ## @@ -195,32 +202,6 @@ under the License. - Review Comment: Done. --

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread GitBox
mbalassi commented on code in PR #417: URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008430526 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationMetadata.java: ## @@ -15,10 +15,9 @@ *

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2022-10-28 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625871#comment-17625871 ] Krzysztof Chmielewski commented on FLINK-27246: --- Hi, I would like to try fix this problem

[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295349886 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295321903 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] XComp commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-28 Thread GitBox
XComp commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1295315230 We might also want to check the other `LeaderContender` implementations (as you already mentioned, `ResourceManagerImpl` does not suffer from this bug but the others might because they

[GitHub] [flink] XComp commented on a diff in pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-28 Thread GitBox
XComp commented on code in PR #21137: URL: https://github.com/apache/flink/pull/21137#discussion_r1008330056 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -683,21 +665,66 @@ public void testJobAlreadyDone()

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet

2022-10-28 Thread GitBox
RyanSkraba commented on code in PR #20230: URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java: ## @@ -126,7 +126,7 @@ class

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet

2022-10-28 Thread GitBox
RyanSkraba commented on code in PR #20230: URL: https://github.com/apache/flink/pull/20230#discussion_r1008315366 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java: ## @@ -79,14 +92,14 @@ public static void setup()

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet

2022-10-28 Thread GitBox
RyanSkraba commented on code in PR #20230: URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java: ## @@ -126,7 +126,7 @@ class

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet

2022-10-28 Thread GitBox
RyanSkraba commented on code in PR #20230: URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java: ## @@ -126,7 +126,7 @@ class

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625817#comment-17625817 ] Salva commented on FLINK-29480: --- Can someone provide any guidance on how to fix those errors? > Skip

[GitHub] [flink] gaborgsomogyi commented on pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21160: URL: https://github.com/apache/flink/pull/21160#issuecomment-1295244072 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] 1996fanrui commented on pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-28 Thread GitBox
1996fanrui commented on PR #21131: URL: https://github.com/apache/flink/pull/21131#issuecomment-1295151769 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoi

2022-10-28 Thread GitBox
1996fanrui commented on code in PR #21131: URL: https://github.com/apache/flink/pull/21131#discussion_r1008188410 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java: ## @@ -98,18 +120,19 @@ private

[jira] [Commented] (FLINK-29711) Topic notification not present in metadata after 60000 ms.

2022-10-28 Thread Durgesh Mishra (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625746#comment-17625746 ] Durgesh Mishra commented on FLINK-29711: [~martijnvisser]  I checked with microsoft  Azure

[GitHub] [flink] pnowojski commented on pull request #21080: [FLINK-29545][runtime] add netty idle state handler

2022-10-28 Thread GitBox
pnowojski commented on PR #21080: URL: https://github.com/apache/flink/pull/21080#issuecomment-1295072883 Hi @zhougit86 , I'm still not sure what's the value of this proposed improvement/fix. It: 1. adds a bit of complexity to the already pretty complex system 2. adds a new publicly

[GitHub] [flink] ericxiao251 commented on pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-10-28 Thread GitBox
ericxiao251 commented on PR #21077: URL: https://github.com/apache/flink/pull/21077#issuecomment-1295069517 @gaoyunhaii although there is more boiler plate code, I have wrapped the java retry strategies and retry predicates in the Scala API :). Let me know what you think. -- This

[GitHub] [flink] flinkbot commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
flinkbot commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295067803 ## CI report: * f4fb9b7b74f920ea8f777550134f77cd83243e62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295065992 Just some further hints, I've put https://github.com/apache/flink/pull/21180 into a loop and the changed test was never failed on my machine. -- This is an automated message from

[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295062961 cc @PatrickRen @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] gaborgsomogyi commented on pull request #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21189: URL: https://github.com/apache/flink/pull/21189#issuecomment-1295062319 Let's see how it looks like at all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24119: --- Labels: auto-deprioritized-critical pull-request-available test-stability (was:

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21189: [FLINK-24119][tests] Add random to Kafka tests topic name

2022-10-28 Thread GitBox
gaborgsomogyi opened a new pull request, #21189: URL: https://github.com/apache/flink/pull/21189 ## What is the purpose of the change Kafka tests are having intermittent issues and because of that retry happens. The main issue is that when a test fails most of the time throws

[GitHub] [flink] gaborgsomogyi closed pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names

2022-10-28 Thread GitBox
gaborgsomogyi closed pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names URL: https://github.com/apache/flink/pull/21180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quantiles

2022-10-28 Thread GitBox
jiangxin369 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1008106690 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/util/QuantileSummary.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625734#comment-17625734 ] Gabor Somogyi commented on FLINK-24119: --- Re-executing failing test is good idea in general.

[GitHub] [flink] gaborgsomogyi commented on pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names

2022-10-28 Thread GitBox
gaborgsomogyi commented on PR #21180: URL: https://github.com/apache/flink/pull/21180#issuecomment-1294990234 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 opened a new pull request, #168: [hotfix] Remove redundant Internal annotations from BroadcastUtils

2022-10-28 Thread GitBox
lindong28 opened a new pull request, #168: URL: https://github.com/apache/flink-ml/pull/168 ## What is the purpose of the change Remove redundant @Internal annotations from BroadcastUtils. ## Brief change log Removed redundant @Internal annotations from BroadcastUtils.

[GitHub] [flink] pnowojski commented on a diff in pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoin

2022-10-28 Thread GitBox
pnowojski commented on code in PR #21131: URL: https://github.com/apache/flink/pull/21131#discussion_r1008052894 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java: ## @@ -98,18 +120,19 @@ private

[GitHub] [flink-ml] lindong28 commented on pull request #168: [hotfix] Remove redundant Internal annotations from BroadcastUtils

2022-10-28 Thread GitBox
lindong28 commented on PR #168: URL: https://github.com/apache/flink-ml/pull/168#issuecomment-1294987282 @zhipeng93 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread GitBox
gyfora commented on code in PR #417: URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008039551 ## flink-kubernetes-operator/pom.xml: ## @@ -195,32 +202,6 @@ under the License. - Review Comment: We should also

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread GitBox
gyfora commented on code in PR #417: URL: https://github.com/apache/flink-kubernetes-operator/pull/417#discussion_r1008028628 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationMetadata.java: ## @@ -15,10 +15,9 @@ *

[GitHub] [flink] flinkbot commented on pull request #21188: [hotfix][docs] Makes the japicmp script documentation more consistent after the change in cb442936.

2022-10-28 Thread GitBox
flinkbot commented on PR #21188: URL: https://github.com/apache/flink/pull/21188#issuecomment-1294931180 ## CI report: * 76b3d548dddace9ff7694d9559d0cad45fc90606 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21188: [hotfix][docs] Makes the japicmp script documentation more consistent after the change in cb442936.

2022-10-28 Thread GitBox
XComp opened a new pull request, #21188: URL: https://github.com/apache/flink/pull/21188 ## What is the purpose of the change PR #21184 updated the documentation a bit leaving it in a kind of inconsistent state. This hotfix PR fixes this issue. ## Brief change log *

[GitHub] [flink-ml] lindong28 closed pull request #167: [FLINK-29786] VarianceThresholdSelector should implement HasInputCol

2022-10-28 Thread GitBox
lindong28 closed pull request #167: [FLINK-29786] VarianceThresholdSelector should implement HasInputCol URL: https://github.com/apache/flink-ml/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-29786) VarianceThresholdSelector should implement HasInputCol

2022-10-28 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-29786: - Issue Type: Improvement (was: Bug) Summary: VarianceThresholdSelector should implement

[GitHub] [flink-ml] lindong28 commented on pull request #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly

2022-10-28 Thread GitBox
lindong28 commented on PR #167: URL: https://github.com/apache/flink-ml/pull/167#issuecomment-1294918502 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-29793) Scala Code 2 Java Code

2022-10-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-29793. -- Resolution: Information Provided No, there are no plans to replace Scala code with Java code.

[jira] [Commented] (FLINK-29733) Error Flink connector hive Test failing

2022-10-28 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625642#comment-17625642 ] Samrat Deb commented on FLINK-29733: Hi [~hxbks2ks] please review the changes in free time  >

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625640#comment-17625640 ] Salva commented on FLINK-29480: --- !Screenshot 2022-10-28 at 13.48.12.png! > Skip invalid messages when

[jira] [Updated] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Salva updated FLINK-29480: -- Attachment: Screenshot 2022-10-28 at 13.48.12.png > Skip invalid messages when writing >

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva edited comment on FLINK-29480 at 10/28/22 11:49 AM: -- [~martijnvisser]

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva edited comment on FLINK-29480 at 10/28/22 11:49 AM: -- [~martijnvisser]

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva edited comment on FLINK-29480 at 10/28/22 11:45 AM: -- [~martijnvisser]

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #417: [FLINK-29655] Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread GitBox
mbalassi opened a new pull request, #417: URL: https://github.com/apache/flink-kubernetes-operator/pull/417 This refactor introduces a new module called `flink-kubernetes-operator-api` and moves the CRD in said module with the aim of making the transitive dependencies of it as slim as

[jira] [Updated] (FLINK-29655) Split Flink CRD from flink-kubernates-operator module

2022-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29655: --- Labels: pull-request-available (was: ) > Split Flink CRD from flink-kubernates-operator

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva edited comment on FLINK-29480 at 10/28/22 11:18 AM: -- [~martijnvisser]

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva edited comment on FLINK-29480 at 10/28/22 11:18 AM: -- [~martijnvisser]

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625619#comment-17625619 ] Salva commented on FLINK-29480: --- [~martijnvisser] This is the error I'm getting: {code:java} [ERROR]

[GitHub] [flink] salvalcantara commented on a diff in pull request #21186: [FLINK-29480][Connectors / Kafka] Skip null records when writing

2022-10-28 Thread GitBox
salvalcantara commented on code in PR #21186: URL: https://github.com/apache/flink/pull/21186#discussion_r1007933805 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -148,6 +148,13 @@ public void

[GitHub] [flink] salvalcantara commented on a diff in pull request #21186: [FLINK-29480][Connectors / Kafka] Skip null records when writing

2022-10-28 Thread GitBox
salvalcantara commented on code in PR #21186: URL: https://github.com/apache/flink/pull/21186#discussion_r1007919969 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -491,6 +498,9 @@ private class

[GitHub] [flink] salvalcantara commented on a diff in pull request #21186: [FLINK-29480][Connectors / Kafka] Skip null records when writing

2022-10-28 Thread GitBox
salvalcantara commented on code in PR #21186: URL: https://github.com/apache/flink/pull/21186#discussion_r1007919969 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -491,6 +498,9 @@ private class

[GitHub] [flink] reswqa commented on a diff in pull request #21125: [FLINK-28102] Flink AkkaRpcSystemLoader fails when temporary directory is a symlink

2022-10-28 Thread GitBox
reswqa commented on code in PR #21125: URL: https://github.com/apache/flink/pull/21125#discussion_r1007918440 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -648,6 +648,29 @@ public static String stripFileExtension(String fileName) { return

[GitHub] [flink] reswqa commented on a diff in pull request #21125: [FLINK-28102] Flink AkkaRpcSystemLoader fails when temporary directory is a symlink

2022-10-28 Thread GitBox
reswqa commented on code in PR #21125: URL: https://github.com/apache/flink/pull/21125#discussion_r1007918440 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -648,6 +648,29 @@ public static String stripFileExtension(String fileName) { return

[jira] [Created] (FLINK-29793) Scala Code 2 Java Code

2022-10-28 Thread linweijiang (Jira)
linweijiang created FLINK-29793: --- Summary: Scala Code 2 Java Code Key: FLINK-29793 URL: https://issues.apache.org/jira/browse/FLINK-29793 Project: Flink Issue Type: Technical Debt

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625574#comment-17625574 ] Qingsheng Ren commented on FLINK-24119: --- Thanks for the input [~gaborgsomogyi] !

[jira] [Comment Edited] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625573#comment-17625573 ] Martijn Visser edited comment on FLINK-24119 at 10/28/22 10:17 AM: ---

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625573#comment-17625573 ] Martijn Visser commented on FLINK-24119: [~gaborgsomogyi] If you look at the history of this

[jira] [Assigned] (FLINK-25911) Add delegation token framework documentation

2022-10-28 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-25911: - Assignee: Gabor Somogyi > Add delegation token framework documentation >

[GitHub] [flink] MartijnVisser commented on pull request #21186: [FLINK-29480][Connectors / Kafka] Skip null records when writing

2022-10-28 Thread GitBox
MartijnVisser commented on PR #21186: URL: https://github.com/apache/flink/pull/21186#issuecomment-1294797758 Also keep in mind that this patch most likely also needs a test where this functionality is indeed tested -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] MartijnVisser commented on pull request #21186: [FLINK-29480][Connectors / Kafka] Skip null records when writing

2022-10-28 Thread GitBox
MartijnVisser commented on PR #21186: URL: https://github.com/apache/flink/pull/21186#issuecomment-1294796796 @salvalcantara There's an incompatibility in your patch that needs to be addressed. ``` [ERROR] Failed to execute goal

[jira] [Commented] (FLINK-29539) dnsPolicy in FlinkPod is not overridable

2022-10-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625565#comment-17625565 ] Yang Wang commented on FLINK-29539: --- Thanks [~carloscastro] for your contribution. > dnsPolicy in

[jira] [Closed] (FLINK-29539) dnsPolicy in FlinkPod is not overridable

2022-10-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-29539. - Resolution: Fixed Fixed via: master: bb9f2525e6e16d00ef2f0739d9cb96c2e47e35e7 release-1.16:

[jira] [Updated] (FLINK-29539) dnsPolicy in FlinkPod is not overridable

2022-10-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-29539: -- Fix Version/s: 1.17.0 1.15.3 1.16.1 > dnsPolicy in FlinkPod is

[GitHub] [flink] wangyang0918 merged pull request #21178: [BP-1.15][FLINK-29539][Deployment/Kubernetes] dnsPolicy in FlinkPod is not overridable

2022-10-28 Thread GitBox
wangyang0918 merged PR #21178: URL: https://github.com/apache/flink/pull/21178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21187: [FLINK-27837][sql-gateway] Support statement set in the SQL Gateway

2022-10-28 Thread GitBox
flinkbot commented on PR #21187: URL: https://github.com/apache/flink/pull/21187#issuecomment-1294782997 ## CI report: * 4d94f14b9d8227609838d9803cc7d5560a1ad582 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625557#comment-17625557 ] Salva edited comment on FLINK-29480 at 10/28/22 9:47 AM: - [~leonard] [~renqs]

[jira] [Commented] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-28 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625561#comment-17625561 ] Sriram Ganesh commented on FLINK-29609: --- I found this place where we are not removing the JM pod.

[jira] [Created] (FLINK-29792) FileStoreCommitTest is unstable and may stuck

2022-10-28 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29792: --- Summary: FileStoreCommitTest is unstable and may stuck Key: FLINK-29792 URL: https://issues.apache.org/jira/browse/FLINK-29792 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-27837) Support statement set in the SQL Gateway

2022-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27837: --- Labels: pull-request-available (was: ) > Support statement set in the SQL Gateway >

[GitHub] [flink] yuzelin opened a new pull request, #21187: [FLINK-27837][sql-gateway] Support statement set in the SQL Gateway

2022-10-28 Thread GitBox
yuzelin opened a new pull request, #21187: URL: https://github.com/apache/flink/pull/21187 ## What is the purpose of the change To support the 'BEGIN STATEMENT SET' syntax in the SQL Gateway. ## Brief change log - Implement `callBeginStatementSetOperation` and

[jira] [Updated] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29480: --- Labels: pull-request-available (was: ) > Skip invalid messages when writing >

[GitHub] [flink] flinkbot commented on pull request #21186: [FLINK-29480][Connectors / Kafka] Skip invalid messages when writing

2022-10-28 Thread GitBox
flinkbot commented on PR #21186: URL: https://github.com/apache/flink/pull/21186#issuecomment-1294767239 ## CI report: * 471433c7ff907deacd82971d5b310e96a4b7c99d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29480) Skip invalid messages when writing

2022-10-28 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625557#comment-17625557 ] Salva commented on FLINK-29480: --- [~leonard] [~renqs] [~martijnvisser] I've submitted the patch here:

[GitHub] [flink] salvalcantara opened a new pull request, #21186: FLINK-24660][Connectors / Kafka] Skip null producer records in KafkaWriter

2022-10-28 Thread GitBox
salvalcantara opened a new pull request, #21186: URL: https://github.com/apache/flink/pull/21186 ## What is the purpose of the change Skip null producer records in `KafkaWriter` since sending them is meaningless. ## Brief change log Add simple if statement in

[GitHub] [flink] xintongsong commented on a diff in pull request #21125: [FLINK-28102] Flink AkkaRpcSystemLoader fails when temporary directory is a symlink

2022-10-28 Thread GitBox
xintongsong commented on code in PR #21125: URL: https://github.com/apache/flink/pull/21125#discussion_r1007846839 ## flink-core/src/main/java/org/apache/flink/util/FileUtils.java: ## @@ -648,6 +648,29 @@ public static String stripFileExtension(String fileName) {

[jira] [Resolved] (FLINK-29787) fix ci METHOD_NEW_DEFAULT issue

2022-10-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-29787. --- Fix Version/s: 1.17.0 Resolution: Fixed master:

[jira] [Updated] (FLINK-29787) fix ci METHOD_NEW_DEFAULT issue

2022-10-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29787: -- Affects Version/s: 1.17.0 > fix ci METHOD_NEW_DEFAULT issue > ---

[jira] [Assigned] (FLINK-29787) fix ci METHOD_NEW_DEFAULT issue

2022-10-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-29787: - Assignee: Yubin Li > fix ci METHOD_NEW_DEFAULT issue > ---

[GitHub] [flink] XComp commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

2022-10-28 Thread GitBox
XComp commented on PR #21184: URL: https://github.com/apache/flink/pull/21184#issuecomment-1294747100 The commits got a bit mixed up. I decided to squash everything into one because the documentation change should be reverted as well if the change itself was wrong. I merged the PR without

[GitHub] [flink] XComp merged pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

2022-10-28 Thread GitBox
XComp merged PR #21184: URL: https://github.com/apache/flink/pull/21184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >