[GitHub] [flink-table-store] zjureel commented on pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
zjureel commented on PR #376: URL: https://github.com/apache/flink-table-store/pull/376#issuecomment-1318222016 Thanks @JingsongLi I have updated the codes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-16 Thread GitBox
JerryYue-M commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318220393 @zhuzhurk your comments had resolved and no checkstyle and compile problems, can you take a look at those new changes -- This is an automated message from the Apache Git

[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-16 Thread GitBox
JerryYue-M commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318219982 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 merged pull request #172: [FLINK-29592] Add Estimator and Transformer for RobustScaler

2022-11-16 Thread GitBox
lindong28 merged PR #172: URL: https://github.com/apache/flink-ml/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #172: [FLINK-29592] Add Estimator and Transformer for RobustScaler

2022-11-16 Thread GitBox
lindong28 commented on PR #172: URL: https://github.com/apache/flink-ml/pull/172#issuecomment-1318216209 Thanks @jiangxin369 for the PR! Thanks @yunfengzhou-hub for the review. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-16 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635183#comment-17635183 ] Weihua Hu commented on FLINK-29572: --- [~AlexXXX] IMO, it's a bug to use loopback. we will remove it in

[jira] [Commented] (FLINK-8712) Cannot execute job with multiple slot sharing groups on LocalExecutor

2022-11-16 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635180#comment-17635180 ] Weihua Hu commented on FLINK-8712: -- [~xtsong] Agree with you, maybe we can close this issue since it is

[GitHub] [flink] gaborgsomogyi commented on pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-16 Thread GitBox
gaborgsomogyi commented on PR #21339: URL: https://github.com/apache/flink/pull/21339#issuecomment-1318206668 @MartijnVisser Yeah, this PR is intended to add more stability to the test (though I'm not saying it will solve the version bump issues). Additionally one needs to change the

[jira] [Closed] (FLINK-30047) getLastSavepointStatus should return null when there is never savepoint completed or pending

2022-11-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30047. -- Fix Version/s: kubernetes-operator-1.3.0 Resolution: Fixed merged to main

[jira] [Assigned] (FLINK-30047) getLastSavepointStatus should return null when there is never savepoint completed or pending

2022-11-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30047: -- Assignee: Clara Xiong > getLastSavepointStatus should return null when there is never

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #443: [FLINK-30047] getLastSavepointStatus should return null when there is…

2022-11-16 Thread GitBox
gyfora merged PR #443: URL: https://github.com/apache/flink-kubernetes-operator/pull/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-16 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635164#comment-17635164 ] AlexHu edited comment on FLINK-29572 at 11/17/22 6:38 AM: -- We faced the same

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-16 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635164#comment-17635164 ] AlexHu commented on FLINK-29572: We faced the same problem at k8s. To be honest, we are confused that

[GitHub] [flink] xintongsong commented on a diff in pull request #21331: [FLINK-29639] Print resourceId of remote taskmanager when encounter transport exception.

2022-11-16 Thread GitBox
xintongsong commented on code in PR #21331: URL: https://github.com/apache/flink/pull/21331#discussion_r1024797669 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ConnectionID.java: ## @@ -75,15 +84,18 @@ public boolean equals(Object other) { }

[GitHub] [flink] AlanConfluent commented on a diff in pull request #21264: [WIP][FLINK-29928][runtime, state] Share RocksDB memory across TM slots

2022-11-16 Thread GitBox
AlanConfluent commented on code in PR #21264: URL: https://github.com/apache/flink/pull/21264#discussion_r1024790314 ## flink-tests/src/test/java/org/apache/flink/test/state/TaskManagerWideRocksDbMemorySharingITCase.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635154#comment-17635154 ] Xintong Song commented on FLINK-28558: -- This feature helps integrate the log browsing service into

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
zjureel commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024778136 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024745027 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-29969) Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635118#comment-17635118 ] Rui Fan commented on FLINK-29969: - Thanks [~yunta] 's good suggestion and review. > Show the root cause

[GitHub] [flink-table-store] zjureel commented on pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
zjureel commented on PR #383: URL: https://github.com/apache/flink-table-store/pull/383#issuecomment-1318036364 CI fails due to HiveE2E, which is a known issue and has created in https://issues.apache.org/jira/browse/FLINK-30038 -- This is an automated message from the Apache Git

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
zjureel commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024730773 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -157,6 +159,33 @@ public TableSchema

[jira] [Updated] (FLINK-29988) Improve upper case fields for hive metastore

2022-11-16 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shammon updated FLINK-29988: Component/s: Table Store > Improve upper case fields for hive metastore >

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
zjureel commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024726786 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-30043) Some example sqls in flink table store rescale-bucket doucument are incorrect.

2022-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-30043: Assignee: Hang HOU > Some example sqls in flink table store rescale-bucket doucument are

[jira] [Closed] (FLINK-30043) Some example sqls in flink table store rescale-bucket doucument are incorrect.

2022-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30043. Fix Version/s: table-store-0.3.0 Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #385: [FLINK-30043] Some example sqls in flink table store rescale-bucket doucument are incorrect.

2022-11-16 Thread GitBox
JingsongLi merged PR #385: URL: https://github.com/apache/flink-table-store/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on pull request #344: [FLINK-29823] Support to get schema of table snapshot

2022-11-16 Thread GitBox
JingsongLi commented on PR #344: URL: https://github.com/apache/flink-table-store/pull/344#issuecomment-1318013199 Thanks @zjureel for the contribution. I want to support this requirement through another solution: - At present, we have supported Snapshots Table:

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024717157 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -157,6 +159,33 @@ public TableSchema

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635101#comment-17635101 ] leo.zhi commented on FLINK-28558: - Yes, so close, we use kafka log appender, and also can write log file

[jira] [Commented] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-16 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635100#comment-17635100 ] Shengkai Fang commented on FLINK-30035: --- Hi. Could you share more exception stack and the steps to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024714412 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024713874 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024712989 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/KeyValueFileStoreScan.java: ## @@ -83,6 +96,26 @@ protected boolean

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024712686 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AppendOnlyFileStoreScan.java: ## @@ -84,6 +93,23 @@ protected boolean

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024712478 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreScan.java: ## @@ -244,6 +257,14 @@ public List files()

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635098#comment-17635098 ] Xintong Song commented on FLINK-28558: -- I'm not familiar whether there's any existing tools that

[jira] [Resolved] (FLINK-29969) Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-29969. -- Fix Version/s: 1.17.0 Assignee: Rui Fan Resolution: Fixed merged in master:

[GitHub] [flink] Myasuka merged pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-16 Thread GitBox
Myasuka merged PR #21281: URL: https://github.com/apache/flink/pull/21281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635094#comment-17635094 ] leo.zhi edited comment on FLINK-28558 at 11/17/22 3:06 AM: --- Hi [~xtsong] ,

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1024709249 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaEvolutionUtil.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635094#comment-17635094 ] leo.zhi commented on FLINK-28558: - Hi [~xtsong] , Thanks for the quick reply. We use Flink on K8s, is

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
zjureel commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024702921 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -157,6 +159,33 @@ public TableSchema

[jira] [Updated] (FLINK-30049) CsvBulkWriter is unsupported for S3 FileSystem in streaming sink

2022-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-30049: - Description: {code:java} Caused by: org.apache.flink.util.SerializedThrowable: Cannot sync

[jira] [Created] (FLINK-30049) CsvBulkWriter is unsupported for S3 FileSystem

2022-11-16 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30049: Summary: CsvBulkWriter is unsupported for S3 FileSystem Key: FLINK-30049 URL: https://issues.apache.org/jira/browse/FLINK-30049 Project: Flink Issue Type:

[jira] [Updated] (FLINK-30049) CsvBulkWriter is unsupported for S3 FileSystem in streaming sink

2022-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-30049: - Summary: CsvBulkWriter is unsupported for S3 FileSystem in streaming sink (was: CsvBulkWriter

[jira] [Commented] (FLINK-30036) Force delete pod when k8s node is not ready

2022-11-16 Thread Peng Yuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635088#comment-17635088 ] Peng Yuan commented on FLINK-30036: --- Just as [~wangyang0918] said, there are a number of conditions

[jira] [Created] (FLINK-30048) MapState.remove(UK key) is better to return the old value.

2022-11-16 Thread xljtswf (Jira)
xljtswf created FLINK-30048: --- Summary: MapState.remove(UK key) is better to return the old value. Key: FLINK-30048 URL: https://issues.apache.org/jira/browse/FLINK-30048 Project: Flink Issue Type:

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635085#comment-17635085 ] Xintong Song commented on FLINK-28558: -- [~leo.zhi] Here's the documentation for this feature.

[jira] [Updated] (FLINK-30047) getLastSavepointStatus should return null when there is never savepoint completed or pending

2022-11-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30047: --- Labels: pull-request-available (was: ) > getLastSavepointStatus should return null when

[GitHub] [flink-kubernetes-operator] clarax opened a new pull request, #443: [FLINK-30047] getLastSavepointStatus should return null when there is…

2022-11-16 Thread GitBox
clarax opened a new pull request, #443: URL: https://github.com/apache/flink-kubernetes-operator/pull/443 … never savepoint completed or pending ## What is the purpose of the change This is for FLINK-30047 getLastSavepointStatus should return null when there is never savepoint

[jira] [Updated] (FLINK-30036) Force delete pod when k8s node is not ready

2022-11-16 Thread Peng Yuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Yuan updated FLINK-30036: -- Attachment: image-2022-11-17-10-25-59-945.png > Force delete pod when k8s node is not ready >

[jira] [Commented] (FLINK-30032) IOException during MAX_WATERMARK emission causes message missing

2022-11-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635081#comment-17635081 ] luoyuxia commented on FLINK-30032: -- Just curious about why this fix can solve this problem. Could you

[jira] [Closed] (FLINK-30027) Fields min and max in BinaryTableStats support lazy deserialization

2022-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30027. Fix Version/s: table-store-0.3.0 Assignee: Shammon Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #382: [FLINK-30027] Fields min and max in BinaryTableStats support lazy deserialization

2022-11-16 Thread GitBox
JingsongLi merged PR #382: URL: https://github.com/apache/flink-table-store/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
JingsongLi commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024684798 ## docs/content/docs/development/create-table.md: ## @@ -296,6 +296,24 @@ Use approach one if you have a large number of filtered queries with only

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #174: [FLINK-29604] Add Estimator and Transformer for CountVectorizer

2022-11-16 Thread GitBox
yunfengzhou-hub commented on code in PR #174: URL: https://github.com/apache/flink-ml/pull/174#discussion_r1024683357 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/countvectorizer/CountVectorizer.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #174: [FLINK-29604] Add Estimator and Transformer for CountVectorizer

2022-11-16 Thread GitBox
yunfengzhou-hub commented on code in PR #174: URL: https://github.com/apache/flink-ml/pull/174#discussion_r1024683072 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/countvectorizer/CountVectorizerParams.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #442: [hotfix][doc][test] correct the incorrect flink release version

2022-11-16 Thread GitBox
yangjf2019 commented on PR #442: URL: https://github.com/apache/flink-kubernetes-operator/pull/442#issuecomment-1317952567 Thanks for your review, and i resolved the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #172: [FLINK-29592] Add Estimator and Transformer for RobustScaler

2022-11-16 Thread GitBox
yunfengzhou-hub commented on code in PR #172: URL: https://github.com/apache/flink-ml/pull/172#discussion_r1024682602 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/robustscaler/RobustScalerModel.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-28558) HistoryServer log retrieval configuration improvement

2022-11-16 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635067#comment-17635067 ] leo.zhi commented on FLINK-28558: - Hi [~xtsong] , May I know how to use below two configuations? Is

[jira] [Commented] (FLINK-30036) Force delete pod when k8s node is not ready

2022-11-16 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635064#comment-17635064 ] Yang Wang commented on FLINK-30036: --- After more investigation, it seems that the terminating pods are

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

2022-11-16 Thread GitBox
1996fanrui commented on code in PR #21281: URL: https://github.com/apache/flink/pull/21281#discussion_r1024664659 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java: ## @@ -204,7 +204,8 @@ private void checkFailureAgainstCounter(

[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #15: [FLINK-29900][Connectors/DynamoDB] Implement Table API for DynamoDB sink

2022-11-16 Thread GitBox
hlteoh37 commented on code in PR #15: URL: https://github.com/apache/flink-connector-aws/pull/15#discussion_r1024629827 ## flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/RowDataElementConverter.java: ## @@ -0,0 +1,50 @@ +package

[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #15: [FLINK-29900][Connectors/DynamoDB] Implement Table API for DynamoDB sink

2022-11-16 Thread GitBox
hlteoh37 commented on code in PR #15: URL: https://github.com/apache/flink-connector-aws/pull/15#discussion_r1024609732 ## flink-connector-dynamodb/pom.xml: ## @@ -77,6 +77,22 @@ under the License. dynamodb-enhanced + +

[GitHub] [flink] mattfysh commented on pull request #21254: Update docker.md

2022-11-16 Thread GitBox
mattfysh commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1317802478 > Flink also works without add, so why is it needed? Did you test on v1.16? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] mattfysh commented on pull request #21254: Update docker.md

2022-11-16 Thread GitBox
mattfysh commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1317799085 Hi @MartijnVisser - my apologies, I am short on time and hoped someone with PyFlink familiarity would pick this up and immediately identify why this change is required. The

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
jbusche commented on PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#issuecomment-1317728635 I just tried an install in all namespaces - that looked good too: ```oc logs -f flink-kubernetes-operator-5b457fb9b7-znhfw |grep watch 2022-11-16 21:53:07,843

[GitHub] [flink] MartijnVisser commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-16 Thread GitBox
MartijnVisser commented on PR #21223: URL: https://github.com/apache/flink/pull/21223#issuecomment-1317675420 @wanglijie95 Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] MartijnVisser commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-16 Thread GitBox
MartijnVisser commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1317674873 @wanglijie95 Do you have any idea when you can look into this ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md

2022-11-16 Thread GitBox
MartijnVisser commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1317672870 @mattfysh Thanks for the PR but please take the code contribution guide into account https://flink.apache.org/contributing/contribute-code.html I can't see why it's important

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
jbusche commented on PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#issuecomment-1317671023 I built a new flink-operator image based on your changes - Twistlock scan shows no known fixable vulnerabilities - helm install looks as before, able to deploy the

[GitHub] [flink] MartijnVisser commented on pull request #21272: [Flink]update some comments

2022-11-16 Thread GitBox
MartijnVisser commented on PR #21272: URL: https://github.com/apache/flink/pull/21272#issuecomment-1317670920 @DarkAssassinator Thanks for the PR, but the benefit of a PR like this vs the cost for running CI for it is that it has none/very little value. -- This is an automated message

[GitHub] [flink] MartijnVisser commented on pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-16 Thread GitBox
MartijnVisser commented on PR #21339: URL: https://github.com/apache/flink/pull/21339#issuecomment-1317657486 @gaborgsomogyi Looking interesting, especially since I've been working on the upgrade to a later Hadoop version with https://github.com/apache/flink/pull/21128 which runs into

[jira] [Created] (FLINK-30047) getLastSavepointStatus should return null when there is never savepoint completed or pending

2022-11-16 Thread Clara Xiong (Jira)
Clara Xiong created FLINK-30047: --- Summary: getLastSavepointStatus should return null when there is never savepoint completed or pending Key: FLINK-30047 URL: https://issues.apache.org/jira/browse/FLINK-30047

[GitHub] [flink] jnh5y commented on a diff in pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-11-16 Thread GitBox
jnh5y commented on code in PR #21133: URL: https://github.com/apache/flink/pull/21133#discussion_r1024424268 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -311,8 +340,29 @@ public GatewayInfo

[GitHub] [flink] yuzelin commented on a diff in pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-11-16 Thread GitBox
yuzelin commented on code in PR #21133: URL: https://github.com/apache/flink/pull/21133#discussion_r1024355066 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -311,8 +340,29 @@ public GatewayInfo

[GitHub] [flink] yuzelin commented on a diff in pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-11-16 Thread GitBox
yuzelin commented on code in PR #21133: URL: https://github.com/apache/flink/pull/21133#discussion_r1024355066 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -311,8 +340,29 @@ public GatewayInfo

[GitHub] [flink] yuzelin commented on a diff in pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-11-16 Thread GitBox
yuzelin commented on code in PR #21133: URL: https://github.com/apache/flink/pull/21133#discussion_r1024355066 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -311,8 +340,29 @@ public GatewayInfo

[GitHub] [flink] zentol commented on pull request #21335: [FLINK-30045][flink-clients] fix too eager check for main class existence

2022-11-16 Thread GitBox
zentol commented on PR #21335: URL: https://github.com/apache/flink/pull/21335#issuecomment-1317332532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-29959) Use optimistic locking when patching resource status

2022-11-16 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29959. -- Fix Version/s: kubernetes-operator-1.3.0 Resolution: Fixed merged to main

[GitHub] [flink] mxm commented on pull request #21023: [FLINK-29501] Add option to override job vertex parallelisms during job submission

2022-11-16 Thread GitBox
mxm commented on PR #21023: URL: https://github.com/apache/flink/pull/21023#issuecomment-1317226026 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state.

2022-11-16 Thread GitBox
gyfora commented on code in PR #438: URL: https://github.com/apache/flink-kubernetes-operator/pull/438#discussion_r1024176617 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -362,11 +362,21 @@ public void

[jira] [Created] (FLINK-30046) Cannot use digest in Helm chart to reference image

2022-11-16 Thread Tobias Hofer (Jira)
Tobias Hofer created FLINK-30046: Summary: Cannot use digest in Helm chart to reference image Key: FLINK-30046 URL: https://issues.apache.org/jira/browse/FLINK-30046 Project: Flink Issue

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
morhidi commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024160767 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -79,7 +79,13 @@ spec: {{- end }} env: -

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #439: [FLINK-29959] Use optimistic locking when updating the status

2022-11-16 Thread GitBox
gyfora commented on code in PR #439: URL: https://github.com/apache/flink-kubernetes-operator/pull/439#discussion_r1024159160 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/SavepointInfo.java: ## @@ -63,7 +63,7 @@ public void

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
morhidi commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024158133 ## flink-kubernetes-webhook/pom.xml: ## @@ -96,6 +96,12 @@ under the License. ${okhttp.version} test + +

[GitHub] [flink] flinkbot commented on pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-16 Thread GitBox
flinkbot commented on PR #21339: URL: https://github.com/apache/flink/pull/21339#issuecomment-1317201283 ## CI report: * 66489dd3b2a70839e469c94725a4409579581b1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #439: [FLINK-29959] Use optimistic locking when updating the status

2022-11-16 Thread GitBox
morhidi commented on code in PR #439: URL: https://github.com/apache/flink-kubernetes-operator/pull/439#discussion_r1024152777 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/SavepointInfo.java: ## @@ -63,7 +63,7 @@ public void

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-16 Thread GitBox
gaborgsomogyi opened a new pull request, #21339: URL: https://github.com/apache/flink/pull/21339 ## What is the purpose of the change YARN e2e tests are using a roughly 7 years old KDC docker image which is hard to maintain. In this PR I've created a `Dockerfile` to build KDC

[GitHub] [flink-kubernetes-operator] tagarr commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
tagarr commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024148468 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -79,7 +79,13 @@ spec: {{- end }} env: - name:

[jira] [Updated] (FLINK-30024) Secure e2e tests are using a super old kerberos docker image

2022-11-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30024: --- Labels: pull-request-available (was: ) > Secure e2e tests are using a super old kerberos

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
morhidi commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024142900 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -79,7 +79,13 @@ spec: {{- end }} env: -

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
morhidi commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024138321 ## flink-kubernetes-webhook/pom.xml: ## @@ -96,6 +96,12 @@ under the License. ${okhttp.version} test + +

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #442: [hotfix][doc][test] correct the incorrect flink release version

2022-11-16 Thread GitBox
gyfora commented on PR #442: URL: https://github.com/apache/flink-kubernetes-operator/pull/442#issuecomment-1317169651 The changes look, good, there is a small merge conflict now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-kubernetes-operator] tagarr commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
tagarr commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024130690 ## flink-kubernetes-webhook/pom.xml: ## @@ -96,6 +96,12 @@ under the License. ${okhttp.version} test + +

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #439: [FLINK-29959] Use optimistic locking when updating the status

2022-11-16 Thread GitBox
gyfora merged PR #439: URL: https://github.com/apache/flink-kubernetes-operator/pull/439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] tagarr commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-11-16 Thread GitBox
tagarr commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024106606 ## flink-kubernetes-webhook/pom.xml: ## @@ -96,6 +96,12 @@ under the License. ${okhttp.version} test + +

[GitHub] [flink] flinkbot commented on pull request #21338: [FLINK-30044][ci] Deduplicate plugin parser loops

2022-11-16 Thread GitBox
flinkbot commented on PR #21338: URL: https://github.com/apache/flink/pull/21338#issuecomment-1317102836 ## CI report: * 17f1ff2881b8650672c5c97e92379ed9278114fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21337: [FLINK-29993][conf] Add MetricOptions#forReporter

2022-11-16 Thread GitBox
flinkbot commented on PR #21337: URL: https://github.com/apache/flink/pull/21337#issuecomment-1317102658 ## CI report: * 35ff4ff233e9aa14128ec016c720b1a53236901b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21336: [FLINK-30029][ci] Parse version/classifier separately

2022-11-16 Thread GitBox
flinkbot commented on PR #21336: URL: https://github.com/apache/flink/pull/21336#issuecomment-1317102461 ## CI report: * 7d3dbcffcdcb79e55f6ec3b3bb80a49d0df2d6cb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >