[GitHub] [flink] flinkbot commented on pull request #21596: [FLINK-29719][hive] Supports native count function for hive dialect

2023-01-03 Thread GitBox
flinkbot commented on PR #21596: URL: https://github.com/apache/flink/pull/21596#issuecomment-1370577686 ## CI report: * ae33e5d7d7916ef45ba2189ae5a2e16a911425f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-03 Thread GitBox
XComp commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1060509031 ## flink-core/src/main/java/org/apache/flink/configuration/HeartbeatManagerOptions.java: ## @@ -50,6 +50,8 @@ public class HeartbeatManagerOptions { private static

[jira] [Updated] (FLINK-30555) Hive cluster can not read oss/s3 tables

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30555: --- Labels: pull-request-available (was: ) > Hive cluster can not read oss/s3 tables >

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #456: [FLINK-30555] Hive cluster can not read oss/s3 tables

2023-01-03 Thread GitBox
JingsongLi opened a new pull request, #456: URL: https://github.com/apache/flink-table-store/pull/456 [FLINK-29964](https://issues.apache.org/jira/browse/FLINK-29964) add oss support for Hive, but only valid in the case of standalone Hive, the distributed Hive compute engine cannot access.

[jira] [Created] (FLINK-30555) Hive cluster can not read oss/s3 tables

2023-01-03 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30555: Summary: Hive cluster can not read oss/s3 tables Key: FLINK-30555 URL: https://issues.apache.org/jira/browse/FLINK-30555 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-29719) Supports hive count function by native implementation

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29719: --- Labels: pull-request-available (was: ) > Supports hive count function by native

[GitHub] [flink] lsyldliu opened a new pull request, #21596: [FLINK-29719][hive] Supports native count function for hive dialect

2023-01-03 Thread GitBox
lsyldliu opened a new pull request, #21596: URL: https://github.com/apache/flink/pull/21596 ## What is the purpose of the change *Implementing a native hive count function based on the expression aggregate function, can improve the agg performance by using hash-agg strategy.*

[jira] [Commented] (FLINK-29705) Document the least access with RBAC setting for native K8s integration

2023-01-03 Thread ouyangwulin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654320#comment-17654320 ] ouyangwulin commented on FLINK-29705: - [~wangyang0918]  Can assign this ticket for me ? > Document

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #423: [FLINK-27844] Support column type evolution in file meta

2023-01-03 Thread GitBox
zjureel commented on code in PR #423: URL: https://github.com/apache/flink-table-store/pull/423#discussion_r1061186583 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/casting/CastExecutors.java: ## @@ -176,7 +176,7 @@ public class CastExecutors {

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #423: [FLINK-27844] Support column type evolution in file meta

2023-01-03 Thread GitBox
zjureel commented on code in PR #423: URL: https://github.com/apache/flink-table-store/pull/423#discussion_r1061186421 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaEvolutionUtil.java: ## @@ -304,4 +307,56 @@ private static int

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #193: [FLINK-30515] Add benchmark for CountVectorizer, Imputer, RobustScale…

2023-01-03 Thread GitBox
jiangxin369 commented on code in PR #193: URL: https://github.com/apache/flink-ml/pull/193#discussion_r1061186218 ## flink-ml-benchmark/src/test/java/org/apache/flink/ml/benchmark/BenchmarkTest.java: ## @@ -54,6 +56,33 @@ public void testParseJsonFile() throws Exception {

[GitHub] [flink] flinkbot commented on pull request #21595: 30321(something wrong, please help close.)

2023-01-03 Thread GitBox
flinkbot commented on PR #21595: URL: https://github.com/apache/flink/pull/21595#issuecomment-1370549985 ## CI report: * 286a7098d1ad6168aef41dd89895cff5f7ee2ea4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Mrart opened a new pull request, #21595: 30321

2023-01-03 Thread GitBox
Mrart opened a new pull request, #21595: URL: https://github.com/apache/flink/pull/21595 ## Contribution Checklist ## What is the purpose of the change Update to Fabric8 Kubernetes Client to a version that has automatic renewal of service account tokens ## Brief change

[jira] [Updated] (FLINK-30543) Adding more examples for setting up jobs via operator.

2023-01-03 Thread Peter Vary (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vary updated FLINK-30543: --- Component/s: Kubernetes Operator > Adding more examples for setting up jobs via operator. >

[GitHub] [flink] LadyForest commented on a diff in pull request #21592: [FLINK-30497][table-api] Introduce TableChange to represent DROP change

2023-01-03 Thread GitBox
LadyForest commented on code in PR #21592: URL: https://github.com/apache/flink/pull/21592#discussion_r1061167593 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -237,7 +236,7 @@ public class

[jira] [Assigned] (FLINK-30554) Remove useless session id in the Sql Client Executor

2023-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30554: - Assignee: Shengkai Fang > Remove useless session id in the Sql Client Executor >

[jira] [Created] (FLINK-30554) Remove useless session id in the Sql Client Executor

2023-01-03 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-30554: - Summary: Remove useless session id in the Sql Client Executor Key: FLINK-30554 URL: https://issues.apache.org/jira/browse/FLINK-30554 Project: Flink Issue

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-01-03 Thread Suhan Mao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654308#comment-17654308 ] Suhan Mao commented on FLINK-30093: --- [~jamesmcguirepro] Thanks for your feedback, I'll update the

[jira] [Created] (FLINK-30553) checkpoint always IN-PROGRESS because of hdfs

2023-01-03 Thread linqichen (Jira)
linqichen created FLINK-30553: - Summary: checkpoint always IN-PROGRESS because of hdfs Key: FLINK-30553 URL: https://issues.apache.org/jira/browse/FLINK-30553 Project: Flink Issue Type: Bug

[GitHub] [flink-table-store] WencongLiu commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
WencongLiu commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061165341 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,16 @@ public Optional

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061163957 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,16 @@ public Optional

[jira] [Commented] (FLINK-28352) [Umbrella] Make Pulsar connector stable

2023-01-03 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654302#comment-17654302 ] Yufan Sheng commented on FLINK-28352: - The only issue we have now is the Direct buffer memory leak

[jira] [Commented] (FLINK-30351) Enable test cases again

2023-01-03 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654301#comment-17654301 ] Yufan Sheng commented on FLINK-30351: - All these tests have been removed in latest Pulsar connector.

[GitHub] [flink-table-store] WencongLiu commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
WencongLiu commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061142837 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-table-store] JingsongLi merged pull request #455: [hotfix] fix typo

2023-01-03 Thread GitBox
JingsongLi merged PR #455: URL: https://github.com/apache/flink-table-store/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30546) WindowDeduplicate didn't write result to sink timely

2023-01-03 Thread kevinshin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kevinshin closed FLINK-30546. - Resolution: Not A Bug > WindowDeduplicate didn't write result to sink timely >

[jira] [Commented] (FLINK-30546) WindowDeduplicate didn't write result to sink timely

2023-01-03 Thread kevinshin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654281#comment-17654281 ] kevinshin commented on FLINK-30546: --- I've resolved the problem. Watermark need to set idleness.

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061121029 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -211,16 +214,18 @@ public Optional

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061120757 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-table-store] WencongLiu commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
WencongLiu commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061118884 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #188: [FLINK-30249] Fix TableUtils.getRowTypeInfo by using ExternalTypeInfo.of()

2023-01-03 Thread GitBox
lindong28 commented on code in PR #188: URL: https://github.com/apache/flink-ml/pull/188#discussion_r106236 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/TableUtils.java: ## @@ -26,18 +26,20 @@ import

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061110047 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -44,6 +45,8 @@ public class SnapshotManager {

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061109602 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061109602 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink] fsk119 commented on a diff in pull request #21592: [FLINK-30497][table-api] Introduce TableChange to represent DROP change

2023-01-03 Thread GitBox
fsk119 commented on code in PR #21592: URL: https://github.com/apache/flink/pull/21592#discussion_r1061102346 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/ColumnReferenceFinder.java: ## @@ -81,7 +82,11 @@ public static Set

[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #454: Speedup build

2023-01-03 Thread GitBox
Ge commented on code in PR #454: URL: https://github.com/apache/flink-table-store/pull/454#discussion_r1061100676 ## pom.xml: ## @@ -260,6 +260,13 @@ under the License. ${flink.version} test + + + +

[jira] [Closed] (FLINK-27917) PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition failed with AssertionError

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-27917. - Fix Version/s: (was: 1.14.7) (was: 1.16.1) (was:

[jira] [Closed] (FLINK-29835) NoClassDefFoundError in PulsarSourceUnorderedE2ECase

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29835. - Resolution: Invalid After FLINK-30413 dropped the related support, this test was dropped also. Invalid

[jira] [Closed] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29755. - Resolution: Invalid After FLINK-30413 dropped the related support, this test was dropped also. Invalid

[jira] [Closed] (FLINK-30393) PulsarSourceUnorderedE2ECase.testScaleDown failed with TimeoutException

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-30393. - Resolution: Invalid After FLINK-30413 dropped the related support, this test was dropped also. Invalid

[jira] [Closed] (FLINK-30340) PulsarUnorderedSourceITCase fails with IllegalStateException

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-30340. - Resolution: Invalid After FLINK-30413 dropped the related support, this test was dropped also. Invalid

[jira] [Closed] (FLINK-29836) PulsarUnorderedSourceITCase#testMultipleSplits failed due to an expected job restart not happening

2023-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29836. - Resolution: Invalid After FLINK-30413 dropped the related support, this test was dropped also. Invalid

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2023-01-03 Thread GitBox
swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1061096672 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -258,7 +376,14 @@ private static void

[GitHub] [flink-table-store] WencongLiu commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
WencongLiu commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061096124 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-kubernetes-operator] nowke commented on a diff in pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

2023-01-03 Thread GitBox
nowke commented on code in PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1061092420 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java: ## @@ -248,13 +252,40 @@ public

[GitHub] [flink] fsk119 commented on a diff in pull request #21592: [FLINK-30497][table-api] Introduce TableChange to represent DROP change

2023-01-03 Thread GitBox
fsk119 commented on code in PR #21592: URL: https://github.com/apache/flink/pull/21592#discussion_r1061088996 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -728,114 +724,166 @@ String

[jira] [Comment Edited] (FLINK-29849) Event time temporal join on an upsert source may produce incorrect execution plan

2023-01-03 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650120#comment-17650120 ] Godfrey He edited comment on FLINK-29849 at 1/4/23 2:07 AM: Fixed in master:

[jira] [Updated] (FLINK-29849) Event time temporal join on an upsert source may produce incorrect execution plan

2023-01-03 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He updated FLINK-29849: --- Fix Version/s: 1.16.1 > Event time temporal join on an upsert source may produce incorrect

[GitHub] [flink] godfreyhe closed pull request #21587: [bp-1.16][FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2023-01-03 Thread GitBox
godfreyhe closed pull request #21587: [bp-1.16][FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan URL: https://github.com/apache/flink/pull/21587 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] godfreyhe commented on pull request #21587: [bp-1.16][FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2023-01-03 Thread GitBox
godfreyhe commented on PR #21587: URL: https://github.com/apache/flink/pull/21587#issuecomment-1370408995 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (FLINK-30545) The SchemaManager doesn't check 'NOT NULL' specification when committing AddColumn change

2023-01-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653856#comment-17653856 ] Jingsong Lee edited comment on FLINK-30545 at 1/4/23 1:45 AM: -- master:

[jira] [Closed] (FLINK-30522) `SHOW TBLPROPERTIES` can't read properties of table in Spark3

2023-01-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30522. Fix Version/s: table-store-0.3.0 Assignee: yuzelin Resolution: Fixed master:

[jira] [Updated] (FLINK-30545) The SchemaManager doesn't check 'NOT NULL' specification when committing AddColumn change

2023-01-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-30545: - Fix Version/s: table-store-0.3.0 (was: table-store-0.4.0) > The

[GitHub] [flink] lindong28 commented on pull request #21579: [FLINK-30536][runtime] Remove CountingOutput from per-record code path for most operators

2023-01-03 Thread GitBox
lindong28 commented on PR #21579: URL: https://github.com/apache/flink/pull/21579#issuecomment-1370397686 @xintongsong @zhuzhurk Can you help review this PR? Note that the first commit of this PR duplicates FLINK-30533. Please feel free to review only the 2nd commit. Thanks! --

[GitHub] [flink-table-store] JingsongLi merged pull request #451: [FLINK-30522] Fix 'SHOW TBLPROPERTIES' can't read properties of table in Spark3

2023-01-03 Thread GitBox
JingsongLi merged PR #451: URL: https://github.com/apache/flink-table-store/pull/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #453: URL: https://github.com/apache/flink-table-store/pull/453#discussion_r1061078195 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java: ## @@ -214,13 +217,22 @@ public Optional

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #454: Speedup build

2023-01-03 Thread GitBox
JingsongLi commented on code in PR #454: URL: https://github.com/apache/flink-table-store/pull/454#discussion_r1061077649 ## pom.xml: ## @@ -260,6 +260,13 @@ under the License. ${flink.version} test + + +

[GitHub] [flink] Myracle commented on pull request #21347: [FLINK-29640][Client/Job Submission]Enhance the function configured by execution.shutdown-on-attached-exi…

2023-01-03 Thread GitBox
Myracle commented on PR #21347: URL: https://github.com/apache/flink/pull/21347#issuecomment-1370384506 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] liuml07 commented on pull request #19537: [FLINK-23589][flink-avro] Support microsecond precision for timestamp

2023-01-03 Thread GitBox
liuml07 commented on PR #19537: URL: https://github.com/apache/flink/pull/19537#issuecomment-1370350926 I think this PR is not blocked by [FLINK-27331](https://issues.apache.org/jira/browse/FLINK-27331) or [FLINK-17224](https://issues.apache.org/jira/browse/FLINK-17224), though

[jira] [Commented] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2023-01-03 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654214#comment-17654214 ] Mingliang Liu commented on FLINK-30483: --- Thanks [~jadireddi] I'll review from next week. This week

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-03 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1060998267 ## flink-core/src/main/java/org/apache/flink/configuration/HeartbeatManagerOptions.java: ## @@ -50,6 +50,8 @@ public class HeartbeatManagerOptions { private

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-03 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1060981282 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/DefaultHeartbeatMonitor.java: ## @@ -35,9 +36,9 @@ * * @param Type of the payload being

[GitHub] [flink-connector-opensearch] reta commented on pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-01-03 Thread GitBox
reta commented on PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-137051 @zentol @MartijnVisser would appreciate if you guys have time for the review, adding AsyncSink support for OpenSearch, discussed initially [1] [1]

[jira] [Updated] (FLINK-30537) Add support for OpenSearch 2.3

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30537: --- Labels: pull-request-available (was: ) > Add support for OpenSearch 2.3 >

[GitHub] [flink-connector-opensearch] reta commented on pull request #4: [FLINK-30537] Update Opensearch dependency to version 2.3

2023-01-03 Thread GitBox
reta commented on PR #4: URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1370221021 @amirhalatzi the OpenSearch 2.x has JDK-11 baseline (the connector works with 2.x as well). Please correct me if I am wrong, Apache Flink still supports JDK 8 (although it is

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-01-03 Thread GitBox
reta commented on code in PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#discussion_r1060946596 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkITCase.java: ## @@ -146,29 +146,30 @@ private void

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #500: [hotfix] Add year 2023 to Notice files

2023-01-03 Thread GitBox
mbalassi merged PR #500: URL: https://github.com/apache/flink-kubernetes-operator/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2023-01-03 Thread Jagadesh Adireddi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654154#comment-17654154 ] Jagadesh Adireddi commented on FLINK-30483: --- Hi [~liuml07] , Thank you for the response.

[GitHub] [flink] flinkbot commented on pull request #21594: [FLINK-30483] [Formats] [Avro] Add avro format support for TIMESTAMP_LTZ

2023-01-03 Thread GitBox
flinkbot commented on PR #21594: URL: https://github.com/apache/flink/pull/21594#issuecomment-1370127985 ## CI report: * 144b02ba1351fb5d632edc43e2a7a78710478782 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30483: --- Labels: pull-request-available (was: ) > Make Avro format support for TIMESTAMP_LTZ >

[GitHub] [flink] jadireddi opened a new pull request, #21594: [FLINK-30483] [Formats] [Avro] Add avro format support for TIMESTAMP_LTZ

2023-01-03 Thread GitBox
jadireddi opened a new pull request, #21594: URL: https://github.com/apache/flink/pull/21594 https://issues.apache.org/jira/browse/FLINK-30483 ## What is the purpose of the change This PR adds Avro format support for TIMESTAMP_LTZ milliseconds. ## Brief change

[GitHub] [flink] ramkrish86 commented on a diff in pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2023-01-03 Thread GitBox
ramkrish86 commented on code in PR #21508: URL: https://github.com/apache/flink/pull/21508#discussion_r1060844881 ## flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AzureBlobFsRecoverableDataOutputStream.java: ## @@ -0,0 +1,312 @@ +/* + *

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-01-03 Thread James Mcguire (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654125#comment-17654125 ] James Mcguire commented on FLINK-30093: --- Using  {{row}} did not work with 1.16.0 for me.   If you

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #499: [docs] Autoscaler doc and example improvement

2023-01-03 Thread GitBox
gyfora merged PR #499: URL: https://github.com/apache/flink-kubernetes-operator/pull/499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30464) Metrics are collected in stabilization phase and do not always span a full metric window

2023-01-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-30464. -- Resolution: Fixed > Metrics are collected in stabilization phase and do not always

[GitHub] [flink-kubernetes-operator] mxm merged pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

2023-01-03 Thread GitBox
mxm merged PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2023-01-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654114#comment-17654114 ] Matthias Pohl commented on FLINK-29755: --- Thanks for letting me know.~ Feel free to update the Jira

[jira] [Updated] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2023-01-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29755: -- Affects Version/s: (was: pulsar-4.0.0) > PulsarSourceUnorderedE2ECase.testSavepoint

[GitHub] [flink-table-store] Gerrrr commented on pull request #454: Speedup build

2023-01-03 Thread GitBox
Ge commented on PR #454: URL: https://github.com/apache/flink-table-store/pull/454#issuecomment-1370036171 @JingsongLi Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-table-store] Gerrrr opened a new pull request, #454: Speedup build

2023-01-03 Thread GitBox
Ge opened a new pull request, #454: URL: https://github.com/apache/flink-table-store/pull/454 This is a follow-up PR for https://github.com/apache/flink-table-store/pull/447. The original PR was reverted because it broke builds with maven 3.2.5. Build failures were due to

[GitHub] [flink] LadyForest commented on a diff in pull request #21592: [FLINK-30497][table-api] Introduce TableChange to represent DROP change

2023-01-03 Thread GitBox
LadyForest commented on code in PR #21592: URL: https://github.com/apache/flink/pull/21592#discussion_r1060581278 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java: ## @@ -229,6 +229,53 @@ static ModifyWatermark modify(WatermarkSpec

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #500: [hotfix] Add year 2023 to Notice files

2023-01-03 Thread GitBox
mbalassi opened a new pull request, #500: URL: https://github.com/apache/flink-kubernetes-operator/pull/500 @gyfora PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-30549) Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654088#comment-17654088 ] Danny Cranmer commented on FLINK-30549: --- Merged commit

[jira] [Closed] (FLINK-30549) Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer closed FLINK-30549. - Resolution: Done > Remove flink-connector-aws-kinesis-firehose from Flink master branch >

[GitHub] [flink] dannycranmer merged pull request #21591: [FLINK-30549] Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread GitBox
dannycranmer merged PR #21591: URL: https://github.com/apache/flink/pull/21591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30389) Add retry to read hints

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30389: --- Labels: pull-request-available (was: ) > Add retry to read hints > ---

[GitHub] [flink-table-store] WencongLiu opened a new pull request, #453: [FLINK-30389] Add retry to read hints

2023-01-03 Thread GitBox
WencongLiu opened a new pull request, #453: URL: https://github.com/apache/flink-table-store/pull/453 ## What is the purpose of the change Add retry to read hints in SnapshotManager ## Brief change log - *Introduce the retry logic in SnapshotManager*

[jira] [Commented] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2023-01-03 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654068#comment-17654068 ] Yufan Sheng commented on FLINK-29755: - [~mapohl] We have removed these tests in {{pulsar-4.0.0}}. >

[GitHub] [flink] lindong28 commented on pull request #21576: [FLINK-30533][runtime] SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-03 Thread GitBox
lindong28 commented on PR #21576: URL: https://github.com/apache/flink/pull/21576#issuecomment-1369812187 @zhuzhurk Thanks for the review! After reading through related source code, I believe this PR won't affect the behavior of multi-input operators, due to the following reasons:

[jira] [Resolved] (FLINK-30510) Allow configuring minimum and maximum metrics window size

2023-01-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-30510. Fix Version/s: (was: kubernetes-operator-1.4.0) Resolution: Later >

[jira] [Commented] (FLINK-30510) Allow configuring minimum and maximum metrics window size

2023-01-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654018#comment-17654018 ] Maximilian Michels commented on FLINK-30510: After the discussion here we decided not to

[GitHub] [flink] wanglijie95 commented on pull request #21588: [FLINK-30544][runtime] Speed up finding minimum watermark across channels by introducing heap-based algorithm

2023-01-03 Thread GitBox
wanglijie95 commented on PR #21588: URL: https://github.com/apache/flink/pull/21588#issuecomment-1369784131 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] dannycranmer commented on a diff in pull request #21591: [FLINK-30549] Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread GitBox
dannycranmer commented on code in PR #21591: URL: https://github.com/apache/flink/pull/21591#discussion_r1060591551 ## flink-python/pom.xml: ## @@ -314,7 +314,7 @@ under the License. org.apache.flink

[GitHub] [flink-playgrounds] alpinegizmo merged pull request #39: FLINK-30442: Upgrading table walk-through to Flink 1.16

2023-01-03 Thread GitBox
alpinegizmo merged PR #39: URL: https://github.com/apache/flink-playgrounds/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] darenwkt commented on a diff in pull request #21591: [FLINK-30549] Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread GitBox
darenwkt commented on code in PR #21591: URL: https://github.com/apache/flink/pull/21591#discussion_r1060584632 ## flink-python/pom.xml: ## @@ -314,7 +314,7 @@ under the License. org.apache.flink

[GitHub] [flink] darenwkt commented on a diff in pull request #21591: [FLINK-30549] Remove flink-connector-aws-kinesis-firehose from Flink master branch

2023-01-03 Thread GitBox
darenwkt commented on code in PR #21591: URL: https://github.com/apache/flink/pull/21591#discussion_r1060584632 ## flink-python/pom.xml: ## @@ -314,7 +314,7 @@ under the License. org.apache.flink

[GitHub] [flink-playgrounds] alpinegizmo merged pull request #37: [FLINK-30446][flink-playgrounds]bump mysql version to 8.0.31 for table-walkthrough supporting more architectures

2023-01-03 Thread GitBox
alpinegizmo merged PR #37: URL: https://github.com/apache/flink-playgrounds/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-playgrounds] alpinegizmo commented on pull request #37: [FLINK-30446][flink-playgrounds]bump mysql version to 8.0.31 for table-walkthrough supporting more architectures

2023-01-03 Thread GitBox
alpinegizmo commented on PR #37: URL: https://github.com/apache/flink-playgrounds/pull/37#issuecomment-1369770472 Thanks @cameres for the contribution, and @gunnarmorling for testing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #499: [docs] Autoscaler doc and example improvement

2023-01-03 Thread GitBox
gyfora opened a new pull request, #499: URL: https://github.com/apache/flink-kubernetes-operator/pull/499 Minor improvement for the autoscaler doc page + example yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (FLINK-30550) Flink master to integrate KDS/KDF docs from flink-connector-aws

2023-01-03 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-30550. --- Resolution: Done > Flink master to integrate KDS/KDF docs from flink-connector-aws >

  1   2   3   >