[GitHub] [flink] snuyanzin commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-20 Thread via GitHub
snuyanzin commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1112683551 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +178,35 @@ ANY,

[GitHub] [flink] snuyanzin commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-20 Thread via GitHub
snuyanzin commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1112683551 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +178,35 @@ ANY,

[jira] [Closed] (FLINK-31052) Release Testing: Verify FLINK-30707 Improve slow task detection

2023-02-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-31052. --- Resolution: Done Thanks for helping with the testing! [~JunRuiLi] > Release Testing: Verify FLINK-30707

[jira] [Closed] (FLINK-31005) Release Testing: Verify FLIP-281 Supports speculative execution of sinks

2023-02-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-31005. --- Resolution: Done Thanks for helping with the testing! [~wanglijie] > Release Testing: Verify FLIP-281

[jira] [Commented] (FLINK-25316) BlobServer can get stuck during shutdown

2023-02-20 Thread hk__lrzy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691438#comment-17691438 ] hk__lrzy commented on FLINK-25316: -- I meet same issue in flink 1.11.6 release, i am not sure why

[jira] [Updated] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-20 Thread miamiaoxyz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miamiaoxyz updated FLINK-31059: --- Attachment: image-2023-02-21-15-49-58-854.png > Release Testing: Verify FLINK-29717 Supports hive

[jira] [Updated] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-20 Thread miamiaoxyz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miamiaoxyz updated FLINK-31059: --- Attachment: image-2023-02-21-15-47-54-043.png > Release Testing: Verify FLINK-29717 Supports hive

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

2023-02-20 Thread via GitHub
xuzhiwen1255 commented on code in PR #21971: URL: https://github.com/apache/flink/pull/21971#discussion_r1112671104 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -264,57 +267,63 @@ void

[jira] [Updated] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-20 Thread miamiaoxyz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miamiaoxyz updated FLINK-31059: --- Attachment: image-2023-02-21-15-45-48-226.png > Release Testing: Verify FLINK-29717 Supports hive

[jira] [Updated] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-20 Thread miamiaoxyz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miamiaoxyz updated FLINK-31059: --- Attachment: image-2023-02-21-15-46-13-966.png > Release Testing: Verify FLINK-29717 Supports hive

[jira] [Created] (FLINK-31163) Unexpected correlate variable $cor0 in the plan error in where clause

2023-02-20 Thread P Rohan Kumar (Jira)
P Rohan Kumar created FLINK-31163: - Summary: Unexpected correlate variable $cor0 in the plan error in where clause Key: FLINK-31163 URL: https://issues.apache.org/jira/browse/FLINK-31163 Project:

[jira] [Created] (FLINK-31164) Unexpected correlate variable $cor0 in the plan error in where clause

2023-02-20 Thread P Rohan Kumar (Jira)
P Rohan Kumar created FLINK-31164: - Summary: Unexpected correlate variable $cor0 in the plan error in where clause Key: FLINK-31164 URL: https://issues.apache.org/jira/browse/FLINK-31164 Project:

[GitHub] [flink] xuzhiwen1255 commented on pull request #21971: [FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

2023-02-20 Thread via GitHub
xuzhiwen1255 commented on PR #21971: URL: https://github.com/apache/flink/pull/21971#issuecomment-1437989291 @XComp The problem of safeDivide has been modified. Could you please help me review it? Thank you! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-27115) Error while executing BLOB connection. java.io.IOException: Unknown operation 80

2023-02-20 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691429#comment-17691429 ] Weihua Hu commented on FLINK-27115: --- This is reproduced in our environment. After some check, this is

[jira] [Commented] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-20 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691424#comment-17691424 ] Samrat Deb commented on FLINK-31120:

[GitHub] [flink] reswqa commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-20 Thread via GitHub
reswqa commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1112641083 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -42,17 +44,18 @@ import static

[GitHub] [flink] reswqa commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-20 Thread via GitHub
reswqa commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1112634137 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java: ## @@ -398,39 +399,38 @@ public void

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-02-20 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691416#comment-17691416 ] Weihua Hu commented on FLINK-31144: --- Thanks for reporting this issue. [~jto] 

[GitHub] [flink] flinkbot commented on pull request #21980: [FLINK-31137][hive] Fix wrong ResultKind in DescribeTable and ShowCre…

2023-02-20 Thread via GitHub
flinkbot commented on PR #21980: URL: https://github.com/apache/flink/pull/21980#issuecomment-1437957241 ## CI report: * f83b765c02c1e4396b630825822e28adfd720fd3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31137) SQL Client doesn't print results for SHOW CREATE TABLE/DESC in hive dialect

2023-02-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691415#comment-17691415 ] Shengkai Fang commented on FLINK-31137: --- Merged into release-1.17:

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-20 Thread via GitHub
SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112631890 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,79 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[jira] [Assigned] (FLINK-31137) SQL Client doesn't print results for SHOW CREATE TABLE/DESC in hive dialect

2023-02-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-31137: - Assignee: Shengkai Fang > SQL Client doesn't print results for SHOW CREATE TABLE/DESC

[GitHub] [flink] fsk119 opened a new pull request, #21980: [FLINK-31137][hive] Fix wrong ResultKind in DescribeTable and ShowCre…

2023-02-20 Thread via GitHub
fsk119 opened a new pull request, #21980: URL: https://github.com/apache/flink/pull/21980 …ateTable result ## What is the purpose of the change *Cherry pick the fix #21976.* -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-20 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He reassigned FLINK-31059: -- Assignee: miamiaoxyz (was: Yunhong Zheng) > Release Testing: Verify FLINK-29717 Supports

[jira] [Assigned] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-20 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He reassigned FLINK-31079: -- Assignee: miamiaoxyz (was: Yunhong Zheng) > Release Testing: Verify FLINK-29663 Further

[GitHub] [flink] fsk119 commented on a diff in pull request #21901: [FLINK-30968][sql-client] Sql client supports dynamic config to open session

2023-02-20 Thread via GitHub
fsk119 commented on code in PR #21901: URL: https://github.com/apache/flink/pull/21901#discussion_r1112610449 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DefaultContextUtils.java: ## @@ -51,12 +52,17 @@ public static DefaultContext

[jira] [Closed] (FLINK-31062) Release Testing: Verify FLINK-30365 New dynamic partition pruning strategy to support more dpp patterns

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31062. -- Resolution: Done > Release Testing: Verify FLINK-30365 New dynamic partition pruning strategy to >

[jira] [Commented] (FLINK-31159) Release Testing: Verify FLINK-30583 Provide the flame graph to the subtask level

2023-02-20 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691410#comment-17691410 ] Qingsheng Ren commented on FLINK-31159: --- [~qingyue] Thanks for taking the issue! I've assign this

[jira] [Comment Edited] (FLINK-31159) Release Testing: Verify FLINK-30583 Provide the flame graph to the subtask level

2023-02-20 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691410#comment-17691410 ] Qingsheng Ren edited comment on FLINK-31159 at 2/21/23 6:52 AM:

[jira] [Assigned] (FLINK-31159) Release Testing: Verify FLINK-30583 Provide the flame graph to the subtask level

2023-02-20 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31159: - Assignee: Jane Chan > Release Testing: Verify FLINK-30583 Provide the flame graph to

[jira] [Commented] (FLINK-31045) In IntelliJ: flink-clients cannot find symbol symbol: class TestUserClassLoaderJobLib

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691408#comment-17691408 ] Weijie Guo commented on FLINK-31045: also got same problem many times > In IntelliJ: flink-clients

[GitHub] [flink] Rruop commented on pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-20 Thread via GitHub
Rruop commented on PR #21968: URL: https://github.com/apache/flink/pull/21968#issuecomment-1437936900 > * @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-30551) Add open method to PartitionCommitPolicy

2023-02-20 Thread tanjialiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691406#comment-17691406 ] tanjialiang commented on FLINK-30551: - I think it is necessary for custom partition commit policy to

[GitHub] [flink] libenchao commented on a diff in pull request #21956: [FLINK-31113] Support AND filter push down in orc

2023-02-20 Thread via GitHub
libenchao commented on code in PR #21956: URL: https://github.com/apache/flink/pull/21956#discussion_r1112600693 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemFilterTest.java: ## @@ -74,5 +75,20 @@ public void testApplyPredicate() {

[GitHub] [flink] Rruop commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-20 Thread via GitHub
Rruop commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1112601120 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the

[GitHub] [flink] Rruop commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-20 Thread via GitHub
Rruop commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1112600478 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot commented on pull request #21979: [FLINK-30810] Rework CliClientITCase extends AbstractStatementTestBase

2023-02-20 Thread via GitHub
flinkbot commented on PR #21979: URL: https://github.com/apache/flink/pull/21979#issuecomment-1437924879 ## CI report: * 5c9983c01f42670df3aaff8c57fd3053d6924987 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31137) SQL Client doesn't print results for SHOW CREATE TABLE/DESC in hive dialect

2023-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31137: --- Labels: pull-request-available (was: ) > SQL Client doesn't print results for SHOW CREATE

[GitHub] [flink] fsk119 merged pull request #21976: [FLINK-31137][hive] Fix wrong ResultKind in DescribeTable and ShowCre…

2023-02-20 Thread via GitHub
fsk119 merged PR #21976: URL: https://github.com/apache/flink/pull/21976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30810) Rework the CliClientITCase to extend AbstractSqlGatewayStatementITCase

2023-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30810: --- Labels: pull-request-available (was: ) > Rework the CliClientITCase to extend

[GitHub] [flink] FangYongs opened a new pull request, #21979: [FLINK-30810] Rework CliClientITCase extends AbstractStatementTestBase

2023-02-20 Thread via GitHub
FangYongs opened a new pull request, #21979: URL: https://github.com/apache/flink/pull/21979 ## What is the purpose of the change This PR aims to rework `CliClientITCase` extend `AbstractStatementTestBase` ## Brief change log - Make `CliClientITCase` extend

[jira] [Updated] (FLINK-31162) Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled

2023-02-20 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata krishnan Sowrirajan updated FLINK-31162: Description: In our internal env, we have enabled [Consistent

[jira] [Updated] (FLINK-31162) Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled

2023-02-20 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata krishnan Sowrirajan updated FLINK-31162: Description: In our internal env, we have enabled [Consistent

[jira] [Comment Edited] (FLINK-29849) Event time temporal join on an upsert source may produce incorrect execution plan

2023-02-20 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691399#comment-17691399 ] lincoln lee edited comment on FLINK-29849 at 2/21/23 6:21 AM: -- Just for

[jira] [Updated] (FLINK-31162) Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled

2023-02-20 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata krishnan Sowrirajan updated FLINK-31162: Description: In our internal env, we have enabled [Consistent

[jira] [Created] (FLINK-31162) Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled

2023-02-20 Thread Venkata krishnan Sowrirajan (Jira)
Venkata krishnan Sowrirajan created FLINK-31162: --- Summary: Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled Key: FLINK-31162 URL:

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-20 Thread via GitHub
zhangjun0x01 commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112587410 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,79 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[jira] [Commented] (FLINK-29849) Event time temporal join on an upsert source may produce incorrect execution plan

2023-02-20 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691399#comment-17691399 ] lincoln lee commented on FLINK-29849: - Just for record: the conclusions of reviewing the semantic

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-20 Thread via GitHub
zhangjun0x01 commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112586512 ## flink-table-store-connector/pom.xml: ## @@ -151,6 +151,27 @@ under the License. provided + +

[jira] [Commented] (FLINK-31138) Either StreamCheckpointingITCase/StreamFaultToleranceTestBase or EventTimeWindowCheckpointingITCase are timinng out

2023-02-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691397#comment-17691397 ] Rui Fan commented on FLINK-31138: - Too many tests run slowly, I'm not sure whether the container has

[GitHub] [flink] huwh commented on pull request #21569: [FLINK-30517][log]Decrease log output interval while waiting for YARN…

2023-02-20 Thread via GitHub
huwh commented on PR #21569: URL: https://github.com/apache/flink/pull/21569#issuecomment-1437910655 @xintongsong Hi, Could you help take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] JunRuiLee commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-20 Thread via GitHub
JunRuiLee commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r111259 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the

[GitHub] [flink] huwh commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-20 Thread via GitHub
huwh commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1112580326 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set

[GitHub] [flink] snuyanzin commented on a diff in pull request #21945: [FLINK-31091][Table SQL/Client] Add Ser/de for Interval types

2023-02-20 Thread via GitHub
snuyanzin commented on code in PR #21945: URL: https://github.com/apache/flink/pull/21945#discussion_r1112572254 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerDeTest.java: ## @@ -219,6 +231,25 @@ private static List

[jira] [Updated] (FLINK-31114) Batch job fails with IllegalStateException when using adaptive batch scheduler

2023-02-20 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang updated FLINK-31114: --- Priority: Blocker (was: Critical) > Batch job fails with IllegalStateException when using adaptive

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-20 Thread via GitHub
SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112563412 ## flink-table-store-connector/pom.xml: ## @@ -151,6 +151,27 @@ under the License. provided + +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-20 Thread via GitHub
SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112563022 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,79 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[jira] [Commented] (FLINK-31091) SQL interval related queries stop working via SQL client

2023-02-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691392#comment-17691392 ] Sergey Nuyanzin commented on FLINK-31091: - Hi [~qingyue] thanks for volunteering, however there

[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #533: [FLINK-30920] [AutoScaler] adds exclude vertex ids for autoscaler to ignore for evaluation and scaling

2023-02-20 Thread via GitHub
gauravmiglanid11 commented on PR #533: URL: https://github.com/apache/flink-kubernetes-operator/pull/533#issuecomment-1437873988 Hi @mxm, changes done,can you please review them.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #21978: [FLINK-31161][build] bump versions-maven-plugin to 2.14.2.

2023-02-20 Thread via GitHub
flinkbot commented on PR #21978: URL: https://github.com/apache/flink/pull/21978#issuecomment-1437872182 ## CI report: * 4ff48dda6a84cd0700fe94de83876beefbf7f281 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31161) upgrade MojoHaus Versions Maven Plugin to 2.14.2

2023-02-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31161: --- Labels: pull-request-available (was: ) > upgrade MojoHaus Versions Maven Plugin to 2.14.2

[GitHub] [flink] liuyongvs opened a new pull request, #21978: [FLINK-31161][build] bump versions-maven-plugin to 2.14.2.

2023-02-20 Thread via GitHub
liuyongvs opened a new pull request, #21978: URL: https://github.com/apache/flink/pull/21978 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21962: [FLINK-31124][Connectors/Hive] Add IT sase for HiveTableSink speculative execution

2023-02-20 Thread via GitHub
zhuzhurk commented on code in PR #21962: URL: https://github.com/apache/flink/pull/21962#discussion_r1112520432 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSpeculativeSinkITCase.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[jira] [Comment Edited] (FLINK-30407) Better encapsulate error handling logic in controllers

2023-02-20 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691340#comment-17691340 ] Shipeng Xie edited comment on FLINK-30407 at 2/21/23 4:59 AM: -- Hi [~gyfora]

[GitHub] [flink] luoyuxia commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-20 Thread via GitHub
luoyuxia commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1112512579 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java: ## @@ -52,6 +52,11 @@ /** Helper for creating

[jira] [Commented] (FLINK-31060) Release Testing: Verify FLINK-30542 Support adaptive local hash aggregate in runtime

2023-02-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691366#comment-17691366 ] dalongliu commented on FLINK-31060: --- Verify step, I create a source table using datagen:  

[jira] [Closed] (FLINK-31060) Release Testing: Verify FLINK-30542 Support adaptive local hash aggregate in runtime

2023-02-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu closed FLINK-31060. - Resolution: Fixed > Release Testing: Verify FLINK-30542 Support adaptive local hash aggregate in >

[jira] [Comment Edited] (FLINK-31060) Release Testing: Verify FLINK-30542 Support adaptive local hash aggregate in runtime

2023-02-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691366#comment-17691366 ] dalongliu edited comment on FLINK-31060 at 2/21/23 4:36 AM: Verify step, I

[jira] [Updated] (FLINK-31161) upgrade MojoHaus Versions Maven Plugin to 2.14.2

2023-02-20 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-31161: - Description: when we use multiple project, the parrent struct like this

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-20 Thread via GitHub
zhuzhurk commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1112520699 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-31161) upgrade MojoHaus Versions Maven Plugin to 2.14.2

2023-02-20 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691364#comment-17691364 ] jackylau commented on FLINK-31161: -- hi [~chesnay] , could you help to review it? > upgrade MojoHaus

[GitHub] [flink] Samrat002 commented on pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-20 Thread via GitHub
Samrat002 commented on PR #21770: URL: https://github.com/apache/flink/pull/21770#issuecomment-1437841702 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-31161) upgrade MojoHaus Versions Maven Plugin to 2.14.2

2023-02-20 Thread jackylau (Jira)
jackylau created FLINK-31161: Summary: upgrade MojoHaus Versions Maven Plugin to 2.14.2 Key: FLINK-31161 URL: https://issues.apache.org/jira/browse/FLINK-31161 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-31060) Release Testing: Verify FLINK-30542 Support adaptive local hash aggregate in runtime

2023-02-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691362#comment-17691362 ] dalongliu commented on FLINK-31060: --- I verified this feature according to the description, and

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-20 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1112513443 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set

[jira] [Resolved] (FLINK-21000) Provide MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-21000. Resolution: Fixed Implemented in master: bacdc326b58749924acbd8921d63eda06663a225 > Provide

[jira] [Updated] (FLINK-21000) Provide MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Priority: Major (was: Critical) > Provide MetricGroup in SourceCoordinatorContext >

[GitHub] [flink] fsk119 commented on a diff in pull request #21945: [FLINK-31091][Table SQL/Client] Add Ser/de for Interval types

2023-02-20 Thread via GitHub
fsk119 commented on code in PR #21945: URL: https://github.com/apache/flink/pull/21945#discussion_r1112507939 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerDeTest.java: ## @@ -219,6 +231,25 @@ private static List

[jira] [Updated] (FLINK-21000) Provide MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Priority: Critical (was: Not a Priority) > Provide MetricGroup in SourceCoordinatorContext >

[jira] [Updated] (FLINK-21000) Provide MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Summary: Provide MetricGroup in SourceCoordinatorContext (was: set MetricGroup in

[jira] [Updated] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Issue Type: Improvement (was: Bug) > set MetricGroup in SourceCoordinatorContext >

[jira] [Updated] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Affects Version/s: 1.16.1 (was: 1.12.0) > set MetricGroup in

[jira] [Updated] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2023-02-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21000: --- Fix Version/s: 1.18.0 > set MetricGroup in SourceCoordinatorContext >

[GitHub] [flink] leonardBang closed pull request #21952: [FLINK-21000][runtime] Add an internal split enumerator metric group

2023-02-20 Thread via GitHub
leonardBang closed pull request #21952: [FLINK-21000][runtime] Add an internal split enumerator metric group URL: https://github.com/apache/flink/pull/21952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (FLINK-31036) StateCheckpointedITCase timed out

2023-02-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691214#comment-17691214 ] Rui Fan edited comment on FLINK-31036 at 2/21/23 3:49 AM: -- merged commit

[GitHub] [flink] fsk119 commented on a diff in pull request #21945: [FLINK-31091][Table SQL/Client] Add Ser/de for Interval types

2023-02-20 Thread via GitHub
fsk119 commented on code in PR #21945: URL: https://github.com/apache/flink/pull/21945#discussion_r1112502607 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerializer.java: ## @@ -87,6 +89,10 @@ public final class

[GitHub] [flink] leonardBang commented on a diff in pull request #21952: [FLINK-21000][runtime] Add an internal split enumerator metric group

2023-02-20 Thread via GitHub
leonardBang commented on code in PR #21952: URL: https://github.com/apache/flink/pull/21952#discussion_r1112502060 ## flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/InternalSplitEnumeratorGroupTest.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[GitHub] [flink] liuyongvs commented on pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-20 Thread via GitHub
liuyongvs commented on PR #21947: URL: https://github.com/apache/flink/pull/21947#issuecomment-1437814073 hi @snuyanzin do you have time to review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (FLINK-31091) SQL interval related queries stop working via SQL client

2023-02-20 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691352#comment-17691352 ] Jane Chan edited comment on FLINK-31091 at 2/21/23 3:31 AM: Thanks, [~Sergey

[jira] [Commented] (FLINK-31091) SQL interval related queries stop working via SQL client

2023-02-20 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691352#comment-17691352 ] Jane Chan commented on FLINK-31091: --- Thanks, [~Sergey Nuyanzin] and [~mapohl] for reporting this. The

[GitHub] [flink] fsk119 commented on a diff in pull request #21974: [FLINK-31136][sql-client] Forbid sql client to read flink-conf.yaml i…

2023-02-20 Thread via GitHub
fsk119 commented on code in PR #21974: URL: https://github.com/apache/flink/pull/21974#discussion_r1112495505 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -142,11 +151,13 @@ public static DefaultContext

[GitHub] [flink-ml] Fanoid commented on pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-20 Thread via GitHub
Fanoid commented on PR #213: URL: https://github.com/apache/flink-ml/pull/213#issuecomment-1437803782 Thanks for your updates. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] shuiqiangchen commented on a diff in pull request #21961: [FLINK-31120] Add concurrent access control for collectorIterators in StreamExecutionEnvironment

2023-02-20 Thread via GitHub
shuiqiangchen commented on code in PR #21961: URL: https://github.com/apache/flink/pull/21961#discussion_r1112479461 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -149,11 +149,14 @@ @Public public class

[jira] [Comment Edited] (FLINK-30407) Better encapsulate error handling logic in controllers

2023-02-20 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691340#comment-17691340 ] Shipeng Xie edited comment on FLINK-30407 at 2/21/23 2:42 AM: -- Hi [~gyfora]

[jira] [Closed] (FLINK-30938) Release Testing: Verify FLINK-29766 Adaptive Batch Scheduler should also work with hybrid shuffle mode

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-30938. -- Resolution: Done > Release Testing: Verify FLINK-29766 Adaptive Batch Scheduler should also work >

[jira] [Comment Edited] (FLINK-31089) pin L0 index in memory can lead to slow memory grow finally lead to memory beyond limit

2023-02-20 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690346#comment-17690346 ] xiaogang zhou edited comment on FLINK-31089 at 2/21/23 2:38 AM: yes,

[jira] [Comment Edited] (FLINK-29816) Userfunction exception in ProcessWindowFunction was called before invoke during restore state(subtask was in INITIALIZING state), but SteamTask skip handle Except

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691341#comment-17691341 ] Weijie Guo edited comment on FLINK-29816 at 2/21/23 2:37 AM: - [~RocMarshal]

[jira] [Assigned] (FLINK-29816) Userfunction exception in ProcessWindowFunction was called before invoke during restore state(subtask was in INITIALIZING state), but SteamTask skip handle Exception

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-29816: -- Assignee: RocMarshal (was: Weijie Guo) > Userfunction exception in ProcessWindowFunction

[jira] [Commented] (FLINK-29816) Userfunction exception in ProcessWindowFunction was called before invoke during restore state(subtask was in INITIALIZING state), but SteamTask skip handle Exception

2023-02-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691341#comment-17691341 ] Weijie Guo commented on FLINK-29816: [~RocMarshal]You are assigned. > Userfunction exception in

[jira] [Commented] (FLINK-30407) Better encapsulate error handling logic in controllers

2023-02-20 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691340#comment-17691340 ] Shipeng Xie commented on FLINK-30407: - Hi [~gyfora] , I would like to know more about the context of

  1   2   3   4   5   >