Re: [PR] [FLINK-33354][runtime] Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects [flink]

2023-11-05 Thread via GitHub
1996fanrui commented on code in PR #23599: URL: https://github.com/apache/flink/pull/23599#discussion_r1382890456 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java: ## @@ -253,13 +274,19 @@ public void loadBigData(

[jira] [Commented] (FLINK-32721) agg max/min supports char type

2023-11-05 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783126#comment-17783126 ] Yao Zhang commented on FLINK-32721: ---  Hi [~jackylau], [~libenchao] and [~lsy], It seems that the

Re: [PR] [FLINK-33147] Introduce endpoint field in REST API and deprecate host field [flink]

2023-11-05 Thread via GitHub
huwh commented on code in PR #23465: URL: https://github.com/apache/flink/pull/23465#discussion_r1382886222 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfoWithHistory.java: ## @@ -208,7 +214,34 @@ public static class ExceptionInfo {

Re: [PR] [FLINK-32721][table-planner] Fix SQL MAX aggregation function does no… [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23671: URL: https://github.com/apache/flink/pull/23671#issuecomment-1794248152 ## CI report: * 178c79746143e96148ffa990e75aab0602604713 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33437) Flink 1.17 sink commited legacy Committable state, but it was not removed from state backend

2023-11-05 Thread Yuchi Duan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783123#comment-17783123 ] Yuchi Duan commented on FLINK-33437: I have already solved this problem, and tested in our

[PR] [FLINK-32721][table-planner] Fix SQL MAX aggregation function does no… [flink]

2023-11-05 Thread via GitHub
paul8263 opened a new pull request, #23671: URL: https://github.com/apache/flink/pull/23671 …t support CHAR type ## What is the purpose of the change Support max aggregation with char data type by reusing the existing MaxAggFunction. ## Brief change log

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-11-05 Thread via GitHub
MartijnVisser commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1794236324 CC @ferenc-csaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33206] Verify the existence of hbase table before read/write [flink-connector-hbase]

2023-11-05 Thread via GitHub
MartijnVisser commented on PR #22: URL: https://github.com/apache/flink-connector-hbase/pull/22#issuecomment-1794236276 CC @ferenc-csaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33451) Implement FileSytem based AutoScalerStateStore (e.g : HbaseAutoScalerStateStore)

2023-11-05 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33451: --- Summary: Implement FileSytem based AutoScalerStateStore (e.g : HbaseAutoScalerStateStore) (was:

Re: [PR] [FLINK-33354][runtime] Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects [flink]

2023-11-05 Thread via GitHub
huwh commented on code in PR #23599: URL: https://github.com/apache/flink/pull/23599#discussion_r1382863857 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java: ## @@ -253,13 +274,19 @@ public void loadBigData(

Re: [PR] [docs] Fix typo [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23670: URL: https://github.com/apache/flink/pull/23670#issuecomment-1794217063 ## CI report: * d9cc305fa4af38fcfaf5fe60568ce0e0c56ffed5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [docs] Fix typo [flink]

2023-11-05 Thread via GitHub
RavenLite opened a new pull request, #23670: URL: https://github.com/apache/flink/pull/23670 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-05 Thread via GitHub
Jiabao-Sun commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794209251 Tests for plan has been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783111#comment-17783111 ] Zakelly Lan commented on FLINK-20672: - I would like to fix this if no one takes. >

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-05 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1382851909 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocatorFactory.java: ## @@ -84,4 +96,25 @@ public ExecutionSlotAllocator

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23669: URL: https://github.com/apache/flink/pull/23669#issuecomment-1794180188 ## CI report: * 2779239ff7d889f0a15dd837609dbb900b9bc693 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-05 Thread via GitHub
WencongLiu commented on PR #23666: URL: https://github.com/apache/flink/pull/23666#issuecomment-1794179565 > @WencongLiu I have finished the translation, PTAL, thanks! Thanks for the contribution. I'll take a look. -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23668: URL: https://github.com/apache/flink/pull/23668#issuecomment-1794179424 ## CI report: * 8cf6ef0c8e877dfc01984cef744382ad6d68ea97 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
fengjiajie commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1794179250 > Hi @fengjiajie, could you pick the fix to branch release-1.18 and release-1.17 as well? Hi @LadyForest , thank you for moving this forward. cherry-picks to 1.17 and 1.18:

[PR] [FLINK-33171][table-planner] Consistent implicit type coercion suppor… [flink]

2023-11-05 Thread via GitHub
fengjiajie opened a new pull request, #23669: URL: https://github.com/apache/flink/pull/23669 …t for equal and non-equal comparisons for codegen This closes #23478 1.18 backport for parent PR https://github.com/apache/flink/pull/23478 ## What is the purpose of

[PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
fengjiajie opened a new pull request, #23668: URL: https://github.com/apache/flink/pull/23668 …t for equal and non-equal comparisons for codegen This closes #23478 1.17 backport for parent PR https://github.com/apache/flink/pull/23478 ## What is the purpose of

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-05 Thread via GitHub
leonardBang commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794172578 > Thanks @leonardBang, shall we remove `flink-table-planner-loader` dependency and replace it with `flink-table-planner-2.12`? `flink-table-planner-loader` is

[jira] [Commented] (FLINK-33171) Consistent implicit type coercion support for equal and non-equal comparisons for codegen

2023-11-05 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783106#comment-17783106 ] Jane Chan commented on FLINK-33171: --- Fixed in master 04b98e6e80ca3a68324775166dedb7d58ae4d60b >

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
LadyForest commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1794159224 Hi @fengjiajie, could you pick the fix to branch release-1.18 and release-1.17 as well? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-05 Thread via GitHub
Jiabao-Sun commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794157929 Thanks @leonardBang, shall we remove `flink-table-planner-loader` dependency and replace it with `flink-table-planner-2.12`? -- This is an automated message from the

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
LadyForest merged PR #23478: URL: https://github.com/apache/flink/pull/23478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-05 Thread via GitHub
leonardBang commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794153008 > Hi @xuyangzhong。 To implement the planner's test, the [flink-table-planner](https://issues.apache.org/jira/browse/FLINK-table-planner)_2.12 related dependencies need

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-05 Thread via GitHub
Jiabao-Sun commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794142093 Hi @leonardBang, could you help do the final check? I think we may introduce it in the release 1.18 version. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-32763][streaming-java] Uncaught exceptions cause retry does not … [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23667: URL: https://github.com/apache/flink/pull/23667#issuecomment-1794139627 ## CI report: * a21e88a92bee3aa6f9ab6750c46f9f4506c534db UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32763][streaming-java] Uncaught exceptions cause retry does not … [flink]

2023-11-05 Thread via GitHub
paul8263 opened a new pull request, #23667: URL: https://github.com/apache/flink/pull/23667 …take effect in SocketTextStreamFunction ## What is the purpose of the change Flink socket text stream connection cannot retry when it cannot connect to the designated host and

[jira] [Updated] (FLINK-32763) Uncaught exceptions cause retry not to take effect in SocketTextStreamFunction

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32763: --- Labels: pull-request-available (was: ) > Uncaught exceptions cause retry not to take

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-05 Thread via GitHub
KarmaGYZ commented on code in PR #23658: URL: https://github.com/apache/flink/pull/23658#discussion_r1382812017 ## flink-core/src/test/java/org/apache/flink/configuration/TaskManagerLoadBalanceModeTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-11-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783090#comment-17783090 ] Zakelly Lan commented on FLINK-20772: - Hi, [~dorbae]. Seems this is still valid in 1.18. Are you

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-05 Thread via GitHub
RocMarshal commented on code in PR #23658: URL: https://github.com/apache/flink/pull/23658#discussion_r1382783206 ## flink-core/src/test/java/org/apache/flink/configuration/TaskManagerLoadBalanceModeTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-05 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783089#comment-17783089 ] Yue Ma commented on FLINK-7: Update: [https://github.com/facebook/rocksdb/pull/11868] merged in

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-05 Thread via GitHub
masteryhx commented on code in PR #23441: URL: https://github.com/apache/flink/pull/23441#discussion_r1382767597 ## flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java: ## @@ -58,10 +58,11 @@ public interface AppendingState extends State { * of

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23666: URL: https://github.com/apache/flink/pull/23666#issuecomment-1794051414 ## CI report: * a6d7cf4800f6402a265b52433f010b007164d335 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-05 Thread via GitHub
liyubin117 commented on PR #23666: URL: https://github.com/apache/flink/pull/23666#issuecomment-1794045001 @WencongLiu I have finished the translation, PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-33445) Translate DataSet migration guideline to Chinese

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33445: --- Labels: pull-request-available starter (was: starter) > Translate DataSet migration

[PR] [FLINK-33445][docs-zh] Translate DataSet migration guideline to Chinese [flink]

2023-11-05 Thread via GitHub
liyubin117 opened a new pull request, #23666: URL: https://github.com/apache/flink/pull/23666 ## What is the purpose of the change Translate DataSet migration guideline to Chinese https://nightlies.apache.org/flink/flink-docs-master/zh/docs/dev/datastream/dataset_migration/

[jira] [Updated] (FLINK-5865) Throw original exception in states

2023-11-05 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-5865: Fix Version/s: 1.19.0 > Throw original exception in states > -- >

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-05 Thread via GitHub
RocMarshal commented on code in PR #23658: URL: https://github.com/apache/flink/pull/23658#discussion_r1382746995 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +711,49 @@ public class TaskManagerOptions {

[jira] [Resolved] (FLINK-5865) Throw original exception in states

2023-11-05 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-5865. - Resolution: Fixed merged cee2611e into master. About the [FLIP-368.

[jira] [Assigned] (FLINK-5865) Throw original exception in states

2023-11-05 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-5865: --- Assignee: Zakelly Lan > Throw original exception in states >

Re: [PR] [FLINK-5865][state] Unwrapping exceptions and throw the original ones in state interfaces [flink]

2023-11-05 Thread via GitHub
masteryhx closed pull request #23371: [FLINK-5865][state] Unwrapping exceptions and throw the original ones in state interfaces URL: https://github.com/apache/flink/pull/23371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-05 Thread via GitHub
Zakelly commented on code in PR #23441: URL: https://github.com/apache/flink/pull/23441#discussion_r1382739665 ## flink-core/src/main/java/org/apache/flink/api/common/state/ListState.java: ## @@ -48,10 +48,13 @@ public interface ListState extends MergingState> { * given

[jira] [Commented] (FLINK-32763) Uncaught exceptions cause retry not to take effect in SocketTextStreamFunction

2023-11-05 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783074#comment-17783074 ] Yao Zhang commented on FLINK-32763: --- Hi community, I got the same issue and wanna work on it. Could

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-05 Thread via GitHub
masteryhx commented on code in PR #23441: URL: https://github.com/apache/flink/pull/23441#discussion_r1382731932 ## flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java: ## @@ -58,10 +58,11 @@ public interface AppendingState extends State { * of

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-05 Thread via GitHub
KarmaGYZ commented on code in PR #23658: URL: https://github.com/apache/flink/pull/23658#discussion_r1382732177 ## flink-core/src/test/java/org/apache/flink/configuration/TaskManagerLoadBalanceModeTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level [flink]

2023-11-05 Thread via GitHub
masteryhx commented on PR #22800: URL: https://github.com/apache/flink/pull/22800#issuecomment-1793983788 > I'm closing that as I will be publishing a FLIP counter-proposal that uses tracing to achieve the same goal. Thanks @pnowojski for helping to push it forward, look forward to

Re: [PR] Draft [FLINK-28048] (CI) [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23665: URL: https://github.com/apache/flink/pull/23665#issuecomment-1793864899 ## CI report: * c39e1268d3bf6ea6d22dda5755837a1798159c8e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28048) Introduce Source API alternative to FiniteTestSource

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28048: --- Labels: pull-request-available (was: ) > Introduce Source API alternative to

[PR] Draft [FLINK-28048] (CI) [flink]

2023-11-05 Thread via GitHub
afedulov opened a new pull request, #23665: URL: https://github.com/apache/flink/pull/23665 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-05 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1382648870 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-05 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1793845354 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-05 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1382645917 ## flink-formats/flink-avro/src/test/java/org/apache/flink/table/runtime/batch/AvroTypesITCase.java: ## @@ -240,7 +240,7 @@ public void testAvroToAvro() { }

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-05 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1382643573 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -123,7

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-05 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1382643298 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1188,14 +1191,14 @@ void

[jira] [Commented] (FLINK-33300) Update testcontainers dependency to v1.19.1

2023-11-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782993#comment-17782993 ] Sergey Nuyanzin commented on FLINK-33300: - Merged as

[jira] [Updated] (FLINK-33300) Update testcontainers dependency to v1.19.1

2023-11-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33300: Fix Version/s: 1.19.0 > Update testcontainers dependency to v1.19.1 >

[jira] [Resolved] (FLINK-33300) Update testcontainers dependency to v1.19.1

2023-11-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33300. - Resolution: Fixed > Update testcontainers dependency to v1.19.1 >

[jira] [Assigned] (FLINK-33300) Update testcontainers dependency to v1.19.1

2023-11-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33300: --- Assignee: Sergey Nuyanzin > Update testcontainers dependency to v1.19.1 >

Re: [PR] [FLINK-33300] Upgrade testcontainers from 1.18.3 to 1.19.1 [flink]

2023-11-05 Thread via GitHub
snuyanzin merged PR #23537: URL: https://github.com/apache/flink/pull/23537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33300] Upgrade testcontainers from 1.18.3 to 1.19.1 [flink]

2023-11-05 Thread via GitHub
snuyanzin commented on PR #23537: URL: https://github.com/apache/flink/pull/23537#issuecomment-1793759229 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-05 Thread via GitHub
flinkbot commented on PR #23664: URL: https://github.com/apache/flink/pull/23664#issuecomment-1793757644 ## CI report: * f2aa5883e67f13ff7b664b3b3f7f851a30488e92 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33331] Update netty to 4.1.100 and arrow to 13.0.0 to make flink-python passing on java 21 [flink]

2023-11-05 Thread via GitHub
snuyanzin opened a new pull request, #23664: URL: https://github.com/apache/flink/pull/23664 ## What is the purpose of the change To support java 21. Since JDK21 there was removed of constructor within https://bugs.openjdk.org/browse/JDK-8303083 Netty should support it and the

[jira] [Reopened] (FLINK-33331) Upgrade netty to 4.1.93+

2023-11-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-1: - Sorry, probably I wasn't clear enough Need to reopen this because to fix we need to update

[jira] [Commented] (FLINK-33458) Add env.java.opts.gateway option in flink-conf.yaml

2023-11-05 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782983#comment-17782983 ] xiangyu feng commented on FLINK-33458: -- Hi [~agsharath], thx for reporting this. However, I think

[jira] [Comment Edited] (FLINK-25420) Port JDBC Source to new Source API (FLIP-27)

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782972#comment-17782972 ] RocMarshal edited comment on FLINK-25420 at 11/5/23 10:09 AM: -- Hi,

[jira] [Commented] (FLINK-25420) Port JDBC Source to new Source API (FLIP-27)

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782972#comment-17782972 ] RocMarshal commented on FLINK-25420: Hi, [~martijnvisser] [~eskabetxe]  I have divided the work

[jira] [Comment Edited] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782969#comment-17782969 ] RocMarshal edited comment on FLINK-33463 at 11/5/23 9:36 AM: - The ticket is

[jira] [Updated] (FLINK-33459) Support the new source that keeps the same functionality as the original JDBC input format

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33459: --- Labels: pull-request-available (was: ) > Support the new source that keeps the same

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-05 Thread via GitHub
boring-cyborg[bot] commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-1793683582 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-05 Thread via GitHub
RocMarshal opened a new pull request, #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78 # Main change - [FLINK-33459][Connector/JDBC] Add dependency items about flink-connector-base and testing into the pom.xml - [FLINK-33459][Connector/JDBC] Support the new source

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782969#comment-17782969 ] RocMarshal commented on FLINK-33463: The ticket is mainly to do the two items: 1. Support the

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-11-05 Thread via GitHub
LadyForest commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1793681676 > @lincoln-lil @LadyForest When you have time, please take a look if any further modifications are needed, thanks. I'm sorry for the late reply; I'll take a look as soon as

[jira] [Commented] (FLINK-33459) Support the new source that keeps the same functionality as the original JDBC input format

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782968#comment-17782968 ] RocMarshal commented on FLINK-33459: The ticket is mainly to do the two items: 1. Support the new

[jira] [Created] (FLINK-33462) Sort out the document page about the new Jdbc source.

2023-11-05 Thread RocMarshal (Jira)
RocMarshal created FLINK-33462: -- Summary: Sort out the document page about the new Jdbc source. Key: FLINK-33462 URL: https://issues.apache.org/jira/browse/FLINK-33462 Project: Flink Issue

[jira] [Updated] (FLINK-33459) Support the new source that keeps the same functionality as the original JDBC input format

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33459: --- Summary: Support the new source that keeps the same functionality as the original JDBC input format

[jira] [Created] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2023-11-05 Thread RocMarshal (Jira)
RocMarshal created FLINK-33463: -- Summary: Support the implementation of dynamic source tables based on the new source Key: FLINK-33463 URL: https://issues.apache.org/jira/browse/FLINK-33463 Project:

[jira] [Created] (FLINK-33461) Support stream related semantics for the new jdbc source

2023-11-05 Thread RocMarshal (Jira)
RocMarshal created FLINK-33461: -- Summary: Support stream related semantics for the new jdbc source Key: FLINK-33461 URL: https://issues.apache.org/jira/browse/FLINK-33461 Project: Flink Issue

[jira] [Updated] (FLINK-33459) Support the new source that supports the same functionality as the original JDBC input format

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33459: --- Summary: Support the new source that supports the same functionality as the original JDBC input

[jira] [Updated] (FLINK-33459) Port the new source that supports the same functionality as the original JDBC input format

2023-11-05 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33459: --- Summary: Port the new source that supports the same functionality as the original JDBC input format

[jira] [Created] (FLINK-33460) Support more authentication connection types such as the secret.

2023-11-05 Thread RocMarshal (Jira)
RocMarshal created FLINK-33460: -- Summary: Support more authentication connection types such as the secret. Key: FLINK-33460 URL: https://issues.apache.org/jira/browse/FLINK-33460 Project: Flink

[jira] [Created] (FLINK-33459) Introduce the new source that supports the same functionality as the original JDBC input format

2023-11-05 Thread RocMarshal (Jira)
RocMarshal created FLINK-33459: -- Summary: Introduce the new source that supports the same functionality as the original JDBC input format Key: FLINK-33459 URL: https://issues.apache.org/jira/browse/FLINK-33459