Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4987#discussion_r155802027
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -27,8 +27,6 @@
/**
* Interface for a metric
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4988#discussion_r155797999
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320903
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5107
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320952
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5086
LGTM
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155549755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
@@ -32,6 +34,20 @@
*/
public interface LogicalSlot
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5090#discussion_r155496482
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -383,6 +386,76 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155502971
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/TestingAllocatedSlotActions.java
---
@@ -0,0 +1,53
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5090#discussion_r155495322
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -383,6 +386,76 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155503994
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155503866
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155507294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155507607
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155519870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155528224
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155520946
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -0,0 +1,722 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155590317
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155604499
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155605251
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155279729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155296898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/AllocatedSlot.java
---
@@ -144,6 +144,78 @@ public TaskManagerGateway
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155276432
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155207330
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -965,11 +965,20 @@ public void cancel
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155208534
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155225733
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/LogicalSlot.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155227397
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -208,27 +209,61 @@ public void setLocality(Locality locality
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155258087
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java
---
@@ -31,7 +30,7 @@
import static
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155240139
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245771
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242108
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242900
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242826
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r154954054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java
---
@@ -37,16 +41,18 @@
* If this slot is part of a {@link
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147656743
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679162
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147681959
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147677068
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147678610
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -194,29 +348,4 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147686546
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147687302
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -922,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147687514
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -362,4 +483,39 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147667457
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147678943
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -442,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679597
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679516
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147680902
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147681520
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147717560
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147689963
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147741136
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147736898
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147735664
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Tests.java
---
@@ -83,49
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147739898
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754127
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754468
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5194
[FLINK-8233][flip6] Add JobExecutionResultHandler
## What is the purpose of the change
*Allow retrieval of the JobExecutionResult cached in Dispatcher via HTTP.
This will be needed so
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r158081176
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java
---
@@ -0,0 +1,153
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r158078273
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java
---
@@ -0,0 +1,153
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158264752
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/StreamingProgramTestBase.java
---
@@ -66,47 +47,34
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158265225
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158254745
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158257284
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259149
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -215,23
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259995
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
---
@@ -55,6 +55,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158260663
--- Diff:
flink-examples/flink-examples-streaming/src/test/scala/org/apache/flink/streaming/scala/examples/StreamingExamplesITCase.scala
---
@@ -23,8 +23,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158261437
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -18,8 +18,8 @@
package
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5973
[FLINK-9261][ssl] Fix SSL support for REST API and Web UI.
## What is the purpose of the change
*Fix SSL support for REST API and Web UI.*
cc: @tillrohrmann @StephanEwen @zentol
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5931
[FLINK-9190][flip6,yarn] Request new container if container completed
unexpectedly
## What is the purpose of the change
*Request new YARN container if container completed unexpectedly
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5938
[FLINK-9196][flip6, yarn] Cleanup application files when deregistering YARN
AM
## What is the purpose of the change
*Ensure that YARN application files are removed if cluster is shutdown
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5938#discussion_r184848405
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -265,6 +264,20 @@ public void waitForClusterToBeReady
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5938#discussion_r184848340
--- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java ---
@@ -18,227 +18,35 @@
package org.apache.flink.yarn;
-import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5938#discussion_r184848354
--- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java ---
@@ -18,227 +18,35 @@
package org.apache.flink.yarn;
-import
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5966
I will take a look at this later today.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5973#discussion_r187194770
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -81,16 +85,62 @@ public static void
setSSLVerAndCipherSuites
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5966
This is relevant
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Discuss-FLIP-26-SSL-Mutual-Authentication-td22188.html
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5931#discussion_r187466146
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -293,21 +293,16 @@ public void startNewWorker(ResourceProfile
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5973
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5297
Thank you for your contribution @shuai-xu. Unfortunately this is a
duplicate of FLINK-7805. Can you close this PR?
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189013436
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -947,6 +964,36 @@ private void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r188992099
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -232,8 +239,10 @@ public TaskExecutor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189004280
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
---
@@ -50,8 +50,11 @@
private final String
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189012246
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -947,6 +964,36 @@ private void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189004536
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -1605,9 +1609,16 @@ public void notifyHeartbeatTimeout(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190500268
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190548385
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190548607
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190650550
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190658100
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190888216
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190654087
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -151,7 +151,9 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190888669
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +40,36
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190887946
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190647503
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -43,14 +49,27
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190648628
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +40,36
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603900
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -732,19 +744,10 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190602807
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
---
@@ -1139,6 +1147,61 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190602158
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
101 - 200 of 690 matches
Mail list logo