[GitHub] [flink] TanYuxin-tyx commented on pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread GitBox
TanYuxin-tyx commented on PR #21620: URL: https://github.com/apache/flink/pull/21620#issuecomment-1383743282 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] NightRunner opened a new pull request, #21685: [FLINK-30696][docs]Translate "join" page of "Querys" into Chinese

2023-01-16 Thread GitBox
NightRunner opened a new pull request, #21685: URL: https://github.com/apache/flink/pull/21685 Page "Application Development"/"Table API&SQL"/"SQL"/"Queries"/joins translate to chinese. ## What is the purpose of the change Translate /dev/table/sql/queries/joins.md ## Bri

[GitHub] [flink] beyond1920 closed pull request #21642: [FLINK-30617][hive] fix wrong data type for cast null literal with Hive dialect

2023-01-16 Thread GitBox
beyond1920 closed pull request #21642: [FLINK-30617][hive] fix wrong data type for cast null literal with Hive dialect URL: https://github.com/apache/flink/pull/21642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #480: [FLINK-27845] Support column type evolution for file data

2023-01-16 Thread GitBox
JingsongLi commented on code in PR #480: URL: https://github.com/apache/flink-table-store/pull/480#discussion_r1071001147 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/file/predicate/LeafPredicate.java: ## @@ -84,7 +99,10 @@ public List literals() {

[GitHub] [flink-table-store] JingsongLi merged pull request #483: [FLINK-30676] Introduce Data Structures for table store

2023-01-16 Thread GitBox
JingsongLi merged PR #483: URL: https://github.com/apache/flink-table-store/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] wanglijie95 closed pull request #21646: [FLINK-30631][runtime] Limit the max number of subpartitons consumed by each downstream task

2023-01-16 Thread GitBox
wanglijie95 closed pull request #21646: [FLINK-30631][runtime] Limit the max number of subpartitons consumed by each downstream task URL: https://github.com/apache/flink/pull/21646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-table-store] yuzelin commented on pull request #483: [FLINK-30676] Introduce Data Structures for table store

2023-01-16 Thread GitBox
yuzelin commented on PR #483: URL: https://github.com/apache/flink-table-store/pull/483#issuecomment-1383711434 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-16 Thread GitBox
wanglijie95 commented on code in PR #21621: URL: https://github.com/apache/flink/pull/21621#discussion_r1070990867 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtilsTest.java: ## @@ -95,6 +100,163 @@ void testGetRecordProcessor2() th

[GitHub] [flink] luoyuxia commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-16 Thread GitBox
luoyuxia commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070986478 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,63 @@ public void testSumAggWi

[GitHub] [flink] TanYuxin-tyx commented on pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread GitBox
TanYuxin-tyx commented on PR #21620: URL: https://github.com/apache/flink/pull/21620#issuecomment-1383698017 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] thexiay commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-16 Thread GitBox
thexiay commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1070972564 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1400,6 +1411,23 @@ public TableResultInternal ex

[GitHub] [flink] dannycranmer merged pull request #21652: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for 1.16

2023-01-16 Thread GitBox
dannycranmer merged PR #21652: URL: https://github.com/apache/flink/pull/21652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] thebalu commented on pull request #16927: [FLINK-18592][Connectors/FileSystem] StreamingFileSink fails due to truncating HDFS file failure

2023-01-16 Thread GitBox
thebalu commented on PR #16927: URL: https://github.com/apache/flink/pull/16927#issuecomment-1383659568 Thanks for your answer. Let me know if I can help with testing somehow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070948002 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateSpecUitls.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070945584 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink] luoyuxia commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070925261 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,63 @@ public void testSumAggWi

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-15 Thread GitBox
zhuzhurk commented on code in PR #21621: URL: https://github.com/apache/flink/pull/21621#discussion_r107091 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordProcessorUtils.java: ## @@ -86,6 +118,71 @@ public static ThrowingConsumer, Excepti

[GitHub] [flink] xintongsong commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
xintongsong commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070900657 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Softw

[GitHub] [flink] luoyuxia commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1070910506 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/DeletePushDownUtils.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apach

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070910191 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,63 @@ public void testSumAggWi

[GitHub] [flink] luoyuxia commented on pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on PR #21257: URL: https://github.com/apache/flink/pull/21257#issuecomment-1383600766 @lsyldliu Thanks for contribution. I have addressed your comments. For the parallelism of `CompactOperator` in aqe , I have created FLINK-29635 to track it. -- This is an automa

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070904577 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,63 @@ public void testSumAggWi

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070898438 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,63 @@ public void testSumAggWi

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070897568 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] JunRuiLee commented on pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-15 Thread GitBox
JunRuiLee commented on PR #21672: URL: https://github.com/apache/flink/pull/21672#issuecomment-1383573928 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] TanYuxin-tyx commented on pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on PR #21620: URL: https://github.com/apache/flink/pull/21620#issuecomment-1383572580 Thanks for helping review the change. I have resolved the conflicts and updated the PR. Could you please help review it again? @xintongsong -- This is an automated message fro

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070892251 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchPartitionCommitterSink.java: ## @@ -0,0 +1,139 @@ +/*

[GitHub] [flink-table-store] zjureel opened a new pull request, #484: [FLINK-30516] Introduce files table in table store

2023-01-15 Thread GitBox
zjureel opened a new pull request, #484: URL: https://github.com/apache/flink-table-store/pull/484 Introduce files table in Table Store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070891601 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070891141 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] X-czh commented on pull request #21673: [FLINK-30513] Cleanup HA storage path on cluster termination

2023-01-15 Thread GitBox
X-czh commented on PR #21673: URL: https://github.com/apache/flink/pull/21673#issuecomment-1383570619 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070890795 ## flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleUtils.java: ## @@ -119,6 +139,82 @@ public static int computeNetworkBuffersForAnnouncin

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070890360 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070890224 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -225,6 +225,35 @@ public class NettyShuffleEnvironmentOptions

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
TanYuxin-tyx commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070890650 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpec.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] JunRuiLee commented on pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-15 Thread GitBox
JunRuiLee commented on PR #21672: URL: https://github.com/apache/flink/pull/21672#issuecomment-1383568933 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070885603 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionLoader.java: ## @@ -76,7 +76,8 @@ public PartitionLoader( }

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070884810 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchFileWriter.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed

[GitHub] [flink] thexiay commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-15 Thread GitBox
thexiay commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1070884554 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/DeletePushDownUtils.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070883134 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionWriter.java: ## @@ -62,4 +62,24 @@ OutputFormat createNewOutputF

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070883134 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionWriter.java: ## @@ -62,4 +62,24 @@ OutputFormat createNewOutputF

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070878161 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070878161 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] luoyuxia commented on pull request #21658: [FLINK-30661][table]Introduce interfaces for Delete/Update

2023-01-15 Thread GitBox
luoyuxia commented on PR #21658: URL: https://github.com/apache/flink/pull/21658#issuecomment-1383550093 @LadyForest @lincoln-lil Thanks for your reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink] luoyuxia commented on a diff in pull request #21658: [FLINK-30661][table]Introduce interfaces for Delete/Update

2023-01-15 Thread GitBox
luoyuxia commented on code in PR #21658: URL: https://github.com/apache/flink/pull/21658#discussion_r1070871519 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/abilities/SupportsRowLevelDelete.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to t

[GitHub] [flink] wanglijie95 commented on pull request #21646: [FLINK-30631][runtime] Limit the max number of subpartitons consumed by each downstream task

2023-01-15 Thread GitBox
wanglijie95 commented on PR #21646: URL: https://github.com/apache/flink/pull/21646#issuecomment-1383531832 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #483: [FLINK-30676] Introduce Data Structures for table store

2023-01-15 Thread GitBox
JingsongLi opened a new pull request, #483: URL: https://github.com/apache/flink-table-store/pull/483 - Introduce new Data Structures - Use new Data Types and Data Structures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #21684: [FLINK-30694][docs]Translate /dev/table/sql/queries/window-tvf

2023-01-15 Thread GitBox
flinkbot commented on PR #21684: URL: https://github.com/apache/flink/pull/21684#issuecomment-1383494024 ## CI report: * 366aa425f0b85e78796941e5d7c3c3aa28ff7002 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] NightRunner opened a new pull request, #21684: [FLINK-30694][docs]Translate /dev/table/sql/queries/window-tvf

2023-01-15 Thread GitBox
NightRunner opened a new pull request, #21684: URL: https://github.com/apache/flink/pull/21684 Page "Application Development"/"Table API&SQL"/"SQL"/"Queries"/Windows TVF translate to chinese. ## What is the purpose of the change Translate /dev/table/sql/queries/window-tvf.md

[GitHub] [flink] NightRunner closed pull request #21682: [FLINK-30694][docs]Translate /dev/table/sql/queries/window-tvf.md

2023-01-15 Thread GitBox
NightRunner closed pull request #21682: [FLINK-30694][docs]Translate /dev/table/sql/queries/window-tvf.md URL: https://github.com/apache/flink/pull/21682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] lsyldliu commented on a diff in pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21608: URL: https://github.com/apache/flink/pull/21608#discussion_r1070834501 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,87 @@ public void testSumAggWi

[GitHub] [flink] godfreyhe commented on a diff in pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

2023-01-15 Thread GitBox
godfreyhe commented on code in PR #21608: URL: https://github.com/apache/flink/pull/21608#discussion_r1070833459 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,87 @@ public void testSumAggW

[GitHub] [flink] godfreyhe commented on a diff in pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

2023-01-15 Thread GitBox
godfreyhe commented on code in PR #21608: URL: https://github.com/apache/flink/pull/21608#discussion_r1070833142 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java: ## @@ -1062,6 +1062,87 @@ public void testSumAggW

[GitHub] [flink] flinkbot commented on pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-15 Thread GitBox
flinkbot commented on PR #21683: URL: https://github.com/apache/flink/pull/21683#issuecomment-1383463668 ## CI report: * e0f770c958d667db2d38d0528b9fc63d75aced96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest opened a new pull request, #21683: [FLINK-30672][sql-parser] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-15 Thread GitBox
LadyForest opened a new pull request, #21683: URL: https://github.com/apache/flink/pull/21683 ## What is the purpose of the change This pull request supports the `EXPLAIN PLAN_ADVICE` statement. ## Brief change log - e0f770c9 supports SQL syntax - TODO ## Ve

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21658: [FLINK-30661][table]Introduce interfaces for Delete/Update

2023-01-15 Thread GitBox
lincoln-lil commented on code in PR #21658: URL: https://github.com/apache/flink/pull/21658#discussion_r1070792730 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsRowLevelModificationScan.java: ## @@ -0,0 +1,80 @@ +/* + *

[GitHub] [flink] flinkbot commented on pull request #21682: Translate /dev/table/sql/queries/window-tvf.md

2023-01-15 Thread GitBox
flinkbot commented on PR #21682: URL: https://github.com/apache/flink/pull/21682#issuecomment-1383452082 ## CI report: * 1b19856e2279fc2119314ffe23cc8f2dae3432df UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] NightRunner opened a new pull request, #21682: Translate /dev/table/sql/queries/window-tvf.md

2023-01-15 Thread GitBox
NightRunner opened a new pull request, #21682: URL: https://github.com/apache/flink/pull/21682 Page "Application Development"/"Table API&SQL"/"SQL"/"Queries"/jions translate to chinese. ## What is the purpose of the change Translate /dev/table/sql/queries/window-tvf.md #

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-15 Thread GitBox
lindong28 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1070769249 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/metrics/MLMetrics.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [flink] flinkbot commented on pull request #21681: [FLINK-18397][docs-zh] Translate "Table & SQL Connectors Overview" pa…

2023-01-15 Thread GitBox
flinkbot commented on PR #21681: URL: https://github.com/apache/flink/pull/21681#issuecomment-1383439136 ## CI report: * 2c8f06d74c3c48c3ba567e8dc21ce0f1ba3b2e5b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Jrebel-i opened a new pull request, #21681: [FLINK-18397][docs-zh] Translate "Table & SQL Connectors Overview" pa…

2023-01-15 Thread GitBox
Jrebel-i opened a new pull request, #21681: URL: https://github.com/apache/flink/pull/21681 ## What is the purpose of the change [FLINK-18397](https://issues.apache.org/jira/browse/FLINK-18397) Translate "Table & SQL Connectors Overview" page into Chinese. The page url is ht

[GitHub] [flink] yunfengzhou-hub commented on pull request #21680: [FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7

2023-01-15 Thread GitBox
yunfengzhou-hub commented on PR #21680: URL: https://github.com/apache/flink/pull/21680#issuecomment-1383431886 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] flinkbot commented on pull request #21680: [FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7

2023-01-15 Thread GitBox
flinkbot commented on PR #21680: URL: https://github.com/apache/flink/pull/21680#issuecomment-1383431236 ## CI report: * a78b7a8e95f7a0ad8148c14dd94dd495b8229f0a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21679: [FLINK-30561][state/changelog] fix changelog local cache file not found

2023-01-15 Thread GitBox
flinkbot commented on PR #21679: URL: https://github.com/apache/flink/pull/21679#issuecomment-1383427385 ## CI report: * 7cd37c90646b3713f4e734741b9074223c762932 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yunfengzhou-hub opened a new pull request, #21680: [FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7

2023-01-15 Thread GitBox
yunfengzhou-hub opened a new pull request, #21680: URL: https://github.com/apache/flink/pull/21680 ## What is the purpose of the change - Updating net.sf.py4j:py4j from 0.10.9.3 to 0.10.9.7 ## Brief change log - Updated POM, Python dev requirements & setup, NOTICE file

[GitHub] [flink] xintongsong commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-15 Thread GitBox
xintongsong commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1070766952 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -225,6 +225,35 @@ public class NettyShuffleEnvironmentOptions

[GitHub] [flink] zoltar9264 opened a new pull request, #21679: [FLINK-30561][state/changelog] fix changelog local cache file not found

2023-01-15 Thread GitBox
zoltar9264 opened a new pull request, #21679: URL: https://github.com/apache/flink/pull/21679 ## What is the purpose of the change Fix the changelog local cache file not found while restarting, described in [FLINK-30561](https://issues.apache.org/jira/browse/FLINK-30561). ## B

[GitHub] [flink] LadyForest commented on a diff in pull request #21658: [FLINK-30661][table]Introduce interfaces for Delete/Update

2023-01-15 Thread GitBox
LadyForest commented on code in PR #21658: URL: https://github.com/apache/flink/pull/21658#discussion_r1070788300 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/abilities/SupportsRowLevelDelete.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-01-15 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1070782561 ## flink-ml-lib/src/test/java/org/apache/flink/ml/recommendation/SwingTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink] lsyldliu commented on pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on PR #21605: URL: https://github.com/apache/flink/pull/21605#issuecomment-1383400146 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] lsyldliu commented on a diff in pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21629: URL: https://github.com/apache/flink/pull/21629#discussion_r1070778492 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java: ## @@ -310,7 +311,11 @@ public TOpenSessionResp O

[GitHub] [flink] xintongsong closed pull request #21603: [FLINK-30332] HsFileDataIndex supports caching and spilling index entry

2023-01-15 Thread GitBox
xintongsong closed pull request #21603: [FLINK-30332] HsFileDataIndex supports caching and spilling index entry URL: https://github.com/apache/flink/pull/21603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] masteryhx commented on pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-15 Thread GitBox
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1383361255 @gaoyunhaii @dawidwys Could you help to take a review ? I'd like to make it usable in 1.17. Thanks a lot! -- This is an automated message from the Apache Git Service. To respon

[GitHub] [flink] masteryhx commented on pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-15 Thread GitBox
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1383357691 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] Myracle commented on pull request #21661: [FLINK-30629][Client/Job Submission] Fix the unstable test ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat

2023-01-15 Thread GitBox
Myracle commented on PR #21661: URL: https://github.com/apache/flink/pull/21661#issuecomment-1383357574 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] lindong28 merged pull request #200: [FLINK-30578][build] Publish SBOM artifacts

2023-01-15 Thread GitBox
lindong28 merged PR #200: URL: https://github.com/apache/flink-ml/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #200: [FLINK-30578][build] Publish SBOM artifacts

2023-01-15 Thread GitBox
lindong28 commented on PR #200: URL: https://github.com/apache/flink-ml/pull/200#issuecomment-1383342110 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] dianfu closed pull request #21664: [FLINK-30168][python] Fix DataStream.execute_and_collect to support None data and ObjectArray

2023-01-15 Thread GitBox
dianfu closed pull request #21664: [FLINK-30168][python] Fix DataStream.execute_and_collect to support None data and ObjectArray URL: https://github.com/apache/flink/pull/21664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] dianfu closed pull request #21655: [FLINK-29231][python] Fix the issue that Python UDAF may produce multiple results for the same window

2023-01-15 Thread GitBox
dianfu closed pull request #21655: [FLINK-29231][python] Fix the issue that Python UDAF may produce multiple results for the same window URL: https://github.com/apache/flink/pull/21655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-table-store] zjureel commented on pull request #480: [FLINK-27845] Support column type evolution for file data

2023-01-15 Thread GitBox
zjureel commented on PR #480: URL: https://github.com/apache/flink-table-store/pull/480#issuecomment-1383320635 > You can rebase latest master. Thanks @JingsongLi I have rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #21678: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

2023-01-15 Thread GitBox
flinkbot commented on PR #21678: URL: https://github.com/apache/flink/pull/21678#issuecomment-1383215782 ## CI report: * c75d60987e3ee5c9605419743c5c9319bc693eff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] chenqin opened a new pull request, #21678: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

2023-01-15 Thread GitBox
chenqin opened a new pull request, #21678: URL: https://github.com/apache/flink/pull/21678 ## What is the purpose of the change To externalize Hive connector, we propose moving flink-sql-parser-hive into hive connector to maintain and release together. Given related class were code g

[GitHub] [flink] chenqin closed pull request #21669: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

2023-01-15 Thread GitBox
chenqin closed pull request #21669: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive URL: https://github.com/apache/flink/pull/21669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-connector-hive] chenqin closed pull request #3: [FLINK-30064] [hive] Move connectors/hive to external repo, support 1.16/1.17 with FlinkPlannerCalciteShim

2023-01-15 Thread GitBox
chenqin closed pull request #3: [FLINK-30064] [hive] Move connectors/hive to external repo, support 1.16/1.17 with FlinkPlannerCalciteShim URL: https://github.com/apache/flink-connector-hive/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070633779 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070625882 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1070624894 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21629: URL: https://github.com/apache/flink/pull/21629#discussion_r1070621229 ## flink-table/flink-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/session/FunctionCreator.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache

[GitHub] [flink] lincoln-lil closed pull request #21662: [FLINK-30668][table-api] Introduce ExplainFormat to Explainable and TableEnvironment

2023-01-15 Thread GitBox
lincoln-lil closed pull request #21662: [FLINK-30668][table-api] Introduce ExplainFormat to Explainable and TableEnvironment URL: https://github.com/apache/flink/pull/21662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] JunRuiLee commented on pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-15 Thread GitBox
JunRuiLee commented on PR #21672: URL: https://github.com/apache/flink/pull/21672#issuecomment-1383158956 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #21677: [FLINK-30693] Introduce RowFormat to SQL Gateway

2023-01-15 Thread GitBox
flinkbot commented on PR #21677: URL: https://github.com/apache/flink/pull/21677#issuecomment-1383149075 ## CI report: * 6e921d334595aec269b0236e84cb726748bcb8a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yuzelin opened a new pull request, #21677: [FLINK-30693] Introduce RowFormat to SQL Gateway

2023-01-15 Thread GitBox
yuzelin opened a new pull request, #21677: URL: https://github.com/apache/flink/pull/21677 ## What is the purpose of the change Currently, the SQL gateway only sends JSON-formatted result to REST endpoint. So this PR introduces RowFormat to control the result format.

[GitHub] [flink-ml] jiangxin369 commented on pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-15 Thread GitBox
jiangxin369 commented on PR #196: URL: https://github.com/apache/flink-ml/pull/196#issuecomment-1383146696 @zhipeng93 Thanks for the updates, LGTM. @lindong28 Could you take a look at the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink] lsyldliu commented on a diff in pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21605: URL: https://github.com/apache/flink/pull/21605#discussion_r1070563021 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveMaxAggFunction.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apac

[GitHub] [flink] lsyldliu commented on pull request #21596: [FLINK-29719][hive] Supports native count function for hive dialect

2023-01-15 Thread GitBox
lsyldliu commented on PR #21596: URL: https://github.com/apache/flink/pull/21596#issuecomment-1383119790 @luoyuxia Thanks for reviewing, I've addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-15 Thread GitBox
lsyldliu commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1070527675 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/SingleDirectoryWriter.java: ## @@ -50,21 +51,32 @@ public SingleDirectory

[GitHub] [flink] fsk119 merged pull request #21640: [FLINK-19883][table] Support "IF EXISTS" in DDL for ALTER TABLE

2023-01-15 Thread GitBox
fsk119 merged PR #21640: URL: https://github.com/apache/flink/pull/21640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] flinkbot commented on pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-15 Thread GitBox
flinkbot commented on PR #21676: URL: https://github.com/apache/flink/pull/21676#issuecomment-1383106462 ## CI report: * a58431deeed8ea46901be338cf39b2ec1b2c0507 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fsk119 commented on pull request #21665: [FLINK-30675][sql-client] Decompose query result print from Executor

2023-01-15 Thread GitBox
fsk119 commented on PR #21665: URL: https://github.com/apache/flink/pull/21665#issuecomment-1383105469 cc @LadyForest @lincoln-lil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] luoyuxia opened a new pull request, #21676: [FLINK-30662][table] Planner supports delete

2023-01-15 Thread GitBox
luoyuxia opened a new pull request, #21676: URL: https://github.com/apache/flink/pull/21676 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

<    2   3   4   5   6   7   8   9   10   11   >