Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
@StefanRRichter I think I was faster ... ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r106659109
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigration11to13Test.java
---
@@ -0,0 +1,268 @@
+/*
+ * Licensed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r106659165
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigration11to13Test.java
---
@@ -0,0 +1,268 @@
+/*
+ * Licensed
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3562
[FLINK-6018] Add tests for KryoSerializer restore with registered types
This is the result of the discussion in #3534.
I changed `TypeSerializer.isCompatibleWith()` to
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
We can deprecate, because it was added to provide a smooth path from Flink
1.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106684096
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -567,6 +600,17 @@ protected
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3484
Thanks for reviewing again, @kl0u! I incorporated all your suggestions. I'm
now waiting for travis to give the green light and then I'll merge.
@chenqin A lot of thanks also
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106685158
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
---
@@ -48,15 +49,25 @@
* output selection
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin I finally merged it. Could you please also close this PR?
And thanks again for working on this for so long! ð
---
If your project is set up for it, you can reply to this email
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3535
@StephanEwen do you think this is enough for Flink 1.2.1 or should we do
the full https://issues.apache.org/jira/browse/FLINK-5972 that throws an error
if users have shrinking merging windows
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3567
[FLINK-6107] Add custom checkstyle for flink-streaming-java
I played around with this a bit over the weekend... ð
This is a proposal for a way forward from the discussion on code style
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
Thanks for reviewing! ð
And yes, the classes I removed where unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3567#discussion_r106853548
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/windowing/delta/extractor/ArrayFromTuple.java
---
@@ -28,7 +28,7
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106854612
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3561
Thanks for reminding, @uce ð Already had this on my list.
The only code that reads the DEFAULT_PARALLELISM from the config should be
in this piece of code in `CliFrontend`:
https
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3557
It would be good to also have a test for this.
R: @kl0u could you please have a look? Now it's not much but with adding a
test it's more than just one line. ð
---
If your
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
In the ML discussion "Google code style" was repeatedly brought up
(initially by me):
https://lists.apache.org/thread.html/94c8c5186b315c58c3f8aaf536501b99e8b92ee97b0034
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Don't worry. ð Is it ready for another review pass now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
We will need at least two: the existing checkstyle for all the other
modules and the new strict style. (We might get away with having one checkstyle
and per-module suppression files that deactivate
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3587
[FLINK-5972] Don't allow shrinking merging windows
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3535
Closing in favour of #3587 which ensures that the situation this PR fixes
cannot occur in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
@StephanEwen this is the better alternative to #3535 in that it doesn't
silently drop windows and throws an exception when window shrinking occurs.
---
If your project is set up for it, yo
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Ok, please ping me when you pushed the fix. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107186780
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
AFAIK it's not possible to make IntelliJ pick up the checkstyle config by
itself. On my machine the setting is in the "*.iml" project file and I think we
have so far not includ
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
@zentol I added a section to our IDE setup Guide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107445929
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -122,6 +121,20
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107445987
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -122,6 +121,20
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107446384
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -352,6 +352,20 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107446308
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -138,7 +138,7
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107446618
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -574,7 +588,7 @@ private
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107450009
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107471533
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107473789
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107474350
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107475345
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java
---
@@ -0,0
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3597
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks for the thorough review, @tzulitai!
And shame over my head for all the code duplication ð±
I now refactored the contract tests into a base class and addressed all the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3562
@tzulitai I would suggest you open a PR with two commits: mine and your
changes on top. What do you think? Then I would close this PR.
---
If your project is set up for it, you can reply to this
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3562
Closing in favour of #3603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3603#discussion_r107692914
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -368,18 +388,29 @@ public void
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3603
your fixes (and especially comments) look good. ð
I think we can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks for merging, @tzulitai! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107704402
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3567#discussion_r107946611
--- Diff: tools/maven/strict-checkstyle.xml ---
@@ -0,0 +1,550 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
I have no preference for any style of import order. I just wanted to
mandate some order so that we don't have edit wars when people use different
IDE settings.
@greghogan Have you
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Thanks for implementing this! ð
I just merged, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3616
[FLINK-6188] Correctly handle PARALLELISM_DEFAULT in stream operator
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3590
@rtudoran Which state backend did you use? I think this can have a great
impact on performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Hehe, thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3567#discussion_r108058013
--- Diff: tools/maven/strict-checkstyle.xml ---
@@ -0,0 +1,550 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
@greghogan Now I'm confused. ð
Are you suggesting we use the Google
style or switch to the default IntelliJ style?
---
If your project is set up for it, you can reply to this email and
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3616
This is not completely done yet. It seems I still have to change when max
parallelism is instantiated for this to work.
---
If your project is set up for it, you can reply to this email and have
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3616#discussion_r108977470
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java
---
@@ -202,7 +203,17 @@ public int
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3616#discussion_r108977967
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java
---
@@ -221,10 +232,19 @@ public int
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3616
@greghogan @kl0u I addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
@StefanRRichter and @tzulitai what's the state of this? Can we go forward
with calling it union state?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3661
Thanks for opening this PR. ð
I had a few comments and I think it's easier to collect them here instead
of commenting on the individual files:
- I would prefer to not
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
This looks very good. ð
And yes, I would be in favour of deprecating `ListCheckpointed` but let's
see what @StefanRRichter and @StephanEwen think.
---
If your project is set up f
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3662
[FLINK-6246] Fix generic type of OutputTag in operator Output
R: @dawidwys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3664
[FLINK-5808] Revert changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink revert-5808-release12
Alternatively you can review
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3662#discussion_r109608264
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java
---
@@ -107,7 +107,8
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3662
@dawidwys thanks for reviewing so quickly. I pushed a commit to address
your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3508#discussion_r109610444
--- Diff: docs/dev/stream/state.md ---
@@ -233,45 +229,44 @@ val counts: DataStream[(String, Int)] = stream
## Using Managed Operator State
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
Nice update to the docs! And yeah, a separate issue for deprecation is very
good. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3661
I'd like to keep it for now, since it might help catch some bugs and
doesn't take long to run.
What was the bug in the comparator?
---
If your project is set up for it, you ca
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3668
LGTM! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3664
Thanks for reviewing! I'm merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3670
[FLINK-5808] Revert changes
This reverts the changes around FLINK-5808 because they introduced
follow-up issues.
You can merge this pull request into a Git repository by running:
$ git pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r87201308
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2777
Thanks for the fix! ð Could you please close the issue and this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2786
I think it's fine to increase the timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2772
Thanks for reviewing @jgrier!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2788
[FLINK-5026] Rename TimelyFlatMap to Process
This is only renaming, the changed Javadoc probably requires most attention
when reviewing this.
R: @jgrier if you could have a look that
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2763
I merged this, thanks for your work! ð
Could you please close this PR and the Jira issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2785
@StephanEwen I think it's not a problem that these physical, low-level
timers don't fire in order of their timestamp because the ordering of timers is
maintained in the impleme
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2785
@StephanEwen It's used to drive the automatic watermark generation and the
inactivity timer in the `BucketingSink`, but those are cases where the order
doesn't matter.
---
If your proj
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87798657
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87798796
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2801
@tzulitai I won't have much time this week so will review this next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r87802539
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -459,7 +545,28 @@ public WindowedStream
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r87801992
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -800,4 +907,39 @@ public
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2803
[FLINK-5061] Remove ContinuousEventTimeTrigger
R: @StephanEwen for review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87862442
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2736
I merged it. Thanks for your work and working with me on this: ð
Could you please close this PR and the two Jira Issues that it solves?
---
If your project is set up for it, you can
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r88001538
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -800,4 +907,39 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r88021648
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -800,4 +907,39 @@ public
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2736
Sure, you're very welcome! `1.2` should be the fix version since that's
going to be the first version that has this new code.
---
If your project is set up for it, you can reply to this
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2736
I reopened and then closed with the correct fix version. I think no-one can
change closed issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88856847
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88861382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88861427
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2732#discussion_r89156639
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobClient.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software
101 - 200 of 5077 matches
Mail list logo
