[GitHub] flink pull request: [FLINK-1522][gelly] Added test for SSSP Exampl...

2015-02-17 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/414#issuecomment-74719038 @rmetzger , thanks for the heads up! Now, instead of returining null, I have a default vertex data set and a default edge data set. Tell me what you think

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-16 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/452#discussion_r26487168 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/EuclideanGraphExample.java --- @@ -0,0 +1,231 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-20 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/505 [FLINK-1726][gelly] Added Community Detection Library and Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink

[GitHub] flink pull request: [FLINK-1632][gelly] Deleted GraphUtils

2015-03-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/462 [FLINK-1632][gelly] Deleted GraphUtils Made the Graph methods use DataSet's count() instead of GraphUtils.count. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/452#issuecomment-80369017 @vasia , The tests on the cluster were also successful. Good to go from my side. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-1677][gelly] Suppressed Sysout Printing...

2015-03-12 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/475#issuecomment-78622670 Hi @uce , First of all thanks! :) Your comments are entirely true, especially the one with MultipleProgramsTestBase. I spent some time to figure out how

[GitHub] flink pull request: [FLINK-1677][gelly] Suppresed Sysout Printing

2015-03-10 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/475 [FLINK-1677][gelly] Suppresed Sysout Printing For the DegreesWithException test suite. Also added a mini cluster instance to speed up tests You can merge this pull request into a Git

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/505#issuecomment-85725549 @vasia , I integrated your suggestions, the example works on the cluster for Orkut, max iter = 20. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-03-29 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-87425953 Hi @vasia , 1). I will add the documentation once we reach a consensus. No use documenting something that might change :) 2). For the public setter: I

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-30 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/544 [FLINK-1741][gelly] Adds Jaccard Similarity Metric Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink flinkJaccard

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-30 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-87830769 Hi @vasia , The problem(at least mine) was that Jaccard works on both an undirected and on a directed graph... and I just needed to make a final decision

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-03-31 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-88088234 Sure, I thought it was obvious from the ugly if :) In EmitOneEdgePerNode we have: public void flatMap(EdgeK, EV edge, CollectorTuple2K, EdgeK, EV

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-03-28 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r27344502 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -38,11 +41,41 @@ * @param Message

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-28 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/452#issuecomment-87269837 @vasia , No need to ignore the hadoop1 failure, I rebased and everything is nice and green now. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1633][gelly] Added getTriplets() method...

2015-03-03 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/452 [FLINK-1633][gelly] Added getTriplets() method and test A convenience Gelly method that generates a DataSet of srcVertexId, trgVertexId, srcVertexVal, trgVertexVal, edgeValue from the input graph

[GitHub] flink pull request: [FLINK-1587][gelly] Added additional check for...

2015-03-04 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/440#issuecomment-77224411 Hi @uce! I am using a data set's print() method in that particular test suite. I tried several mixes and matches with the logger but none were successful

[GitHub] flink pull request: [FLINK-1522][gelly] Added test for SSSP Exampl...

2015-02-20 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1522][gelly] Added test for SSSP Exampl...

2015-02-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/429#issuecomment-75312569 Thank you for the tip! I am still learning the dirty insights of Git :) Next time I will just update the PR. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1587][gelly] Added additional check for...

2015-02-25 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/440 [FLINK-1587][gelly] Added additional check for edge src/trg id validity You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink

[GitHub] flink pull request: [FLINK-1726][gelly] Added Community Detection ...

2015-03-26 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/505#issuecomment-86366858 Travis passed :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-13 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/596 [FLINK-1883][gelly] Added Min Vertex Id Propagation library and example You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-92750207 Hi @vasia , I wanted to be as close to the example in the guide, to show that Spargel code can easily be ported to Gelly, hence the name. I changed it now

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-94572014 Apart from the fact that I don't agree with those two methods having the same name, everything else was updated. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28811435 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/example/IncrementalSSSPITCase.java --- @@ -0,0 +1,84

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-94438358 @vasia , The library method matches Spargel now. I also refactored the randomised edges test a bit. Tell me what you think! --- If your project is set

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/600#issuecomment-94432522 Hi @vasia , The general guidelines were added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-94461019 Hi @vasia , The inline comments have been addressed, I still have the big comment to look at :) One thing(or two ^^) that could be discussed

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28764335 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java --- @@ -40,7 +42,37 @@ VertexValue

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28785218 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java --- @@ -138,69 +146,46 @@ public void

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-04-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/408#issuecomment-95866092 I noticed that there is no GSAPageRank example in the latest version of the code. I'd like to take care of that once this PR gets merged, to get to understand

[GitHub] flink pull request: [FLINK-1944][gelly] Added GSA-PageRank example

2015-04-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/626 [FLINK-1944][gelly] Added GSA-PageRank example This PR also adds the getSuperStepNumber() method to the Gather, Sum and Apply Functions. You can merge this pull request into a Git repository

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-04-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/625 [gelly][Refactoring] Removed example string @vasia, Just FYI :), in example/utils we have a class EdgeWithLongIdNullValueParser that is never used. The examples that correspond

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-21 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-94915061 Hi @vasia , I added some answers to your inline comments! I will push my latest version for this tomorrow. Regarding the suggestion that the Vertex

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-05-01 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/600#issuecomment-98173050 Hi @vasia ! To me it looked normal, probably because I know Spargel :P I moved it in a separate section and rebased. Should be fine now :) --- If your

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-28 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-97159494 Thanks for the review, @StephanEwen! PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...

2015-04-27 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/635 [FLINK-1942][gelly] GSA Iteration Configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink gsaConfig Alternatively you

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-99499311 @vasia Don't forget to also have a look at this PR. It's rebased :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1987][docs] Fixed broken links

2015-05-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/662 [FLINK-1987][docs] Fixed broken links The two html links I replaced were never actually written. In any flink release. In my opinion it is better to omit this information than to point the user

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-98983169 For the test: did you have a look at the other Gelly tests(https://github.com/apache/flink/tree/master/flink-staging/flink-gelly/src/test/java/org/apache/flink/graph

[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-99157184 Hi @vasia, The alternatives to having a single config class for all types of iterations are: - having two separate classes in spargel and in gsa = massive

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-100544083 Indeed I was missing that annotation. Nice catch! PR updated :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-08 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/663 [FLINK-1976][gelly] Added ForwardedFields Annotations You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink fwdFields

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-100372745 Sure @hsaputra , I thought the JIRA issue was descriptive enough. We were missing ForwardedFields* annotations for the majority of Gelly classes

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-05 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-99232613 Hey @vasia , Everyone is acting as though I do not want to make these methods user-freindly. I do :), it's just not possible. Keep in mind

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102684206 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-15 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/678 [FLINK-2012][gelly] Added methods to remove/add multiple edges/vertices This pull request provides methods for adding/deleting more than one vertex/edge at a time. The addEdges method

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-102301712 Well that was embarrassing ^^. Excellent catch @rmetzger! The code was written yesterday evening during a plane ride; My tests found a bug and I basically put

[GitHub] flink pull request: [FLINK-1523] vertex-centric iteration extensio...

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/680#issuecomment-102387218 Uhhh this looks incredibly clean now :)) +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-15 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102376105 If you don't like the example string at the end, then we can go for sol (b) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1976][gelly] Added ForwardedFields Anno...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/663#issuecomment-101972007 Guys, Maybe it makes sense to merge this :) It's been here for a while. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-101978637 Hi @vasia, I had a look at the new branch. The changes look good, degrees are no longer exposed to the user and the current approach removes the need

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-05-14 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-101989242 @joey001, How did you rebase this? It should not normally contain everyone's commits... Right now it looks like 18 people participated in the implementation

[GitHub] flink pull request: [FLINK-1871][gelly] Added Spargel to Gelly mig...

2015-04-14 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/600 [FLINK-1871][gelly] Added Spargel to Gelly migration guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink migrationGuide

[GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...

2015-04-17 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/408#issuecomment-93975508 Hi @balidani :) This PR has not been updated in a while now. Are you facing any issues? In that case I would like to help. Otherwise, if you're busy maybe

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/576#issuecomment-92270780 Hello @vasia , I updated the PR to use reduce where possible(for the functions which return one value per vertex). Let me know if there is anything I

[GitHub] flink pull request: [FLINK-1883][gelly] Added Min Vertex Id Propag...

2015-04-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/596#issuecomment-94177583 Hi @vasia , I will change the code to match Spargel, probably Monday :) I came across this class in our tests the other day, while searching for something

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-90061271 @vasia , PR updated :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-04-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-90062739 Fair enough :). Let me know if the example seems clearer now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1758][gelly] Neighborhood Methods Exten...

2015-04-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/576 [FLINK-1758][gelly] Neighborhood Methods Extensions You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink extendNeighborhood

[GitHub] flink pull request: [FLINK-1741][gelly] Adds Jaccard Similarity Me...

2015-04-07 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/544#issuecomment-90715751 @vasia, I updated the PR with your latest suggestions. Travis seems to fail because of flink-steaming :-s; my quick refactoring couldn't have triggered

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-07 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-90728415 Hi @vasia , I simply assumed that if the previous examples work, the iteration also works as before. Would you like a specific test suite

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-103862850 Hi @vasia , I will address your comments one by one :) - the addVertices method receives a List of Edges instead of a DataSet of Edges because you need

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31677964 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/HITS.java --- @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-108634942 Hi @mfahimazizi, The common practice is to prefix the commit with the Jira issue, e.g. [FLINK-20XX][gelly]. Also, you should play with your IDE's settings

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31678387 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/HITSExample.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request: Hits

2015-06-03 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/765#discussion_r31678355 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/HITSExample.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-07 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/801 [FLINK-2150][gelly] Added library method for assigning unique labels to vertices This PR adds a library method that assigns unique labels to vertices. The following facts are used

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-06 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/799 [FLINK-2178][gelly] Fixed groupReduceOnNeighbors bug This PR adds an iterator.hasNext() check in the groupReduceOnNeighbors method, fixing the NoSuchElementException bug reported in FLINK-2178

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/807#issuecomment-110070080 Hi @shghatge , This very nice for a first PR and I am happy to see that you followed my guidelines :) I left a set of comments in-line. Apart

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930812 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1233,6 +1233,34 @@ public void coGroup(IterableEdgeK, EV edge

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932002 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932048 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930244 --- Diff: docs/libs/gelly_guide.md --- @@ -236,6 +236,8 @@ GraphLong, Double, Double networkWithWeights = network.joinWithEdgesOnSource(v

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31930744 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1233,6 +1233,34 @@ public void coGroup(IterableEdgeK, EV edge

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/807#discussion_r31932709 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphOperationsITCase.java --- @@ -266,6 +266,47 @@ public void

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-03 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/770 [FLINK-2149][gelly] Simplified Jaccard Example This PR simplifies Gelly's Jaccard example by using the more efficient reduceOnNeighbors rather than groupReduceOnNeighbors. You can merge

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-108431985 For 1, I would open a fresh PR, I guess this is too messy to try to fix. Normally, you should: change to master git remote -v pull the latest

[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...

2015-06-02 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/763 [docs/javadoc][hotfix] Corrected Join hint and misleadling pointer to Spargel This PR adds the following patches: - in the Iteration programming guide, there was a misleading link

[GitHub] flink pull request: [FLINK-1526][gelly] [work in progress] Added M...

2015-06-03 Thread andralungu
Github user andralungu closed the pull request at: https://github.com/apache/flink/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-06-03 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-108364900 Hi @vasia , I believe the problem @joey001 had was that in one of the test modes, he got the classical Too few memory segments provided. You need at least 33

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-110448745 I am super excited about this one! :) Will also have a look in the next days! Awesome job! --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-110739263 Hi @shghatge, Apart from the minor cosmetic suggestions I made, everything looks well. @vasia, could you double check this? After Shivani simplifies

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110502315 Hi @fhueske , To tell the truth, I was a bit reserved regarding your approach, so maybe we can discuss it a bit further! :) I updated the PR to contain what

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-110481761 uhmm, guys! IMO this should be merged before the release! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2140][gelly] Allowed access to the numb...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/779#issuecomment-110654021 If no objections, I'd like to merge this one within the next week. There is a direction issue for GSA(FLINK-2141) that will actually touch the same files

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110647258 Hi @tillrohrmann , For the log2 part, you mean something like this: ceil(log2(x)) = 32 - numberOfLeadingZeros(x - 1)? 32 because it's int, in this case

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-10 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110642404 Ooops! My bad. Fixed the log and the ceil issue in the latest update. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2150][gelly] Added library method for a...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/801#issuecomment-110520392 I think I got it! Have a look now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-113149078 Hi @shghatge , Don't forget to remove the definition for the public removeVertices(DataSet) from the documentation. Up for discussion: should we

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114481973 Hey @tillrohrmann , Sorry for the incredibly late reply. The last weeks have been very hectic. Nevertheless, I'd like to properly finish and polish

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-20 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/770#issuecomment-113752297 Meging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114883882 Uhmmm... flink.api.scala is imported. That's not the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-24 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-114878728 Actually, I get a weird compile error: it says missing Type parameter for the map in DataSet.scala... I think this is because the map is overriden... and I haven't

[GitHub] flink pull request: [FLINK-2152] Added zipWithIndex

2015-06-25 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/832#issuecomment-115134406 Hey Theo, Thanks a lot for finding my bug there ^^ PR updated to address the Java issues and to contain a pimped Scala version of `zipWithIndex

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113213190 This looks very nice! Someone deserves a virtual :ice_cream: ! There are some tests missing: - test `fromCSV` with a Mapper - you just test `types

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113217602 Ah! And I just remembered! Maybe it makes sense to update the examples to use `fromCSV` when creating the Graph instead of `getEdgesDataSet`. --- If your project

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-19 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113483077 Mea culpa. No the mapper test is fine; For the examples comment, I meant to go through the classes in the example folder and to modify the way the graph

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-06-23 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114420568 Thanks @aljoscha for reminding me... This slipped my mind for a sec. I agree that the methods should have Scaladoc (this should be straightforward to add

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-26 Thread andralungu
Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33354071 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,54 @@ public void flatMap(EdgeK, EV edge

  1   2   >