[GitHub] flink pull request #3570: [FLINK-6122] add TravisCI build status to README.m...

2017-03-20 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3570 [FLINK-6122] add TravisCI build status to README.md Add TravisCI build status image to FLINK's github repo homepage https://cloud.githubusercontent.com/assets/1892692/24091460/6b6e26b4

[GitHub] flink pull request #3577: [FLINK-6133] fix build status in README.md

2017-03-20 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3577 [FLINK-6133] fix build status in README.md So sorry, I think I made a mistake when committing code for https://issues.apache.org/jira/browse/FLINK-6122. I tried to copy what's

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Green build! @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727098 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727145 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727162 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112728271 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112729036 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112729232 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112280185 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,216

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112282965 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112279814 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112283099 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Addressed @zentol and @StephanEwen 's comments. Ready for another round! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496785 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112499012 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496915 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112498342 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112520676 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,29 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112521836 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,200

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112522071 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,78 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Where is the title that you're referring to? This PR's title at the very top is already "[FLINK-6013][metrics] Add Datadog HTTP metrics reporter" (without double quote) --- If yo

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Aha! Updated! Apparently Chrome search is case insensitive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112338938 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340440 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340350 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340825 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344921 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339291 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340221 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341238 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341697 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112342781 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344359 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339524 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMeter.java --- @@ -0,0 +1,42 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340046 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340582 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341399 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341874 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344296 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/SerializationUtils.java --- @@ -0,0 +1,30

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344276 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/TimestampUtils.java --- @@ -0,0 +1,27

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344522 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344622 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol ready for another round. The build fails because there are a few unrelated flake tests timing out in travis build --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3736 [Flink-6013][metrics] Add Datadog HTTP metrics reporter I'm adding a DatadogHttpReporter for Flink metrics system. The implementation, including making parameters in Flink's metrics

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Great advice. Thanks, @zentol ! My questions to your suggestions: 1. If I make DatadogHttpReport implement MetricReporter interface, shall I just ignore Histogram and Meter which

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Addressed @zentol 's comments. Ready for another round. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112083224 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112115925 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,38 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112115930 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol any further details and suggestions on the maven-jar-plugin part? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-24 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112985930 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink pull request #4466: [FLINK-7356][configuration] misleading s3 file uri...

2017-08-02 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4466 [FLINK-7356][configuration] misleading s3 file uri in configuration file **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai Hi Gordon, shall we add more explanation of these keys in Flink docs, or do you think the java doc is sufficient? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-03 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4473 [FLINK-7367][kinesis connector] Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc) ## What is the purpose of the change

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 yeah, we ran our job with this change on Flink 1.3.0 on EMR and didn't have issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #4547: [FLINK-7454][docs] update 'Monitoring Current Even...

2017-08-16 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4547 [FLINK-7454][docs] update 'Monitoring Current Event Time' section of Flink doc **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-16 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 oh.this is not goodDo you mean that we cannot upgrade KPL/KCL until Flink 1.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-15 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r133121728 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java

[GitHub] flink issue #4537: [FLINK-7440] [kinesis] Add various eager serializability ...

2017-08-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4537 Once this is checked in, we'll be more confident that https://github.com/apache/flink/pull/4473 is all good and it doesn't break anything --- If your project is set up for it, you can reply

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai @aljoscha Let me know if this PR looks good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r132376988 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java

[GitHub] flink issue #4508: [FLINK-7405][metrics] Reduce spamming warning logging fro...

2017-08-10 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4508 @zentol Please let me know if this is good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r132375079 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r132376112 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -165,17

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r132373651 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java

[GitHub] flink pull request #4522: [FLINK-7366][kinesis connector] Upgrade kinesis-pr...

2017-08-10 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4522 [FLINK-7366][kinesis connector] Upgrade kinesis-producer-library in flink-connector-kinesis from 0.10.2 to 0.12.5 ## What is the purpose of the change Upgrade kinesis-producer-library

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @tzulitai @aljoscha there's another major bug in KPL that we need to fix for flink-connector-kinesis https://github.com/awslabs/amazon-kinesis-producer/issues/10 We've been seeing that bug

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai Let me know what you think about this PR now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @tzulitai OK, I only upgraded KPL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #4473: [FLINK-7367][kinesis connector] Parameterize more ...

2017-08-14 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4473#discussion_r132879596 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -57,6

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 hmmm... I was deploying our Flink job with this change. The Flink job failed to start, and log reports: ``` The implementation of the RichSinkFunction is not serializable. The object

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai Thanks Gordan for the quick response! You are right, I set the schema in unit test to be static and it passes. For my Flink job. When I build it against Flink 1.3.0, it can run

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai it's failing on ``` The implementation of the RichSinkFunction is not serializable. The object probably contains or references non serializable fields

[GitHub] flink pull request #4537: [FLINK-7440] [kinesis] Add various eager serializa...

2017-08-14 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4537#discussion_r13250 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java

[GitHub] flink issue #4537: [FLINK-7440] [kinesis] Add various eager serializability ...

2017-08-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4537 @tzulitai LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4309 I ran into this too. Thanks for the PR! Shall we also create a ticket to move generated files out of `src`? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 During testing, I saw the following exception: ```java java.lang.IllegalStateException: Socket not created by this factory

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-17 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4136 @zentol @alpinegizmo Let me know your thoughts on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-07 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4136#discussion_r126240877 --- Diff: docs/ops/state_backends.md --- @@ -124,7 +124,7 @@ RocksDBStateBackend is currently the only backend that offers incremental checkp

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r126511039 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -36,6 +36,8 @@ under the License. 1.10.71 1.6.2

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r126509865 --- Diff: docs/setup/aws.md --- @@ -224,8 +224,6 @@ Depending on which file system you use, please add the following dependencies. Y - `S3AFileSystem

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4136#discussion_r126503269 --- Diff: docs/ops/state_backends.md --- @@ -123,8 +123,7 @@ RocksDBStateBackend is currently the only backend that offers incremental checkp

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-10 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 @tzulitai @tedyu Hi guys, I'm also wondering how much percentage of Flink users are using Flink with Kinesis? Kinesis has so many limitations that we are considering to move from Kinesis

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-07 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 @tzulitai I shaded httpcomponents. Does it look good? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r127138994 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -56,6 +58,18 @@ under the License

[GitHub] flink pull request #4150: [FLINK-6951] Incompatible versions of httpcomponen...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4150#discussion_r127139879 --- Diff: flink-connectors/flink-connector-kinesis/pom.xml --- @@ -56,6 +58,18 @@ under the License

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 ok, I kind of figured out what `promoteTransitiveDependencies` means. I removed explicit dependencies of httpclient and httpcore from `pom.xml`, and made sure http-components are shaded

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 I added http components to dependencies because Hadoop-aws 2.7 depends on http components 4.2. ``` $ jar -tf flink-connector-kinesis_2.11-1.4-SNAPSHOT.jar | grep apache/http org

[GitHub] flink pull request #4375: [Flink 6365][kinesis-connector] Adapt default valu...

2017-07-20 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4375 [Flink 6365][kinesis-connector] Adapt default values of the Kinesis connector Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4136 @zentol @alpinegizmo Guys, please let me know your thoughts :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 My Flink job checkpoints to S3, I'm configuring S3AFileSystem shown in https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/aws.html#flink-for-hadoop-27. I doubt if this error

[GitHub] flink pull request #3775: [FLINK-6386] Missing bracket in 'Compiler Limitati...

2017-04-25 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3775 [FLINK-6386] Missing bracket in 'Compiler Limitation' section Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113510125 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113512176 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,199

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-27 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol Hi guys, I just tested it on my machine and it works as expected. What's your plan on this PR? I found on email thread that there'll be a feature freeze of release 1.3

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113259225 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol I shaded okhttp3 and okio from flink-metrics-datadog. I didn't use 'shade-flink' because I found it somehow prevents me from building a uber jar. Let me know if it's ok

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-28 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol I've made the following changes: 1) Datadog (DD) itself has a bug of being unstable when users filter metrics by 'host' in dashboards if 'host' is sent as tags

  1   2   3   4   5   >