GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/5961
[Flink-8255][DataSet API, DataStream API] key expressions on named row
types do not work
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6007
[FLINK-8518][Table API & SQL] Support DOW, EPOCH, DECADE for EXTRACT
dow extraction support implemented + tests
*Thank you very much for contributing to Apache Flink - we are h
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/5961
Hello @fhueske
Thank you for your review
As you proposed I tried to use
org.apache.flink.api.java.typeutils.RowTypeInfo#isTupleType
```java
public boolean isTupleType
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
@walterddr thank you for your comment
it is just DOW implementation because to implement EPOCH we have to wait
for CALCITE-2303 resolution
about DECADE - there are 2 ways: one is also
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6040
@tzulitai, @tedyu thnk you for your review, comments and contribution tips
I did updates which includes moving test into AbstractFetcherTest and
making it kafka connector version independent
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r189168596
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/Flink9349Test.java
---
@@ -0,0
Github user snuyanzin closed the pull request at:
https://github.com/apache/flink/pull/6007
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
sorry, closed by mistake, restored
---
Github user snuyanzin closed the pull request at:
https://github.com/apache/flink/pull/5961
---
GitHub user snuyanzin reopened a pull request:
https://github.com/apache/flink/pull/5961
[FLINK-8255][DataSet API, DataStream API] key expressions on named row
types do not work
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/5961
sorry, was closed by mistake
reopened
---
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6032
[FLINK-9378][Table API & SQL] Improve TableException message with TypeName
usage
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve F
GitHub user snuyanzin reopened a pull request:
https://github.com/apache/flink/pull/6007
[FLINK-8518][Table API & SQL] Support DOW for EXTRACT
dow extraction support implemented + tests
*Thank you very much for contributing to Apache Flink - we are happy that
you
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6040
[FLINK-9349][Kafka Connector] KafkaConnector Exception while fetching from
multiple kafka topics
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r189035401
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r189038623
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/Flink9349Test.java
---
@@ -0,0
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6032
@twalthr thank you for your review.
To be honest thought about such approach indeed
org.apache.flink.api.common.typeinfo.BasicTypeInfo#toString should be changed
at least to fix case from here
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6040
@tzulitai thank you for your review and comments
based on your comments I have a question. Could you please clarify it?
You mentioned Flink's `OneShotLatch ` and `CheckedThread
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
@twalthr thank you for your comment.
I took a similar ticket in Calcite/Avatica from which the current depends
on and I pointed this discrepancy in the [comment
](https://issues.apache.org
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
@twalthr thank you for your comment but could you please clarify this
> Can you add some documentation to sqlApi.md such that users know about
the semantics?
1. Am I ri
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
> Just because DOW is in the reserved keywords section doesn't mean that we
support it.
Definitely agree however my point was that the same situation is for DOY,
CENTURY and others...
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
yes, done
---
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6007#discussion_r190299515
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1473,6 +1473,14 @@ class
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6161
[FLINK-9581] Remove extra spaces to make COLLECT left aligned
## Brief change log
extra spaces removed
## Does this pull request potentially affect one of the following parts
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6099
[FLINK-9473][Table API & SQL] Added new methods into ExternalCatalogSchema
based on interface Schema changes in Calcite
## What is the purpose of the change
Make Flink compilable a
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6226
@fhueske thank you for your review
I have left comments and done changes. Please let me know if it is required
some more efforts
---
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199223349
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala
---
@@ -44,7 +44,26 @@ class
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199222853
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6233
Hello @hequn8128! Thank you for your review and comments.
About PR template - I did changes based on proposed #5811. Please let me
know if it is acceptable or not.
About `rowToString` agree
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6233#discussion_r199364581
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java
---
@@ -0,0 +1,108
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6233#discussion_r199364538
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java
---
@@ -0,0 +1,108
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199366673
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -,6 +,53 @@ class
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/5961
commits squashed into one
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6233
@hequn8128 thank you for your idea about Row. I used it in tests. Also I
checked usages of `org.apache.flink.table.client.cli.CliStrings#NULL_COLUMN` it
was added only recently and used only
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6223
@fhueske @hequn8128 @yanghua thank you very much for your review and
comments
I did almost all the corrections except one related to atan2 description
So I have a question
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199223615
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6233
[FLINK-9696] Deep toString for array/map sql types
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199543936
--- Diff: docs/dev/table/sql.md ---
@@ -1510,6 +1510,17 @@ ATAN(numeric)
+
+
+{% highlight text
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6233#discussion_r199559926
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java
---
@@ -0,0 +1,108
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6250
[FLINK-8864] added command history
## What is the purpose of the change
*This PR adds history for sql queries/sqlclient commands*
## Brief change log
- *Added
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6249
[hotfix] [docs] [FLINK-9734] Fix 'deleimiter' typo
## What is the purpose of the change
*This PR fixes typo in deleimeter word at
https://ci.apache.org/projects/flink/flink-docs-master
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6258#discussion_r200209274
--- Diff: docs/dev/table/sql.md ---
@@ -2656,7 +2656,7 @@ Although not every SQL feature is implemented yet,
some string combinations
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6258
[hotfix][docs][FLINK-9757] fix typos
## What is the purpose of the change
*This PR corrects typos found while hunspell run*
## Brief change log
typos from [FLINK-9757
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6263
[FLINK-9743][Client] Use correct zip/jar path separator
## What is the purpose of the change
*This PR resolves libraries extraction issue from jars*
## Brief change log
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6161
@fhueske thank you for review
@tillrohrmann if you took #6258 and @fhueske reviewed this may be it also
makes sense to take into 1.5.1?
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6250
cc @twalthr as you are the issue reporter could you please have a look
here?
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6263
ok, thank you for review
about `public TemporaryFolder temporaryFolder = new TemporaryFolder();`
could be final - agree.
However while searching for usages I realized that in most cases
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6246
[hotfix][FLINK-9729][docs][Table API & SQL] Remove duplicate row for %W
## What is the purpose of the change
*This PR removes duplicate line for `%W Weekday name (Sunday .. Satu
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199866207
--- Diff: docs/dev/table/tableApi.md ---
@@ -2184,6 +2184,17 @@ NUMERIC.atan()
+
+
+{% highlight
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6226
[FLINK-8650] Tests for WINDOW clause and documentation update
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r198928117
--- Diff: docs/dev/table/sql.md ---
@@ -139,7 +143,8 @@ select:
[ WHERE booleanExpression ]
[ GROUP BY { groupItem [, groupItem
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r198928207
--- Diff: docs/dev/table/sql.md ---
@@ -115,6 +115,10 @@ The following BNF-grammar describes the superset of
supported SQL features in ba
52 matches
Mail list logo
