[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70883754 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70884431 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java --- @@ -72,26 +68,36 @@ * This class is the executable entry

[GitHub] flink issue #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2249 Please make sure to follow the naming conventions for pull requests, as described in the PR template. First entry under "General" : "The pull request references the related JIRA iss

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 That's great to hear, working on a test right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I've update the PR accordingly. The PR is now separated into 4 commits: 1. move all user-facing API into flink-metrics-core 2. move remaining metric classes out of flink-core

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 - added test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2292: [FLINK-3891] [table] Add a class containing all su...

2016-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2292#discussion_r72048591 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/CastingITCase.java --- @@ -138,50 +138,5 @@ public void

[GitHub] flink pull request #2287: [hotfix] Prevent CheckpointCommitter from failing ...

2016-07-22 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2287 [hotfix] Prevent CheckpointCommitter from failing job This PR fixes an issue in the `GenericWriteAheadSink` that @aljoscha stumbled upon. If the sink fails while writing the data

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2287 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I found out why the `testJobManagerMetricAccess` fails: Since we moved the JMXReporter to flink-runtime the package declaration changed (it now includes "runtime"). The class name was

[GitHub] flink pull request #2287: [hotfix] Prevent CheckpointCommitter from failing ...

2016-07-25 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I took this change from @StephanEwen branch; I don't _know_ why, but I'm assuming for the purpose of making `flink-metrics-core` truly independent. --- If your project is set up for it, you can

[GitHub] flink issue #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2271 Also, the documentation (list of all exposed metrics) was not updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler

2016-07-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 +1 to merge. Just for future considerations: The Flink community uses rebasing instead of merging branches to avoid these pesky merge commits. :) --- If your project is set up for it, you

[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler

2016-07-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 Please don't spend your time to write an actual test for this; for this change it is not necessary. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2312: [FLINK-4276] Fix TextInputFormatTest#testNestedFil...

2016-07-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2312 [FLINK-4276] Fix TextInputFormatTest#testNestedFileRead The problem with test was a simple formatting mismatch between the paths returned by `"file:" + File.getAbsolutePath()` and `Pat

[GitHub] flink pull request #2309: [FLINK-4161] Add Quickstart exclusion for flink-di...

2016-07-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2309 [FLINK-4161] Add Quickstart exclusion for flink-dist dependencies Updated version of #2218 which got closed as I accidentally deleted the branch. In addition to the previous changes

[GitHub] flink pull request #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#test...

2016-07-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2310 [FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading This PR fixes the `TaskManagerConfigurationTest#testDefaultFsParameterLoading` by creating a proper `flink-conf.yaml

[GitHub] flink pull request #2311: [FLINK-4284] [docu] Fix broken links

2016-07-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2311 [FLINK-4284] [docu] Fix broken links Fixes several broken links in the documentation. There were all links to the Batch documentation that are now under "Basic API Concepts". You

[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler

2016-07-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2307 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...

2016-07-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2310 @mxm addressed your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2308: [FLINK-4279] [py] Set flink dependencies to provid...

2016-07-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2308 [FLINK-4279] [py] Set flink dependencies to provided * removed unused `flink-optimizer` and `flink-clients` dependency * set the remaining dependencies to `provided` * as otherwise several

[GitHub] flink issue #2311: [FLINK-4284] [docu] Fix broken links

2016-07-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2311 If this `[transformations](#dataset-transformations)` is a pure anchor link then they aren't broken. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2311: [FLINK-4284] [docu] Fix broken links

2016-08-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2311 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2318: [FLINK-4291] Add log entry for scheduled reporters

2016-08-01 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2318 [FLINK-4291] Add log entry for scheduled reporters simple PR that adds a log message for instantiated unscheduled reporters containing the name and class. You can merge this pull request into a Git

[GitHub] flink issue #2308: [FLINK-4279] [py] Set flink dependencies to provided

2016-08-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2308 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...

2016-08-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2310 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...

2016-08-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2317#discussion_r72981367 --- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh --- @@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log" -Dlog4j.con

[GitHub] flink pull request #2349: [FLINK-4365] [metrics] Add documentation to Metric...

2016-08-10 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2349 [FLINK-4365] [metrics] Add documentation to MetricConfig Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #2330: FLINK-4311 Fixed several problems in TableInputFormat

2016-08-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2330 I don't know, and it seems the InputFormat itself doesn't know either. If we go by the previous implementation then yes, there will only be one table. However, based on the comments on Line 64

[GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...

2016-08-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2330#discussion_r73382033 --- Diff: flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java --- @@ -237,7 +244,7 @@ private void

[GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...

2016-08-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2330#discussion_r73381826 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -328,7 +328,11

[GitHub] flink issue #2330: FLINK-4311 Fixed several problems in TableInputFormat

2016-08-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2330 maybe you can move the table initialization into `openInputFormat()` (called once before all splits) and close it in `closeInputFormat()` (called once after all splits). --- If your project is set

[GitHub] flink issue #2330: FLINK-4311 Fixed several problems in TableInputFormat

2016-08-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2330 I would say yes, since `open()` and `close()` can also throw an `IOException`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2364: [FLINK-4293] Fix malformatted license headers

2016-08-12 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2364 [FLINK-4293] Fix malformatted license headers Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend

2016-08-12 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2363 [FLINK-4389] Expose metrics to WebFrontend This PR exposes metrics to the Webfrontend, as proposed in [FLIP-7](https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics

[GitHub] flink issue #2347: [FLINK-4236] fix error handling for jar files with no mai...

2016-08-10 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2347 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70584088 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70589875 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591165 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591328 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591698 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591835 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java

[GitHub] flink pull request #2210: [FLINK-4167] [metrics] Close IOMetricGroup in Task...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2210#discussion_r70597751 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/ProxyMetricGroup.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #2210: [FLINK-4167] [metrics] Close IOMetricGroup in TaskMetricG...

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2210 Only had a small comment, otherwise +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2237: [FLINK-4206][metrics] Remove alphanumeric name res...

2016-07-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2237 [FLINK-4206][metrics] Remove alphanumeric name restriction You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 4206_me_so_special

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2236 You can rebase on top of #2237. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2235: [hotfix] removed duplicated code

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2235 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2219 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70590934 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java

[GitHub] flink issue #2217: [FLINK-4159] Remove Quickstart exclusions for unused depe...

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2217 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2220: [FLINK-4184] [metrics] Replace invalid characters ...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2220#discussion_r70768940 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java --- @@ -100,10 +101,29 @@ public AbstractMetricGroup

[GitHub] flink issue #2220: [FLINK-4184] [metrics] Replace invalid characters in Sche...

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2220 do we have a test that verifies that reporters properly pass their filter when notified of new metrics? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2220: [FLINK-4184] [metrics] Replace invalid characters ...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2220#discussion_r70770115 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java --- @@ -100,10 +101,29 @@ public AbstractMetricGroup

[GitHub] flink issue #2273: [FLINK-4238] Only allow/require query for Tuple Stream in...

2016-07-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2273 Since we now have separate branches for both sink types it may be worthwhile to move these checks completely into the respective `CassandraXXXSinkBuilder` classes. Otherwise, +1. --- If your

[GitHub] flink issue #2271: [FLINK-4202] Add restarting time JM metric

2016-07-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2271 The Javadoc for the `RestartingTimeGauge` is not consistent with the implementation. The Javadocs say "The time between the RESTARTING and RUNNING". The implementation s

[GitHub] flink issue #2128: [FLINK-4053] Return value from Connection should be check...

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2128 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2254: [FLINK-3630] [docs] Little mistake in documentation

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2254 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2233 ok, go ahead then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2135: [hotfix] [metrics] Prevent log flooding from collisions

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2135 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2241: [FLINK-3666] Remove all remaining Nephele references

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2241 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 @StephanEwen I've changed the `MetricConfig`to extend `Properties` and remove the `setString()` method. I've kept the other methods for now. --- If your project is set up for it, you can reply

[GitHub] flink issue #2255: [FLINK-4142][docs] Add warning about YARN HA bug

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2255 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2241: [FLINK-3666] Remove all remaining Nephele referenc...

2016-07-15 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2241 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2186 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2115: [FLINK-4017] [py] Add Aggregation support to Python API

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2115 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2216: [FLINK-4173] Use shade-plugin in flink-metrics

2016-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2216#discussion_r71177650 --- Diff: flink-metrics/flink-metrics-statsd/pom.xml --- @@ -49,4 +49,31 @@ under the License. test

[GitHub] flink issue #2266: [FLINK-4229] Do not start any Metrics Reporter by default

2016-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2266 This PR is a good time to make a slight change in `JMXReporter#open()`; making it use the `metrics.reporter.arguments` property instead of `metrics.jmx.port`. Since the special port property

[GitHub] flink pull request #2266: [FLINK-4229] Do not start any Metrics Reporter by ...

2016-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2266#discussion_r71527251 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java --- @@ -50,9 +50,10 @@ public void

[GitHub] flink issue #2266: [FLINK-4229] Do not start any Metrics Reporter by default

2016-07-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2266 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2266: [FLINK-4229] Do not start any Metrics Reporter by default

2016-07-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2266 The documentation for JMX wasn't updated; it still references `metrics.jmx.port`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2266: [FLINK-4229] Do not start any Metrics Reporter by ...

2016-07-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2266#discussion_r71517800 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java --- @@ -50,9 +50,10 @@ public void

[GitHub] flink issue #2220: [FLINK-4184] [metrics] Replace invalid characters in Sche...

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2220 I would appreciate it if you would give me time to answer to your response before going ahead with a merge. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request #2220: [FLINK-4184] [metrics] Replace invalid characters ...

2016-07-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2220#discussion_r70979472 --- Diff: flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java --- @@ -74,6 +75,15 @@ protected

[GitHub] flink issue #2243: [FLINK-4196] [runtime] Remove recovery timestamp from che...

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2243 @StephanEwen Could you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #1947: [FLINK-1502] [WIP] Basic Metric System

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/1947 @sumitchawla sure you can, as described here: https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html#registering-metrics --- If your project is set up for it, you can reply

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70885172 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 you are correct that the MetricRegistry could remain in flink-core. However, you would still need the new MetricConfig due to the MetricReporter. --- If your project is set up for it, you can reply

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 Using anything but a simple wrapper around a HashMap (what the MetricConfig currently is) is overkill. We would have a bunch of methods without an actual use-case cluttering up the interface

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 The whole point of this PR is to have the MetricReporter in a separate module; other changes are just side-effects. I'll look into the Properties class. --- If your project is set up

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70475544 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I've looked into the `Properties` class. I would prefer not to use it since it would force the Reporter implementations to parse things from Strings manually. I would be nicer if we could hide

[GitHub] flink pull request #2233: [FLINK-2125][streaming] Delimiter change from char...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2233#discussion_r70614809 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@ -96,19 +96,21 @@ public

[GitHub] flink pull request #2233: [FLINK-2125][streaming] Delimiter change from char...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2233#discussion_r70614465 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@ -96,19 +96,21 @@ public

[GitHub] flink issue #2235: [hotfix] removed duplicated code

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2235 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2238: [FLINK-3729] Fix Several SQL tests on Windows OS

2016-07-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2238 [FLINK-3729] Fix Several SQL tests on Windows OS - fixed ExplainTest by replacing all occurrences of `\r\n` with `\n` before comparing the output - replaced usages of `\n

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2233 Only had 2 small comments, otherwise this looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 Alright, although I am curious why this wasn't an issue when we merged the metric system initially. Since you mentioned that we should/could add additional helper methods, please provide

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I've reverted moving of the MetricRegistry; it was in fact not necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70591379 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricGetter.java

[GitHub] flink issue #2230: [FLINK-4200] [Kafka Connector] Kafka consumers logs the o...

2016-07-13 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2230 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2217: [FLINK-4159] Remove Quickstart exclusions for unus...

2016-07-13 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2241: [FLINK-3666] Remove all remaining Nephele referenc...

2016-07-13 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2241 [FLINK-3666] Remove all remaining Nephele references You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 3666_bye_bye_nephele

[GitHub] flink issue #1947: [FLINK-1502] [WIP] Basic Metric System

2016-07-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/1947 What do you mean by "Job writers"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] flink pull request #:

2016-07-15 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/2477161352e12e75e2f0f85b5833ad04dc6d31f2#commitcomment-18257970 In flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTaskState.java: In flink-streaming-java

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70935614 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70935698 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2146 I moved the checkpoint metrics into the Tracker (and reverted the changed to ExecutionGraph). Currently trying it out locally. Regarding the exception catching in the metrics: I can't decide

[GitHub] flink pull request #2128: [FLINK-4053] Return value from Connection should b...

2016-06-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2128#discussion_r68580911 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -76,6 +76,9

<    3   4   5   6   7   8   9   10   11   12   >