[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-14 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334341019
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
 ##
 @@ -687,6 +687,18 @@ public void testCastAsRowType() {
"CAST(`A` AS ROW(`F0` VARCHAR NOT NULL, `F1` TIMESTAMP) 
MULTISET)");
}
 
+   @Test
+   public void testValidateSqlCreateTable() {
+   String sql = "CREATE TABLE tbl1";
 
 Review comment:
   `SqlCreateTable` is a sql node name, we should avoid to use such name and 
use the sql term instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-14 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices 
right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648
 
 
   
   ## CI report:
   
   * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131094955)
   * 2de47e991caa74adea1792b6b9153dee94e46b95 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131457976)
   * 0c32e3b010d2ca9cb7371bb90833b9028c516b0e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131524791)
   * 4270dd87c5e6657708d32bc1dd71cd07ccb9e09f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131560712)
   * c602f6a3deb290f5f6106deefee0a02645126034 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725668)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334333525
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -181,16 +185,16 @@ tEnv.registerTableSink("spend_report", new 
SpendReportTableSink)
 
 
 
-Two tables are registered; a transaction input table, and a spend report 
output table.
-The transactions (`transactions`) table lets us read credit card transactions, 
which contain account ID's (`accountId`), timestamps (`timestamp`), and US$ 
amounts (`amount`).
-In this tutorial, the table is backed by data generated in memory to avoid any 
dependencies on external systems.
-In practice, the `BoundedTransactionTableSource` may be backed by a 
filesystem, a database, or any other static source.
-The spend report (`spend_report`) table logs each row with log level **INFO**, 
instead of writing to persistent storage, so you can easily see your results.
+上例代码注册了两张表。交易表作为输入表,支出报告表作为输出表。
+我们可以从交易(`transactions`)表中读取信用卡的交易记录,其中包含了账户 
ID(`accountId`)字段、时间戳(`timestamp`)字段和交易金额(`amount`)字段。
+本教程中,该表使用内存中的数据,以避免对外部系统的任何依赖。
+而在实际情况下,`BoundedTransactionTableSource` 可能来源于文件系统、数据库或任何静态数据源。
+支出报告表 `spend_report` 用 **INFO** 日志级别记录每一行日志,而不是写入持久化存储,所以你可以很容易地查看结果。
 
 Review comment:
   这里应该不是记录不是每一行日志,而是将表的每一行数据记录到日志


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334337065
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -300,10 +303,11 @@ This query consumes all records from the `transactions` 
table, calculates the re
 {% endhighlight %}
 
 ## Adding Windows
+## 添加窗口
 
 Review comment:
   英文标题没有删掉


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334321431
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -24,35 +24,39 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-Apache Flink offers a Table API as a unified, relational API for batch and 
stream processing, i.e., queries are executed with the same semantics on 
unbounded, real-time streams or bounded, batch data sets and produce the same 
results.
-The Table API in Flink is commonly used to ease the definition of data 
analytics, data pipelining, and ETL applications.
+Apache Filnk 提供 Table API 作为批处理和流处理统一的关系型API,
 
+即,查询在无界实时流或有界批数据集上以相同的语义执行,并产生相同的结果。
+
+Flink 中的 Table API 通常用于简化数据分析,数据流水线和 ETL 应用程序的定义。
 
 Review comment:
   引入了多余的空行,根据markdown语法,这会导致额外的段落切换。
   下文中多处存在相同问题,不再一一赘述。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334339338
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -399,27 +403,29 @@ tEnv.registerTableSource("transactions", new 
UnboundedTransactionTableSource)
 
 
 
-And that's it, a fully functional, stateful, distributed streaming application!
-The query continuously consumes the stream of transactions, computes the 
hourly spendings, and emits results as soon as they are ready.
-Since the input is unbounded, the query keeps running until it is manually 
stopped.
-And because the Job uses time window-based aggregations, Flink can perform 
specific optimizations such as state clean up when the framework knows that no 
more records will arrive for a particular window.
+这就是一个功能齐全、有状态的分布式流式应用!
+这个查询会持续处理交易流,计算每小时的消费额,然后实时输出结果。
+由于输入是无界的,因此查询将一直运行,直到手动停止为止。
+因为这个作业使用了基于时间的聚合,Flink 可以使用一些特定的优化,比如当系统知道一个特定的窗口不会再有新的数据到来,它就会对状态进行清理。
 
 Review comment:
   “基于时间的聚合”->“基于时间窗口的聚合”:这点很重要,如果不是基于窗口,flink无法进行此类优化


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334338639
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -380,10 +384,10 @@ val tEnv = StreamTableEnvironment.create(env)
 
 
 
-The second step is to migrate from a bounded data source to an infinite data 
source.
-The project comes with an `UnboundedTransactionTableSource` that continuously 
creates transaction events in real-time.
-Similar to the `BoundedTransactionTableSource` this table is backed by data 
generated in memory to avoid any dependencies on external systems.
-In practice, this table might read from a streaming source such as Apache 
Kafka, AWS Kinesis, or Pravega.
+第二步就是把有界的数据源替换成无限的数据源。
+这个项目通过 `UnboundedTransactionTableSource` 来实时生成交易事件。
 
 Review comment:
   译文没包含continuously


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334332204
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -158,12 +162,12 @@ val tEnv = BatchTableEnvironment.create(env)
 
 
 
- Registering Tables
+ 注册表
 
-Next, tables are registered in the execution environment that you can use to 
connect to external systems for reading and writing both batch and streaming 
data.
-A table source provides access to data stored in external systems; such as a 
database, a key-value store, a message queue, or a file system.
-A table sink emits a table to an external storage system.
-Depending on the type of source and sink, they support different formats such 
as CSV, JSON, Avro, or Parquet.
+接下来,表将会被注册到运行环境之中,这样你就可以用它们连接外部系统以读取或写入批数据或流数据。
+表数据源提供对存储在外部系统中的数据的访问;例如数据库、键-值存储、消息队列或文件系统。
+表接收器则将表中的数据发送到外部存储系统。
+根据数据源或接收器的类型,它们支持不同的格式,如 CSV、JSON、Avro 或 Parquet。
 
 Review comment:
   sink 翻译成接收器不是很合适
   [Flink Translation 
Specifications](https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)
 建议 sink 是不翻译的,但是并没有提到 source 是否要翻译。我的建议是 source / sink 作为一对专有名词统一不翻译。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xintongsong commented on a change in pull request #9784: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-10-14 Thread GitBox
xintongsong commented on a change in pull request #9784: [FLINK-13485] 
[chinese-translation] Translate "Table API Example Walkthrough" page into 
Chinese
URL: https://github.com/apache/flink/pull/9784#discussion_r334321914
 
 

 ##
 File path: docs/getting-started/walkthroughs/table_api.zh.md
 ##
 @@ -24,35 +24,39 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-Apache Flink offers a Table API as a unified, relational API for batch and 
stream processing, i.e., queries are executed with the same semantics on 
unbounded, real-time streams or bounded, batch data sets and produce the same 
results.
-The Table API in Flink is commonly used to ease the definition of data 
analytics, data pipelining, and ETL applications.
+Apache Filnk 提供 Table API 作为批处理和流处理统一的关系型API,
 
+即,查询在无界实时流或有界批数据集上以相同的语义执行,并产生相同的结果。
+
+Flink 中的 Table API 通常用于简化数据分析,数据流水线和 ETL 应用程序的定义。
 * This will be replaced by the TOC
 {:toc}
 
-## What Will You Be Building? 
+## 接下来你会构建什么? 
+
+在本教程中,你将学习如何构建持续不断的 ETL 流水线,以便按账户跟踪金融交易。
 
 Review comment:
   “持续不断的” -> “连续的”:流水线是名词,用“持续不断的”形容比较别扭
   over time 漏掉了?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy closed pull request #9892: Spillable test

2019-10-14 Thread GitBox
banmoy closed pull request #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] ch33hau commented on issue #8217: [hotfix][flink-table] Add a space when generate query

2019-10-14 Thread GitBox
ch33hau commented on issue #8217: [hotfix][flink-table] Add a space when 
generate query
URL: https://github.com/apache/flink/pull/8217#issuecomment-541517079
 
 
   Hi @rmetzger , I just realised that this PR still remaining opened.
   
   Do you need more information for the changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-14 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334334945
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   Thanks. Can we resolve this now :) ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541488344
 
 
   
   ## CI report:
   
   * 85df9d5df107825b0ab8002a39eda6202bb8e976 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725676)
   * f956f83c10cc51d04286f3d2e1c4cd3b61ca7d13 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131726855)
   * 6c7d38cfa6c9780f4218c17d1b6c902fec3f9485 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131733378)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices 
right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648
 
 
   
   ## CI report:
   
   * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131094955)
   * 2de47e991caa74adea1792b6b9153dee94e46b95 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131457976)
   * 0c32e3b010d2ca9cb7371bb90833b9028c516b0e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131524791)
   * 4270dd87c5e6657708d32bc1dd71cd07ccb9e09f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131560712)
   * c602f6a3deb290f5f6106deefee0a02645126034 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725668)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334332274
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   Currently we did support create empty columns table with our parser, i have 
no strong objections to add test cases for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541488344
 
 
   
   ## CI report:
   
   * 85df9d5df107825b0ab8002a39eda6202bb8e976 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725676)
   * f956f83c10cc51d04286f3d2e1c4cd3b61ca7d13 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131726855)
   * 6c7d38cfa6c9780f4218c17d1b6c902fec3f9485 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce LimitableTableSource for optimizing limit

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce 
LimitableTableSource for optimizing limit
URL: https://github.com/apache/flink/pull/9876#issuecomment-540462303
 
 
   
   ## CI report:
   
   * 3eca02d54759452fdc285687c7aedbf2199a7b46 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131275265)
   * 6e0d738d635cf770a4b2f6fe65182e51e2580468 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131729719)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zhuzhurk commented on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
zhuzhurk commented on issue #9860: [FLINK-14331][runtime] Reset vertices right 
after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-541506958
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] Don't use ContinuousFileReaderOperator to support multiple paths

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] 
Don't use ContinuousFileReaderOperator to support multiple paths
URL: https://github.com/apache/flink/pull/9803#issuecomment-536271535
 
 
   
   ## CI report:
   
   * d0485eff552c55f9b987e1ad596f9f3dbe0fda69 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129583771)
   * e05994bb9786166c073e4b81d4f1fbb513bdcca6 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131729703)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334327984
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   Thanks for pointing it out. I'm not sure about the use case =_= (Maybe 
creating an empty table firstly and adding columns into it?). My motivation is 
that we should make `primaryKeyList` and  `uniqueKeysList`'s default value 
consistent with other fields like `partitionKeyList`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce LimitableTableSource for optimizing limit

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce 
LimitableTableSource for optimizing limit
URL: https://github.com/apache/flink/pull/9876#issuecomment-540462303
 
 
   
   ## CI report:
   
   * 3eca02d54759452fdc285687c7aedbf2199a7b46 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131275265)
   * 6e0d738d635cf770a4b2f6fe65182e51e2580468 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131729719)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131682155)
   * d56abf646bca3c01062554f69dac9bdcf968f838 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131727433)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] Don't use ContinuousFileReaderOperator to support multiple paths

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] 
Don't use ContinuousFileReaderOperator to support multiple paths
URL: https://github.com/apache/flink/pull/9803#issuecomment-536271535
 
 
   
   ## CI report:
   
   * d0485eff552c55f9b987e1ad596f9f3dbe0fda69 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129583771)
   * e05994bb9786166c073e4b81d4f1fbb513bdcca6 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131729703)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce LimitableTableSource for optimizing limit

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce 
LimitableTableSource for optimizing limit
URL: https://github.com/apache/flink/pull/9876#issuecomment-540462303
 
 
   
   ## CI report:
   
   * 3eca02d54759452fdc285687c7aedbf2199a7b46 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131275265)
   * 6e0d738d635cf770a4b2f6fe65182e51e2580468 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] Don't use ContinuousFileReaderOperator to support multiple paths

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9803: [FLINK-14265][table-planner-blink] 
Don't use ContinuousFileReaderOperator to support multiple paths
URL: https://github.com/apache/flink/pull/9803#issuecomment-536271535
 
 
   
   ## CI report:
   
   * d0485eff552c55f9b987e1ad596f9f3dbe0fda69 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129583771)
   * e05994bb9786166c073e4b81d4f1fbb513bdcca6 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541488344
 
 
   
   ## CI report:
   
   * 85df9d5df107825b0ab8002a39eda6202bb8e976 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725676)
   * f956f83c10cc51d04286f3d2e1c4cd3b61ca7d13 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131726855)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices 
right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648
 
 
   
   ## CI report:
   
   * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131094955)
   * 2de47e991caa74adea1792b6b9153dee94e46b95 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131457976)
   * 0c32e3b010d2ca9cb7371bb90833b9028c516b0e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131524791)
   * 4270dd87c5e6657708d32bc1dd71cd07ccb9e09f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131560712)
   * c602f6a3deb290f5f6106deefee0a02645126034 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725668)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131682155)
   * d56abf646bca3c01062554f69dac9bdcf968f838 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131727433)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334319990
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   Well, exactly, the `TableCreationContext` only was initialized when we 
encounter the `(`. I think we can give a `SqlNodeList.EMPTY` as default value 
for `primaryKeyList` and `uniqueKeysList` instead of null.
   
   BTW, what is the use case for table without column definitions ? Can you 
explain a little more ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] JingsongLi commented on a change in pull request #9803: [FLINK-14265][table-planner-blink] Don't use ContinuousFileReaderOperator to support multiple paths

2019-10-13 Thread GitBox
JingsongLi commented on a change in pull request #9803: 
[FLINK-14265][table-planner-blink] Don't use ContinuousFileReaderOperator to 
support multiple paths
URL: https://github.com/apache/flink/pull/9803#discussion_r334319595
 
 

 ##
 File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableSourceITCase.scala
 ##
 @@ -247,4 +248,24 @@ class TableSourceITCase extends BatchTestBase {
 row(3, "7.10", "123", "123"))
 )
   }
+
+  @Test
+  def testMultiPaths(): Unit = {
+val tmpFile1 = File.createTempFile("flink-table-sink-test", ".tmp")
 
 Review comment:
   done, thanks for your review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541488344
 
 
   
   ## CI report:
   
   * 85df9d5df107825b0ab8002a39eda6202bb8e976 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725676)
   * f956f83c10cc51d04286f3d2e1c4cd3b61ca7d13 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices 
right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648
 
 
   
   ## CI report:
   
   * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131094955)
   * 2de47e991caa74adea1792b6b9153dee94e46b95 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131457976)
   * 0c32e3b010d2ca9cb7371bb90833b9028c516b0e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131524791)
   * 4270dd87c5e6657708d32bc1dd71cd07ccb9e09f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131560712)
   * c602f6a3deb290f5f6106deefee0a02645126034 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131725668)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131682155)
   * d56abf646bca3c01062554f69dac9bdcf968f838 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334316882
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -76,7 +80,7 @@ public SqlCreateTable(
SqlCharStringLiteral comment) {
super(OPERATOR, pos, false, false);
this.tableName = requireNonNull(tableName, "Table name is 
missing");
-   this.columnList = requireNonNull(columnList, "Column list 
should not be null");
+   this.columnList = columnList;
 
 Review comment:
   Done. To distinguish two kind of fields(which can't be missing and which can 
be missing but can't be null), I add different error messages.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334316903
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateView.java
 ##
 @@ -44,6 +47,8 @@
private final SqlIdentifier viewName;
private final SqlNodeList fieldList;
private final SqlNode query;
+
+   @Nullable
private final SqlCharStringLiteral comment;
 
public SqlCreateView(
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334316640
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
 ##
 @@ -687,6 +687,18 @@ public void testCastAsRowType() {
"CAST(`A` AS ROW(`F0` VARCHAR NOT NULL, `F1` TIMESTAMP) 
MULTISET)");
}
 
+   @Test
+   public void testValidateSqlCreateTable() {
+   String sql = "CREATE TABLE tbl1";
 
 Review comment:
   You mean the method name?  I've already changed it to 
testValidateEmptySqlCreateTable and testValidateEmptySqlCreateView?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334316640
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
 ##
 @@ -687,6 +687,18 @@ public void testCastAsRowType() {
"CAST(`A` AS ROW(`F0` VARCHAR NOT NULL, `F1` TIMESTAMP) 
MULTISET)");
}
 
+   @Test
+   public void testValidateSqlCreateTable() {
+   String sql = "CREATE TABLE tbl1";
 
 Review comment:
   You mean the method name?  I've already changed it to testValidateEmpty...?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot commented on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541488344
 
 
   
   ## CI report:
   
   * 85df9d5df107825b0ab8002a39eda6202bb8e976 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9860: [FLINK-14331][runtime] Reset vertices 
right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-539900648
 
 
   
   ## CI report:
   
   * 80c100513c089a9dd0930aa547383ae970c4e7f8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131094955)
   * 2de47e991caa74adea1792b6b9153dee94e46b95 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131457976)
   * 0c32e3b010d2ca9cb7371bb90833b9028c516b0e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131524791)
   * 4270dd87c5e6657708d32bc1dd71cd07ccb9e09f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131560712)
   * c602f6a3deb290f5f6106deefee0a02645126034 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334314565
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLValidationTest.java
 ##
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser;
+
+import org.apache.flink.sql.parser.ddl.SqlCreateTable;
+import org.apache.flink.sql.parser.ddl.SqlCreateView;
+import org.apache.flink.sql.parser.error.SqlValidateException;
+import org.apache.flink.sql.parser.impl.FlinkSqlParserImpl;
+
+import org.apache.calcite.avatica.util.Casing;
+import org.apache.calcite.avatica.util.Quoting;
+import org.apache.calcite.sql.SqlNodeList;
+import org.apache.calcite.sql.parser.SqlParseException;
+import org.apache.calcite.sql.parser.SqlParser;
+import org.apache.calcite.sql.parser.SqlParserImplFactory;
+import org.apache.calcite.util.SourceStringReader;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Validation tests for ddl fields.
+ */
+public class FlinkDDLValidationTest {
+
+   protected SqlParserImplFactory parserImplFactory() {
+   return FlinkSqlParserImpl.FACTORY;
+   }
+
+   private SqlParser getSqlParser(String sql) {
+   SourceStringReader source = new SourceStringReader(sql);
+   return SqlParser.create(source,
+   SqlParser.configBuilder()
 
 Review comment:
   +1. We can trace this problem in the JIRA issue. Resolving this...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334314005
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -76,7 +80,7 @@ public SqlCreateTable(
SqlCharStringLiteral comment) {
super(OPERATOR, pos, false, false);
this.tableName = requireNonNull(tableName, "Table name is 
missing");
-   this.columnList = requireNonNull(columnList, "Column list 
should not be null");
+   this.columnList = columnList;
 
 Review comment:
   Add `requireNonNull` on all the fields should not be null. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334314304
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateView.java
 ##
 @@ -44,6 +47,8 @@
private final SqlIdentifier viewName;
private final SqlNodeList fieldList;
private final SqlNode query;
+
+   @Nullable
private final SqlCharStringLiteral comment;
 
public SqlCreateView(
 
 Review comment:
   Could you also add `requireNonNull` for the fields should not be null in 
`SqlCreateView`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9892: Spillable test

2019-10-13 Thread GitBox
flinkbot commented on issue #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892#issuecomment-541486446
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 85df9d5df107825b0ab8002a39eda6202bb8e976 (Mon Oct 14 
02:35:19 UTC 2019)
   
   **Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **Invalid pull request title: No valid Jira ID provided**
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] banmoy opened a new pull request #9892: Spillable test

2019-10-13 Thread GitBox
banmoy opened a new pull request #9892: Spillable test
URL: https://github.com/apache/flink/pull/9892
 
 
   POC for SpillableStateBackend which only supports CopyOnWriteSkipListStateMap


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zhuzhurk commented on issue #9860: [FLINK-14331][runtime] Reset vertices right after they transition to terminated states

2019-10-13 Thread GitBox
zhuzhurk commented on issue #9860: [FLINK-14331][runtime] Reset vertices right 
after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#issuecomment-541485852
 
 
   Rebased onto master since FLINK-14291 is merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334313351
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   @danny0405  Yes, but this only works when it has columns. It doesn't work 
for sql "create table tbl1". In this PR, I initialize `primaryKeyList` and 
`uniqueKeysList` to avoid this situation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] HuangZhenQiu commented on issue #9887: [FLINK-14215] [docs] add environment variable configuration

2019-10-13 Thread GitBox
HuangZhenQiu commented on issue #9887: [FLINK-14215] [docs] add environment 
variable configuration
URL: https://github.com/apache/flink/pull/9887#issuecomment-541483441
 
 
   @rmetzger 
   The build passed https://travis-ci.com/HuangZhenQiu/flink/builds/131667038.
   Would you please help to merge it into master?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334311449
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
 ##
 @@ -687,6 +687,18 @@ public void testCastAsRowType() {
"CAST(`A` AS ROW(`F0` VARCHAR NOT NULL, `F1` TIMESTAMP) 
MULTISET)");
}
 
+   @Test
+   public void testValidateSqlCreateTable() {
+   String sql = "CREATE TABLE tbl1";
 
 Review comment:
   testValidateCreateTableWithNakedTableName


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334311321
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLValidationTest.java
 ##
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser;
+
+import org.apache.flink.sql.parser.ddl.SqlCreateTable;
+import org.apache.flink.sql.parser.ddl.SqlCreateView;
+import org.apache.flink.sql.parser.error.SqlValidateException;
+import org.apache.flink.sql.parser.impl.FlinkSqlParserImpl;
+
+import org.apache.calcite.avatica.util.Casing;
+import org.apache.calcite.avatica.util.Quoting;
+import org.apache.calcite.sql.SqlNodeList;
+import org.apache.calcite.sql.parser.SqlParseException;
+import org.apache.calcite.sql.parser.SqlParser;
+import org.apache.calcite.sql.parser.SqlParserImplFactory;
+import org.apache.calcite.util.SourceStringReader;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Validation tests for ddl fields.
+ */
+public class FlinkDDLValidationTest {
+
+   protected SqlParserImplFactory parserImplFactory() {
+   return FlinkSqlParserImpl.FACTORY;
+   }
+
+   private SqlParser getSqlParser(String sql) {
+   SourceStringReader source = new SourceStringReader(sql);
+   return SqlParser.create(source,
+   SqlParser.configBuilder()
 
 Review comment:
   Yes, it is, we may add an exception assertion when we passed in the error 
message explicitly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
danny0405 commented on a change in pull request #9843: [FLINK-14296] [Table 
SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334311147
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   `primaryKeyList` default is an empty list[1], also is `uniqueKeysList`[2], i 
agree the code is not that intuitive, i would make some refactoring if i have 
time.
   
   [1] 
https://github.com/apache/flink/blob/dbe1bfa31db4a561b6faa9c1235f02dc130825ca/flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl#L100
   
[2]https://github.com/apache/flink/blob/dbe1bfa31db4a561b6faa9c1235f02dc130825ca/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java#L316


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] 
FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if 
`newPartitionsInTransaction` is empty when enable EoS
URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428
 
 
   
   ## CI report:
   
   * 87ae788d6490da7af5284c404648647c9919a6df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129820284)
   * c4b5a18b039a90aa6b313c43f423622536bc8cd4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131462013)
   * d2f3997d1c9ceaec594b5160581b26bfed49ceff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131514683)
   * 0392625d9055fdbe44f8eff7198f61a480a513a2 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131697208)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] GJL closed pull request #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-13 Thread GitBox
GJL closed pull request #9872: [FLINK-14291][runtime,tests] Add test coverage 
to DefaultScheduler
URL: https://github.com/apache/flink/pull/9872
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] 
FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if 
`newPartitionsInTransaction` is empty when enable EoS
URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428
 
 
   
   ## CI report:
   
   * 87ae788d6490da7af5284c404648647c9919a6df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129820284)
   * c4b5a18b039a90aa6b313c43f423622536bc8cd4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131462013)
   * d2f3997d1c9ceaec594b5160581b26bfed49ceff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131514683)
   * 0392625d9055fdbe44f8eff7198f61a480a513a2 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131697208)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691044)
   * 47706d03f178962d0e0fabc4b4a51d0810be5e91 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131693072)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9824: [FLINK-14302] FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if `newPartitionsInTransaction` is empty when enable

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9824: [FLINK-14302] 
FlinkKafkaInternalProducer should not send `ADD_PARTITIONS_TO_TXN` request if 
`newPartitionsInTransaction` is empty when enable EoS
URL: https://github.com/apache/flink/pull/9824#issuecomment-536928428
 
 
   
   ## CI report:
   
   * 87ae788d6490da7af5284c404648647c9919a6df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129820284)
   * c4b5a18b039a90aa6b313c43f423622536bc8cd4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131462013)
   * d2f3997d1c9ceaec594b5160581b26bfed49ceff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131514683)
   * 0392625d9055fdbe44f8eff7198f61a480a513a2 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] 
Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032
 
 
   
   ## CI report:
   
   * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124167653)
   * 4263f76529de2d80aa3554ee91c206fc0f9152e5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124179375)
   * befcc101f408baca6bb2bf83eea14cb4a9f496bd : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124863326)
   * df676fa3d969772b8995538adc147bbb86c36189 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124881729)
   * 24328ec47f13f4a445f3c431ea6025a368aaedc1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/125238415)
   * 38d3ce4f2e78ec98aceea6a9d1f958f903ae5f3f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128211309)
   * cfbb8387223123f660bc5d5b1f02ec36616b6c11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128339902)
   * 2819c8dd4ede0cb088ac20ba3715e8d8bafb124e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129069417)
   * 1cf8f18b890dcbb0e19870cb4be6efc1a600fea5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129082047)
   * 20e2c58d7ba5b385a6b6e898a49b8ce9a0c81243 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129230744)
   * 8af6229634471ccd064c02b71fc60bc5262c8ab1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129306669)
   * 80bde06accbe5b4a6bf24d4346b5f3a285998403 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129428242)
   * f7233cb92215a8e85515fc897e079f875e3e3db4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/130546181)
   * 728f37b2743a9e969c3219b6ded682c9a497adc7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131594441)
   * cda6e8090f29f406298c2ae8c922f1902f3c6122 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131602364)
   * 57b4b4b6f94058a194b2206f61236872040f6f11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131612775)
   * 6c59df1414336a026a2e5a72087bff49b9627c19 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131636770)
   * d638070cc09553497ae22d28ea49f28ead88 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131693065)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9872: [FLINK-14291][runtime,tests] Add test 
coverage to DefaultScheduler
URL: https://github.com/apache/flink/pull/9872#issuecomment-540007360
 
 
   
   ## CI report:
   
   * 371827eb6bdb0d8e0cf626acb580b0b6b7eafbd3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/13114)
   * beca5e0a8b831b0a1e0d674c2855e4eebdea9953 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131357880)
   * 743a3906ebaad2107df00578996267bd91f86eb1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131535384)
   * dbe1bfa31db4a561b6faa9c1235f02dc130825ca : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131692371)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691044)
   * 47706d03f178962d0e0fabc4b4a51d0810be5e91 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131693072)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] 
Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032
 
 
   
   ## CI report:
   
   * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124167653)
   * 4263f76529de2d80aa3554ee91c206fc0f9152e5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124179375)
   * befcc101f408baca6bb2bf83eea14cb4a9f496bd : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124863326)
   * df676fa3d969772b8995538adc147bbb86c36189 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124881729)
   * 24328ec47f13f4a445f3c431ea6025a368aaedc1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/125238415)
   * 38d3ce4f2e78ec98aceea6a9d1f958f903ae5f3f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128211309)
   * cfbb8387223123f660bc5d5b1f02ec36616b6c11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128339902)
   * 2819c8dd4ede0cb088ac20ba3715e8d8bafb124e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129069417)
   * 1cf8f18b890dcbb0e19870cb4be6efc1a600fea5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129082047)
   * 20e2c58d7ba5b385a6b6e898a49b8ce9a0c81243 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129230744)
   * 8af6229634471ccd064c02b71fc60bc5262c8ab1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129306669)
   * 80bde06accbe5b4a6bf24d4346b5f3a285998403 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129428242)
   * f7233cb92215a8e85515fc897e079f875e3e3db4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/130546181)
   * 728f37b2743a9e969c3219b6ded682c9a497adc7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131594441)
   * cda6e8090f29f406298c2ae8c922f1902f3c6122 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131602364)
   * 57b4b4b6f94058a194b2206f61236872040f6f11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131612775)
   * 6c59df1414336a026a2e5a72087bff49b9627c19 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131636770)
   * d638070cc09553497ae22d28ea49f28ead88 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131693065)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691044)
   * 47706d03f178962d0e0fabc4b4a51d0810be5e91 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9872: [FLINK-14291][runtime,tests] Add test 
coverage to DefaultScheduler
URL: https://github.com/apache/flink/pull/9872#issuecomment-540007360
 
 
   
   ## CI report:
   
   * 371827eb6bdb0d8e0cf626acb580b0b6b7eafbd3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/13114)
   * beca5e0a8b831b0a1e0d674c2855e4eebdea9953 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131357880)
   * 743a3906ebaad2107df00578996267bd91f86eb1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131535384)
   * dbe1bfa31db4a561b6faa9c1235f02dc130825ca : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131692371)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] 
Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032
 
 
   
   ## CI report:
   
   * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124167653)
   * 4263f76529de2d80aa3554ee91c206fc0f9152e5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124179375)
   * befcc101f408baca6bb2bf83eea14cb4a9f496bd : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124863326)
   * df676fa3d969772b8995538adc147bbb86c36189 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124881729)
   * 24328ec47f13f4a445f3c431ea6025a368aaedc1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/125238415)
   * 38d3ce4f2e78ec98aceea6a9d1f958f903ae5f3f : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128211309)
   * cfbb8387223123f660bc5d5b1f02ec36616b6c11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128339902)
   * 2819c8dd4ede0cb088ac20ba3715e8d8bafb124e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129069417)
   * 1cf8f18b890dcbb0e19870cb4be6efc1a600fea5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129082047)
   * 20e2c58d7ba5b385a6b6e898a49b8ce9a0c81243 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129230744)
   * 8af6229634471ccd064c02b71fc60bc5262c8ab1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/129306669)
   * 80bde06accbe5b4a6bf24d4346b5f3a285998403 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129428242)
   * f7233cb92215a8e85515fc897e079f875e3e3db4 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/130546181)
   * 728f37b2743a9e969c3219b6ded682c9a497adc7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131594441)
   * cda6e8090f29f406298c2ae8c922f1902f3c6122 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131602364)
   * 57b4b4b6f94058a194b2206f61236872040f6f11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131612775)
   * 6c59df1414336a026a2e5a72087bff49b9627c19 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131636770)
   * d638070cc09553497ae22d28ea49f28ead88 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9891: Util method to get udfName

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9891: Util method to get udfName
URL: https://github.com/apache/flink/pull/9891#issuecomment-541419886
 
 
   
   ## CI report:
   
   * 3fd1154fa3727c5a5fbc92cfdaaf30451d69e6b5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691742)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691044)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9872: [FLINK-14291][runtime, tests] Add test coverage to DefaultScheduler

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9872: [FLINK-14291][runtime,tests] Add test 
coverage to DefaultScheduler
URL: https://github.com/apache/flink/pull/9872#issuecomment-540007360
 
 
   
   ## CI report:
   
   * 371827eb6bdb0d8e0cf626acb580b0b6b7eafbd3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/13114)
   * beca5e0a8b831b0a1e0d674c2855e4eebdea9953 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131357880)
   * 743a3906ebaad2107df00578996267bd91f86eb1 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131535384)
   * dbe1bfa31db4a561b6faa9c1235f02dc130825ca : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131691044)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9891: Util method to get udfName

2019-10-13 Thread GitBox
flinkbot commented on issue #9891: Util method to get udfName
URL: https://github.com/apache/flink/pull/9891#issuecomment-541419886
 
 
   
   ## CI report:
   
   * 3fd1154fa3727c5a5fbc92cfdaaf30451d69e6b5 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9891: Util method to get udfName

2019-10-13 Thread GitBox
flinkbot commented on issue #9891: Util method to get udfName
URL: https://github.com/apache/flink/pull/9891#issuecomment-541418211
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d589742ff57de1ce74ea77749a89134ed9bbc3c6 (Sun Oct 13 
13:23:10 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **Invalid pull request title: No valid Jira ID provided**
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot commented on issue #9890: [FLINK-14272][python][table-planner-blink] 
Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541418126
 
 
   
   ## CI report:
   
   * ec7f1a70fd420d25326e49ac1f4de878d4aae481 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] archit0 opened a new pull request #9891: Util method to getUdfName

2019-10-13 Thread GitBox
archit0 opened a new pull request #9891: Util method to getUdfName
URL: https://github.com/apache/flink/pull/9891
 
 
   - Created a util method to get the Udf name from callLocation
   
   
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
 - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
 - *Deployments RPC transmits only the blob storage reference*
 - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
 - *Extended integration test for recovery after master (JobManager) 
failure*
 - *Added test that validates that TaskInfo is transferred only once across 
recoveries*
 - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
 - The serializers: (yes / no / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
 - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
flinkbot commented on issue #9890: [FLINK-14272][python][table-planner-blink] 
Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#issuecomment-541416833
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit ec7f1a70fd420d25326e49ac1f4de878d4aae481 (Sun Oct 13 
13:04:50 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-14272).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] HuangXingBo opened a new pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF

2019-10-13 Thread GitBox
HuangXingBo opened a new pull request #9890: 
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890
 
 
   ## What is the purpose of the change
   
   *This pull request supports Blink planner for Python UDF*
   
   ## Brief change log
   
 - *Introduces PythonScalarFunctionSplitRule which split multiple 
ScalarFunctions contained in the same node*
 - *Introduces StreamExecPythonCalcRule/BatchExecPythonCalcRule*
 - *Introduces StreamExecPythonCalc/BatchExecPythonCalc for Python 
ScalarFunction execution*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
 - *Added test PythonScalarFunctionSplitRuleTest and blink planner it case 
in test_udf.py*
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9889: [FLINK-14355] [docs] Example code in 
state processor API docs doesn't compile
URL: https://github.com/apache/flink/pull/9889#issuecomment-541406869
 
 
   
   ## CI report:
   
   * e19b14735956644135960c9697bd64b597d02b3b : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131686398)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
carp84 commented on a change in pull request #9501: [FLINK-12697] [State 
Backends] Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#discussion_r334274093
 
 

 ##
 File path: 
flink-state-backends/flink-statebackend-heap-spillable/src/test/java/org/apache/flink/runtime/state/heap/CopyOnWriteSkipListStateMapTest.java
 ##
 @@ -115,577 +144,783 @@ public void testInitStateMap() {
assertFalse(stateMap.getStateIncrementalVisitor(100).hasNext());
 
stateMap.close();
-   assertEquals(0, stateMap.size());
-   assertEquals(0, stateMap.totalSize());
-   assertTrue(stateMap.isClosed());
}
 
/**
-* Test basic operations.
+* Test state put operation.
 */
@Test
-   public void testBasicOperations() throws Exception {
-   TypeSerializer keySerializer = IntSerializer.INSTANCE;
-   TypeSerializer namespaceSerializer = 
LongSerializer.INSTANCE;
-   TypeSerializer stateSerializer = 
StringSerializer.INSTANCE;
-   CopyOnWriteSkipListStateMap stateMap = 
new CopyOnWriteSkipListStateMap<>(
-   keySerializer, namespaceSerializer, stateSerializer, 
spaceAllocator);
+   public void testPutState() {
+   testWithFunction((totalSize, stateMap, referenceStates) -> 
getDefaultSizes(totalSize));
+   }
 
-   ThreadLocalRandom random = ThreadLocalRandom.current();
-   // map to store expected states, namespace -> key -> state
-   Map> referenceStates = new 
HashMap<>();
-   int totalSize = 0;
+   /**
+* Test remove existing state.
+*/
+   @Test
+   public void testRemoveExistingState() {
+   testRemoveState(false, false);
+   }
 
-   // put some states
-   for (long namespace = 0; namespace < 10; namespace++) {
-   for (int key = 0; key < 100; key++) {
-   totalSize++;
-   String state = String.valueOf(key * namespace);
-   if (random.nextBoolean()) {
-   stateMap.put(key, namespace, state);
-   } else {
-   assertNull(stateMap.putAndGetOld(key, 
namespace, state));
+   /**
+* Test remove and get existing state.
+*/
+   @Test
+   public void testRemoveAndGetExistingState() {
+   testRemoveState(false, true);
+   }
+
+   /**
+* Test remove absent state.
+*/
+   @Test
+   public void testRemoveAbsentState() {
+   testRemoveState(true, true);
 
 Review comment:
   I don't quite agree here. I think for the boolean parameters, it's normal to 
get their meaning through javadoc or parameter name in method signature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9889: [FLINK-14355] [docs] Example code in 
state processor API docs doesn't compile
URL: https://github.com/apache/flink/pull/9889#issuecomment-541406869
 
 
   
   ## CI report:
   
   * e19b14735956644135960c9697bd64b597d02b3b : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131686398)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-13 Thread GitBox
flinkbot commented on issue #9889: [FLINK-14355] [docs] Example code in state 
processor API docs doesn't compile
URL: https://github.com/apache/flink/pull/9889#issuecomment-541406869
 
 
   
   ## CI report:
   
   * e19b14735956644135960c9697bd64b597d02b3b : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-13 Thread GitBox
flinkbot commented on issue #9889: [FLINK-14355] [docs] Example code in state 
processor API docs doesn't compile
URL: https://github.com/apache/flink/pull/9889#issuecomment-541405685
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit e19b14735956644135960c9697bd64b597d02b3b (Sun Oct 13 
10:19:47 UTC 2019)
   
   **Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese 
documentation or file Jira ticket.
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-14355).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy opened a new pull request #9889: [FLINK-14355] [docs] Example code in state processor API docs doesn't compile

2019-10-13 Thread GitBox
buptljy opened a new pull request #9889: [FLINK-14355] [docs] Example code in 
state processor API docs doesn't compile
URL: https://github.com/apache/flink/pull/9889
 
 
   Fix compiling errors in examples of state processor api.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
 
 
   
   ## CI report:
   
   * b37d86b0fbc58892a68e821239b7083dffc46d75 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131678943)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] carp84 removed a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
carp84 removed a comment on issue #9501: [FLINK-12697] [State Backends] Support 
on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#issuecomment-541245502
 
 
   bq. Some of the tests seem to be a bit convoluted with a lot of indirections 
which are not easy to understand.
   Could you give me some example about such "convoluted with indirections"? Is 
it possible that the original `CopyOnWriteSkipListStateMapTest` is better 
regardless of the test case split up part?
   
   I've addressed all comments on `CopyOnWriteSkipListStateMap` and will get 
back on `CopyOnWriteSkipListStateMapTest` after getting some response. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-13 Thread GitBox
carp84 commented on a change in pull request #9501: [FLINK-12697] [State 
Backends] Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#discussion_r334180018
 
 

 ##
 File path: 
flink-state-backends/flink-statebackend-heap-spillable/src/test/java/org/apache/flink/runtime/state/heap/CopyOnWriteSkipListStateMapTest.java
 ##
 @@ -115,577 +144,783 @@ public void testInitStateMap() {
assertFalse(stateMap.getStateIncrementalVisitor(100).hasNext());
 
stateMap.close();
-   assertEquals(0, stateMap.size());
-   assertEquals(0, stateMap.totalSize());
-   assertTrue(stateMap.isClosed());
}
 
/**
-* Test basic operations.
+* Test state put operation.
 */
@Test
-   public void testBasicOperations() throws Exception {
-   TypeSerializer keySerializer = IntSerializer.INSTANCE;
-   TypeSerializer namespaceSerializer = 
LongSerializer.INSTANCE;
-   TypeSerializer stateSerializer = 
StringSerializer.INSTANCE;
-   CopyOnWriteSkipListStateMap stateMap = 
new CopyOnWriteSkipListStateMap<>(
-   keySerializer, namespaceSerializer, stateSerializer, 
spaceAllocator);
+   public void testPutState() {
+   testWithFunction((totalSize, stateMap, referenceStates) -> 
getDefaultSizes(totalSize));
+   }
 
-   ThreadLocalRandom random = ThreadLocalRandom.current();
-   // map to store expected states, namespace -> key -> state
-   Map> referenceStates = new 
HashMap<>();
-   int totalSize = 0;
+   /**
+* Test remove existing state.
+*/
+   @Test
+   public void testRemoveExistingState() {
+   testRemoveState(false, false);
+   }
 
-   // put some states
-   for (long namespace = 0; namespace < 10; namespace++) {
-   for (int key = 0; key < 100; key++) {
-   totalSize++;
-   String state = String.valueOf(key * namespace);
-   if (random.nextBoolean()) {
-   stateMap.put(key, namespace, state);
-   } else {
-   assertNull(stateMap.putAndGetOld(key, 
namespace, state));
+   /**
+* Test remove and get existing state.
+*/
+   @Test
+   public void testRemoveAndGetExistingState() {
+   testRemoveState(false, true);
+   }
+
+   /**
+* Test remove absent state.
+*/
+   @Test
+   public void testRemoveAbsentState() {
+   testRemoveState(true, true);
+   }
+
+   /**
+* Test remove previously removed state.
+*/
+   @Test
+   public void testPutPreviouslyRemovedState() {
+   testWithFunction(
+   (totalSize, stateMap, referenceStates) -> 
applyFunctionAfterRemove(stateMap, referenceStates,
+   (removedCnt, removedStates) -> {
+   int size = totalSize - removedCnt;
+   for (Map.Entry> 
entry : removedStates.entrySet()) {
+   long namespace = entry.getKey();
+   for (int key : 
entry.getValue()) {
+   size++;
+   String state = 
String.valueOf(key * namespace);
+   
assertNull(stateMap.putAndGetOld(key, namespace, state));
+   
referenceStates.computeIfAbsent(namespace, (none) -> new HashMap<>()).put(key, 
String.valueOf(state));
+   }
+   }
+   return getDefaultSizes(size);
}
-   referenceStates.computeIfAbsent(namespace, 
(none) -> new HashMap<>()).put(key, state);
-   assertEquals(totalSize, stateMap.size());
-   assertEquals(totalSize, stateMap.totalSize());
-   }
-   }
+   )
+   );
 
 Review comment:
   Let me try to improve... It seems sometimes we suggest to use functions to 
reduce duplicated codes and the other cases we are against it. Hopefully I 
could get better known about the standard/convention.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For 

[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131682155)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
 
 
   
   ## CI report:
   
   * b37d86b0fbc58892a68e821239b7083dffc46d75 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131678943)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wangxlong commented on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
wangxlong commented on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541398040
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131682155)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use 
Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-538718823
 
 
   
   ## CI report:
   
   * a9b3b6131bc282e47937d4eb4d9db4ab952ccd1a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/130566050)
   * de7da5abb5bc0bd9e59d0d2e3672a4f7cf649bf4 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/131624515)
   * ffaf3aec34e6bbe435b225d0d82b45b3c8ce7ff0 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131625462)
   * da22ea656e993c653c436c74958f281c22504592 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for 
optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
 
 
   @wucho  @danny0  Thanks for your review and I've improve the code according 
to most of your comments. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional 
for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
 
 
   @wuchong   @danny0405  Thanks for your review and I've improve the code 
according to most of your comments. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy edited a comment on issue #9843: [FLINK-14296] [Table SQL] Use Optional 
for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902
 
 
   @wucho  @danny0405  Thanks for your review and I've improve the code 
according to most of your comments. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334266966
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLValidationTest.java
 ##
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser;
+
+import org.apache.flink.sql.parser.ddl.SqlCreateTable;
+import org.apache.flink.sql.parser.ddl.SqlCreateView;
+import org.apache.flink.sql.parser.error.SqlValidateException;
+import org.apache.flink.sql.parser.impl.FlinkSqlParserImpl;
+
+import org.apache.calcite.avatica.util.Casing;
+import org.apache.calcite.avatica.util.Quoting;
+import org.apache.calcite.sql.SqlNodeList;
+import org.apache.calcite.sql.parser.SqlParseException;
+import org.apache.calcite.sql.parser.SqlParser;
+import org.apache.calcite.sql.parser.SqlParserImplFactory;
+import org.apache.calcite.util.SourceStringReader;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Validation tests for ddl fields.
+ */
+public class FlinkDDLValidationTest {
+
+   protected SqlParserImplFactory parserImplFactory() {
+   return FlinkSqlParserImpl.FACTORY;
+   }
+
+   private SqlParser getSqlParser(String sql) {
+   SourceStringReader source = new SourceStringReader(sql);
+   return SqlParser.create(source,
+   SqlParser.configBuilder()
 
 Review comment:
   I've deleted the FlinkDDLValidationTest.java and migrate the tests into 
FlinkSqlParserImplTest.
   
   BTW, I find there is a serious bug in ValidationMatcher in 
FlinkSqlParserImplTest. I've created a jira 
issue(https://issues.apache.org/jira/browse/FLINK-14384) for it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334265001
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   @danny0405  `primaryKeyList` and `uniqueKeysList` are null if they're not 
defined because we define them in parserImpls.ftl as null by default, which is 
different with other fields like propertyList and partitionColumns. Please 
correct me if I'm wrong.
   
   @wuchong I kind of misunderstand your comments in jira. I thought we should 
keep `primaryKeyList` and `uniqueKeysList` 's default value. I will make them 
consistent with propertyList and partitionColumns.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for 
optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#issuecomment-541394973
 
 
   @flinkbot run travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
 
 
   
   ## CI report:
   
   * b37d86b0fbc58892a68e821239b7083dffc46d75 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/131678943)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot edited a comment on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
 
 
   
   ## CI report:
   
   * b37d86b0fbc58892a68e821239b7083dffc46d75 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131678943)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391905
 
 
   
   ## CI report:
   
   * b37d86b0fbc58892a68e821239b7083dffc46d75 : UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-13 Thread GitBox
buptljy commented on a change in pull request #9843: [FLINK-14296] [Table SQL] 
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334265001
 
 

 ##
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##
 @@ -57,12 +60,15 @@
 
private final SqlNodeList propertyList;
 
+   @Nullable
 
 Review comment:
   @danny0405  `primaryKeyList` and `uniqueKeysList` are null if they're not 
defined because we define them in parserImpls.ftl as null by default, which is 
different with other fields like propertyList and partitionColumns.
   
   @wuchong I kind of misunderstand your comments in jira. I thought we should 
keep `primaryKeyList` and `uniqueKeysList` 's default value. I will make them 
consistent with propertyList and partitionColumns.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
flinkbot commented on issue #9888: [hotfix][doc]fix typos in richfunction
URL: https://github.com/apache/flink/pull/9888#issuecomment-541391094
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b37d86b0fbc58892a68e821239b7083dffc46d75 (Sun Oct 13 
06:29:09 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wangxlong opened a new pull request #9888: [hotfix][doc]fix typos in richfunction

2019-10-13 Thread GitBox
wangxlong opened a new pull request #9888: [hotfix][doc]fix typos in 
richfunction
URL: https://github.com/apache/flink/pull/9888
 
 
   ## What is the purpose of the change
   Fix typos in RichFunction annotation. For only RichFilterFunction has open 
method to extend, so we should change FilterFunction to RichFilterFunction.
   
   ## Brief change log
   typos in RichFunction
   
   ## Verifying this change
   This change is a trivial work.
   
   ## Does this pull request potentially affect one of the following parts:
 - Dependencies (does it add or upgrade a dependency): ( no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an 
implementation of pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405
 
 
   
   ## CI report:
   
   * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/119869757)
   * 6a187929b931a4bd8cd7dbd0ec3d2c5a7a98278d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121411219)
   * 4f2afd322f96aeaba6d9c0b67a82a051eff22df0 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121723032)
   * c4fc6905d3adf3ad9ff6f58c5d4f472fdfa7d52b : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121724039)
   * b1855d5dfff586e41f152a6861ae04f30042cfde : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/127193220)
   * 54210a098757726e439e71797c44a6c22d48bc27 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128328713)
   * b089ac03c90e327467a903fcba5d61fbfdf2583e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128458501)
   * 67f96bda736cf31fb9edee77dc5ec8ccb37a63fd : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/128685328)
   * 54c4c47a573ea7d86ac3a226c5ee1693cf3bbaf5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129062768)
   * 2983c5d535e3caa98389665c36fbfea229c232b9 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129233636)
   * 576ff18cd9d0174ffd6737f17ce59f4820a4d3a5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129585067)
   * 16f1ec83d5e8562fafb69a3b2950b8b5c1a6340b : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129589023)
   * acb4479ac4cda25b7c9fd809dc7e4de4c47ebe4a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131514727)
   * a13f249a530d00db2860166fdf392080bfc71626 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131646104)
   * 750515312b78b0c9d420c00c82cccbda3a8b474b : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131672900)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-10-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an 
implementation of pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405
 
 
   
   ## CI report:
   
   * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/119869757)
   * 6a187929b931a4bd8cd7dbd0ec3d2c5a7a98278d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121411219)
   * 4f2afd322f96aeaba6d9c0b67a82a051eff22df0 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121723032)
   * c4fc6905d3adf3ad9ff6f58c5d4f472fdfa7d52b : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121724039)
   * b1855d5dfff586e41f152a6861ae04f30042cfde : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/127193220)
   * 54210a098757726e439e71797c44a6c22d48bc27 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128328713)
   * b089ac03c90e327467a903fcba5d61fbfdf2583e : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/128458501)
   * 67f96bda736cf31fb9edee77dc5ec8ccb37a63fd : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/128685328)
   * 54c4c47a573ea7d86ac3a226c5ee1693cf3bbaf5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129062768)
   * 2983c5d535e3caa98389665c36fbfea229c232b9 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129233636)
   * 576ff18cd9d0174ffd6737f17ce59f4820a4d3a5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129585067)
   * 16f1ec83d5e8562fafb69a3b2950b8b5c1a6340b : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/129589023)
   * acb4479ac4cda25b7c9fd809dc7e4de4c47ebe4a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131514727)
   * a13f249a530d00db2860166fdf392080bfc71626 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/131646104)
   * 750515312b78b0c9d420c00c82cccbda3a8b474b : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/131672900)
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   5   6   7   8   9   10   >