Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205110205
--- Diff:
flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java
---
@@ -66,14
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205084257
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205084180
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205082457
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205080760
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205076492
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6372#discussion_r205030130
--- Diff: flink-end-to-end-tests/README.md ---
@@ -31,6 +31,12 @@ You can also run tests individually via
$ FLINK_DIR= flink-end-to-end-tests/run
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6415
[FLINK-8974] Run all-round DataSet job with failures in HA mode
Added all-round DataSet end-to-end test that runs in HA mode. It verifies
the job is restarted correctly after job manager failure
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6388
Thanks for the review @StefanRRichter and @zentol. Will fix the indentation
while merging.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6388
In the first place I thought it might make providing the variables a bit
more flexible with `flink-env.sh`. In the end it is just a bash script, but the
longer I think the more convinced I am it
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6388
I added a small section. I was thorn a little in the first place if we
should make it highly visible in docs as it might be wrongly understood those
variables will be distributed to the cluster as
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204328745
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/README.md ---
@@ -0,0 +1,118 @@
+# Apache Hadoop Docker image with Kerberos
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204327765
--- Diff: flink-end-to-end-tests/test-scripts/test_yarn_kerberos_docker.sh
---
@@ -0,0 +1,104 @@
+#!/usr/bin/env bash
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6388
[FLINK-6222] Allow passing env variables to start scripts via
Added possibility to pass env variables (e.g. HADOOP_CONF_DIR) through
flink-env.sh
You can merge this pull request into a Git
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204057806
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/docker-compose.yml
---
@@ -0,0 +1,87
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204057939
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/docker-compose.yml
---
@@ -0,0 +1,87
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204057245
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
---
@@ -0,0 +1,121 @@
+#!/bin/bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6372#discussion_r204022195
--- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
@@ -51,6 +51,7 @@ run_test "Shaded Hadoop S3A end-to-end test"
"$END_TO_END_D
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6372#discussion_r204021806
--- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
@@ -51,6 +51,7 @@ run_test "Shaded Hadoop S3A end-to-end test"
"$END_TO_END_D
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204020995
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
---
@@ -0,0 +1,121 @@
+#!/bin/bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204020749
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/README.md ---
@@ -0,0 +1,118 @@
+# Apache Hadoop Docker image with Kerberos
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204019505
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204018916
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204017957
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204017611
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r204017355
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r203982453
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/docker-compose.yml
---
@@ -0,0 +1,87
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r203983391
--- Diff: flink-end-to-end-tests/test-scripts/test_yarn_kerberos_docker.sh
---
@@ -0,0 +1,104 @@
+#!/usr/bin/env bash
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6377#discussion_r203981196
--- Diff:
flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/Dockerfile ---
@@ -0,0 +1,159
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6372
It probably requires some polishing, but would like to hear general
comments if it is a step in the right direction.
Would love to hear you opinions @tillrohrmann @aljoscha
---
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6372
[Flink 9353] Tests running per job standalone cluster with Docker &
Kubernetes
## What is the purpose of the change
Tests that we can run flink jobs in a standalone per job cluster
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6371
[FLINK-9871] Use Description class for ConfigOptions with rich formatâ¦
Updated `ConfigOptions` which had links to use `Description` class, which
properly handles rich formatting.
You can merge
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6259
Actually I've suggested to move the whole writing schema logic into the
coder. So the coder should have a method like `writeSchema(..., OutputStream
out)`.
Substituting previous `
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6259
@medcv the new commit does not address any of my previous comments or I
don't understand something.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6344
Merging this, when my travis gives green.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6312
Merging, will fix a spelling mistake in test while merging (if my travis
gives green).
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6344#discussion_r203325086
--- Diff: flink-container/kubernetes/README.md ---
@@ -17,6 +17,7 @@ The files contain the following variables:
- `${FLINK_IMAGE_NAME}`: Name of
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6344#discussion_r203324113
--- Diff: flink-dist/src/main/flink-bin/bin/standalone-job.sh ---
@@ -56,7 +56,7 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP ==
"s
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r203292416
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r203268482
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r203070220
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6297
LGTM for me, Thanks for your contribution @yanghua.
@GJL would you like to have last look, or can I merge it?
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r203003509
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r203000441
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -352,6 +352,76 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r203000456
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -352,6 +352,76 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r203000672
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -352,6 +352,76 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r203000806
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -352,6 +352,76 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202992096
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202967561
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6294
I've rebased it on top of rich formatting feature for documentation,
therefore only the last commit applies to the issue.
I will also check the `DominantResourceCalculator` once again.
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202803069
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6344
[FLINK-9866] Allow passing command line arguments to standalone job
## What is the purpose of the change
Allow passing program arguments to standalone job
## Brief change log
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6338
merging
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6297
Changes look good now. I think we are still missing tests for the added
behaviour. We should check:
- if yarn cli parameters are properly parsed without units
- if yarn cli parameters
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202623960
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +500,19 @@ protected Configuration
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202624004
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +500,19 @@ protected Configuration
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202599741
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6338
[FLINK-8731] Replaced mockito with custom mock in TestInputChannel
Replaced questionable usage if Mockito with custom written mock.
You can merge this pull request into a Git repository by
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6260
+1, merging
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202365404
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r202359797
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6109
+1, merging
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6110
Thanks @makeyang for your contribution.
Could you also regenerate the documentation to update the description for
this option on the web page.
You can do it by:
mvn
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202338957
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +501,11 @@ protected Configuration
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202338312
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java
---
@@ -29,6 +29,46 @@
private static final String
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202339002
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +501,11 @@ protected Configuration
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202338296
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java
---
@@ -29,6 +29,46 @@
private static final String
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6283
Thanks @tillrohrmann for review. I've pushed one more commit that fixes
test failure. It adds proper comparison of `RestartStrategies`, otherwise
`org.apache.flink.api.common.ExecutionConfi
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202320783
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
---
@@ -357,6 +362,42 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202319384
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -339,12 +339,28 @@ public void
setSnapshotSettings
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202311125
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java
---
@@ -149,7 +149,7 @@ public static
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5516
Thanks, merging.
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202098798
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CoordinatorShutdownTest.java
---
@@ -83,6 +86,10 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202085772
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202059575
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202023148
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202018873
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6260
Hi @Myasuka ,
Thank you for your contribution. How about extracting it to a helper method
e.g. `createTestContinousFileMonitoringFunction`?
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6310
+1
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5516
Hi @BillLeecn
Thank you for the contribution!
Would you mind adding guard against null messages as well? Other than that
it looks good.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6274
+1
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201940611
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201844991
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/LineBreakElement.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201819026
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/ListElement.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201819059
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/BlockElement.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201818972
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/description/Formatter.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201803766
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201803366
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6312#discussion_r201796123
--- Diff: docs/_includes/generated/security_configuration.html ---
@@ -10,7 +10,7 @@
security.ssl.algorithms
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6312
[FLINK-9792] Added custom Description class for ConfigOptions to enable
rich formatting.
## What is the purpose of the change
Enable rich formatting of options description
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6205
Hi @Aitozi ,
Thanks for the work here. I think we could improve a bit separation of
concerns in the SharedBuffer. I am a bit afraid this class will become too
complex once again. How about we
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6205
Hi @Aitozi ,
Thanks for the work here. I think we could improve a bit separation of
concerns in the SharedBuffer. I am a bit afraid this class will become too
complex once again. How about we
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6120#discussion_r201662934
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -119,19 +120,15 @@ public boolean filter(Event value) throws
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6120#discussion_r201655890
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -584,21 +581,6 @@ private static void registerFactory
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6120#discussion_r201655466
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -584,21 +581,6 @@ private static void registerFactory
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6120#discussion_r201657797
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -695,29 +678,14 @@ private static void registerFactory
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r201399926
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,7 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6294#discussion_r201394304
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -132,7 +132,10 @@ Stop the YARN session by stopping the unix process
(using CTRL+C) or by entering
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6294
@NicoK Could you have a look, as you were the one that created this issue?
---
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6294
[FLINK-9013][docs] Document yarn.containers.vcores only being effective
wheâ¦
Added required configuration documentation on the cluster side for the
parameter `yarn.containers.vcores` to take
1 - 100 of 637 matches
Mail list logo