[GitHub] flink pull request #5372: [FLINK-8101] [es connector] Elasticsearch 6.x (and...

2018-01-30 Thread fpompermaier
Github user fpompermaier closed the pull request at: https://github.com/apache/flink/pull/5372 ---

[GitHub] flink issue #5372: [FLINK-8101] [es connector] Elasticsearch 6.x (and 5.3+) ...

2018-01-30 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/5372 Closed in favour of more advanced implementation of PR #5374 or #4675. This PR was just a draft to start a discussion in https://issues.apache.org/jira/browse/FLINK-8101 ---

[GitHub] flink pull request #5372: [FLINK-8101] [es connector] Elasticsearch 6.x (and...

2018-01-26 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/5372 [FLINK-8101] [es connector] Elasticsearch 6.x (and 5.3+) Flink connector ## Purpose of the change : implementation of Flink ES connector (5.3+) See https://issues.apache.org/jira/browse

[GitHub] flink pull request #:

2018-01-25 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/commit/b5caaef82add4a6f424094d526700c77b011724e#commitcomment-27100256 In flink-connectors/flink-connector-elasticsearch5/src/main/java/org/apache/flink/streaming/connectors/elasticsearch5

[GitHub] flink issue #4670: [FLINK-2170] [connectors] Add ORC connector for TableSour...

2017-10-20 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/4670 Any update on this? reading ORC data would be a very nice feature.. ---

[GitHub] flink pull request #4572: [Flink-7243] [connectors] Add ParquetInputFormat

2017-09-20 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/4572#discussion_r139971451 --- Diff: flink-connectors/flink-parquet/pom.xml --- @@ -0,0 +1,81 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2017-05-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2332 anyone working on this? HBase streaming sink would be a very nice addition... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-20 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Now it should be ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Of course..but how should I handle them? should I catch just one exception? What should I log? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Anyone willing to merge this PR...? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a single s...

2017-04-18 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3686 You were right @patricklucas, now I've correct the email address in my .gitconfig. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a s...

2017-04-07 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3686#discussion_r110337693 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -162,11 +162,11 @@ public void

[GitHub] flink issue #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a single s...

2017-04-07 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3686 Is it ok...? Could this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a s...

2017-04-06 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3686#discussion_r110164047 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -180,6 +180,52 @@ public void

[GitHub] flink pull request #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a s...

2017-04-06 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3686#discussion_r110159791 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -180,6 +180,52 @@ public void

[GitHub] flink pull request #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a s...

2017-04-06 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/3686 [FLINK-6271][jdbc]Fix nullPointer when there's a single split Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-03-27 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Does the current exception handling address your comments @StephanEwen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3598: [FLINK-6103] LocalFileSystem rename() uses File.re...

2017-03-24 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3598#discussion_r107894608 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java --- @@ -262,8 +265,13 @@ public FSDataOutputStream create

[GitHub] flink pull request #3598: [Flink-6103] LocalFileSystem rename() uses File.re...

2017-03-22 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/3598 [Flink-6103] LocalFileSystem rename() uses File.renameTo() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3417: [FLINK-5907] [java api] [WIP] Fix trailing empty fields i...

2017-02-27 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3417 I've tested your PR against my original CSV that was causing the problem and it works now! Thanks for this fix --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...

2017-02-24 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 Awesome news! Thanks a lot @tzulitai for the great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3107 It's for this reason that I think that Flink needs a "source catalog" somewhere.. On 22 February 2017 at 09:35, twalthr <notificati...@github.com> wrote:

[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...

2017-02-17 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 Any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #3246: [FLINK-5353] [elasticsearch] User-provided failure handle...

2017-02-01 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3246 I think that's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #3112: [FLINK-4988] [elasticsearch] Add Elasticsearch 5.x Connec...

2017-01-31 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3112 Hi @tzulitai, congrats for the great work! For my use case it is important also to be resilient to malformed documents (https://issues.apache.org/jira/browse/FLINK-5353). Do you think you could

[GitHub] flink pull request #3112: [FLINK-4988] [elasticsearch] Add Elasticsearch 5.x...

2017-01-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3112#discussion_r96265039 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java

[GitHub] flink issue #2861: [FLINK-5122] Index requests will be retried if the error ...

2016-12-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2861 Indeed my goal is to replace completely Logstash with Flink becuase Flink is much faster (Logstash is the official Elasticsearch indexer). On a 10 M docs Flink takes 10 min while Logstash 30

[GitHub] flink issue #2861: [FLINK-5122] Index requests will be retried if the error ...

2016-12-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2861 @rmetzger Are you sure that Logstash doesn't perform any retry logic..? For example https://logstash.jira.com/browse/LOGSTASH-720 seems to implement that.. You can test document loss

[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...

2016-11-23 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 Fine for us about the ES helper. Since it took some time to implement that functionality and the was a JIRA ticket for that we thought that it was a good idea to share that code with other

[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...

2016-11-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 From my point of view ElasticSearchHelper is very useful if you plan to use the Flink Elasticsearch Sink in a real production use case, because it reduce a lot the complexity of interfacing

[GitHub] flink issue #2829: Hotfix 2016 11 18

2016-11-18 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2829 Could this be a possible fix for FLINK-4719? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2790: [FLINK-4491] Handle index.number_of_shards in the ...

2016-11-17 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/2790#discussion_r88567247 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2

[GitHub] flink pull request #2790: [FLINK-4491] Handle index.number_of_shards in the ...

2016-11-17 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/2790#discussion_r88566350 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/helper

[GitHub] flink pull request #2790: [FLINK-4491] Handle index.number_of_shards in the ...

2016-11-17 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/2790#discussion_r88566247 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/helper

[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...

2016-11-17 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 Any other feedback on this?could it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2297: [FLINK-4081] [core] [table] FieldParsers should support e...

2016-08-02 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2297 For our use cases it is important to know whether a value of cell is empty or it is 0. The EMPTY_STRING error could be intercepted by the csv parser in order to generate Row objects

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Ok for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread fpompermaier
Github user fpompermaier closed the pull request at: https://github.com/apache/flink/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-21 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Don't worry @twalthr, it will be nice to have it in the 1.1 but I understand that it's not a priority :) Thanks a lot for the update! --- If your project is set up for it, you can reply

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Hi @twalthr, any news about this? Are you going to merge this PR in the upcoming 1.1 release? If you were waiting for a feedback you have my +1 about your strategy..go ahead and convert

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67314234 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -0,0 +1,1075

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67299396 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -0,0 +1,1075

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67296019 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java --- @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67295853 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java --- @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67295498 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java --- @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] flink pull request #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-16 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1989#discussion_r67295348 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -0,0 +1,1075

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-03 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 Now it should be ok, according to your suggestions. I misunderstood what @StephanEwen was trying to say, thanks @zentol for the clarification! Just another thing: the method

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-01 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 I think that leaving the responsibility of calling resetErrorStateAndParse() to "consumers" of FieldParser is really a bad idea. Isn't safer to force its call using the strate

[GitHub] flink pull request: [FLINK-3908] Fixed Parser's error state reset

2016-06-01 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/2007 How should I proceed here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2016-05-27 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-222177257 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3908] Fixed Parser's error state reset

2016-05-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/2007#issuecomment-221880071 I don't understand :( Assuming that `reset` could be renamed as `resetErrorStateAndParse`, the other 2 suggestions cannot be applied to my current

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-221864540 From my tests it does but I think it is something that should have a unit test --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3908] Fixed Parser's error state reset

2016-05-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/2007#issuecomment-221862570 Hi Stephan, thanks for reviewing this PR. These are my reasons to not apply your suggestions to my PR, and I'd like to hear your opinion (anyone interested

[GitHub] flink pull request: [Flink-3908] Fixed Parser's error state reset

2016-05-19 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/2007 [Flink-3908] Fixed Parser's error state reset Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request: Flink 3750 fixed

2016-05-18 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r63680024 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java --- @@ -156,88 +63,97 @@ public

[GitHub] flink pull request: FLINK-3901 - Added CsvRowInputFormat

2016-05-13 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/1989 FLINK-3901 - Added CsvRowInputFormat Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink pull request: Flink 3750 fixed

2016-05-11 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62854701 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java --- @@ -0,0 +1,91

[GitHub] flink pull request: Flink 3750 fixed

2016-05-11 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62852662 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -157,14 +216,25 @@ public

[GitHub] flink pull request: Flink 3750 fixed

2016-05-11 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62850239 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java --- @@ -0,0 +1,182

[GitHub] flink pull request: Flink 3750 fixed

2016-05-11 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62847383 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -81,25 +134,51 @@ public void

[GitHub] flink pull request: Flink 3750 fixed

2016-05-04 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62022375 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -157,14 +203,25 @@ public

[GitHub] flink pull request: Flink 3750 fixed

2016-05-04 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62021375 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -157,14 +203,25 @@ public

[GitHub] flink pull request: Flink 3750 fixed

2016-05-04 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r62019523 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -157,14 +203,25 @@ public

[GitHub] flink pull request: Flink 3750 fixed

2016-05-02 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1941#discussion_r61736272 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -26,52 +26,69 @@ import

[GitHub] flink pull request: Flink 3750 fixed

2016-04-26 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/1941 Flink 3750 fixed Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1885#issuecomment-214813684 Sorry messed up... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-26 Thread fpompermaier
Github user fpompermaier closed the pull request at: https://github.com/apache/flink/pull/1885 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1903#issuecomment-214730690 I added the missing assert, now it should be ok! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-23 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60828060 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/InputFormatVertex.java --- @@ -82,9 +82,6 @@ public void initializeOnMaster

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-22 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1903#issuecomment-213406637 Me and Stefano agree on this :) I'll will edit the PR and commit today --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-20 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1885#issuecomment-212479891 Depends on Flink-3777 (https://github.com/apache/flink/pull/1903) to properly manage the single connection instantiation --- If your project is set up for it, you

[GitHub] flink pull request: Managed closeInputFormat()

2016-04-18 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/1903 Managed closeInputFormat() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-15 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59851873 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -119,7 +118,11 @@ private

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59728464 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -139,13 +163,10 @@ public void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59728344 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -58,54 +52,39 @@ public

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59729313 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/DerbyUtil.java --- @@ -19,7 +19,6 @@ import

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59728967 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -232,7 +255,7 @@ private void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59715336 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -139,13 +163,10 @@ public void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59713178 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -232,7 +255,7 @@ private void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59712911 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -241,10 +264,31 @@ private void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59712726 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -139,13 +163,10 @@ public void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59712650 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java --- @@ -81,19 +90,34 @@ public void

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59712441 --- Diff: flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -58,54 +52,39 @@ public

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59712531 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/RangeInputSplit.java --- @@ -0,0 +1,58

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1885#discussion_r59711573 --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/RangeInputSplit.java --- @@ -0,0 +1,58

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...

2016-04-14 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/1885 Improved JDBCInputFormat (FLINK-3750) and other fixes Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750), fixed t...

2016-04-14 Thread fpompermaier
Github user fpompermaier closed the pull request at: https://github.com/apache/flink/pull/1884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3570), fixed t...

2016-04-14 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1884#issuecomment-209901546 Yes Ufuk, you're right! it is 3750...do I have to reissue a PR with the right branch name? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3570), fixed t...

2016-04-14 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/1884 Improved JDBCInputFormat (FLINK-3570), fixed test Exceptions in the Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request: [FLINK-2964] [runtime] Fix broken spilling of ...

2015-11-03 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1324#issuecomment-153606566 Do yiu think that this could fix also #2763? On 4 Nov 2015 02:20, "Till Rohrmann" <notificati...@github.com> wrote: > The HashPart

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-27 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r29130488 --- Diff: flink-staging/flink-hbase/pom.xml --- @@ -112,6 +112,12 @@ under the License. /exclusion

[GitHub] flink pull request: Fixed missing call to configure() for Configur...

2015-04-27 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/632 Fixed missing call to configure() for Configurable HadoopOutputFormats (Flink-1828) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: Addde HBase OutputFormat example (Flink-1828)

2015-04-27 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/633 Addde HBase OutputFormat example (Flink-1828) Fixed on top of PR #632, shows how to write data into HBase You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-23 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r28966088 --- Diff: flink-staging/flink-hbase/pom.xml --- @@ -112,6 +112,12 @@ under the License. /exclusion

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-22 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r28869610 --- Diff: flink-staging/flink-hbase/pom.xml --- @@ -112,6 +112,12 @@ under the License. /exclusion

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-21 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r28765996 --- Diff: flink-staging/flink-hbase/pom.xml --- @@ -112,6 +112,12 @@ under the License. /exclusion

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-21 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r28766073 --- Diff: flink-staging/flink-hbase/src/test/resources/hbase-site.xml --- @@ -22,14 +22,13 @@ -- configuration +!-- --- End

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-07 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/571#issuecomment-90481118 Ok, I created this issue (https://issues.apache.org/jira/browse/FLINK-1834) about the mapred.output.dir --- If your project is set up for it, you can reply

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/571 Fixed Configurable HadoopOutputFormat (FLINK-1828) See https://issues.apache.org/jira/browse/FLINK-1828 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/571#issuecomment-89570344 Removed comments and commented code as suggested by Fabian. Do I have also to create a JIRA ticket about mapred.output.dir parameter? I think that it can

  1   2   >