[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r579274752 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r579259796 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r579234673 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,41 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578786368 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578787023 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578786368 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578737299 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-05 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r569986337 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -522,6 +527,7 @@ protected

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-04 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r570520523 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ## @@ -1022,18 +1021,38 @@ private boolean

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-03 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r570012364 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -870,6 +874,78 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-03 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r569986337 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -522,6 +527,7 @@ protected

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-03 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r569720896 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraphTest.java ## @@ -371,9 +375,12 @@ private static

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-03 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r569551171 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java ## @@ -317,13 +316,11 @@ public TaskManagerLocation

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567422474 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -870,6 +874,78 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567421044 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java ## @@ -267,9 +267,16 @@ private void

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567418341 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -641,6 +648,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567418118 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -870,6 +874,78 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567417737 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -164,6 +168,8 @@ private final Map

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-01-31 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r567417575 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailureHandlingResult.java ## @@ -100,17 +116,22 @@