[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-216280065 Implemented in 08e4bf9440a566c874c2b8e74ae2127ff264c672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-216277509 Updated docs. Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-216042040 Thanks for the updates @greghogan. Could you please also add the new `GraphAlgorithm`s in the docs? And maybe explain when to use those instead of the Graph methods?

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215738750 I pushed the most recent changes. In order of things I care more about to things I care less about: The indentation is as intended. I find method chaining on

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61583101 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueAddOffset.java --- @@ -0,0 +1,50 @@ +/* + *

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61582214 --- Diff: flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -407,6 +407,36 @@ TypeInformation :

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61579289 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61552437 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551910 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551647 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551561 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551440 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/Translate.java --- @@ -0,0 +1,346 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551292 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueAddOffset.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551265 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueToStringValue.java --- @@ -0,0 +1,39 @@ +/* + *

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551225 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueToIntValue.java --- @@ -0,0 +1,47 @@ +/* + *

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551172 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueAddOffset.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61551105 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/LongValueAddOffset.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61550681 --- Diff: flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -407,6 +407,36 @@ TypeInformation :

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215663664 My intention was to simplify the API, not have different ways to do the same thing. Anyway, if you think it's useful to have both the methods and the algorithms, I won't

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215451225 One can now choose between: `graph.translateEdgeValues(new LongValueToStringValue()))` `graph.run(new TranslateEdgeValues<>(new LongValueToStringValue()))`

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215440722 There's no reason we can't have both algorithms and methods on `Graph` which run the algorithm and ignore customization. I'll add this shortly. --- If your project

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215432236 We can't translate vertex or edge IDs without modifying both as long as we want to return a `Graph` Setting parallelism is critical to scaling Flink to large

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215428452 Hi @greghogan, I feel we're over-engineering something that should be way simpler... Translators are just a set of `MapFunction`s applied on vertex or edge ids

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215167381 The switch to `MapFunction` means that a user can use a `RichMapFunction` with open, close, accumulators, etc. Rather than add six new methods to `Graph` I

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215040606 I think this is a very good idea, and we can wrap the user's MapFunction to function like a MapFunction. Now we can start discussing algorithms :) --- If

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-215012658 How about we add the translate methods to the `Graph` class and implement translators as `MapFunction`? This way they can be used even if don't have a graph but

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-214825734 By reuse I was referring to needing `MapVertexValueLongToString` and `MapEdgeValueLongToString` since the current `Graph` methods operate at the level of `Vertex` and

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-214782976 Hi @vasia, Comparing the APIs, `Translate` processes at the level of label or value whereas `mapVertices/Edges` process vertices and edges. What are use cases for

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1900#discussion_r61083553 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/translate/Translate.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1900#issuecomment-214733082 Hi @greghogan, I looked at the PR in more detail and I have some thoughts. First, why do we need a `Translate` class and `Translator` interface? Can't we simply

[GitHub] flink pull request: [FLINK-3771] [gelly] Methods for translating G...

GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1900 [FLINK-3771] [gelly] Methods for translating Graphs Methods for translation of the type or value of graph labels, vertex values, and edge values. You can merge this pull request into a Git