Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4894
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147661477
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -38,23 +38,26 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147661037
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -56,33 +63,123 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147658004
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceUtil.scala
---
@@ -0,0 +1,518 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147657884
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FieldComputer.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147583120
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FieldComputer.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147574828
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceUtil.scala
---
@@ -0,0 +1,518 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147580191
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -56,33 +63,123 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147582469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -38,23 +38,26 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147358782
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -84,6 +86,13
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147339907
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonScan.scala
---
@@ -18,55 +18,7 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147339820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1332,6 +1322,11 @@ abstract class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147339574
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -124,9 +124,15 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146574319
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -84,6 +86,13
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146582532
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -124,9 +124,15 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146576347
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableSchema.scala
---
@@ -50,6 +50,11 @@ class TableSchema(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146586028
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonScan.scala
---
@@ -18,55 +18,7 @@
package
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146584051
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -246,40 +245,31 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146585641
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1332,6 +1322,11 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146587166
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/PhysicalTableSourceScan.scala
---
@@ -22,24 +22,30 @@ import
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146575110
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
---
@@ -89,34 +98,50 @@ public void
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146583860
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -246,40 +245,31 @@ abstract class
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4894
[FLINK-7548] [table] Improve rowtime support of TableSources.
## What is the purpose of the change
This PR refactors the `TableSource` interface and some related interfaces.
The goal of
23 matches
Mail list logo
