1996fanrui merged PR #24340:
URL: https://github.com/apache/flink/pull/24340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24340:
URL: https://github.com/apache/flink/pull/24340#issuecomment-1954319134
CI passed, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
XComp commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495440125
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -341,7 +343,7 @@ public void
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495400609
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -341,7 +343,7 @@ public void
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495400609
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -341,7 +343,7 @@ public void
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495400609
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -341,7 +343,7 @@ public void
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495401227
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -163,6 +163,8 @@ public void setup() throws Exception {
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495400609
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -341,7 +343,7 @@ public void
XComp commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495372884
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -163,6 +163,8 @@ public void setup() throws Exception {
flinkbot commented on PR #24340:
URL: https://github.com/apache/flink/pull/24340#issuecomment-1953400607
## CI report:
* 3c5a7ccf0f1c9c2a4cc27b34ffebb51cb5296c62 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
1996fanrui commented on code in PR #24340:
URL: https://github.com/apache/flink/pull/24340#discussion_r1495176445
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -163,6 +163,8 @@ public void setup() throws Exception {
1996fanrui opened a new pull request, #24340:
URL: https://github.com/apache/flink/pull/24340
Backporting FLINK-34336 to 1.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui merged PR #24248:
URL: https://github.com/apache/flink/pull/24248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24248:
URL: https://github.com/apache/flink/pull/24248#issuecomment-1953382889
> LGTM
Thanks @XComp for the review! Merging
> Can you create a 1.19 backport PR?
Sure, I will do it asap.
--
This is an automated message from the Apache Git
XComp commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1494741651
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -427,7 +427,8 @@ public void
1996fanrui commented on PR #24248:
URL: https://github.com/apache/flink/pull/24248#issuecomment-1933278564
https://github.com/apache/flink/pull/24246 is merged so far, I guess the CI
of master branch may be stuck. This PR can fix it if CI is stuck on
`waitForRunningTasks` of
1996fanrui commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1479228550
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -337,7 +337,7 @@ public void
1996fanrui commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1479230252
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -427,7 +427,8 @@ public void
1996fanrui commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1479228550
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -337,7 +337,7 @@ public void
XComp commented on code in PR #24248:
URL: https://github.com/apache/flink/pull/24248#discussion_r1478245157
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java:
##
@@ -337,7 +337,7 @@ public void
20 matches
Mail list logo
