[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224913#comment-16224913 ] ASF GitHub Bot commented on FLINK-7548: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224884#comment-16224884 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224616#comment-16224616 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224613#comment-16224613 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224583#comment-16224583 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224581#comment-16224581 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224027#comment-16224027 ] ASF GitHub Bot commented on FLINK-7548: --- Github user xccui commented on a diff in the pull request:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224025#comment-16224025 ] ASF GitHub Bot commented on FLINK-7548: --- Github user xccui commented on a diff in the pull request:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224024#comment-16224024 ] ASF GitHub Bot commented on FLINK-7548: --- Github user xccui commented on a diff in the pull request:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224026#comment-16224026 ] ASF GitHub Bot commented on FLINK-7548: --- Github user xccui commented on a diff in the pull request:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223885#comment-16223885 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222519#comment-16222519 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222013#comment-16222013 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221986#comment-16221986 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221869#comment-16221869 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221867#comment-16221867 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221865#comment-16221865 ] ASF GitHub Bot commented on FLINK-7548: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221812#comment-16221812 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221813#comment-16221813 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221811#comment-16221811 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221808#comment-16221808 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221805#comment-16221805 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221810#comment-16221810 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221807#comment-16221807 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221806#comment-16221806 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221809#comment-16221809 ] ASF GitHub Bot commented on FLINK-7548: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216777#comment-16216777 ] ASF GitHub Bot commented on FLINK-7548: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-23 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215805#comment-16215805 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the feedback [~wheat9]. I've addressed the issue

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-23 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215758#comment-16215758 ] Haohui Mai commented on FLINK-7548: --- Sorry for the late response. The APIs should work for our use cases

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209327#comment-16209327 ] Kurt Young commented on FLINK-7548: --- Actually I was thinking that when projections are pushed down, we

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209299#comment-16209299 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the comment [~ykt836]. I think the projection

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209188#comment-16209188 ] Kurt Young commented on FLINK-7548: --- Hi [~fhueske], sorry for the late response. I'm not very familiar

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209002#comment-16209002 ] Till Rohrmann commented on FLINK-7548: -- Is this strictly a blocker for 1.4? > Support watermark

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208238#comment-16208238 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the comments [~twalthr] and [~xccui]. @ Timo: I

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207782#comment-16207782 ] Xingcan Cui commented on FLINK-7548: Hi [~fhueske], sorry for the late reply. I'll first share some

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207717#comment-16207717 ] Timo Walther commented on FLINK-7548: - Thanks for the proposal [~fhueske]. I like the idea with a

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207628#comment-16207628 ] Fabian Hueske commented on FLINK-7548: -- Hi [~jark], [~wheat9], [~twalthr], [~xccui], [~ykt836],I'd

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197673#comment-16197673 ] Fabian Hueske commented on FLINK-7548: -- I've created a proposal for a reworked TableSource API that

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-26 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181847#comment-16181847 ] Xingcan Cui commented on FLINK-7548: Thanks for the explanation, [~fhueske]. I was too paranoid about

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181234#comment-16181234 ] Fabian Hueske commented on FLINK-7548: -- I think there might be a misunderstanding of the

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-25 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180077#comment-16180077 ] Xingcan Cui commented on FLINK-7548: Thanks for the answers, [~fhueske]. Some extra comments. About

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179836#comment-16179836 ] Fabian Hueske commented on FLINK-7548: -- Thanks for your thoughts [~xccui]. I added a few comments to

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-22 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176020#comment-16176020 ] Xingcan Cui commented on FLINK-7548: Hi [~fhueske] and [~jark], sorry for the late reply. Honestly, I

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174581#comment-16174581 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the feedback [~jark]! bq. Regarding to the

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-19 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171634#comment-16171634 ] Jark Wu commented on FLINK-7548: Hi [~fhueske], thanks for the proposal. I really like it ! It meets most

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-09-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171469#comment-16171469 ] Fabian Hueske commented on FLINK-7548: -- At the moment, we expect a {{TableSource}} to assign

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-08-29 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144836#comment-16144836 ] Xingcan Cui commented on FLINK-7548: Thanks for the issue [~jark]. I'd like to share some ideas about