[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380880#comment-16380880 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380514#comment-16380514 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380469#comment-16380469 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379148#comment-16379148 ] ASF GitHub Bot commented on FLINK-8538: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379044#comment-16379044 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379026#comment-16379026 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376735#comment-16376735 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376730#comment-16376730 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376696#comment-16376696 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376692#comment-16376692 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374620#comment-16374620 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374593#comment-16374593 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374581#comment-16374581 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374575#comment-16374575 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374579#comment-16374579 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374589#comment-16374589 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374586#comment-16374586 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374594#comment-16374594 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374577#comment-16374577 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374587#comment-16374587 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374578#comment-16374578 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374574#comment-16374574 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374584#comment-16374584 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374580#comment-16374580 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374595#comment-16374595 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374592#comment-16374592 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374591#comment-16374591 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374576#comment-16374576 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374582#comment-16374582 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374585#comment-16374585 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374590#comment-16374590 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374583#comment-16374583 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374588#comment-16374588 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374572#comment-16374572 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374573#comment-16374573 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374571#comment-16374571 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374100#comment-16374100 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui closed the pull request a

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374098#comment-16374098 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374097#comment-16374097 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374092#comment-16374092 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374095#comment-16374095 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374093#comment-16374093 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374096#comment-16374096 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374094#comment-16374094 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374091#comment-16374091 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373044#comment-16373044 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373037#comment-16373037 ] ASF GitHub Bot commented on FLINK-8538: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368158#comment-16368158 ] ASF GitHub Bot commented on FLINK-8538: --- Github user xccui commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368151#comment-16368151 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367293#comment-16367293 ] Timo Walther commented on FLINK-8538: - Sorry for my impatience. Thank you for your eff

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-16 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366956#comment-16366956 ] Xingcan Cui commented on FLINK-8538: Sorry for the late PR [~twalthr]. I was just here

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366928#comment-16366928 ] ASF GitHub Bot commented on FLINK-8538: --- GitHub user xccui opened a pull request:

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366925#comment-16366925 ] Timo Walther commented on FLINK-8538: - [~xccui] any news on this? If you find no time

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364488#comment-16364488 ] Timo Walther commented on FLINK-8538: - [~xccui] I just opened a PR for FLINK-8630. Loo

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-14 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363802#comment-16363802 ] Xingcan Cui commented on FLINK-8538: Hi [~twalthr], I think Friday will be fine. Thoug

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363724#comment-16363724 ] Timo Walther commented on FLINK-8538: - [~xccui] good point maybe we should make those

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-14 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363700#comment-16363700 ] Xingcan Cui commented on FLINK-8538: BTW, it may not be a good idea to implement them

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-12 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360725#comment-16360725 ] Xingcan Cui commented on FLINK-8538: Thanks for the comments, [~twalthr] and [~fhueske

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360630#comment-16360630 ] Fabian Hueske commented on FLINK-8538: -- Hi, I agree with [~twalthr]. This looks mostl

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360606#comment-16360606 ] Timo Walther commented on FLINK-8538: - Thanks for working on this [~xccui]. I had a qu

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-12 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360559#comment-16360559 ] Xingcan Cui commented on FLINK-8538: Hi [~twalthr] and [~fhueske], I committed a WIP b

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-09 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358494#comment-16358494 ] Xingcan Cui commented on FLINK-8538: Thanks for the comments [~twalthr] and [~fhueske]

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-09 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358372#comment-16358372 ] Fabian Hueske commented on FLINK-8538: -- Regarding the options: * Option 1: This was

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-09 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358295#comment-16358295 ] Timo Walther commented on FLINK-8538: - [~xccui] yes, I think this is necessary. We als

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-09 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358286#comment-16358286 ] Xingcan Cui commented on FLINK-8538: Hi [~twalthr], I think we need a converter to tra

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355523#comment-16355523 ] Timo Walther commented on FLINK-8538: - [~xccui] the nice thing about the SPI is that a

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-07 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355511#comment-16355511 ] Xingcan Cui commented on FLINK-8538: If I understood correctly, maybe we should create

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-07 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355468#comment-16355468 ] Xingcan Cui commented on FLINK-8538: Hi [~twalthr] and [~fhueske], it's still a questi

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353508#comment-16353508 ] Xingcan Cui commented on FLINK-8538: Thanks for your reply, [~fhueske]. I'll think it

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352657#comment-16352657 ] Fabian Hueske commented on FLINK-8538: -- Hi [~xccui], please see my comments: # Yes,

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352634#comment-16352634 ] Xingcan Cui commented on FLINK-8538: Thanks for the explanation [~twalthr]. I've glanc

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1635#comment-1635 ] Timo Walther commented on FLINK-8538: - [~xccui] thanks for working on this issue. This

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-03 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351405#comment-16351405 ] Xingcan Cui commented on FLINK-8538: Hi [~twalthr], thanks for opening this. I just g