[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374002#comment-16374002 ] Cyrille Artho commented on GEODE-3584: -- If we want to preserve API compatibility, probably the best

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373638#comment-16373638 ] Patrick Rhomberg commented on GEODE-3584: - A few thoughts, in no particular order: First, I love

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373286#comment-16373286 ] Kenneth Howe commented on GEODE-3584: - I done some work resolving compilation coflicts between

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321562#comment-16321562 ] Cyrille Artho commented on GEODE-3584: -- Thanks. In this case, some of the changes I've tried ended up

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319627#comment-16319627 ] Cyrille Artho commented on GEODE-3584: -- With the latest patch, the entire code base again compiles

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317803#comment-16317803 ] Cyrille Artho commented on GEODE-3584: -- I have attached another work-in-progress patch

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312597#comment-16312597 ] Cyrille Artho commented on GEODE-3584: -- Is it possible to push this to the shared repository under a

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312376#comment-16312376 ] Cyrille Artho commented on GEODE-3584: -- Field "port" in LocatorLauncher corresponds to "serverPort"

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310097#comment-16310097 ] Kenneth Howe commented on GEODE-3584: - Thanks for your input. If you haven't reviewed the Apache Geode

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309279#comment-16309279 ] Cyrille Artho commented on GEODE-3584: -- Other fields are contained in the static class "Builder",

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309239#comment-16309239 ] Cyrille Artho commented on GEODE-3584: -- Code related to helpMap, usageMap, Command is heavily

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304279#comment-16304279 ] Cyrille Artho commented on GEODE-3584: -- Another view of the table, with the leftmost column

[jira] [Commented] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304277#comment-16304277 ] Cyrille Artho commented on GEODE-3584: -- Hi, I can help with this task. As far as I can see, the