[jira] [Commented] (GEODE-2886) The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an IllegalStateException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112214#comment-16112214
 ] 

ASF GitHub Bot commented on GEODE-2886:
---

Github user ameybarve15 commented on a diff in the pull request:

https://github.com/apache/geode/pull/609#discussion_r131056489
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
@@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
   }
 
 } else {
-  throw new IllegalArgumentException(
+  IllegalStateException illegalStateException = new 
IllegalStateException(
   "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
+  logger.error(illegalStateException.getMessage());
--- End diff --

@jhuynh1 
If we throw exception from WaitUntilFlushedFunction then executing side 
will not get a true or false.
Unless we send the result explicitly using resultSender.lastResult(result);
or other alternative is to send this exception using sendException() Api 
and executing side needs to handle this exception to return a boolean result 
for waitUntilFlushed.

@upthewaterspout @dschneider-pivotal @bschuchardt - please correct me if I 
am wrong.


> The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an 
> IllegalStateException
> ---
>
> Key: GEODE-2886
> URL: https://issues.apache.org/jira/browse/GEODE-2886
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an 
> IllegalArgumentException like:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the 
> index xxx region /yyy
> at 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> {noformat}
> The arguments are actually fine so should it instead throw an 
> IllegalStateException?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112154#comment-16112154
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049655
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
+@Category(IntegrationTest.class)
+public class PulseConnectivityTest {
+  @ClassRule
+  public static LocatorStarterRule locator = new 
LocatorStarterRule().withJMXManager();
+
+  // Test Connectivity for Default Configuration
+  @Category(IntegrationTest.class)
+  public static class DefaultBindAddressTest {
+@Rule
+public EmbeddedPulseRule pulse = new EmbeddedPulseRule();
+
+@BeforeClass
+public static void beforeClass() throws Exception {
+  locator.startLocator();
+}
+
+@Test
+public void testConnectToJmx() throws Exception {
+  pulse.useJmxPort(locator.getJmxPort());
+  Cluster cluster = pulse.getRepository().getCluster("admin", null);
+  assertThat(cluster.isConnectedFlag()).isTrue();
+  assertThat(cluster.getServerCount()).isEqualTo(0);
+}
+
+@Test
+public void testConnectToLocator() throws Exception {
+  pulse.useLocatorPort(locator.getPort());
+  Cluster cluster = pulse.getRepository().getCluster("admin", null);
+  assertThat(cluster.isConnectedFlag()).isTrue();
+  assertThat(cluster.getServerCount()).isEqualTo(0);
+}
+
+@AfterClass
+public static void afterClass() throws Exception {
+  locator.after();
+}
+  }
+
+  // GEODE-3292: Test Connectivity for Non Default Configuration
+  @Category(IntegrationTest.class)
+  public static class NonDefaultBindAddressTest {
+public static String jmxBindAddress;
+
+@Rule
+public EmbeddedPulseRule pulse = new EmbeddedPulseRule();
+
+@BeforeClass
+public static void beforeClass() throws Exception {
+  // Make sure we use something different than "localhost" for this 
test.
+  jmxBindAddress = InetAddress.getLocalHost().getHostName();
+  if ("localhost".equals(jmxBindAddress)) {
+jmxBindAddress = InetAddress.getLocalHost().getHostAddress();
+  }
+
+  Properties locatorProperties = new Properties();
+  locatorProperties.setProperty(JMX_MANAGER_BIND_ADDRESS, 
jmxBindAddress);
+  locator.withProperties(locatorProperties).startLocator();
+}
+
+@Test
+public void testConnectToJmx() throws Exception {
+  pulse.useJmxManager(jmxBindAddress, locator.getJmxPort());
+  Cluster cluster = pulse.getRepository().getCluster("admin", null);
+  assertThat(cluster.isConnectedFlag()).isTrue();
+  assertThat(cluster.getServerCount()).isEqualTo(0);
+}
+
+@AfterClass
+public static void 

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112155#comment-16112155
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049401
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
--- End diff --

I am not sure I've seen this pattern before. It looks like you are adding 
another set of test to the original PulseVerificationTest. I believe another 
separate test class would read better. I would leave the original test alone 
(since it has a test that uses httpClient to try to connect with a wrong 
password). 


> Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
> 
>
> Key: GEODE-3292
> URL: https://issues.apache.org/jira/browse/GEODE-3292
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Minor
>
> The PULSE webApp (embedded mode) fails to connect to the jmx-manager when a 
> non-default {{jmx-manager-bind-address}} is configured. The app tries to 
> connect by default to 
> {{service:jmx:rmi://localhost/jndi/rmi://localhost:17991/jmxrmi}} whenever it 
> detects it's running in embedded mode, instead of getting the local hostname 
> through {{InetAddress.getLocalHost().getCanonicalHostName()}} as it used to 
> do before.
> The problem was introduced by 
> [GEODE-2927|https://issues.apache.org/jira/browse/GEODE-2927], commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6].
> Steps to reproduce:
> {code:none}
> $ export JAVA_ARGS="-Dgfsh.log-level=config -Dgfsh.log-dir=$(pwd)"
> $ gfsh start locator --name=locator1 --force=true --connect=false \
> --J=-Dpulse.Log-Level=debug --J=-Dpulse.Log-File-Name=pulse.log 
> --J=-Dpulse.Log-FileLocation=$(pwd) \
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
> --J=-Dgemfire.jmx-manager-port=17991 \
> --J=-Dgemfire.jmx-manager-bind-address=$(ipconfig getifaddr en0)
> $ gfsh start pulse
> {code}
> At this point, and after a successful login to PULSE, the application doesn't 
> show any cluster data and the exception can be seen (both in the logs and in 
> the PULSE screen).
> The easiest solution would be to revert back some lines of the changes made 
> by commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6],
>  as follows:
> {code:title=PulseAppListener.java|borderStyle=solid}
> @Override
>   public void contextInitialized(ServletContextEvent event) {
>   (...)
> boolean sysIsEmbedded = 
> Boolean.getBoolean(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED);
> if (sysIsEmbedded) {
>   // jmx connection parameters
>   
> 

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112156#comment-16112156
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049464
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
+@Category(IntegrationTest.class)
+public class PulseConnectivityTest {
+  @ClassRule
+  public static LocatorStarterRule locator = new 
LocatorStarterRule().withJMXManager();
+
+  // Test Connectivity for Default Configuration
+  @Category(IntegrationTest.class)
+  public static class DefaultBindAddressTest {
+@Rule
+public EmbeddedPulseRule pulse = new EmbeddedPulseRule();
+
+@BeforeClass
+public static void beforeClass() throws Exception {
--- End diff --

if you use new LocatorStarterRule().withAutoStart(), you don't need this 
@BeforeClass block anymore.


> Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
> 
>
> Key: GEODE-3292
> URL: https://issues.apache.org/jira/browse/GEODE-3292
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Minor
>
> The PULSE webApp (embedded mode) fails to connect to the jmx-manager when a 
> non-default {{jmx-manager-bind-address}} is configured. The app tries to 
> connect by default to 
> {{service:jmx:rmi://localhost/jndi/rmi://localhost:17991/jmxrmi}} whenever it 
> detects it's running in embedded mode, instead of getting the local hostname 
> through {{InetAddress.getLocalHost().getCanonicalHostName()}} as it used to 
> do before.
> The problem was introduced by 
> [GEODE-2927|https://issues.apache.org/jira/browse/GEODE-2927], commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6].
> Steps to reproduce:
> {code:none}
> $ export JAVA_ARGS="-Dgfsh.log-level=config -Dgfsh.log-dir=$(pwd)"
> $ gfsh start locator --name=locator1 --force=true --connect=false \
> --J=-Dpulse.Log-Level=debug --J=-Dpulse.Log-File-Name=pulse.log 
> --J=-Dpulse.Log-FileLocation=$(pwd) \
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
> --J=-Dgemfire.jmx-manager-port=17991 \
> --J=-Dgemfire.jmx-manager-bind-address=$(ipconfig getifaddr en0)
> $ gfsh start pulse
> {code}
> At this point, and after a successful login to PULSE, the application doesn't 
> show any cluster data and the exception can be seen (both in the logs and in 
> the PULSE screen).
> The easiest solution would be to revert back some lines of the changes made 
> by commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6],
>  as follows:
> {code:title=PulseAppListener.java|borderStyle=solid}
> 

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112152#comment-16112152
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131050061
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
 ---
@@ -270,6 +271,7 @@ private void startHttpService(boolean isServer) {
   }
 
   System.setProperty(PULSE_EMBEDDED_PROP, "true");
+  System.setProperty(PULSE_HOST_PROP, "" + 
config.getJmxManagerBindAddress());
--- End diff --

+1 the product code change is good to go. Just some test re-org is needed.


> Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
> 
>
> Key: GEODE-3292
> URL: https://issues.apache.org/jira/browse/GEODE-3292
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Minor
>
> The PULSE webApp (embedded mode) fails to connect to the jmx-manager when a 
> non-default {{jmx-manager-bind-address}} is configured. The app tries to 
> connect by default to 
> {{service:jmx:rmi://localhost/jndi/rmi://localhost:17991/jmxrmi}} whenever it 
> detects it's running in embedded mode, instead of getting the local hostname 
> through {{InetAddress.getLocalHost().getCanonicalHostName()}} as it used to 
> do before.
> The problem was introduced by 
> [GEODE-2927|https://issues.apache.org/jira/browse/GEODE-2927], commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6].
> Steps to reproduce:
> {code:none}
> $ export JAVA_ARGS="-Dgfsh.log-level=config -Dgfsh.log-dir=$(pwd)"
> $ gfsh start locator --name=locator1 --force=true --connect=false \
> --J=-Dpulse.Log-Level=debug --J=-Dpulse.Log-File-Name=pulse.log 
> --J=-Dpulse.Log-FileLocation=$(pwd) \
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
> --J=-Dgemfire.jmx-manager-port=17991 \
> --J=-Dgemfire.jmx-manager-bind-address=$(ipconfig getifaddr en0)
> $ gfsh start pulse
> {code}
> At this point, and after a successful login to PULSE, the application doesn't 
> show any cluster data and the exception can be seen (both in the logs and in 
> the PULSE screen).
> The easiest solution would be to revert back some lines of the changes made 
> by commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6],
>  as follows:
> {code:title=PulseAppListener.java|borderStyle=solid}
> @Override
>   public void contextInitialized(ServletContextEvent event) {
>   (...)
> boolean sysIsEmbedded = 
> Boolean.getBoolean(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED);
> if (sysIsEmbedded) {
>   // jmx connection parameters
>   
> logger.info(resourceBundle.getString("LOG_MSG_APP_RUNNING_EMBEDDED_MODE"));
>   repository.setJmxUseLocator(false);
>   
> //
> String sysPulseHost;
>   try {
> // Get host name of machine running pulse in embedded mode
> sysPulseHost = InetAddress.getLocalHost().getCanonicalHostName();
>   } catch (Exception e) {
> 
> logger.debug(resourceBundle.getString("LOG_MSG_JMX_CONNECTION_UNKNOWN_HOST"), 
> e);
> // Set default host name
> sysPulseHost = PulseConstants.GEMFIRE_DEFAULT_HOST;
>   }
>   repository.setHost(sysPulseHost);
>   
> //
>   
> repository.setPort(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_PORT,
>   PulseConstants.GEMFIRE_DEFAULT_PORT));
>   // SSL, all the other system properties are already set in the embedded 
> VM
>   repository.setUseSSLManager(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_MANAGER)));
>   repository.setUseSSLLocator(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_LOCATOR)));
>   (...)
>   }
> {code}
> I can make the changes and submit a PR if someone assigns me this ticket.
> Cheers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3387) Refactor function names to proper meaning and remove unused comments

[nabarun (JIRA)]

nabarun created GEODE-3387:
--

 Summary: Refactor function names to proper meaning and remove 
unused comments
 Key: GEODE-3387
 URL: https://issues.apache.org/jira/browse/GEODE-3387
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


In waitUntilFlushedFunction, clean out the unused vaiables
Remove mentions of gemfire from the module in comments
Remove comment “/* wrapper of IndexWriter */“ in LuceneIndexForPartitionedRegion
Rename initializeAEQ to more suitable / function appropriate name.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3257) Refactor DeployCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111980#comment-16111980
 ] 

ASF GitHub Bot commented on GEODE-3257:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/680

GEODE-3257: Refactoring DeployCommands

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3257)

**Testing Status: Precheckin to be run on morning of 8/3**

- [x] JIRA ticket

- [x] PR rebased

- [x] Commit single & squashed

- [x] `gradlew build` runs cleanly

- [ ] Tests to be updated with 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #680


commit db50d331c54ec4c8ed7f583685c78002c91c7bde
Author: YehEmily 
Date:   2017-08-03T00:28:10Z

GEODE-3257: Refactoring DeployCommands




> Refactor DeployCommands
> ---
>
> Key: GEODE-3257
> URL: https://issues.apache.org/jira/browse/GEODE-3257
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3257) Refactor DeployCommands

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh reassigned GEODE-3257:


Assignee: Emily Yeh

> Refactor DeployCommands
> ---
>
> Key: GEODE-3257
> URL: https://issues.apache.org/jira/browse/GEODE-3257
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3336) Refactor IndexCommandsDUnitTest to use test rules

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh resolved GEODE-3336.
--
Resolution: Fixed

> Refactor IndexCommandsDUnitTest to use test rules
> -
>
> Key: GEODE-3336
> URL: https://issues.apache.org/jira/browse/GEODE-3336
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{IndexCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a 
> deprecated class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3339) Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh resolved GEODE-3339.
--
Resolution: Fixed

> Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules
> ---
>
> Key: GEODE-3339
> URL: https://issues.apache.org/jira/browse/GEODE-3339
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ClusterConfigurationServiceEndToEndDUnitTest}} is using 
> {{CliCommandTestBase}}, which is a deprecated class. It should be refactored 
> to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3305) CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-3305.
-
Resolution: Fixed

> CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> ---
>
> Key: GEODE-3305
> URL: https://issues.apache.org/jira/browse/GEODE-3305
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Bruce Schuchardt
>  Labels: flaky
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1205
> [fatal 2017/07/22 06:17:05.747 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> ---
> Found suspect string in log4j at line 1734
> [fatal 2017/07/22 06:17:09.980 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_3>
>  tid=0x50] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2040
> [fatal 2017/07/22 06:17:11.030 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_0>
>  tid=0xb5] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2329
> [fatal 2017/07/22 06:17:12.043 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x156] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 2635
> [fatal 2017/07/22 06:17:12.656 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x161] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 3391
> [fatal 2017/07/22 06:17:15.750 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3305) CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111866#comment-16111866
 ] 

ASF subversion and git services commented on GEODE-3305:


Commit cea8312b02b7942b6a2da5ccca501c3ea8feb517 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cea8312 ]

GEODE-3305 testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED

Reinstated cleaning up of TcpClient locator version information in
tearDownVM.  This was lost when DistributedTestCase was emptied and
its contents poured into JUnit4DistributedTestCase.


> CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> ---
>
> Key: GEODE-3305
> URL: https://issues.apache.org/jira/browse/GEODE-3305
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Bruce Schuchardt
>  Labels: flaky
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1205
> [fatal 2017/07/22 06:17:05.747 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> ---
> Found suspect string in log4j at line 1734
> [fatal 2017/07/22 06:17:09.980 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_3>
>  tid=0x50] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2040
> [fatal 2017/07/22 06:17:11.030 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_0>
>  tid=0xb5] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2329
> [fatal 2017/07/22 06:17:12.043 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x156] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 2635
> [fatal 2017/07/22 06:17:12.656 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x161] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 3391
> [fatal 2017/07/22 06:17:15.750 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3305) CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111812#comment-16111812
 ] 

Bruce Schuchardt commented on GEODE-3305:
-

This is caused by a merge [~klund] pushed on 3/18/16 that refactored the unit 
test classes.  I had made a change to DistributedTestCase to clean up 
TcpClient's static cache of locator versions on 3/14/16 and Kirk's merge 
clobbered that change.

{noformat}
commit 57c8600be29ab1d61f499f4e53c40e2fe3f8c605
Author: Kirk Lund 
Date:   Fri Mar 18 14:45:06 2016 -0700

GEODE-1050: add JUnit 4 versions of DistributedTestCase and CacheTestCase

* refactor DistributedTestCase into two implementations that delegate: 
JUnit3DistributedTestCase and JUnit4DistributedTestCase
* refactor CacheTestCase into two implementations that delegate: 
JUnit3CacheTestCase and JUnit4CacheTestCase
* refactor super.setUp() hierarchy into template method chain like 
tearDown()
* change all variables in CacheTestCase and DistributedTestCase to private 
and use methods to access them
* change some tests to use getDistributedSystemProperties() and getSystem()
{noformat}

{noformat}
commit aef84eb091791312efba7d42bcde9b7f6436223c
Author: Bruce Schuchardt 
Date:   Mon Mar 14 09:31:08 2016 -0700

GEODE-986 MultiuserAPIDUnitTest.testMultiUserUnsupportedAPIs failed with 
SocketException

Reactivated the TcpServer backward-compatibility test.  This test failed if
TcpClient thought that the locator was running 5.7 (I hand-sabotaged the
code to make it think the locator was 5.7) but it passes with 9a .0 fallback
default.
{noformat}

I'll reinstate the lost changes.

> CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> ---
>
> Key: GEODE-3305
> URL: https://issues.apache.org/jira/browse/GEODE-3305
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Bruce Schuchardt
>  Labels: flaky
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1205
> [fatal 2017/07/22 06:17:05.747 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> ---
> Found suspect string in log4j at line 1734
> [fatal 2017/07/22 06:17:09.980 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_3>
>  tid=0x50] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2040
> [fatal 2017/07/22 06:17:11.030 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_0>
>  tid=0xb5] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2329
> [fatal 2017/07/22 06:17:12.043 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x156] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 2635
> [fatal 2017/07/22 06:17:12.656 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x161] 

[jira] [Commented] (GEODE-3308) Add lucene backward compatibility and rolling upgrade dunit tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111814#comment-16111814
 ] 

ASF subversion and git services commented on GEODE-3308:


Commit 37d388b3c7f92e52b5fd9887c88d6dea22bd82df in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=37d388b ]

GEODE-3308: Lucene rolling upgrade and backwards compatibility tests added


> Add lucene backward compatibility and rolling upgrade dunit tests 
> --
>
> Key: GEODE-3308
> URL: https://issues.apache.org/jira/browse/GEODE-3308
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3305) CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-3305:
---

Assignee: Bruce Schuchardt

> CI failure: org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> ---
>
> Key: GEODE-3305
> URL: https://issues.apache.org/jira/browse/GEODE-3305
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Bruce Schuchardt
>  Labels: flaky
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest > 
> testEventProcessingMixedSiteOneCurrentSiteTwo[1] FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1205
> [fatal 2017/07/22 06:17:05.747 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> ---
> Found suspect string in log4j at line 1734
> [fatal 2017/07/22 06:17:09.980 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_3>
>  tid=0x50] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2040
> [fatal 2017/07/22 06:17:11.030 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1_0>
>  tid=0xb5] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_1" could not 
> get remote locator information for remote site "1".
> ---
> Found suspect string in log4j at line 2329
> [fatal 2017/07/22 06:17:12.043 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x156] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 2635
> [fatal 2017/07/22 06:17:12.656 UTC  GatewaySender_testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0_0>
>  tid=0x161] GatewaySender 
> "testEventProcessingMixedSiteOneCurrentSiteTwo[1]_gatewaysender_0" could not 
> get remote locator information for remote site "0".
> ---
> Found suspect string in log4j at line 3391
> [fatal 2017/07/22 06:17:15.750 UTC  tid=0x22] 
> Exception in processing request from 172.17.0.6
> org.apache.geode.cache.UnsupportedVersionException: Peer or client 
> version with ordinal 65 not supported. Highest known version is 9.1
>   at org.apache.geode.internal.Version.fromOrdinal(Version.java:255)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:375)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3340) Refactor ConfigCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111765#comment-16111765
 ] 

ASF GitHub Bot commented on GEODE-3340:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r131003469
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
--- End diff --

I think this move made it possible to run this test over HTTP without 
needing to run it through `CommandOverHttpDUnitTest`, since we are trying to 
get rid of `CommandOverHttpDUnitTest` anyway.


> Refactor ConfigCommandsDUnitTest to use test rules
> --
>
> Key: GEODE-3340
> URL: https://issues.apache.org/jira/browse/GEODE-3340
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a 
> deprecated class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3340) Refactor ConfigCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111762#comment-16111762
 ] 

ASF GitHub Bot commented on GEODE-3340:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r131003075
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
+  @Rule
+  public LocatorServerStartupRule startupRule = new 
LocatorServerStartupRule();
+
+  @Rule
+  public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
+
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Test
+  @Parameters({"true", "false"})
+  public void testDescribeConfig(final boolean connectOverHttp) throws 
Exception {
+Properties localProps = new Properties();
+localProps.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
+localProps.setProperty(ENABLE_TIME_STATISTICS, "true");
+localProps.setProperty(GROUPS, "G1");
+MemberVM server0 = startupRule.startServerAsJmxManager(0, localProps);
+
+if (connectOverHttp) {
+  gfsh.connectAndVerify(server0.getHttpPort(), 
GfshShellConnectionRule.PortType.http);
+} else {
+  gfsh.connectAndVerify(server0.getJmxPort(), 
GfshShellConnectionRule.PortType.jmxManger);
+}
+
+server0.invoke(() -> {
+  InternalCache cache = 
LocatorServerStartupRule.serverStarter.getCache();
+  InternalDistributedSystem system = 
cache.getInternalDistributedSystem();
+  DistributionConfig config = system.getConfig();
+  config.setArchiveFileSizeLimit(1000);
+});
+
+gfsh.executeAndVerifyCommand("describe config --member=" + 
server0.getName());
+String result = gfsh.getGfshOutput();
+
+assertThat(result).contains("enable-time-statistics   
: true");
--- End 

[jira] [Assigned] (GEODE-3321) Error Codes Specification for all operations

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe reassigned GEODE-3321:
-

Assignee: Brian Rowe

> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3284) New flow: getAvailableServers

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe resolved GEODE-3284.
---
Resolution: Fixed

> New flow: getAvailableServers
> -
>
> Key: GEODE-3284
> URL: https://issues.apache.org/jira/browse/GEODE-3284
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
>
> As a Geode client user, I'd like to be able to know all available servers in 
> a grid in order to support operations targeting any available server.
> Create op handler for getAvailableServers message, following proto message 
> definition.
> Client should be able to complete getAvailableServers, receiving all servers 
> available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3340) Refactor ConfigCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111742#comment-16111742
 ] 

ASF GitHub Bot commented on GEODE-3340:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r130998820
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
--- End diff --

What was the motivation to move this test from :geode-core into :geode-web? 
 


> Refactor ConfigCommandsDUnitTest to use test rules
> --
>
> Key: GEODE-3340
> URL: https://issues.apache.org/jira/browse/GEODE-3340
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a 
> deprecated class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3340) Refactor ConfigCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111741#comment-16111741
 ] 

ASF GitHub Bot commented on GEODE-3340:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r130998592
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
+  @Rule
+  public LocatorServerStartupRule startupRule = new 
LocatorServerStartupRule();
+
+  @Rule
+  public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
+
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Test
+  @Parameters({"true", "false"})
+  public void testDescribeConfig(final boolean connectOverHttp) throws 
Exception {
+Properties localProps = new Properties();
+localProps.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
+localProps.setProperty(ENABLE_TIME_STATISTICS, "true");
+localProps.setProperty(GROUPS, "G1");
+MemberVM server0 = startupRule.startServerAsJmxManager(0, localProps);
+
+if (connectOverHttp) {
+  gfsh.connectAndVerify(server0.getHttpPort(), 
GfshShellConnectionRule.PortType.http);
+} else {
+  gfsh.connectAndVerify(server0.getJmxPort(), 
GfshShellConnectionRule.PortType.jmxManger);
+}
+
+server0.invoke(() -> {
+  InternalCache cache = 
LocatorServerStartupRule.serverStarter.getCache();
+  InternalDistributedSystem system = 
cache.getInternalDistributedSystem();
+  DistributionConfig config = system.getConfig();
+  config.setArchiveFileSizeLimit(1000);
+});
+
+gfsh.executeAndVerifyCommand("describe config --member=" + 
server0.getName());
+String result = gfsh.getGfshOutput();
+
+assertThat(result).contains("enable-time-statistics   
: true");
--- 

[jira] [Assigned] (GEODE-3284) New flow: getAvailableServers

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe reassigned GEODE-3284:
-

Assignee: Brian Rowe

> New flow: getAvailableServers
> -
>
> Key: GEODE-3284
> URL: https://issues.apache.org/jira/browse/GEODE-3284
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
>
> As a Geode client user, I'd like to be able to know all available servers in 
> a grid in order to support operations targeting any available server.
> Create op handler for getAvailableServers message, following proto message 
> definition.
> Client should be able to complete getAvailableServers, receiving all servers 
> available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3319) Use protobuf serialization for primitive types

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe reassigned GEODE-3319:
-

Assignee: Brian Rowe

> Use protobuf serialization for primitive types
> --
>
> Key: GEODE-3319
> URL: https://issues.apache.org/jira/browse/GEODE-3319
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
>
> As a developer using the new protocol to write a new client, I'd rather not 
> worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some 
> burden off of the client and eliminate the problem of language-to-language 
> endian mismatches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3319) Use protobuf serialization for primitive types

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe resolved GEODE-3319.
---
Resolution: Fixed

> Use protobuf serialization for primitive types
> --
>
> Key: GEODE-3319
> URL: https://issues.apache.org/jira/browse/GEODE-3319
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
>
> As a developer using the new protocol to write a new client, I'd rather not 
> worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some 
> burden off of the client and eliminate the problem of language-to-language 
> endian mismatches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3386) Create Error type for KeyedErrorResponse and ErrorResponse

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-3386:
---

 Summary: Create Error type for KeyedErrorResponse and ErrorResponse
 Key: GEODE-3386
 URL: https://issues.apache.org/jira/browse/GEODE-3386
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Galen O'Sullivan


For logical separation of the new client API, it will be better to have an 
Error that is contained by ErrorResponse, rather than having KeyedErrorResponse 
contain an ErrorResponse.

{code}
PutAllResponse {
  repeated Entry successes = 1,
  repeated KeyedErrorResponse errors = 2,
}
KeyedErrorResponse {
  Key,
  ErrorResponse
}
ErrorResponse {
  string
}
{code}
instead,
{code}
KeyedErrorResponse {
  Key,
  Error,
}
{code}
and 
{code}
ErrorResponse {
Error
}

Error {
string
}
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3385) Change GetAllRequest to return list of errors

[Galen O'Sullivan (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111728#comment-16111728
 ] 

Galen O'Sullivan commented on GEODE-3385:
-

Apparently we don't throw classcast on GetAll, perhaps we can omit keys? Needs 
discussion.

> Change GetAllRequest to return list of errors
> -
>
> Key: GEODE-3385
> URL: https://issues.apache.org/jira/browse/GEODE-3385
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> GetAllRequest currently returns a list of successful keys or an error (if 
> getting any key threw an exception). We should instead return a list of 
> errors, similar to PutAllRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111688#comment-16111688
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/664
  
Thanks @jujoramos, this looks good to me.  Do you have any thoughts 
@jinmeiliao?


> Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
> 
>
> Key: GEODE-3292
> URL: https://issues.apache.org/jira/browse/GEODE-3292
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Minor
>
> The PULSE webApp (embedded mode) fails to connect to the jmx-manager when a 
> non-default {{jmx-manager-bind-address}} is configured. The app tries to 
> connect by default to 
> {{service:jmx:rmi://localhost/jndi/rmi://localhost:17991/jmxrmi}} whenever it 
> detects it's running in embedded mode, instead of getting the local hostname 
> through {{InetAddress.getLocalHost().getCanonicalHostName()}} as it used to 
> do before.
> The problem was introduced by 
> [GEODE-2927|https://issues.apache.org/jira/browse/GEODE-2927], commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6].
> Steps to reproduce:
> {code:none}
> $ export JAVA_ARGS="-Dgfsh.log-level=config -Dgfsh.log-dir=$(pwd)"
> $ gfsh start locator --name=locator1 --force=true --connect=false \
> --J=-Dpulse.Log-Level=debug --J=-Dpulse.Log-File-Name=pulse.log 
> --J=-Dpulse.Log-FileLocation=$(pwd) \
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
> --J=-Dgemfire.jmx-manager-port=17991 \
> --J=-Dgemfire.jmx-manager-bind-address=$(ipconfig getifaddr en0)
> $ gfsh start pulse
> {code}
> At this point, and after a successful login to PULSE, the application doesn't 
> show any cluster data and the exception can be seen (both in the logs and in 
> the PULSE screen).
> The easiest solution would be to revert back some lines of the changes made 
> by commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6],
>  as follows:
> {code:title=PulseAppListener.java|borderStyle=solid}
> @Override
>   public void contextInitialized(ServletContextEvent event) {
>   (...)
> boolean sysIsEmbedded = 
> Boolean.getBoolean(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED);
> if (sysIsEmbedded) {
>   // jmx connection parameters
>   
> logger.info(resourceBundle.getString("LOG_MSG_APP_RUNNING_EMBEDDED_MODE"));
>   repository.setJmxUseLocator(false);
>   
> //
> String sysPulseHost;
>   try {
> // Get host name of machine running pulse in embedded mode
> sysPulseHost = InetAddress.getLocalHost().getCanonicalHostName();
>   } catch (Exception e) {
> 
> logger.debug(resourceBundle.getString("LOG_MSG_JMX_CONNECTION_UNKNOWN_HOST"), 
> e);
> // Set default host name
> sysPulseHost = PulseConstants.GEMFIRE_DEFAULT_HOST;
>   }
>   repository.setHost(sysPulseHost);
>   
> //
>   
> repository.setPort(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_PORT,
>   PulseConstants.GEMFIRE_DEFAULT_PORT));
>   // SSL, all the other system properties are already set in the embedded 
> VM
>   repository.setUseSSLManager(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_MANAGER)));
>   repository.setUseSSLLocator(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_LOCATOR)));
>   (...)
>   }
> {code}
> I can make the changes and submit a PR if someone assigns me this ticket.
> Cheers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3385) Change GetAllRequest to return list of errors

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-3385:
---

 Summary: Change GetAllRequest to return list of errors
 Key: GEODE-3385
 URL: https://issues.apache.org/jira/browse/GEODE-3385
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Galen O'Sullivan


GetAllRequest currently returns a list of successful keys or an error (if 
getting any key threw an exception). We should instead return a list of errors, 
similar to PutAllRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111673#comment-16111673
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/676
  
Looks like there are some conflicts that need to be resolved.


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111651#comment-16111651
 ] 

ASF GitHub Bot commented on GEODE-3230:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130982335
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
 ---
@@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, 
boolean putIfAbsent, Stri
   try {
 keyObject = getClassObject(key, keyClass);
   } catch (ClassNotFoundException e) {
-return DataCommandResult.createPutResult(key, null, null,
-"ClassNotFoundException " + keyClass, false);
+return DataCommandResult.createPutResult(key, null, 
e.getException(),
--- End diff --

I don't understand the context of this change - the message was 
"ClassNotFound" but now it's "key not found" with a key class? 


> Delete unused commands in CliStrings
> 
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example, 
> {{start manager}} has a whole set of associated commands - 
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}}, 
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere. 
> These commands should be deleted to clean up the code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3254) Refactor ConfigCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111532#comment-16111532
 ] 

ASF GitHub Bot commented on GEODE-3254:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/665#discussion_r130965197
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
 ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Map;
+
+import org.apache.geode.management.cli.Result;
+import 
org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
+import org.apache.geode.management.internal.cli.GfshParseResult;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.shell.Gfsh;
+
+/**
+ * Interceptor used by gfsh to intercept execution of export config 
command at "shell".
+ */
+public class Interceptor extends AbstractCliAroundInterceptor {
--- End diff --

Oops - it seems that it's actually being used, but only in 
`ExportConfigCommand`, so I moved it there. Thanks for pointing this out!


> Refactor ConfigCommands
> ---
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3254) Refactor ConfigCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111500#comment-16111500
 ] 

ASF GitHub Bot commented on GEODE-3254:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/665#discussion_r130960859
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static org.apache.commons.io.FileUtils.deleteDirectory;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static org.apache.geode.distributed.ConfigurationProperties.NAME;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.internal.cache.xmlcache.CacheXmlGenerator;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.test.dunit.Host;
+import org.apache.geode.test.dunit.SerializableRunnable;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.categories.FlakyTest;
+
+@Category(DistributedTest.class)
+public class ExportConfigCommandDUnitTest extends CliCommandTestBase {
+  private File managerConfigFile;
+  private File managerPropsFile;
+  private File vm1ConfigFile;
+  private File vm1PropsFile;
+  private File vm2ConfigFile;
+  private File vm2PropsFile;
+  private File shellConfigFile;
+  private File shellPropsFile;
+  private File subDir;
+  private File subManagerConfigFile;
+
+  @Override
+  protected final void postSetUpCliCommandTestBase() throws Exception {
+this.managerConfigFile = 
this.temporaryFolder.newFile("Manager-cache.xml");
+this.managerPropsFile = 
this.temporaryFolder.newFile("Manager-gf.properties");
+this.vm1ConfigFile = this.temporaryFolder.newFile("VM1-cache.xml");
+this.vm1PropsFile = this.temporaryFolder.newFile("VM1-gf.properties");
+this.vm2ConfigFile = this.temporaryFolder.newFile("VM2-cache.xml");
+this.vm2PropsFile = this.temporaryFolder.newFile("VM2-gf.properties");
+this.shellConfigFile = this.temporaryFolder.newFile("Shell-cache.xml");
+this.shellPropsFile = 
this.temporaryFolder.newFile("Shell-gf.properties");
+this.subDir = this.temporaryFolder.newFolder(getName());
+this.subManagerConfigFile = new File(this.subDir, 
this.managerConfigFile.getName());
+  }
+
+  @Category(FlakyTest.class) // GEODE-1449
+  @Test
+  public void testExportConfig() throws Exception {
+Properties localProps = new Properties();
+localProps.setProperty(NAME, "Manager");
+localProps.setProperty(GROUPS, "Group1");
+setUpJmxManagerOnVm0ThenConnect(localProps);
+
+// Create a cache in another VM (VM1)
+Host.getHost(0).getVM(1).invoke(new SerializableRunnable() {
+  public void run() {
+Properties localProps = new Properties();
+localProps.setProperty(NAME, "VM1");
+localProps.setProperty(GROUPS, "Group2");
+getSystem(localProps);
+getCache();
+  }
+});
+
+// Create a cache in a 3rd VM (VM2)
+Host.getHost(0).getVM(2).invoke(new SerializableRunnable() {
+  public void run() {
+Properties localProps = new Properties();
+localProps.setProperty(NAME, "VM2");
  

[jira] [Commented] (GEODE-3254) Refactor ConfigCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111493#comment-16111493
 ] 

ASF GitHub Bot commented on GEODE-3254:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/665#discussion_r130960231
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
 ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Map;
+
+import org.apache.geode.management.cli.Result;
+import 
org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
+import org.apache.geode.management.internal.cli.GfshParseResult;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.shell.Gfsh;
+
+/**
+ * Interceptor used by gfsh to intercept execution of export config 
command at "shell".
+ */
+public class Interceptor extends AbstractCliAroundInterceptor {
--- End diff --

Ahh, not sure how I didn't notice that! I've deleted it - thanks for your 
feedback!


> Refactor ConfigCommands
> ---
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111490#comment-16111490
 ] 

ASF GitHub Bot commented on GEODE-3230:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130959623
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
 ---
@@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, 
boolean putIfAbsent, Stri
   try {
 keyObject = getClassObject(key, keyClass);
   } catch (ClassNotFoundException e) {
-return DataCommandResult.createPutResult(key, null, null,
-"ClassNotFoundException " + keyClass, false);
+return DataCommandResult.createPutResult(key, null, 
e.getException(),
--- End diff --

Fixed - thanks for your feedback!


> Delete unused commands in CliStrings
> 
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example, 
> {{start manager}} has a whole set of associated commands - 
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}}, 
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere. 
> These commands should be deleted to clean up the code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[xiaojian zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou updated GEODE-3055:
-
Fix Version/s: 1.3.0

> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
> Fix For: 1.3.0
>
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3314) OldGen heap usage grows without increase in data size, large number of DLockTokens

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan resolved GEODE-3314.
-
   Resolution: Fixed
Fix Version/s: 1.2.1

> OldGen heap usage grows without increase in data size, large number of 
> DLockTokens
> --
>
> Key: GEODE-3314
> URL: https://issues.apache.org/jira/browse/GEODE-3314
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
> Fix For: 1.2.1
>
>
> When using Global Replicate regions, the DLockTokens are not correctly 
> cleaned up, causing a memory leak.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (GEODE-1449) CI Failure: ConfigCommandsDUnitTest.testExportConfig

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh reopened GEODE-1449:
--

> CI Failure: ConfigCommandsDUnitTest.testExportConfig
> 
>
> Key: GEODE-1449
> URL: https://issues.apache.org/jira/browse/GEODE-1449
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Udo Kohlmeyer
>Assignee: Emily Yeh
>  Labels: CI, Flaky
>
> Build #478 (May 24, 2016 3:42:27 AM)
> Revision: 45a4ef29f3c8174281aad667265a0764b0b912a3
> https://builds.apache.org/job/Geode-nightly/478/testReport/junit/com.gemstone.gemfire.management.internal.cli.commands/ConfigCommandsDUnitTest/testExportConfig/
> Stacktrace
> java.lang.AssertionError: Connect command failed to connect to manager 
> asf902.gq1.ygridcore.net[20761] result=Failed to retrieve RMIServer stub: 
> javax.naming.CommunicationException [Root exception is 
> java.rmi.NoSuchObjectException: no such object in table]
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.connect(CliCommandTestBase.java:223)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.setUpJmxManagerOnVm0ThenConnect(CliCommandTestBase.java:106)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.ConfigCommandsDUnitTest.testExportConfig(ConfigCommandsDUnitTest.java:172)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 

[jira] [Resolved] (GEODE-1449) CI Failure: ConfigCommandsDUnitTest.testExportConfig

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh resolved GEODE-1449.
--
Resolution: Fixed

> CI Failure: ConfigCommandsDUnitTest.testExportConfig
> 
>
> Key: GEODE-1449
> URL: https://issues.apache.org/jira/browse/GEODE-1449
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Udo Kohlmeyer
>Assignee: Emily Yeh
>  Labels: CI, Flaky
>
> Build #478 (May 24, 2016 3:42:27 AM)
> Revision: 45a4ef29f3c8174281aad667265a0764b0b912a3
> https://builds.apache.org/job/Geode-nightly/478/testReport/junit/com.gemstone.gemfire.management.internal.cli.commands/ConfigCommandsDUnitTest/testExportConfig/
> Stacktrace
> java.lang.AssertionError: Connect command failed to connect to manager 
> asf902.gq1.ygridcore.net[20761] result=Failed to retrieve RMIServer stub: 
> javax.naming.CommunicationException [Root exception is 
> java.rmi.NoSuchObjectException: no such object in table]
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.connect(CliCommandTestBase.java:223)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.setUpJmxManagerOnVm0ThenConnect(CliCommandTestBase.java:106)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.ConfigCommandsDUnitTest.testExportConfig(ConfigCommandsDUnitTest.java:172)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
>   at 
> 

[jira] [Assigned] (GEODE-1449) CI Failure: ConfigCommandsDUnitTest.testExportConfig

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh reassigned GEODE-1449:


Assignee: Emily Yeh

> CI Failure: ConfigCommandsDUnitTest.testExportConfig
> 
>
> Key: GEODE-1449
> URL: https://issues.apache.org/jira/browse/GEODE-1449
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Udo Kohlmeyer
>Assignee: Emily Yeh
>  Labels: CI, Flaky
>
> Build #478 (May 24, 2016 3:42:27 AM)
> Revision: 45a4ef29f3c8174281aad667265a0764b0b912a3
> https://builds.apache.org/job/Geode-nightly/478/testReport/junit/com.gemstone.gemfire.management.internal.cli.commands/ConfigCommandsDUnitTest/testExportConfig/
> Stacktrace
> java.lang.AssertionError: Connect command failed to connect to manager 
> asf902.gq1.ygridcore.net[20761] result=Failed to retrieve RMIServer stub: 
> javax.naming.CommunicationException [Root exception is 
> java.rmi.NoSuchObjectException: no such object in table]
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.connect(CliCommandTestBase.java:223)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase.setUpJmxManagerOnVm0ThenConnect(CliCommandTestBase.java:106)
>   at 
> com.gemstone.gemfire.management.internal.cli.commands.ConfigCommandsDUnitTest.testExportConfig(ConfigCommandsDUnitTest.java:172)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
>   at 
> 

[jira] [Commented] (GEODE-2886) The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an IllegalStateException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111440#comment-16111440
 ] 

ASF GitHub Bot commented on GEODE-2886:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/609#discussion_r130952081
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
@@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
   }
 
 } else {
-  throw new IllegalArgumentException(
+  IllegalStateException illegalStateException = new 
IllegalStateException(
   "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
+  logger.error(illegalStateException.getMessage());
--- End diff --

I still think we should just throw the exception here.  The executing side 
will either get a true or false anyways and the exception never actually gets 
propagated to the user.


> The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an 
> IllegalStateException
> ---
>
> Key: GEODE-2886
> URL: https://issues.apache.org/jira/browse/GEODE-2886
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an 
> IllegalArgumentException like:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the 
> index xxx region /yyy
> at 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> {noformat}
> The arguments are actually fine so should it instead throw an 
> IllegalStateException?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3380) data mismatch caused by removeAll

[xiaojian zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou resolved GEODE-3380.
--
Resolution: Fixed

> data mismatch caused by removeAll
> -
>
> Key: GEODE-3380
> URL: https://issues.apache.org/jira/browse/GEODE-3380
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> Host name: r02-s12
> OS name: Linux
> Architecture: amd64
> OS version: 4.4.0-66-lowlatency
> Java version: 1.8.0_45
> Java vm name: Java HotSpot(TM) 64-Bit Server VM
> Java vendor: Oracle Corporation
> Java home: /export/java/users/java_share/jdk/1.8.0_45/x86_64.linux/jre
>   #
>   Product
> Product-Name: Pivotal GemFire
> Product-Version: 0.0.0
> Native version: native code unavailable
>   Build
> Build-Date: 2017-06-21 18:09:56 -0700
> Build-Id: xzhou 
> Build-Java-Version: 1.8.0_66
> Build-Platform: Linux 4.4.0-66-lowlatency amd64
>   Open
> Source-Date: 2017-06-21 18:13:11 -0700
> Source-Repository: feature/GEM-1483
> Source-Revision: 524983349ccc576623eb69860d5287b8343a6064
>   Closed
> GemFire-Source-Date: 2017-06-14 08:59:26 -0700
> GemFire-Source-Repository: develop
> GemFire-Source-Revision: 1fe7c957e77cbfa254dbc353fd200233aebd3280
> Running on: /10.118.50.12, 24 cpu(s), amd64 Linux 4.4.0-66-lowlatency
>   #
> Test was run from ./test1455.bt
> Test:
> lucene/concParRegHAPersist.conf
>A=accessor
>B=dataStore
>accessorHosts=1
>accessorThreadsPerVM=5
>accessorVMsPerHost=1
>dataStoreHosts=6
>dataStoreThreadsPerVM=5
>dataStoreVMsPerHost=1
>numVMsToStop=2
>redundantCopies=0
> Run with local.conf:
> hydra.GemFirePrms-logLevel=fine;
> // hydra.VmPrms-extraVMArgs = -Xmx512m -Xms512m;
> // hydra.VmPrms-extraVMArgs=-Xmx500m;
> // hydra.Prms-randomSeed=1481188814352;
> hydra.Prms-randomSeed=1497100016755;
> // hydra.RegionPrms-offHeap = false;
> //randomSeed extracted from test:
> hydra.Prms-randomSeed=1497100016755;
> *** Test failed with this error:
> CLIENT vm_4_thr_20_dataStore4_r02-s12_10282
> TASK[1] parReg.ParRegTest.HydraTask_HADoEntryOps
> ERROR util.TestException: util.TestException: waitUntilFlushed returned true 
> after 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at util.MethodCoordinator.executeOnce(MethodCoordinator.java:68)
> at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2287)
> at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040)
> at sun.reflect.GeneratedMethodAccessor267.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> util.TestException: util.TestException: waitUntilFlushed returned true after 
> 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> 

[jira] [Resolved] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[xiaojian zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou resolved GEODE-3055.
--
Resolution: Fixed

> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3380) data mismatch caused by removeAll

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111407#comment-16111407
 ] 

ASF subversion and git services commented on GEODE-3380:


Commit 8d370977aa7d2cfacdd4f2b33d3c3739dd2bc1ef in geode's branch 
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8d37097 ]

GEODE-3380: spotlessApply to fix format


> data mismatch caused by removeAll
> -
>
> Key: GEODE-3380
> URL: https://issues.apache.org/jira/browse/GEODE-3380
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> Host name: r02-s12
> OS name: Linux
> Architecture: amd64
> OS version: 4.4.0-66-lowlatency
> Java version: 1.8.0_45
> Java vm name: Java HotSpot(TM) 64-Bit Server VM
> Java vendor: Oracle Corporation
> Java home: /export/java/users/java_share/jdk/1.8.0_45/x86_64.linux/jre
>   #
>   Product
> Product-Name: Pivotal GemFire
> Product-Version: 0.0.0
> Native version: native code unavailable
>   Build
> Build-Date: 2017-06-21 18:09:56 -0700
> Build-Id: xzhou 
> Build-Java-Version: 1.8.0_66
> Build-Platform: Linux 4.4.0-66-lowlatency amd64
>   Open
> Source-Date: 2017-06-21 18:13:11 -0700
> Source-Repository: feature/GEM-1483
> Source-Revision: 524983349ccc576623eb69860d5287b8343a6064
>   Closed
> GemFire-Source-Date: 2017-06-14 08:59:26 -0700
> GemFire-Source-Repository: develop
> GemFire-Source-Revision: 1fe7c957e77cbfa254dbc353fd200233aebd3280
> Running on: /10.118.50.12, 24 cpu(s), amd64 Linux 4.4.0-66-lowlatency
>   #
> Test was run from ./test1455.bt
> Test:
> lucene/concParRegHAPersist.conf
>A=accessor
>B=dataStore
>accessorHosts=1
>accessorThreadsPerVM=5
>accessorVMsPerHost=1
>dataStoreHosts=6
>dataStoreThreadsPerVM=5
>dataStoreVMsPerHost=1
>numVMsToStop=2
>redundantCopies=0
> Run with local.conf:
> hydra.GemFirePrms-logLevel=fine;
> // hydra.VmPrms-extraVMArgs = -Xmx512m -Xms512m;
> // hydra.VmPrms-extraVMArgs=-Xmx500m;
> // hydra.Prms-randomSeed=1481188814352;
> hydra.Prms-randomSeed=1497100016755;
> // hydra.RegionPrms-offHeap = false;
> //randomSeed extracted from test:
> hydra.Prms-randomSeed=1497100016755;
> *** Test failed with this error:
> CLIENT vm_4_thr_20_dataStore4_r02-s12_10282
> TASK[1] parReg.ParRegTest.HydraTask_HADoEntryOps
> ERROR util.TestException: util.TestException: waitUntilFlushed returned true 
> after 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at util.MethodCoordinator.executeOnce(MethodCoordinator.java:68)
> at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2287)
> at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040)
> at sun.reflect.GeneratedMethodAccessor267.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> util.TestException: util.TestException: waitUntilFlushed returned true after 
> 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at 

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111398#comment-16111398
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit bb847c767f1507eed8c26dee02b377c65d43a0f7 in geode's branch 
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=bb847c7 ]

GEODE-3055: The old primary's the shadow bucket is not
initialized when rebalance remove it. Thus the new primary candidate can
never initialize from it. The fix is to wait until new primary exists before
remove the old primary's bucket in rebalance.

When the colocated child bucket failed to initialize, remove the leader
bucket since all these buckets should be created atomically.

This closes #570


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3384) Incorrect java doc for PageableLuceneQueryResults

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111394#comment-16111394
 ] 

ASF GitHub Bot commented on GEODE-3384:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/678


> Incorrect java doc for PageableLuceneQueryResults
> -
>
> Key: GEODE-3384
> URL: https://issues.apache.org/jira/browse/GEODE-3384
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Javadocs for PageableLuceneQueryResults mention that 
> {noformat}
>  * Each page is fetched individually from the server, so {@link 
> PageableLuceneQueryResults} cannot
>  * be serialized and sent to other members.
> {noformat}
> but now this interface is serializable, this change must be reflected in the 
> javadoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3256) Refactor DataCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111388#comment-16111388
 ] 

ASF GitHub Bot commented on GEODE-3256:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/672#discussion_r130944162
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
 ---
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.StringTokenizer;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+
+import org.apache.geode.LogWriter;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.management.DistributedRegionMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.MBeanJMXAdapter;
+import org.apache.geode.management.internal.cli.CliUtil;
+import org.apache.geode.management.internal.cli.LogWrapper;
+import org.apache.geode.management.internal.cli.domain.DataCommandRequest;
+import org.apache.geode.management.internal.cli.domain.DataCommandResult;
+import 
org.apache.geode.management.internal.cli.functions.DataCommandFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CompositeResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+
+public class DataCommandsUtils {
--- End diff --

I would prefer to avoid *Utils classes as well. It's reasonable to 
introduce it as a temporary refactoring though just to facilitate breaking 
DataCommands up into multiple Command classes. At some point, we should try to 
refactor DataCommandUtils to non-static OO classes.

Unfortunately I don't have any examples for changing DataCommandUtils to OO 
off the top of my head. That code is going to require some studying to figure 
out how to properly organize it. 

I guess my recommendation at this point is to pull in these changes as they 
are and then @jaredjstewart @YehEmily @jinmeiliao and myself could get together 
and mob on restructuring DataCommandUtils. Thoughts?


> Refactor DataCommands
> -
>
> Key: GEODE-3256
> URL: https://issues.apache.org/jira/browse/GEODE-3256
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DataCommands.java}} is a large class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3380) data mismatch caused by removeAll

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111384#comment-16111384
 ] 

ASF subversion and git services commented on GEODE-3380:


Commit 71dc0f865668974668077fe5d3289587944e0b34 in geode's branch 
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=71dc0f8 ]

GEODE-3380: There're 2 problems here
1) when removeAll is retried, it will get EntryNotFound exception. It should 
still put the remove event
into the AEQ.
2) An old bug fix in 8.2 was not merged into develop: when removeAll encounter 
EntryNotFound exception, should
return version tag of the tombstone.

This closes #674


> data mismatch caused by removeAll
> -
>
> Key: GEODE-3380
> URL: https://issues.apache.org/jira/browse/GEODE-3380
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> Host name: r02-s12
> OS name: Linux
> Architecture: amd64
> OS version: 4.4.0-66-lowlatency
> Java version: 1.8.0_45
> Java vm name: Java HotSpot(TM) 64-Bit Server VM
> Java vendor: Oracle Corporation
> Java home: /export/java/users/java_share/jdk/1.8.0_45/x86_64.linux/jre
>   #
>   Product
> Product-Name: Pivotal GemFire
> Product-Version: 0.0.0
> Native version: native code unavailable
>   Build
> Build-Date: 2017-06-21 18:09:56 -0700
> Build-Id: xzhou 
> Build-Java-Version: 1.8.0_66
> Build-Platform: Linux 4.4.0-66-lowlatency amd64
>   Open
> Source-Date: 2017-06-21 18:13:11 -0700
> Source-Repository: feature/GEM-1483
> Source-Revision: 524983349ccc576623eb69860d5287b8343a6064
>   Closed
> GemFire-Source-Date: 2017-06-14 08:59:26 -0700
> GemFire-Source-Repository: develop
> GemFire-Source-Revision: 1fe7c957e77cbfa254dbc353fd200233aebd3280
> Running on: /10.118.50.12, 24 cpu(s), amd64 Linux 4.4.0-66-lowlatency
>   #
> Test was run from ./test1455.bt
> Test:
> lucene/concParRegHAPersist.conf
>A=accessor
>B=dataStore
>accessorHosts=1
>accessorThreadsPerVM=5
>accessorVMsPerHost=1
>dataStoreHosts=6
>dataStoreThreadsPerVM=5
>dataStoreVMsPerHost=1
>numVMsToStop=2
>redundantCopies=0
> Run with local.conf:
> hydra.GemFirePrms-logLevel=fine;
> // hydra.VmPrms-extraVMArgs = -Xmx512m -Xms512m;
> // hydra.VmPrms-extraVMArgs=-Xmx500m;
> // hydra.Prms-randomSeed=1481188814352;
> hydra.Prms-randomSeed=1497100016755;
> // hydra.RegionPrms-offHeap = false;
> //randomSeed extracted from test:
> hydra.Prms-randomSeed=1497100016755;
> *** Test failed with this error:
> CLIENT vm_4_thr_20_dataStore4_r02-s12_10282
> TASK[1] parReg.ParRegTest.HydraTask_HADoEntryOps
> ERROR util.TestException: util.TestException: waitUntilFlushed returned true 
> after 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at util.MethodCoordinator.executeOnce(MethodCoordinator.java:68)
> at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2287)
> at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040)
> at sun.reflect.GeneratedMethodAccessor267.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> util.TestException: util.TestException: waitUntilFlushed returned true after 
> 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at 

[jira] [Commented] (GEODE-3380) data mismatch caused by removeAll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111385#comment-16111385
 ] 

ASF GitHub Bot commented on GEODE-3380:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/674


> data mismatch caused by removeAll
> -
>
> Key: GEODE-3380
> URL: https://issues.apache.org/jira/browse/GEODE-3380
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> Host name: r02-s12
> OS name: Linux
> Architecture: amd64
> OS version: 4.4.0-66-lowlatency
> Java version: 1.8.0_45
> Java vm name: Java HotSpot(TM) 64-Bit Server VM
> Java vendor: Oracle Corporation
> Java home: /export/java/users/java_share/jdk/1.8.0_45/x86_64.linux/jre
>   #
>   Product
> Product-Name: Pivotal GemFire
> Product-Version: 0.0.0
> Native version: native code unavailable
>   Build
> Build-Date: 2017-06-21 18:09:56 -0700
> Build-Id: xzhou 
> Build-Java-Version: 1.8.0_66
> Build-Platform: Linux 4.4.0-66-lowlatency amd64
>   Open
> Source-Date: 2017-06-21 18:13:11 -0700
> Source-Repository: feature/GEM-1483
> Source-Revision: 524983349ccc576623eb69860d5287b8343a6064
>   Closed
> GemFire-Source-Date: 2017-06-14 08:59:26 -0700
> GemFire-Source-Repository: develop
> GemFire-Source-Revision: 1fe7c957e77cbfa254dbc353fd200233aebd3280
> Running on: /10.118.50.12, 24 cpu(s), amd64 Linux 4.4.0-66-lowlatency
>   #
> Test was run from ./test1455.bt
> Test:
> lucene/concParRegHAPersist.conf
>A=accessor
>B=dataStore
>accessorHosts=1
>accessorThreadsPerVM=5
>accessorVMsPerHost=1
>dataStoreHosts=6
>dataStoreThreadsPerVM=5
>dataStoreVMsPerHost=1
>numVMsToStop=2
>redundantCopies=0
> Run with local.conf:
> hydra.GemFirePrms-logLevel=fine;
> // hydra.VmPrms-extraVMArgs = -Xmx512m -Xms512m;
> // hydra.VmPrms-extraVMArgs=-Xmx500m;
> // hydra.Prms-randomSeed=1481188814352;
> hydra.Prms-randomSeed=1497100016755;
> // hydra.RegionPrms-offHeap = false;
> //randomSeed extracted from test:
> hydra.Prms-randomSeed=1497100016755;
> *** Test failed with this error:
> CLIENT vm_4_thr_20_dataStore4_r02-s12_10282
> TASK[1] parReg.ParRegTest.HydraTask_HADoEntryOps
> ERROR util.TestException: util.TestException: waitUntilFlushed returned true 
> after 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at util.MethodCoordinator.executeOnce(MethodCoordinator.java:68)
> at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2287)
> at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040)
> at sun.reflect.GeneratedMethodAccessor267.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at hydra.MethExecutor.execute(MethExecutor.java:182)
> at hydra.MethExecutor.execute(MethExecutor.java:150)
> at hydra.TestTask.execute(TestTask.java:192)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212)
> util.TestException: util.TestException: waitUntilFlushed returned true after 
> 7ms
> Verifying 479 matches for lucene index against snapshot of size 478
> Lucene query did not match region values.
> missingKeys=[], extraKeys=[Object_5740],
>  pendingAsyncOps=[],
>  lastException=
> at lucene.LuceneHelper.verifyLuceneIndex(LuceneHelper.java:149)
> at lucene.LuceneTest.verifyLuceneIndex(LuceneTest.java:516)
> at lucene.LuceneTest.verifyFromSnapshotOnly(LuceneTest.java:398)
> at parReg.ParRegTest.verifyFromSnapshot(ParRegTest.java:5703)
> at parReg.ParRegTest.concVerify(ParRegTest.java:6106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> 

[jira] [Commented] (GEODE-3384) Incorrect java doc for PageableLuceneQueryResults

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111372#comment-16111372
 ] 

ASF GitHub Bot commented on GEODE-3384:
---

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/678

GEODE-3384: Javadoc change for PageableLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3384

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 5eddfc9ac1b70757e7dedf9c4e8cb9d0c3078614
Author: nabarun 
Date:   2017-08-02T17:26:07Z

GEODE-3384: Javadoc change for PageabelLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members




> Incorrect java doc for PageableLuceneQueryResults
> -
>
> Key: GEODE-3384
> URL: https://issues.apache.org/jira/browse/GEODE-3384
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Javadocs for PageableLuceneQueryResults mention that 
> {noformat}
>  * Each page is fetched individually from the server, so {@link 
> PageableLuceneQueryResults} cannot
>  * be serialized and sent to other members.
> {noformat}
> but now this interface is serializable, this change must be reflected in the 
> javadoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-258) Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111363#comment-16111363
 ] 

ASF GitHub Bot commented on GEODE-258:
--

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/467
  
@davinash Sorry to take so long to respond! For the security logger you can 
use this:
```java
  private static Logger securityLogger = 
LogService.getLogger(LogService.SECURITY_LOGGER_NAME);
```
At some point, we should add this to LogService (feel free to add this if 
you want to):
```java
  public static Logger getSecurityLogger() {
return getLogger(LogService.SECURITY_LOGGER_NAME);
  }
```
Then you could use:
```java
  private static Logger securityLogger = LogService.getSecurityLogger();
```


> Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods
> ---
>
> Key: GEODE-258
> URL: https://issues.apache.org/jira/browse/GEODE-258
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Remove the deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods. 
> All calls can be replaced with getLogger().convertToLogWriterI18n() so this 
> should be a quick task.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3384) Incorrect java doc for PageableLuceneQueryResults

[nabarun (JIRA)]

nabarun created GEODE-3384:
--

 Summary: Incorrect java doc for PageableLuceneQueryResults
 Key: GEODE-3384
 URL: https://issues.apache.org/jira/browse/GEODE-3384
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


Javadocs for PageableLuceneQueryResults mention that 
{noformat}
 * Each page is fetched individually from the server, so {@link 
PageableLuceneQueryResults} cannot
 * be serialized and sent to other members.
{noformat}

but now this interface is serializable, this change must be reflected in the 
javadoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3384) Incorrect java doc for PageableLuceneQueryResults

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun reassigned GEODE-3384:
--

Assignee: nabarun

> Incorrect java doc for PageableLuceneQueryResults
> -
>
> Key: GEODE-3384
> URL: https://issues.apache.org/jira/browse/GEODE-3384
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Javadocs for PageableLuceneQueryResults mention that 
> {noformat}
>  * Each page is fetched individually from the server, so {@link 
> PageableLuceneQueryResults} cannot
>  * be serialized and sent to other members.
> {noformat}
> but now this interface is serializable, this change must be reflected in the 
> javadoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111343#comment-16111343
 ] 

ASF GitHub Bot commented on GEODE-3055:
---

Github user gesterzhou commented on a diff in the pull request:

https://github.com/apache/geode/pull/570#discussion_r130938862
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
@@ -494,6 +494,18 @@ CreateBucketResult grabFreeBucket(final int 
possiblyFreeBucketId, final Distribu
 
   return result;
 
+} catch (RuntimeException validationException) {
+  // GEODE-3055
+  PartitionedRegion leader = 
ColocationHelper.getLeaderRegion(this.partitionedRegion);
+  boolean isLeader = leader.equals(this.partitionedRegion);
--- End diff --

Remove the leader will remove all its children. 


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111335#comment-16111335
 ] 

ASF GitHub Bot commented on GEODE-3055:
---

Github user boglesby commented on a diff in the pull request:

https://github.com/apache/geode/pull/570#discussion_r130937683
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
@@ -494,6 +494,18 @@ CreateBucketResult grabFreeBucket(final int 
possiblyFreeBucketId, final Distribu
 
   return result;
 
+} catch (RuntimeException validationException) {
+  // GEODE-3055
+  PartitionedRegion leader = 
ColocationHelper.getLeaderRegion(this.partitionedRegion);
+  boolean isLeader = leader.equals(this.partitionedRegion);
--- End diff --

What if there is more than one colocated child region and one of the child 
buckets is successfully created, but the other is not. This code will remove 
the parent bucket. Will the one that was successfully created also get removed?


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3314) OldGen heap usage grows without increase in data size, large number of DLockTokens

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111329#comment-16111329
 ] 

ASF GitHub Bot commented on GEODE-3314:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/663


> OldGen heap usage grows without increase in data size, large number of 
> DLockTokens
> --
>
> Key: GEODE-3314
> URL: https://issues.apache.org/jira/browse/GEODE-3314
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> When using Global Replicate regions, the DLockTokens are not correctly 
> cleaned up, causing a memory leak.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3028) Fix the expected value of the test that depended on Locale

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111314#comment-16111314
 ] 

ASF subversion and git services commented on GEODE-3028:


Commit d77d69f65677bb3e9e7babb316a2bd84cbe9991c in geode's branch 
refs/heads/develop from [~masaki.yamakawa]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d77d69f ]

GEODE-3028: Fix the expected value of the test that depended on Locale

Fix the test that uses the English message as the expected value so that
it does not depend on the locale at runtime environment.

This closes #556


> Fix the expected value of the test that depended on Locale
> --
>
> Key: GEODE-3028
> URL: https://issues.apache.org/jira/browse/GEODE-3028
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I am testing in Japanese environment. Running the test in the Japanese 
> environment will cause the Assertion to fail due to the difference in Locale, 
> so I want to change this so that it does not depend on the runtime 
> environment.
> The target classes are as follows:
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithAuthenticatorTest
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithSecurityManagerTest
> - org.apache.geode.internal.cache.tier.sockets.ServerConnectionTest
> - org.apache.geode.internal.cache.ColocationHelperTest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3028) Fix the expected value of the test that depended on Locale

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111316#comment-16111316
 ] 

ASF GitHub Bot commented on GEODE-3028:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/556


> Fix the expected value of the test that depended on Locale
> --
>
> Key: GEODE-3028
> URL: https://issues.apache.org/jira/browse/GEODE-3028
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I am testing in Japanese environment. Running the test in the Japanese 
> environment will cause the Assertion to fail due to the difference in Locale, 
> so I want to change this so that it does not depend on the runtime 
> environment.
> The target classes are as follows:
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithAuthenticatorTest
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithSecurityManagerTest
> - org.apache.geode.internal.cache.tier.sockets.ServerConnectionTest
> - org.apache.geode.internal.cache.ColocationHelperTest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3319) Use protobuf serialization for primitive types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111288#comment-16111288
 ] 

ASF GitHub Bot commented on GEODE-3319:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/661


> Use protobuf serialization for primitive types
> --
>
> Key: GEODE-3319
> URL: https://issues.apache.org/jira/browse/GEODE-3319
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol to write a new client, I'd rather not 
> worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some 
> burden off of the client and eliminate the problem of language-to-language 
> endian mismatches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3319) Use protobuf serialization for primitive types

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111285#comment-16111285
 ] 

ASF subversion and git services commented on GEODE-3319:


Commit e5f8e8cb29d81e23ec65aa81d47d4c568fe0b9fa in geode's branch 
refs/heads/develop from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e5f8e8c ]

GEODE-3319 - refactor to use protobuf encoding for primitive types. This now 
closes #661


> Use protobuf serialization for primitive types
> --
>
> Key: GEODE-3319
> URL: https://issues.apache.org/jira/browse/GEODE-3319
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol to write a new client, I'd rather not 
> worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some 
> burden off of the client and eliminate the problem of language-to-language 
> endian mismatches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (GEODE-3131) CI Failure: org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun reopened GEODE-3131:


> CI Failure: 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut
> --
>
> Key: GEODE-3131
> URL: https://issues.apache.org/jira/browse/GEODE-3131
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.1.0
>Reporter: Jason Huynh
> Fix For: 1.3.0
>
>
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest > 
> testRefCountForNormalAndGIIPut FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest$$Lambda$95/1198712296.run
>  in VM 1 running on Host 893875957fbb with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut(HARQueueNewImplDUnitTest.java:383)
> Caused by:
> java.lang.AssertionError: expected:<3> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.verifyQueueData(HARQueueNewImplDUnitTest.java:1061)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.lambda$testRefCountForNormalAndGIIPut$bb17a952$11(HARQueueNewImplDUnitTest.java:383)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3284) New flow: getAvailableServers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111267#comment-16111267
 ] 

ASF GitHub Bot commented on GEODE-3284:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/673


> New flow: getAvailableServers
> -
>
> Key: GEODE-3284
> URL: https://issues.apache.org/jira/browse/GEODE-3284
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a Geode client user, I'd like to be able to know all available servers in 
> a grid in order to support operations targeting any available server.
> Create op handler for getAvailableServers message, following proto message 
> definition.
> Client should be able to complete getAvailableServers, receiving all servers 
> available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3284) New flow: getAvailableServers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111264#comment-16111264
 ] 

ASF subversion and git services commented on GEODE-3284:


Commit bf2e0f6e03d1c50580a45efdd3588d1a19bdb5d9 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=bf2e0f6 ]

GEODE-3284: New flow: getAvailableServers. This now closed #673

Signed-off-by: Bruce Schuchardt 


> New flow: getAvailableServers
> -
>
> Key: GEODE-3284
> URL: https://issues.apache.org/jira/browse/GEODE-3284
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a Geode client user, I'd like to be able to know all available servers in 
> a grid in order to support operations targeting any available server.
> Create op handler for getAvailableServers message, following proto message 
> definition.
> Client should be able to complete getAvailableServers, receiving all servers 
> available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111240#comment-16111240
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130928395
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java
 ---
@@ -95,8 +97,8 @@ public void 
processReturnsUnsucessfulResponseForInvalidRegion()
 operationHandler.process(serializationServiceStub, removeRequest, 
cacheStub);
 
 assertTrue(result instanceof Failure);
-org.junit.Assert.assertThat(result.getErrorMessage().getMessage(),
-CoreMatchers.containsString("Region"));
+assertEquals(ProtocolErrorCode.REGION_NOT_FOUND.codeValue,
--- End diff --

+1


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111241#comment-16111241
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130928974
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with 
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software 
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR 
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language 
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+  GENERIC_FAILURE(1000),
--- End diff --

I believe any error code structure decides how many characters are to be 
used for an error code. 
The fact that we represent them as integers is merely a "simplification" 
choice over using Alpha numerics.
I don't believe starting the error code at 1000 is a problem


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1663#comment-1663
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130920986
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with 
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software 
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR 
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language 
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+  GENERIC_FAILURE(1000),
--- End diff --

This originally started at "1" and was followed by "100". After I protested 
it was changed to "001". After more discussion we ended up with the "1000" and 
"2000" ranges to accommodate for sub-ranges.


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1665#comment-1665
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user WireBaron commented on the issue:

https://github.com/apache/geode/pull/676
  
Copied the license fresh from another file.


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3336) Refactor IndexCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1659#comment-1659
 ] 

ASF GitHub Bot commented on GEODE-3336:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/670


> Refactor IndexCommandsDUnitTest to use test rules
> -
>
> Key: GEODE-3336
> URL: https://issues.apache.org/jira/browse/GEODE-3336
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{IndexCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a 
> deprecated class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1359) Cleanup CliCommandTestBase tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1657#comment-1657
 ] 

ASF subversion and git services commented on GEODE-1359:


Commit 636e970d93f2fe67c4bb8cbc59c5243b44f4a89d in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=636e970 ]

GEODE-1359: Refactor IndexCommandsDUnitTest to use test rules and allow for 
removal of CliCommandTestBase

* this closes #670


> Cleanup CliCommandTestBase tests
> 
>
> Key: GEODE-1359
> URL: https://issues.apache.org/jira/browse/GEODE-1359
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>
> Cleanup CliCommandTestBase tests
> * Fix up potential time sensitivity issues.
> * Ensure output goes to TemporaryFolder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3339) Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1652#comment-1652
 ] 

ASF GitHub Bot commented on GEODE-3339:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/675


> Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules
> ---
>
> Key: GEODE-3339
> URL: https://issues.apache.org/jira/browse/GEODE-3339
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ClusterConfigurationServiceEndToEndDUnitTest}} is using 
> {{CliCommandTestBase}}, which is a deprecated class. It should be refactored 
> to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3339) Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1651#comment-1651
 ] 

ASF subversion and git services commented on GEODE-3339:


Commit 67026df70ca75a2a00b24e50b3de46b4ac116cb0 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=67026df ]

GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest

* this closes #675


> Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules
> ---
>
> Key: GEODE-3339
> URL: https://issues.apache.org/jira/browse/GEODE-3339
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ClusterConfigurationServiceEndToEndDUnitTest}} is using 
> {{CliCommandTestBase}}, which is a deprecated class. It should be refactored 
> to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3284) New flow: getAvailableServers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1636#comment-1636
 ] 

ASF GitHub Bot commented on GEODE-3284:
---

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/673
  
Locators aren't configured via cluster config.  None of the 
distributed-system properties are configured through cluster configuration 
because you must connect to the distributed system in order to obtain the 
cluster configuration.


> New flow: getAvailableServers
> -
>
> Key: GEODE-3284
> URL: https://issues.apache.org/jira/browse/GEODE-3284
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a Geode client user, I'd like to be able to know all available servers in 
> a grid in order to support operations targeting any available server.
> Create op handler for getAvailableServers message, following proto message 
> definition.
> Client should be able to complete getAvailableServers, receiving all servers 
> available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3321) Error Codes Specification for all operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1632#comment-1632
 ] 

ASF GitHub Bot commented on GEODE-3321:
---

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/676
  
The license header was probably damaged during some search 
operations to transform the google-doc version of the list into an enum


> Error Codes Specification for all operations
> 
>
> Key: GEODE-3321
> URL: https://issues.apache.org/jira/browse/GEODE-3321
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> As a developer using the new protocol, I need to know what error codes to 
> expect from the server and what they mean.
> Delineate the possible error codes for each operation, documenting each error 
> code, when it will occur, and what message will be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3038) A server process shuts down quietly when path to cache.xml is incorrect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111032#comment-16111032
 ] 

ASF GitHub Bot commented on GEODE-3038:
---

GitHub user anton-mironenko opened a pull request:

https://github.com/apache/geode/pull/677

GEODE-3038: A server process shuts down quietly when path to cache.xml is 
incorrect

[GEODE-3038](https://issues.apache.org/jira/browse/GEODE-3038)
The error 
"Declarative Cache XML file/resource \[path-to-cache-xml\] does not exist"
is trying to be written into the log in GemFireCacheImpl.basicCreate(), 
after method GemFireCacheImpl.close() is called, so that writing into the log 
is already not available.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anton-mironenko/geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit f119fb381d4212e8714d26f2388860206daa3d8a
Author: Anton Mironenko 
Date:   2017-08-01T12:18:12Z

write cachexml-not-found exception into the log in a proper place

commit bf0b059035751b3d7cba82a145546edb7efce824
Author: Anton Mironenko 
Date:   2017-08-01T12:52:14Z

Merge remote-tracking branch 'upstream/develop' into GEODE-3038




> A server process shuts down quietly when path to cache.xml is incorrect
> ---
>
> Key: GEODE-3038
> URL: https://issues.apache.org/jira/browse/GEODE-3038
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Reporter: Anton Mironenko
>Assignee: Kirk Lund
>Priority: Minor
>
> Geode version: 1.1.1, 1.3.0 (latest develop snapshot)
> If I start a server with incorrect path to Server.xml, it shuts down quietly 
> without any message in the log. 
> An expected behavior would be the error message "Server.xml not found in the 
> path [...], shutting down"
> Here are the steps to reproduce, please use GEODE-3003 for zip files.
> Test preparation:
> -
> Here are two attached zip files - "geode-host1.zip" and "geode-host2.zip"
> 1) unzip "geode-host1.zip" into some folder on your first host
> 2) in start-locator.sh change the IPs of locators to the values of your host1 
> and host2
> "--locators=10.50.3.38[20236],10.50.3.14[20236]"
> 3) in start-server.sh
> "locators=10.50.3.38[20236],10.50.3.14[20236]" change the IPs of locators to 
> the values of your host1 and host2
> 4) do the bullets 1)-4) for host2, the folder where you unzip the file should 
> be the same as on the first host
> Test running:
> ---
> 0) change start-server.sh so that the path to Server.xml is wrong
> cache-xml-file=$SERVERXML_DIR/Server.xml
> ->
> cache-xml-file=$SERVERXML_DIR/Server_.xml
> 1) run ./start-locator.sh on host1
> 2) after some pause run ./start-server
> 3) observe the server started and immediately stopped,
> 4) observe in the server logs, server1/cacheserver.log:
> [info 2017/06/06 18:32:05.141 MSK host1-server-1  tid=0x1] Received 
> cluster configuration from the locator
> [info 2017/06/06 18:32:05.141 MSK host1-server-1  tid=0x1] 
>   ***
>   Configuration for  'cluster'
>   
>   Jar files to deployed
> [info 2017/06/06 18:32:05.141 MSK host1-server-1  tid=0x1] Requesting 
> cluster configuration
> [info 2017/06/06 18:32:05.143 MSK host1-server-1  tid=0x1] Got response 
> with jars: 
> [info 2017/06/06 18:32:05.209 MSK host1-server-1  tid=0x1] 

[jira] [Commented] (GEODE-3292) Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110799#comment-16110799
 ] 

ASF GitHub Bot commented on GEODE-3292:
---

Github user jujoramos commented on the issue:

https://github.com/apache/geode/pull/664
  
Hello @jaredjstewart,

Just pushed the requested changes.

- Renamed `PulseVerificationTest` to `PulseConnectivityTest`.
- Removed `loginWithIncorrectPassword` test method, it is the same as the 
one in `PulseSecurityTest`.
- Added integration tests to check the connectivity between PULSE and the 
local jmx-manager, both when the default and non-default bind-address is used.
- Added `PulseAppListenerTest` unit test to verify that the repository is 
correctly configured by the `PulseAppListener` when PULSE is running in 
embedded mode.

Cheers.


> Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
> 
>
> Key: GEODE-3292
> URL: https://issues.apache.org/jira/browse/GEODE-3292
> Project: Geode
>  Issue Type: Bug
>  Components: pulse
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Minor
>
> The PULSE webApp (embedded mode) fails to connect to the jmx-manager when a 
> non-default {{jmx-manager-bind-address}} is configured. The app tries to 
> connect by default to 
> {{service:jmx:rmi://localhost/jndi/rmi://localhost:17991/jmxrmi}} whenever it 
> detects it's running in embedded mode, instead of getting the local hostname 
> through {{InetAddress.getLocalHost().getCanonicalHostName()}} as it used to 
> do before.
> The problem was introduced by 
> [GEODE-2927|https://issues.apache.org/jira/browse/GEODE-2927], commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6].
> Steps to reproduce:
> {code:none}
> $ export JAVA_ARGS="-Dgfsh.log-level=config -Dgfsh.log-dir=$(pwd)"
> $ gfsh start locator --name=locator1 --force=true --connect=false \
> --J=-Dpulse.Log-Level=debug --J=-Dpulse.Log-File-Name=pulse.log 
> --J=-Dpulse.Log-FileLocation=$(pwd) \
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
> --J=-Dgemfire.jmx-manager-port=17991 \
> --J=-Dgemfire.jmx-manager-bind-address=$(ipconfig getifaddr en0)
> $ gfsh start pulse
> {code}
> At this point, and after a successful login to PULSE, the application doesn't 
> show any cluster data and the exception can be seen (both in the logs and in 
> the PULSE screen).
> The easiest solution would be to revert back some lines of the changes made 
> by commit 
> [0f978a6df711d04e0c7c1926fb1e297d07c21aa3|https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0f978a6],
>  as follows:
> {code:title=PulseAppListener.java|borderStyle=solid}
> @Override
>   public void contextInitialized(ServletContextEvent event) {
>   (...)
> boolean sysIsEmbedded = 
> Boolean.getBoolean(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED);
> if (sysIsEmbedded) {
>   // jmx connection parameters
>   
> logger.info(resourceBundle.getString("LOG_MSG_APP_RUNNING_EMBEDDED_MODE"));
>   repository.setJmxUseLocator(false);
>   
> //
> String sysPulseHost;
>   try {
> // Get host name of machine running pulse in embedded mode
> sysPulseHost = InetAddress.getLocalHost().getCanonicalHostName();
>   } catch (Exception e) {
> 
> logger.debug(resourceBundle.getString("LOG_MSG_JMX_CONNECTION_UNKNOWN_HOST"), 
> e);
> // Set default host name
> sysPulseHost = PulseConstants.GEMFIRE_DEFAULT_HOST;
>   }
>   repository.setHost(sysPulseHost);
>   
> //
>   
> repository.setPort(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_PORT,
>   PulseConstants.GEMFIRE_DEFAULT_PORT));
>   // SSL, all the other system properties are already set in the embedded 
> VM
>   repository.setUseSSLManager(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_MANAGER)));
>   repository.setUseSSLLocator(
>   
> Boolean.valueOf(System.getProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_LOCATOR)));
>   (...)
>   }
> {code}
> I can make the changes and submit a PR if someone assigns me this ticket.
> Cheers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)