[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Open (was: Patch Available)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Attachment: 20111030_4703_all.v3.patch
Should fix the points above.
Improvements in tests
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Patch Available (was: Open)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139986#comment-13139986
]
gaojinchao commented on HBASE-4695:
---
Latest Trunk version, test passed in a real
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139987#comment-13139987
]
gaojinchao commented on HBASE-4695:
---
@Ted
I think your patch has some problem. when
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gaojinchao updated HBASE-4695:
--
Attachment: HBASE-4695_Trunk_V2.patch
WAL logs get deleted before region server can fully flush
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140007#comment-13140007
]
Hadoop QA commented on HBASE-4703:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140009#comment-13140009
]
gaojinchao commented on HBASE-4695:
---
@Ted
Our laboratory network failure, I verify the
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Open (was: Patch Available)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Patch Available (was: Open)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140044#comment-13140044
]
Hadoop QA commented on HBASE-4695:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Patch Available (was: Open)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Open (was: Patch Available)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140135#comment-13140135
]
ramkrishna.s.vasudevan commented on HBASE-4277:
---
The patch applies as is..
Avoid unnecessary DNS lookups for locality computation in HMaster
-
Key: HBASE-4707
URL: https://issues.apache.org/jira/browse/HBASE-4707
Project: HBase
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140210#comment-13140210
]
nkeywal commented on HBASE-4703:
I've managed to reproduce the stack on
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Attachment: 20111030_4703_all.v4.patch
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140212#comment-13140212
]
ramkrishna.s.vasudevan commented on HBASE-4552:
---
In test case
[
https://issues.apache.org/jira/browse/HBASE-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140217#comment-13140217
]
Jonathan Hsieh commented on HBASE-4677:
---
@Stack
I lean slightly towards removing
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Patch Available (was: Open)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nkeywal updated HBASE-4703:
---
Status: Open (was: Patch Available)
Improvements in tests
-
[
https://issues.apache.org/jira/browse/HBASE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140233#comment-13140233
]
Ming Ma commented on HBASE-4298:
Just in case, there was another code review at
[
https://issues.apache.org/jira/browse/HBASE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140251#comment-13140251
]
stack commented on HBASE-4298:
--
Thanks Ming. Let me chase Aravind today.
[
https://issues.apache.org/jira/browse/HBASE-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140265#comment-13140265
]
stack commented on HBASE-4677:
--
@Jon OK. Want to attach your last patch up on RB here so I
[
https://issues.apache.org/jira/browse/HBASE-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140269#comment-13140269
]
Ted Yu commented on HBASE-4677:
---
@Stack:
For TRUNK, this change is contained in
[
https://issues.apache.org/jira/browse/HBASE-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140270#comment-13140270
]
stack commented on HBASE-4277:
--
+1 on commit
HRS.closeRegion should be able
[
https://issues.apache.org/jira/browse/HBASE-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140275#comment-13140275
]
stack commented on HBASE-4677:
--
Hmmm. I'm a little lost as to what is to be applied. I'll
[
https://issues.apache.org/jira/browse/HBASE-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140290#comment-13140290
]
Phabricator commented on HBASE-4704:
stack has commented on the revision HBASE-4704
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140297#comment-13140297
]
stack commented on HBASE-4695:
--
+1 on patch. Looks good to me.
WAL logs
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140299#comment-13140299
]
stack commented on HBASE-4695:
--
@Jack You want to try this patch?
WAL logs
[
https://issues.apache.org/jira/browse/HBASE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4695:
-
Fix Version/s: 0.92.0
WAL logs get deleted before region server can fully flush
[
https://issues.apache.org/jira/browse/HBASE-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140302#comment-13140302
]
stack commented on HBASE-4674:
--
@Prakash Thanks
splitLog silently fails
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140306#comment-13140306
]
Hadoop QA commented on HBASE-4703:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140317#comment-13140317
]
Jonathan Hsieh commented on HBASE-4552:
---
@Ram, on trunk or 0.92 branches,
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140335#comment-13140335
]
nkeywal commented on HBASE-4703:
The two errors in the report above are caused by a
[
https://issues.apache.org/jira/browse/HBASE-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140344#comment-13140344
]
Ted Yu commented on HBASE-4552:
---
Integrated to 0.92 and TRUNK.
Thanks for the patch
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4703:
-
Fix Version/s: 0.92.0
Improvements in tests
-
Key: HBASE-4703
[
https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140343#comment-13140343
]
stack commented on HBASE-4703:
--
I will apply this patch this afternoon unless objection.
[
https://issues.apache.org/jira/browse/HBASE-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4677:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
This patch has been integrated to 0.92 as
[
https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4610:
-
Priority: Major (was: Critical)
No movement on this; making it major. Not going to let it get in way of
mbautin has accepted the revision [jira] [HBASE-4698] Let the HFile Pretty
Printer print all the key values for a specific row..
Looks good (a few very minor comments inline).
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71
Nit: it would be nice to
[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140369#comment-13140369
]
Phabricator commented on HBASE-4698:
mbautin has accepted the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140367#comment-13140367
]
ramkrishna.s.vasudevan commented on HBASE-4552:
---
@Jon
Yes.. i was
[
https://issues.apache.org/jira/browse/HBASE-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140371#comment-13140371
]
Eugene Koontz commented on HBASE-4690:
--
Thanks for the fix Ted; it looks good to me
Liyin updated the revision [jira] [HBASE-4698] Let the HFile Pretty Printer
print all the key values for a specific row..
Reviewers: mbautin, Kannan, jgray, gqchen, nspiegelberg, JIRA
Address Mikhail's Comments
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4698:
---
Attachment: D111.3.patch
Liyin updated the revision [jira] [HBASE-4698] Let the HFile Pretty Printer
nspiegelberg has commented on the revision [jira] [HBASE-4698] Let the HFile
Pretty Printer print all the key values for a specific row..
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137
I would remove this line. We should only print out
[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140377#comment-13140377
]
Phabricator commented on HBASE-4698:
nspiegelberg has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140386#comment-13140386
]
stack commented on HBASE-4680:
--
Reverting because of this discussion:
[
https://issues.apache.org/jira/browse/HBASE-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140388#comment-13140388
]
ramkrishna.s.vasudevan commented on HBASE-4649:
---
{code}
// were
[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack reopened HBASE-4680:
--
Reopening
FSUtils.isInSafeMode() checks should operate on HBase root dir, where we have
[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140391#comment-13140391
]
stack commented on HBASE-4680:
--
I reverted this change.
Revert safemode related pieces of hbase-4510
Key: HBASE-4708
URL: https://issues.apache.org/jira/browse/HBASE-4708
Project: HBase
Issue Type: Task
Reporter: stack
This thread in dev
[
https://issues.apache.org/jira/browse/HBASE-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4708:
-
Priority: Critical (was: Major)
Fix Version/s: 0.92.0
Marking critical against 0.92.
[
https://issues.apache.org/jira/browse/HBASE-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J reassigned HBASE-4708:
--
Assignee: Harsh J
Revert safemode related pieces of hbase-4510
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140401#comment-13140401
]
ramkrishna.s.vasudevan commented on HBASE-4669:
---
+1 on patch if tests
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4669:
--
Status: Open (was: Patch Available)
Add an option of using round-robin assignment for enabling table
[
https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140413#comment-13140413
]
Jesse Yates commented on HBASE-4336:
It _seems_ like the number of developed patches
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4669:
--
Attachment: (was: HBASE-4669-Trunk-V2.patch)
Add an option of using round-robin assignment for
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4669:
--
Attachment: HBASE-4669-Trunk-V2.patch
Add an option of using round-robin assignment for enabling table
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4669:
--
Status: Patch Available (was: Open)
Patch testing.
Add an option of using round-robin
[
https://issues.apache.org/jira/browse/HBASE-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4690:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
TRUNK build 2390 has passed.
Will open new
[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4680:
-
Priority: Major (was: Critical)
FSUtils.isInSafeMode() checks should operate on HBase root dir, where we
[
https://issues.apache.org/jira/browse/HBASE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140455#comment-13140455
]
Aravind Gottipati commented on HBASE-4298:
--
I haven't had the time to figure out
[
https://issues.apache.org/jira/browse/HBASE-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140463#comment-13140463
]
Ted Yu commented on HBASE-4532:
---
Looks like CHANGES.txt wasn't updated to include this JIRA.
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140503#comment-13140503
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140533#comment-13140533
]
Jonathan Hsieh commented on HBASE-4377:
---
Addressed most of stack's comments:
*
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140541#comment-13140541
]
Hadoop QA commented on HBASE-4669:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140546#comment-13140546
]
jirapos...@reviews.apache.org commented on HBASE-4377:
--
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140544#comment-13140544
]
Ted Yu commented on HBASE-4669:
---
The test failures were due to 'Too many open files'
[
https://issues.apache.org/jira/browse/HBASE-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140548#comment-13140548
]
John Sichi commented on HBASE-4611:
---
Marek has just checked in support for svn workflows
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140551#comment-13140551
]
Ted Yu commented on HBASE-4669:
---
Integrated to TRUNK.
Thanks for the patch Jieshan.
Thanks
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4669:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Add an
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140554#comment-13140554
]
jirapos...@reviews.apache.org commented on HBASE-4377:
--
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-4377:
--
Status: Open (was: Patch Available)
[hbck] Offline rebuild .META. from fs data only.
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-4377:
--
Status: Patch Available (was: Open)
[hbck] Offline rebuild .META. from fs data only.
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140560#comment-13140560
]
Hadoop QA commented on HBASE-4377:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-4377:
--
Attachment: (was: hbase-4377.0.90.v6.patch)
[hbck] Offline rebuild .META. from fs
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-4377:
--
Attachment: (was: hbase-4377.trunk.v6.patch)
[hbck] Offline rebuild .META. from fs
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-4377:
--
Attachment: hbase-4377.trunk.v6.patch
hbase-4377.0.90.v6.patch
Generated new
[
https://issues.apache.org/jira/browse/HBASE-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140584#comment-13140584
]
Hudson commented on HBASE-4552:
---
Integrated in HBase-TRUNK #2392 (See
[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140585#comment-13140585
]
Hudson commented on HBASE-4680:
---
Integrated in HBase-TRUNK #2392 (See
[
https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140601#comment-13140601
]
jirapos...@reviews.apache.org commented on HBASE-4120:
--
mbautin has commented on the revision [jira] [HBASE-4698] Let the HFile Pretty
Printer print all the key values for a specific row..
A few more comments -- coding style only.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70
Code style: add an empty
[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140628#comment-13140628
]
Phabricator commented on HBASE-4698:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4553:
-
Assignee: stack
Status: Patch Available (was: Open)
The update of .tableinfo is not atomic; we
[
https://issues.apache.org/jira/browse/HBASE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-4553:
-
Attachment: 3446-v8.txt
Change .tableinfo naming so its now .tableinfo.SEQUENCEID. The sequenceid
always rolls
Liyin has requested changes to the revision [jira] [HBASE-4686] [89-fb] Fix
per-store metrics aggregation
.
Thanks Mikhail for the patch.
There are some comments inline.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386
[code style] Please
[
https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140663#comment-13140663
]
Phabricator commented on HBASE-4686:
Liyin has requested changes to the revision
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140661#comment-13140661
]
Hadoop QA commented on HBASE-4377:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140666#comment-13140666
]
Hadoop QA commented on HBASE-4553:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140671#comment-13140671
]
Ted Yu commented on HBASE-4377:
---
The failed tests were due to 'Too many open files'.
[
https://issues.apache.org/jira/browse/HBASE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140679#comment-13140679
]
stack commented on HBASE-4553:
--
I need to put back the bit where .tableinfo is made in a tmp
Hadoop metrics2 setup in test MiniDFSClusters spewing JMX errors
Key: HBASE-4709
URL: https://issues.apache.org/jira/browse/HBASE-4709
Project: HBase
Issue Type: Bug
Liyin has commented on the revision [jira] [HBASE-4686] [89-fb] Fix per-store
metrics aggregation
.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386
Can you elaborate what the key and value in this tmpMap is in the javadoc?
It does no look
[
https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140686#comment-13140686
]
Phabricator commented on HBASE-4686:
Liyin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140688#comment-13140688
]
Hudson commented on HBASE-4669:
---
Integrated in HBase-TRUNK #2393 (See
Liyin has commented on the revision [jira] [HBASE-4698] Let the HFile Pretty
Printer print all the key values for a specific row..
Thanks Mikhail's and Nicolas's review and response the comments inline.
I will update the diff to address the comments.
INLINE COMMENTS
[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140699#comment-13140699
]
Phabricator commented on HBASE-4698:
Liyin has commented on the revision [jira]
mbautin has commented on the revision [jira] [HBASE-4686] [89-fb] Fix
per-store metrics aggregation
.
OK, this is now becoming a code style discussion, which is not a bad thing
once in a while :)
In general, the style guide for HBase seems to point to Oracle (former Sun)'s
coding
1 - 100 of 165 matches
Mail list logo
