[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-646439291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1925: HBASE-24591 get_table_rsgroup ignored the existence of rsgroup config…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1925: URL: https://github.com/apache/hbase/pull/1925#issuecomment-646438730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1925: HBASE-24591 get_table_rsgroup ignored the existence of rsgroup config…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1925: URL: https://github.com/apache/hbase/pull/1925#issuecomment-646437080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140201#comment-17140201 ] Duo Zhang commented on HBASE-24585: --- {quote} HBASE-19216 is where framework was flushed out. Will add

[jira] [Comment Edited] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140171#comment-17140171 ] Michael Stack edited comment on HBASE-23739 at 6/19/20, 4:01 AM: - bq.

[jira] [Commented] (HBASE-24577) Doc WALSplitter classes

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140181#comment-17140181 ] Hudson commented on HBASE-24577: Results for branch branch-2 [build #2710 on

[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140182#comment-17140182 ] Hudson commented on HBASE-24550: Results for branch branch-2 [build #2710 on

[jira] [Commented] (HBASE-24574) Procedure V2 - Distributed WAL Splitting => LOGGING

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140185#comment-17140185 ] Hudson commented on HBASE-24574: Results for branch branch-2 [build #2710 on

[jira] [Commented] (HBASE-24579) Failed SASL authentication does not result in an exception on client side

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140183#comment-17140183 ] Hudson commented on HBASE-24579: Results for branch branch-2 [build #2710 on

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140184#comment-17140184 ] Hudson commented on HBASE-24205: Results for branch branch-2 [build #2710 on

[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140171#comment-17140171 ] Michael Stack commented on HBASE-23739: --- bq. Ok. It use hbase admin to get table descriptor, so it

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-18 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r442613146 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -114,6 +120,14 @@ public boolean removeServer(Address

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140164#comment-17140164 ] Michael Stack commented on HBASE-24585: --- Issue is actually something else. Sorry for the

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140157#comment-17140157 ] Michael Stack commented on HBASE-24585: --- bq. Do we have any doc to explana this design? If not, we

[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-646409758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140153#comment-17140153 ] Michael Stack commented on HBASE-24585: --- I think we are doing the right thing after all... the

[GitHub] [hbase] Apache-HBase commented on pull request #1925: HBASE-24591 get_table_rsgroup ignored the existence of rsgroup config…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1925: URL: https://github.com/apache/hbase/pull/1925#issuecomment-646408584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-24591) get_table_rsgroup ignored the existence of rsgroup config for namespace

2020-06-18 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24591 started by Sun Xin. --- > get_table_rsgroup ignored the existence of rsgroup config for namespace >

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-646402962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-24586) Add table level locality in table.jsp

2020-06-18 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24586: --- Attachment: HBASE-24586-afterpatch.png HBASE-24586-beforepatch.png > Add table

[GitHub] [hbase] bsglz opened a new pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-06-18 Thread GitBox
bsglz opened a new pull request #1926: URL: https://github.com/apache/hbase/pull/1926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ddupg opened a new pull request #1925: HBASE-24591 get_table_rsgroup ignored the existence of rsgroup config…

2020-06-18 Thread GitBox
ddupg opened a new pull request #1925: URL: https://github.com/apache/hbase/pull/1925 … for namespace This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (HBASE-24591) get_table_rsgroup ignored the existence of rsgroup config for namespace

2020-06-18 Thread Sun Xin (Jira)
Sun Xin created HBASE-24591: --- Summary: get_table_rsgroup ignored the existence of rsgroup config for namespace Key: HBASE-24591 URL: https://issues.apache.org/jira/browse/HBASE-24591 Project: HBase

[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-18 Thread GitBox
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-646390645 Any updates here sir @saintstack ? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] infraio commented on a change in pull request #1916: HBASE-24546 CloneSnapshotProcedure unlimited retry

2020-06-18 Thread GitBox
infraio commented on a change in pull request #1916: URL: https://github.com/apache/hbase/pull/1916#discussion_r442589333 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java ## @@ -457,6 +457,10 @@ private void

[jira] [Created] (HBASE-24590) Clone snapshot with optional table level property overrides

2020-06-18 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24590: Summary: Clone snapshot with optional table level property overrides Key: HBASE-24590 URL: https://issues.apache.org/jira/browse/HBASE-24590 Project:

[GitHub] [hbase] mattf-apache edited a comment on pull request #1907: HBASE-24567 Create release should url-encode all characters when building git uri

2020-06-18 Thread GitBox
mattf-apache edited a comment on pull request #1907: URL: https://github.com/apache/hbase/pull/1907#issuecomment-646384044 Yes please, that’s the right id for me. Thanks! This is an automated message from the Apache Git

[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140091#comment-17140091 ] Hudson commented on HBASE-24550: Results for branch branch-2.3 [build #145 on

[GitHub] [hbase] mattf-apache commented on pull request #1907: HBASE-24567 Create release should url-encode all characters when building git uri

2020-06-18 Thread GitBox
mattf-apache commented on pull request #1907: URL: https://github.com/apache/hbase/pull/1907#issuecomment-646384044 Yes please, that’s the right id for me. Thanks! —Matt — Open Source Technologies @  On Jun 18, 2020, at 10:41 AM, Nick Dimiduk

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140087#comment-17140087 ] Guanghao Zhang commented on HBASE-24585: {quote}I think the design here is the task should not

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-646381262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24589) In HBase UI, srcChecksum has bad content

2020-06-18 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24589: -- Description: The value of srcChecksum displayed in the HBase UI is generated at build time

[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly

2020-06-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140086#comment-17140086 ] Guanghao Zhang commented on HBASE-23739: {quote}We try 18 times to get the descriptor from

[jira] [Created] (HBASE-24589) In HBase UI, srcChecksum has bad content

2020-06-18 Thread Matthew Foley (Jira)
Matthew Foley created HBASE-24589: - Summary: In HBase UI, srcChecksum has bad content Key: HBASE-24589 URL: https://issues.apache.org/jira/browse/HBASE-24589 Project: HBase Issue Type: Bug

[jira] [Created] (HBASE-24588) Normalizer plan execution is not consistent between plan types

2020-06-18 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24588: Summary: Normalizer plan execution is not consistent between plan types Key: HBASE-24588 URL: https://issues.apache.org/jira/browse/HBASE-24588 Project: HBase

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140056#comment-17140056 ] Michael Stack commented on HBASE-24585: --- Some more context. Here are exceptions before the ERROR

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-646348628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names

2020-06-18 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140048#comment-17140048 ] Clara Xiong commented on HBASE-23927: - Created and linked to the new jira.  > hbck2 assigns command

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140045#comment-17140045 ] Guanghao Zhang commented on HBASE-24205: +1 for branch-2.2. Thanks. > Create metric to know the

[jira] [Commented] (HBASE-24431) RSGroupInfo add configuration map to store something extra

2020-06-18 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140043#comment-17140043 ] Guanghao Zhang commented on HBASE-24431: Yes. Now we have two ideas which will base this. # Use

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1903: URL: https://github.com/apache/hbase/pull/1903#discussion_r442539030 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1166,7 +1166,11 @@ private void

[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140034#comment-17140034 ] Hudson commented on HBASE-24550: Results for branch branch-2.2 [build #896 on

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1903: URL: https://github.com/apache/hbase/pull/1903#discussion_r442538908 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1166,7 +1166,11 @@ private void

[jira] [Updated] (HBASE-24552) Replica region needs to do check if primary region exists in hdfs during createRegionOnFileSystem().

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24552: - Description: In hbase-1, it always runs into the situation that primary region has been

[GitHub] [hbase] huaxiangsun opened a new pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-18 Thread GitBox
huaxiangsun opened a new pull request #1924: URL: https://github.com/apache/hbase/pull/1924 … exists at file system in TransitRegionStateProcedure This is an automated message from the Apache Git Service. To respond to the

[jira] [Work started] (HBASE-24552) Replica region needs to check if primary region directory exists at file system in TransitRegionStateProcedure

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24552 started by Huaxiang Sun. > Replica region needs to check if primary region directory exists at file >

[jira] [Updated] (HBASE-24552) Replica region needs to dcheck if primary region exists in hdfs in TransitRegionStateProcedure

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24552: - Summary: Replica region needs to dcheck if primary region exists in hdfs in

[jira] [Updated] (HBASE-24552) Replica region needs to check if primary region directory exists at file system in TransitRegionStateProcedure

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24552: - Summary: Replica region needs to check if primary region directory exists at file system in

[jira] [Updated] (HBASE-24552) Replica region needs to check if primary region exists in hdfs in TransitRegionStateProcedure

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24552: - Summary: Replica region needs to check if primary region exists in hdfs in

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646324326 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646320692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139915#comment-17139915 ] Viraj Jasani commented on HBASE-24380: -- [~apurtell] Please take a look once, I believe this

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646222796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24580) Persist map of regions-to-last-flush-sequenceid across restarts

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139890#comment-17139890 ] Michael Stack commented on HBASE-24580: --- [~ndimiduk] notes this implemented already storing to a

[GitHub] [hbase] ndimiduk commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-18 Thread GitBox
ndimiduk commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-646219165 > I am not understanding this Apache pre-commit builds, why the build fails in first and succeeds in second attempt @mmpataki The precommit job runs in three stages: (1)

[GitHub] [hbase] ndimiduk commented on pull request #1907: HBASE-24567 Create release should url-encode all characters when building git uri

2020-06-18 Thread GitBox
ndimiduk commented on pull request #1907: URL: https://github.com/apache/hbase/pull/1907#issuecomment-646210245 @mattf-apache how about the info you have on your GitHub user name, so it would look like ``` Signed-off-by: Matt Foley ```

[GitHub] [hbase] ndimiduk commented on pull request #1907: HBASE-24567 Create release should url-encode all characters when building git uri

2020-06-18 Thread GitBox
ndimiduk commented on pull request #1907: URL: https://github.com/apache/hbase/pull/1907#issuecomment-646208452 @mattf-apache around these parts we include a `Signed-off-by` line in our commit messages to track reviewer participation. The line include a git identity, just like the

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646199416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442372173 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442371151 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442371151 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442371151 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646166681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
BukrosSzabolcs commented on a change in pull request #1903: URL: https://github.com/apache/hbase/pull/1903#discussion_r442364460 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1166,7 +1166,11 @@ private void

[GitHub] [hbase] ndimiduk commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-18 Thread GitBox
ndimiduk commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r442360729 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java ## @@ -114,4 +115,12 @@ static RSGroupInfoManager

[GitHub] [hbase] Apache-HBase commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-646147459 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24582) The current implementation of assignMetaReplicas() may assign replica meta regions to the same server hosting primary meta region.

2020-06-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139537#comment-17139537 ] Huaxiang Sun commented on HBASE-24582: -- Got it. > The current implementation of

[jira] [Commented] (HBASE-24431) RSGroupInfo add configuration map to store something extra

2020-06-18 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139532#comment-17139532 ] Nick Dimiduk commented on HBASE-24431: -- [~zghao] I haven't any experience with the rs group

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1903: URL: https://github.com/apache/hbase/pull/1903#discussion_r442350601 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java ## @@ -355,4 +362,58 @@ public void

[GitHub] [hbase] joshelser commented on pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…

2020-06-18 Thread GitBox
joshelser commented on pull request #1908: URL: https://github.com/apache/hbase/pull/1908#issuecomment-646136031 Oh, duh. This didn't go to `master` so my `Closes..` wouldn't work. Thanks Viraj! This is an automated message

[GitHub] [hbase] virajjasani commented on pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…

2020-06-18 Thread GitBox
virajjasani commented on pull request #1908: URL: https://github.com/apache/hbase/pull/1908#issuecomment-646135291 Closing the PR @joshelser :) Thanks This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] virajjasani closed pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…

2020-06-18 Thread GitBox
virajjasani closed pull request #1908: URL: https://github.com/apache/hbase/pull/1908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
huaxiangsun commented on a change in pull request #1903: URL: https://github.com/apache/hbase/pull/1903#discussion_r442343397 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1166,7 +1166,11 @@ private void

[GitHub] [hbase] virajjasani commented on a change in pull request #1901: HBASE-24560 Add a new option of designatedfile in RegionMover

2020-06-18 Thread GitBox
virajjasani commented on a change in pull request #1901: URL: https://github.com/apache/hbase/pull/1901#discussion_r442334986 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java ## @@ -435,6 +451,10 @@ public boolean unload() throws

[jira] [Resolved] (HBASE-24574) Procedure V2 - Distributed WAL Splitting => LOGGING

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24574. --- Fix Version/s: 2.3.1 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase-operator-tools] clarax closed pull request #68: HBASE-23927 hbck2 command should accept one or more files containing …

2020-06-18 Thread GitBox
clarax closed pull request #68: URL: https://github.com/apache/hbase-operator-tools/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase-operator-tools] clarax commented on pull request #68: HBASE-23927 hbck2 command should accept one or more files containing …

2020-06-18 Thread GitBox
clarax commented on pull request #68: URL: https://github.com/apache/hbase-operator-tools/pull/68#issuecomment-646115702 https://github.com/apache/hbase-operator-tools/pull/69 Created a new Jira and PR. This is an

[GitHub] [hbase-operator-tools] clarax opened a new pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …

2020-06-18 Thread GitBox
clarax opened a new pull request #69: URL: https://github.com/apache/hbase-operator-tools/pull/69 …a list of region names/table names/namespaces This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-24587) hbck2 command should accept one or more files containing a list of region names/table names/namespaces

2020-06-18 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-24587: Summary: hbck2 command should accept one or more files containing a list of region names/table

[jira] [Created] (HBASE-24587) hbck2 command should accept one or more files containing a list of region names

2020-06-18 Thread Clara Xiong (Jira)
Clara Xiong created HBASE-24587: --- Summary: hbck2 command should accept one or more files containing a list of region names Key: HBASE-24587 URL: https://issues.apache.org/jira/browse/HBASE-24587

[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names

2020-06-18 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-23927: Description: The interface is not very ergonomic. Currently the command accepts a list of region

[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names

2020-06-18 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-23927: Summary: hbck2 assigns command should accept one or more files containing a list of region names

[GitHub] [hbase] saintstack merged pull request #1912: HBASE-24574 Procedure V2 - Distributed WAL Splitting => LOGGING

2020-06-18 Thread GitBox
saintstack merged pull request #1912: URL: https://github.com/apache/hbase/pull/1912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24585) If RSProcedureHandler throws exception, it aborts the hosting RS

2020-06-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139493#comment-17139493 ] Michael Stack commented on HBASE-24585: --- Thanks for input [~zhangduo] Yeah, the main Handler

[GitHub] [hbase] virajjasani commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
virajjasani commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442303643 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void

[GitHub] [hbase] virajjasani commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-18 Thread GitBox
virajjasani commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r442300846 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SplitNormalizationPlan.java ## @@ -33,11 +36,9 @@ private static

[GitHub] [hbase] Apache-HBase commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-646072776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646027047 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-18 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139421#comment-17139421 ] ramkrishna.s.vasudevan commented on HBASE-24205: Pushed to master and branch-2. Thanks

[jira] [Updated] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-18 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-24205: --- Fix Version/s: (was: 2.2.6) > Create metric to know the number of reads

[GitHub] [hbase] ramkrish86 merged pull request #1920: HBASE-24205 - Create metric to know the number of reads that happens

2020-06-18 Thread GitBox
ramkrish86 merged pull request #1920: URL: https://github.com/apache/hbase/pull/1920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Reidddddd commented on a change in pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-18 Thread GitBox
Reidd commented on a change in pull request #1923: URL: https://github.com/apache/hbase/pull/1923#discussion_r442194628 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -230,7 +243,7 @@ public FSHLog(final FileSystem fs,

[GitHub] [hbase] Apache-HBase commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-645999641 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] BukrosSzabolcs commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-18 Thread GitBox
BukrosSzabolcs commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-645990655 @huaxiangsun About your last question. Well, yes, the test is not obvious. If you check the code you can see that setting a Procedure on the master replica node just

[GitHub] [hbase] Apache-HBase commented on pull request #1920: HBASE-24205 - Create metric to know the number of reads that happens

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1920: URL: https://github.com/apache/hbase/pull/1920#issuecomment-645989596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1920: HBASE-24205 - Create metric to know the number of reads that happens

2020-06-18 Thread GitBox
Apache-HBase commented on pull request #1920: URL: https://github.com/apache/hbase/pull/1920#issuecomment-645988715 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-18 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139376#comment-17139376 ] wenfeiyi666 commented on HBASE-24550: - no problem > Passing '-h' or '--help' to bin/hbase doesn't

[GitHub] [hbase] WenFeiYi opened a new pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-18 Thread GitBox
WenFeiYi opened a new pull request #1923: URL: https://github.com/apache/hbase/pull/1923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24518) waitForNamespaceOnline() should return false if any region is offline

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139371#comment-17139371 ] Hudson commented on HBASE-24518: Results for branch master [build #1760 on

[jira] [Commented] (HBASE-24577) Doc WALSplitter classes

2020-06-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139372#comment-17139372 ] Hudson commented on HBASE-24577: Results for branch master [build #1760 on

  1   2   >