[GitHub] [hbase] WenFeiYi commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-05 Thread GitBox
WenFeiYi commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-669711164 Irrelevant, these tests is unstable, sometimes succeeds sometimes fails. This is an automated message from the

[GitHub] [hbase] WenFeiYi commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-05 Thread GitBox
WenFeiYi commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-669711280 > Test fail related? Specially TestReplicationSyncUpToolWithMultipleWAL? Irrelevant, these tests is unstable, sometimes succeeds sometimes fails.

[GitHub] [hbase] WenFeiYi removed a comment on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-05 Thread GitBox
WenFeiYi removed a comment on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-669711164 Irrelevant, these tests is unstable, sometimes succeeds sometimes fails. This is an automated message

[GitHub] [hbase] busbey commented on pull request #2134: Cherry pick HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-08-05 Thread GitBox
busbey commented on pull request #2134: URL: https://github.com/apache/hbase/pull/2134#issuecomment-669699255 please make sure commit messages start their subject with the jira key This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669696044 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey commented on pull request #2133: Cherry pick HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-08-05 Thread GitBox
busbey commented on pull request #2133: URL: https://github.com/apache/hbase/pull/2133#issuecomment-669694800 please make sure commit messages start their subject with the jira key This is an automated message from the

[jira] [Updated] (HBASE-24713) RS startup with FSHLog throws NPE after HBASE-21751

2020-08-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24713: Fix Version/s: 2.4.0 > RS startup with FSHLog throws NPE after HBASE-21751 >

[GitHub] [hbase] busbey commented on pull request #2201: HBASE-24713 backport to branch-2

2020-08-05 Thread GitBox
busbey commented on pull request #2201: URL: https://github.com/apache/hbase/pull/2201#issuecomment-669688353 please make sure commit messages start their subject with the jira key This is an automated message from the

[GitHub] [hbase] anoopsjohn commented on pull request #2187: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-05 Thread GitBox
anoopsjohn commented on pull request #2187: URL: https://github.com/apache/hbase/pull/2187#issuecomment-669665084 Test fail related? Specially TestReplicationSyncUpToolWithMultipleWAL? This is an automated message from the

[GitHub] [hbase] anoopsjohn commented on pull request #2194: HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-08-05 Thread GitBox
anoopsjohn commented on pull request #2194: URL: https://github.com/apache/hbase/pull/2194#issuecomment-669665564 branch-1 also had issue with precommit QA. This is fixed now. Can u pls do a commit (new line or so) to trigger QA

[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-05 Thread GitBox
bsglz commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669657366 The remained checkstyle issue is unrelated to this PR. This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-24753) HA masters based on raft

2020-08-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171878#comment-17171878 ] Duo Zhang commented on HBASE-24753: --- {quote} Duo, my concern was not on avoid zk usage and all HM have

[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669653892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24753) HA masters based on raft

2020-08-05 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171877#comment-17171877 ] Anoop Sam John commented on HBASE-24753: Thanks Nick... Ya even what he mentioned also possible.

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669652966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669650583 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
bsglz commented on pull request #2179: URL: https://github.com/apache/hbase/pull/2179#issuecomment-669640919 Test failure on jdk11 seems unrelated to this PR. This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-24820) [hbase-thirdparty] Add jersey-hk2 when shading jersey and bump jetty to 9.4.31

2020-08-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24820: -- Summary: [hbase-thirdparty] Add jersey-hk2 when shading jersey and bump jetty to 9.4.31 (was:

[jira] [Commented] (HBASE-24753) HA masters based on raft

2020-08-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171864#comment-17171864 ] Duo Zhang commented on HBASE-24753: --- {quote} I believe Anoop Sam John's point is that today we can

[GitHub] [hbase] liuml07 commented on a change in pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
liuml07 commented on a change in pull request #2204: URL: https://github.com/apache/hbase/pull/2204#discussion_r466093040 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java ## @@ -271,7 +270,20 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2205: URL: https://github.com/apache/hbase/pull/2205#issuecomment-669616688 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] Apache-HBase commented on pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2205: URL: https://github.com/apache/hbase/pull/2205#issuecomment-669616450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2205: URL: https://github.com/apache/hbase/pull/2205#issuecomment-669615674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669614765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
huaxiangsun commented on pull request #2205: URL: https://github.com/apache/hbase/pull/2205#issuecomment-669607944 [ https://user-images.githubusercontent.com/62515050/89475969-442d8700-d73e-11ea-94e6-0d446b3510b6.png;> ](url)

[GitHub] [hbase] huaxiangsun commented on pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
huaxiangsun commented on pull request #2205: URL: https://github.com/apache/hbase/pull/2205#issuecomment-669607804 Attached is the Sample output from 2.3 (apply the same patch to 2.3.0) with read replica RandomReadTest, killing a region server process during the test. Newly added text are

[GitHub] [hbase] ndimiduk commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
ndimiduk commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r466070307 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -115,20 +129,50 @@ MasterRegistry(Configuration

[GitHub] [hbase] infraio commented on pull request #2199: HBASE-24819 Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetwe…

2020-08-05 Thread GitBox
infraio commented on pull request #2199: URL: https://github.com/apache/hbase/pull/2199#issuecomment-669606830 @saintstack Ping for reviewing. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] ndimiduk commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
ndimiduk commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r466069574 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -115,20 +129,50 @@ MasterRegistry(Configuration

[GitHub] [hbase] ndimiduk commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
ndimiduk commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r466069499 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -170,6 +214,11 @@ public static String

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669603384 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] sguggilam commented on a change in pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
sguggilam commented on a change in pull request #2204: URL: https://github.com/apache/hbase/pull/2204#discussion_r466065585 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java ## @@ -271,7 +270,20 @@ public void

[GitHub] [hbase] huaxiangsun opened a new pull request #2205: HBASE-24824 Add more stats in PE for read replica

2020-08-05 Thread GitBox
huaxiangsun opened a new pull request #2205: URL: https://github.com/apache/hbase/pull/2205 Currently, added read replica stats for RandomReadTest . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2203: HBASE-21905 (addendum): Address compaction races in TestFIFOCompactio…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2203: URL: https://github.com/apache/hbase/pull/2203#issuecomment-669602118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669601335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #1922: URL: https://github.com/apache/hbase/pull/1922#issuecomment-669588973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24821) Simplify the logic of getRegionInfo in TestFlushFromClient to reduce redundancy code

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171812#comment-17171812 ] Hudson commented on HBASE-24821: Results for branch branch-2.2 [build #926 on

[GitHub] [hbase] Apache-HBase commented on pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #1922: URL: https://github.com/apache/hbase/pull/1922#issuecomment-669584477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24753) HA masters based on raft

2020-08-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171807#comment-17171807 ] Nick Dimiduk commented on HBASE-24753: -- I believe [~anoop.hbase]'s point is that today we can clone

[GitHub] [hbase] liuml07 commented on a change in pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
liuml07 commented on a change in pull request #2204: URL: https://github.com/apache/hbase/pull/2204#discussion_r466046163 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java ## @@ -271,7 +270,20 @@ public void

[GitHub] [hbase] bharathv commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
bharathv commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r466035689 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -115,20 +129,50 @@ MasterRegistry(Configuration

[GitHub] [hbase] sguggilam commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
sguggilam commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669548350 Sample snapshot journal after the change: Table snapshot journal : Running FLUSH table snapshot test-snapshot C_M_SNAPSHOT_TABLE on table test at 1596660607606

[GitHub] [hbase] ndimiduk commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
ndimiduk commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r466021691 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -170,6 +214,11 @@ public static String

[GitHub] [hbase] Apache-HBase commented on pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2204: URL: https://github.com/apache/hbase/pull/2204#issuecomment-669525748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2198: URL: https://github.com/apache/hbase/pull/2198#issuecomment-669524398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-05 Thread GitBox
ndimiduk commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r465984755 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java ## @@ -200,70 +201,7 @@ public static ThreadPoolExecutor

[jira] [Commented] (HBASE-24554) Improve/stable read replica

2020-08-05 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171761#comment-17171761 ] Huaxiang Sun commented on HBASE-24554: -- Add PE stats to show how read replica perform. >

[jira] [Created] (HBASE-24824) Add more stats in PE for read replica

2020-08-05 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24824: Summary: Add more stats in PE for read replica Key: HBASE-24824 URL: https://issues.apache.org/jira/browse/HBASE-24824 Project: HBase Issue Type:

[GitHub] [hbase] sguggilam opened a new pull request #2204: HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp…

2020-08-05 Thread GitBox
sguggilam opened a new pull request #2204: URL: https://github.com/apache/hbase/pull/2204 …lit/merge/compact/flush transaction journals to master branch This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-24823) Port HBASE-22762 Print the delta between phases in the split/merge/compact/flush transaction journals to master branch

2020-08-05 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171750#comment-17171750 ] Sandeep Guggilam commented on HBASE-24823: -- FYI [~apurtell] > Port HBASE-22762 Print the delta

[jira] [Commented] (HBASE-24758) Avoid flooding replication source RSes logs when no sinks are available

2020-08-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171749#comment-17171749 ] Sean Busbey commented on HBASE-24758: - why didn't this go to branch-2.2? > Avoid flooding

[GitHub] [hbase] saintstack commented on pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
saintstack commented on pull request #2198: URL: https://github.com/apache/hbase/pull/2198#issuecomment-669501322 The failures seem unrelated (too many and the few I checked pass locally) This is an automated message from

[GitHub] [hbase] bharathv opened a new pull request #2203: HBASE-21905 (addendum): Address compaction races in TestFIFOCompactio…

2020-08-05 Thread GitBox
bharathv opened a new pull request #2203: URL: https://github.com/apache/hbase/pull/2203 …nPolicy Looped through the test 100 times and it passes. Without the patch it fails every ~10 runs or so. This is an

[GitHub] [hbase] saintstack commented on a change in pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
saintstack commented on a change in pull request #2198: URL: https://github.com/apache/hbase/pull/2198#discussion_r465995263 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/WALEntryFilter.java ## @@ -49,5 +47,5 @@ * @return a (possibly

[GitHub] [hbase] saintstack commented on a change in pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
saintstack commented on a change in pull request #2198: URL: https://github.com/apache/hbase/pull/2198#discussion_r465994744 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSource.java ## @@ -295,7 +356,40 @@ protected

[GitHub] [hbase] saintstack commented on a change in pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
saintstack commented on a change in pull request #2198: URL: https://github.com/apache/hbase/pull/2198#discussion_r465994449 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -194,30 +232,34 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #1922: URL: https://github.com/apache/hbase/pull/1922#issuecomment-669497061 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171746#comment-17171746 ] Michael Stack commented on HBASE-11288: --- Started baseline running branch-2 at place where you

[jira] [Commented] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171735#comment-17171735 ] Viraj Jasani commented on HBASE-24750: -- (y) > All executor service should start using guava

[jira] [Created] (HBASE-24823) Port HBASE-22762 Print the delta between phases in the split/merge/compact/flush transaction journals to master branch

2020-08-05 Thread Sandeep Guggilam (Jira)
Sandeep Guggilam created HBASE-24823: Summary: Port HBASE-22762 Print the delta between phases in the split/merge/compact/flush transaction journals to master branch Key: HBASE-24823 URL:

[jira] [Updated] (HBASE-24795) RegionMover should deal with unknown (split/merged) regions

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24795: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch

[jira] [Updated] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24750: - Fix Version/s: (was: 2.3.1) This is not a bug fix, so dropping 2.3.x from the target fix

[jira] [Updated] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24809: - Description: For HBase doc section "*HBase API Surface*", doc references for Apache Yetus

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171710#comment-17171710 ] Viraj Jasani commented on HBASE-24809: -- Sounds good, yeah these IA APIs are quite stable. Let me

[GitHub] [hbase] tedyu commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-05 Thread GitBox
tedyu commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r465946272 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedurePool.java ## @@ -62,10 +62,9 @@ public

[GitHub] [hbase] virajjasani commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-05 Thread GitBox
virajjasani commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r465928335 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollBackupSubprocedurePool.java ## @@ -62,10 +62,9 @@ public

[jira] [Commented] (HBASE-24754) Bulk load performance is degraded in HBase 2

2020-08-05 Thread Y. SREENIVASULU REDDY (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171658#comment-17171658 ] Y. SREENIVASULU REDDY commented on HBASE-24754: --- [~ram_krish] - After replacing the entire

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
anoopsjohn commented on a change in pull request #2198: URL: https://github.com/apache/hbase/pull/2198#discussion_r465907752 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -194,30 +232,34 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2192: Backport "HBASE-24662 Update DumpClusterStatusAction to notice changes in region server count" to branch-1

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2192: URL: https://github.com/apache/hbase/pull/2192#issuecomment-669331958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2179: URL: https://github.com/apache/hbase/pull/2179#issuecomment-669326589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2179: URL: https://github.com/apache/hbase/pull/2179#issuecomment-669318495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Reopened] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-08-05 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada reopened HBASE-21905: -- I figured there is another race that adds to the flakiness (usually happens once

[GitHub] [hbase] virajjasani commented on pull request #2192: Backport "HBASE-24662 Update DumpClusterStatusAction to notice changes in region server count" to branch-1

2020-08-05 Thread GitBox
virajjasani commented on pull request #2192: URL: https://github.com/apache/hbase/pull/2192#issuecomment-669316228 Let me re-trigger the build This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-669310988 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-669309528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #2197: HBASE-24807 Backport HBASE-20417 to branch-1

2020-08-05 Thread GitBox
bharathv commented on a change in pull request #2197: URL: https://github.com/apache/hbase/pull/2197#discussion_r465867164 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReaderThread.java ## @@ -132,6 +135,10 @@

[jira] [Commented] (HBASE-15222) Use less contended classes for metrics

2020-08-05 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171602#comment-17171602 ] Rushabh Shah commented on HBASE-15222: -- [~eclark] Could you please share the benchmarking tool you

[GitHub] [hbase] virajjasani commented on a change in pull request #2198: HBASE-24817 Allow configuring WALEntry filters on ReplicationSource

2020-08-05 Thread GitBox
virajjasani commented on a change in pull request #2198: URL: https://github.com/apache/hbase/pull/2198#discussion_r465794580 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSource.java ## @@ -295,7 +356,40 @@ protected

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-669212936 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HBASE-24808) skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException)

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171523#comment-17171523 ] Hudson commented on HBASE-24808: Results for branch master [build #1804 on

[jira] [Commented] (HBASE-15519) Add per-user metrics

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171522#comment-17171522 ] Hudson commented on HBASE-15519: Results for branch master [build #1804 on

[jira] [Commented] (HBASE-24795) RegionMover should deal with unknown (split/merged) regions

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171520#comment-17171520 ] Hudson commented on HBASE-24795: Results for branch master [build #1804 on

[jira] [Commented] (HBASE-24767) Change default to false for HBASE-15519 per-user metrics

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171521#comment-17171521 ] Hudson commented on HBASE-24767: Results for branch master [build #1804 on

[jira] [Commented] (HBASE-24795) RegionMover should deal with unknown (split/merged) regions

2020-08-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171559#comment-17171559 ] Hudson commented on HBASE-24795: Results for branch branch-2.3 [build #200 on

[GitHub] [hbase] bsglz commented on a change in pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
bsglz commented on a change in pull request #2179: URL: https://github.com/apache/hbase/pull/2179#discussion_r465747344 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ## @@ -302,6 +302,13 @@ */ CompletableFuture flush(TableName

[GitHub] [hbase] bsglz commented on a change in pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
bsglz commented on a change in pull request #2179: URL: https://github.com/apache/hbase/pull/2179#discussion_r465747166 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -513,6 +513,15 @@ default void modifyColumnFamily(TableName

[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669207083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil commented on a change in pull request #2179: HBASE-24694 Support flush a single column family of table

2020-08-05 Thread GitBox
wchevreuil commented on a change in pull request #2179: URL: https://github.com/apache/hbase/pull/2179#discussion_r465735191 ## File path: hbase-shell/src/main/ruby/shell/commands/flush.rb ## @@ -25,10 +25,11 @@ def help Flush all regions in passed table or pass a region row

[jira] [Commented] (HBASE-24821) Simplify the logic of getRegionInfo in TestFlushFromClient to reduce redundancy code

2020-08-05 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171555#comment-17171555 ] Zheng Wang commented on HBASE-24821: Thanks. [~vjasani] > Simplify the logic of getRegionInfo in

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-669234775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24821) Simplify the logic of getRegionInfo in TestFlushFromClient to reduce redundancy code

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24821. -- Fix Version/s: 2.2.7 2.4.0 2.3.1

[jira] [Commented] (HBASE-24821) Simplify the logic of getRegionInfo in TestFlushFromClient to reduce redundancy code

2020-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171541#comment-17171541 ] Viraj Jasani commented on HBASE-24821: -- Merged changes to master, branch-2, 2.3, 2.2. Thanks for

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-669229281 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 316 |

[GitHub] [hbase] virajjasani closed pull request #2200: HBASE-24821 simplify the logic of getRegionInfo in TestFlushFromClien…

2020-08-05 Thread GitBox
virajjasani closed pull request #2200: URL: https://github.com/apache/hbase/pull/2200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24713) RS startup with FSHLog throws NPE after HBASE-21751

2020-08-05 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171493#comment-17171493 ] ramkrishna.s.vasudevan commented on HBASE-24713: Pushed to branch-2 also. > RS startup

[GitHub] [hbase] ramkrish86 merged pull request #2201: HBASE-24713 backport to branch-2

2020-08-05 Thread GitBox
ramkrish86 merged pull request #2201: URL: https://github.com/apache/hbase/pull/2201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171489#comment-17171489 ] Duo Zhang commented on HBASE-11288: --- Waiting for your good news. > Splittable Meta > ---

[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-05 Thread GitBox
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669170851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
virajjasani commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r465695297 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -115,20 +132,49 @@ MasterRegistry(Configuration

[GitHub] [hbase] virajjasani commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-05 Thread GitBox
virajjasani commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r465693339 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java ## @@ -126,4 +131,46 @@ public void testRegistryRPCs()

  1   2   >