[GitHub] [hbase] ramkrish86 commented on pull request #2663: HBASE-24637 - Reseek regression related to filter SKIP hinting

2020-12-09 Thread GitBox
ramkrish86 commented on pull request #2663: URL: https://github.com/apache/hbase/pull/2663#issuecomment-742334015 @infraio I have updated the PR with a new config 'hbase.switchto.next.bytes.read' . It defaults to preadMaxBytes though. also if you configure this value to be < 0 then we

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-12-09 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247063#comment-17247063 ] Viraj Jasani commented on HBASE-25329: -- [~caroliney14] If you could create PRs including backport

[jira] [Commented] (HBASE-22404) Open/Close region request may be executed twice when master restart

2020-12-09 Thread Sanjeet Nishad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247055#comment-17247055 ] Sanjeet Nishad commented on HBASE-22404: Hi [~zhangduo] & [~zghao], we are using HBase-2.2.3.

[jira] [Updated] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-12-09 Thread Caroline (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-25329: - Attachment: HBASE-25329.branch-1.000.patch HBASE-25329.branch-2.000.patch

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-742287290 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-742284543 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2753: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2753: URL: https://github.com/apache/hbase/pull/2753#issuecomment-742273859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2753: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2020-12-09 Thread GitBox
saintstack commented on pull request #2753: URL: https://github.com/apache/hbase/pull/2753#issuecomment-742254863 Failure seems unrelated. Rerunning anyways while Huaxiang sleeps. This is an automated message from the Apache

[GitHub] [hbase] saintstack commented on a change in pull request #2753: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2020-12-09 Thread GitBox
saintstack commented on a change in pull request #2753: URL: https://github.com/apache/hbase/pull/2753#discussion_r539859613 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -363,7 +363,23 @@ static TableName getTable(final byte []

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742245463 Tried upping the vagrantfile ubuntu... removed the old image first. vagrant@rmvm:~$ more /etc/issue Ubuntu 20.04.1 LTS \n \l vagrant@rmvm:~$ gpg --sign

[jira] [Commented] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247006#comment-17247006 ] Pankaj Kumar commented on HBASE-25378: -- Np [~ram_krish], yeah it's better to handle in 

[jira] [Commented] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247005#comment-17247005 ] Pankaj Kumar commented on HBASE-25378: -- [~anoop.hbase]  I've verified in my local env,  2.2.3

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-742213897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25346) hbase2.x the performance is lower than hbase 1.x ?

2020-12-09 Thread nilonealex (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246984#comment-17246984 ] nilonealex commented on HBASE-25346: [^test_for_randomWrite.log] > hbase2.x the performance is

[jira] [Updated] (HBASE-25346) hbase2.x the performance is lower than hbase 1.x ?

2020-12-09 Thread nilonealex (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nilonealex updated HBASE-25346: --- Attachment: test_for_randomWrite.log > hbase2.x the performance is lower than hbase 1.x ? >

[jira] [Commented] (HBASE-25372) Fix typo in ban-jersey section of the enforcer plugin in pom.xml

2020-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246980#comment-17246980 ] Hudson commented on HBASE-25372: Results for branch branch-2.4 [build #5 on

[GitHub] [hbase] Apache-HBase commented on pull request #2760: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2760: URL: https://github.com/apache/hbase/pull/2760#issuecomment-742198364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2759: HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2759: URL: https://github.com/apache/hbase/pull/2759#issuecomment-742188057 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742179447 On Mac its $ gpg --version gpg (GnuPG) 2.2.25 Trying later ubuntu... This is an automated message

[GitHub] [hbase] huaxiangsun commented on pull request #2759: HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

2020-12-09 Thread GitBox
huaxiangsun commented on pull request #2759: URL: https://github.com/apache/hbase/pull/2759#issuecomment-742178536 checking the client error at my local machine now. This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-742177170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-742167846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25376) [create-release] Fix double .asc

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25376: -- Fix Version/s: 3.0.0-alpha-1 > [create-release] Fix double .asc >

[jira] [Resolved] (HBASE-25376) [create-release] Fix double .asc

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25376. --- Hadoop Flags: Reviewed Resolution: Fixed Merge. Thanks for review [~apurtell] >

[jira] [Resolved] (HBASE-25380) [create-release] Add timestamping to log output

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25380. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Assignee: Michael Stack

[GitHub] [hbase] saintstack merged pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
saintstack merged pull request #2758: URL: https://github.com/apache/hbase/pull/2758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
saintstack commented on pull request #2758: URL: https://github.com/apache/hbase/pull/2758#issuecomment-742160868 Signed-off-by: Andrew Purtell This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] saintstack commented on pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
saintstack commented on pull request #2758: URL: https://github.com/apache/hbase/pull/2758#issuecomment-742160489 Thanks @apurtell This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742159172 Head's up though -- if the issue here is indeed gpg agent version mismatch, create-release in docker mode will have the same problems because it's also using an ubuntu bionic

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742157507 I think this project has bit-rot since I used it last (which has been several months). My current best guess is that gpg version miss-match is preventing agent forwarding to

[GitHub] [hbase] Apache-HBase commented on pull request #2759: HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2759: URL: https://github.com/apache/hbase/pull/2759#issuecomment-742153293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2760: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2760: URL: https://github.com/apache/hbase/pull/2760#issuecomment-742153201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun opened a new pull request #2760: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
huaxiangsun opened a new pull request #2760: URL: https://github.com/apache/hbase/pull/2760 …haning from meta replica to non-meta-replica at the server side. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742136556 Ok. Sorted out the virtualbox and vagrant stuff... Thats all good. Just stuck now on the gpg secret passing bit (Nick has been helping me out offline).

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-742131236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25356 started by Huaxiang Sun. > HBaseAdmin#getRegion() needs to filter out non-regionName and >

[jira] [Work started] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25368 started by Huaxiang Sun. > Filter out more invalid encoded name in isEncodedRegionName(byte[] >

[GitHub] [hbase] Apache-HBase commented on pull request #2759: HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2759: URL: https://github.com/apache/hbase/pull/2759#issuecomment-742106469 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742105721 Build fails for me because no gpg key in vagrant env... $ gpg --sign repos/hbase/pom.xml gpg: no default secret key: No secret key gpg: signing failed: No secret

[GitHub] [hbase] huaxiangsun opened a new pull request #2759: HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

2020-12-09 Thread GitBox
huaxiangsun opened a new pull request #2759: URL: https://github.com/apache/hbase/pull/2759 … and non-encodedRegionName This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25356: - Affects Version/s: (was: 1.6.0) > HBaseAdmin#getRegion() needs to filter out non-regionName

[jira] [Updated] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25356: - Description: I was running shell command to major compact meta table. The implementation is

[jira] [Updated] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25356: - Summary: HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

[jira] [Updated] (HBASE-25356) shell command major_compact misbehave for hbase:meta

2020-12-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-25356: - Description: I was running shell command to major compact meta table. The implementation is

[GitHub] [hbase] Apache-HBase commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-742065444 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on pull request #2745: [HBASE-25246] Backup/Restore hbase cell tags.

2020-12-09 Thread GitBox
shahrs87 commented on pull request #2745: URL: https://github.com/apache/hbase/pull/2745#issuecomment-742036969 Thank you @anoopsjohn and @virajjasani for your offline help. Could you guys please review the changes. Thank you !

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2753: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

2020-12-09 Thread GitBox
huaxiangsun commented on a change in pull request #2753: URL: https://github.com/apache/hbase/pull/2753#discussion_r539631859 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java ## @@ -116,6 +130,8 @@ public void testCompactionTimestamps()

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742029557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742029108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742028698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742027391 On another host (my build machine as it happens), it seems to just work. Trying test build... Looked like this when I logged in... ``` $ vagrant ssh Welcome

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742024258 Oh, one other idea: sometimes VirtualBox gets stuck in such a way that the only way to resolve it is by launching it's GUI and clicking through whatever error messages it

[GitHub] [hbase] saintstack merged pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
saintstack merged pull request #2755: URL: https://github.com/apache/hbase/pull/2755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-742022909 VirtualBox is really painful to use. It doesn't help that Vagrant and VirtualBox don't always update together. If it helps at all, the vm is working for my with this version

[jira] [Assigned] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar reassigned HBASE-19352: Assignee: Pankaj Kumar (was: Esteban Gutierrez) > Port HADOOP-10379: Protect

[jira] [Assigned] (HBASE-19352) Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar reassigned HBASE-19352: Assignee: Esteban Gutierrez (was: Pankaj Kumar) > Port HADOOP-10379: Protect

[jira] [Resolved] (HBASE-25362) Quoting in hbase-vote script fails build with empty ""

2020-12-09 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York resolved HBASE-25362. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Quoting in

[GitHub] [hbase] saintstack commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
saintstack commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-741997273 FYI @ndimiduk ``` $ vagrant up Bringing machine 'rmvm' up with 'virtualbox' provider... ==> rmvm: Checking if box 'ubuntu/bionic64' version '20201207.0.0' is up

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-741985767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-09 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246745#comment-17246745 ] Andrew Kyle Purtell commented on HBASE-25277: - +1 Please merge to all branch-2.x. This is a

[GitHub] [hbase] apurtell commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
apurtell commented on pull request #2755: URL: https://github.com/apache/hbase/pull/2755#issuecomment-741970436 Ah and that's how my manual invocation messed up too, I did "mvn clean install deploy" (sigh) This is an

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2020-12-09 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-741959562 > Anyway, if you think this is useful then let's try it. It's been useful for me. I don't know if it's useful to other release managers. I don't want to add unused code to

[jira] [Commented] (HBASE-25363) Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize

2020-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246729#comment-17246729 ] Hudson commented on HBASE-25363: Results for branch branch-2 [build #125 on

[jira] [Commented] (HBASE-25277) postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246730#comment-17246730 ] Hudson commented on HBASE-25277: Results for branch branch-2 [build #125 on

[jira] [Commented] (HBASE-25328) Add builder method to create Tags.

2020-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246728#comment-17246728 ] Hudson commented on HBASE-25328: Results for branch branch-2 [build #125 on

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-741950171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-741946178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25328) Add builder method to create Tags.

2020-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246699#comment-17246699 ] Hudson commented on HBASE-25328: Results for branch branch-2.3 [build #122 on

[GitHub] [hbase] Apache-HBase commented on pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2756: URL: https://github.com/apache/hbase/pull/2756#issuecomment-741916198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun merged pull request #2726: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
huaxiangsun merged pull request #2726: URL: https://github.com/apache/hbase/pull/2726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246683#comment-17246683 ] ramkrishna.s.vasudevan commented on HBASE-25378: Ya Pankaj. Sorry even I missed this

[GitHub] [hbase] huaxiangsun commented on pull request #2726: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
huaxiangsun commented on pull request #2726: URL: https://github.com/apache/hbase/pull/2726#issuecomment-741912765 Thanks Stack for review, pushing the changes. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2726: HBASE-25293 Followup jira to address the client handling issue when c…

2020-12-09 Thread GitBox
huaxiangsun commented on a change in pull request #2726: URL: https://github.com/apache/hbase/pull/2726#discussion_r539488382 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -262,16 +261,16 @@ private

[GitHub] [hbase] saintstack commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
saintstack commented on pull request #2755: URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904830 @apurtell One liner now. No need of install target when you call deploy. See JIRA for 'proof' change works. #2758 has the logging+README change.

[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2755: URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2755: URL: https://github.com/apache/hbase/pull/2755#issuecomment-741904191 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2748: HBASE-25373 Remove HTrace completely in code base and try to make use…

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2748: URL: https://github.com/apache/hbase/pull/2748#issuecomment-741901367 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2758: URL: https://github.com/apache/hbase/pull/2758#issuecomment-741901165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2758: URL: https://github.com/apache/hbase/pull/2758#issuecomment-741900775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2758: URL: https://github.com/apache/hbase/pull/2758#issuecomment-741900659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246669#comment-17246669 ] Pankaj Kumar edited comment on HBASE-25378 at 12/9/20, 4:49 PM: Thanks

[jira] [Commented] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246669#comment-17246669 ] Pankaj Kumar commented on HBASE-25378: -- Yeah I missed 

[GitHub] [hbase] saintstack opened a new pull request #2758: HBASE-25380 [create-release] Add timestamping to log output

2020-12-09 Thread GitBox
saintstack opened a new pull request #2758: URL: https://github.com/apache/hbase/pull/2758 Added logging of timestamp so we can tell where we are spending time. Added context to the README copied from head of entrance script.

[jira] [Created] (HBASE-25380) [create-release] Add timestamping to log output

2020-12-09 Thread Michael Stack (Jira)
Michael Stack created HBASE-25380: - Summary: [create-release] Add timestamping to log output Key: HBASE-25380 URL: https://issues.apache.org/jira/browse/HBASE-25380 Project: HBase Issue

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread GitBox
pankaj72981 commented on a change in pull request #2756: URL: https://github.com/apache/hbase/pull/2756#discussion_r539468971 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java ## @@ -612,6 +612,8 @@ private String

[jira] [Commented] (HBASE-25376) [create-release] Fix double .asc

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246658#comment-17246658 ] Michael Stack commented on HBASE-25376: --- !Screen Shot 2020-12-09 at 8.24.56 AM.png!   This

[GitHub] [hbase] saintstack commented on pull request #2755: HBASE-25376 [create-release] Fix double .asc

2020-12-09 Thread GitBox
saintstack commented on pull request #2755: URL: https://github.com/apache/hbase/pull/2755#issuecomment-741892699 bq. 99% of the changes are out of scope for the fix? np This is an automated message from the Apache

[jira] [Updated] (HBASE-25376) [create-release] Fix double .asc

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25376: -- Attachment: Screen Shot 2020-12-09 at 8.24.56 AM.png > [create-release] Fix double .asc >

[jira] [Updated] (HBASE-25376) [create-release] Fix double .asc

2020-12-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25376: -- Attachment: Screen Shot 2020-12-09 at 8.24.07 AM.png > [create-release] Fix double .asc >

[jira] [Commented] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246648#comment-17246648 ] Anoop Sam John commented on HBASE-25378: At first thought its a data compatibility break issue.

[GitHub] [hbase] Apache-HBase commented on pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2756: URL: https://github.com/apache/hbase/pull/2756#issuecomment-741883535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25378: - Description: HBASE-24968 moved MetaCellComparator out from CellComparatorImpl to avoid the

[jira] [Updated] (HBASE-25378) Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-25378: --- Fix Version/s: 2.3.4 2.4.0 > Legacy comparator in Hfile trailer will

[GitHub] [hbase] Apache-HBase commented on pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2757: URL: https://github.com/apache/hbase/pull/2757#issuecomment-741860359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread GitBox
virajjasani commented on a change in pull request #2756: URL: https://github.com/apache/hbase/pull/2756#discussion_r539393476 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java ## @@ -612,6 +612,8 @@ private String

[jira] [Updated] (HBASE-25379) Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25379: - Fix Version/s: 3.0.0-alpha-1 Status: Patch Available (was: Open) > Make intial

[GitHub] [hbase] pankaj72981 opened a new pull request #2757: HBASE-25379 Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread GitBox
pankaj72981 opened a new pull request #2757: URL: https://github.com/apache/hbase/pull/2757 Added "hbase.rpc.shortoperation.pause.time" for initial pause for reportRegionStateTransition. This is an automated message from

[jira] [Created] (HBASE-25379) Make intial pause time configurable for regionserver while sending reportRegionStateTransition

2020-12-09 Thread Pankaj Kumar (Jira)
Pankaj Kumar created HBASE-25379: Summary: Make intial pause time configurable for regionserver while sending reportRegionStateTransition Key: HBASE-25379 URL: https://issues.apache.org/jira/browse/HBASE-25379

[jira] [Commented] (HBASE-25373) Remove HTrace completely in code base and try to make use of OpenTelemetry

2020-12-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246555#comment-17246555 ] Duo Zhang commented on HBASE-25373: --- After learning the docs of open-telemetry-java and

[GitHub] [hbase] Apache-HBase commented on pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

2020-12-09 Thread GitBox
Apache-HBase commented on pull request #2756: URL: https://github.com/apache/hbase/pull/2756#issuecomment-741794200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >