[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132563#comment-14132563
]
Hudson commented on HBASE-11805:
FAILURE: Integrated in HBase-0.98 #516 (See
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132592#comment-14132592
]
Hudson commented on HBASE-11805:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #491
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132239#comment-14132239
]
Andrew Purtell commented on HBASE-11805:
Is the addendum patch the revert? Can we
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132503#comment-14132503
]
Anoop Sam John commented on HBASE-11805:
Agree Andy. I have reverted the old
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132545#comment-14132545
]
Hudson commented on HBASE-11805:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #490
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128176#comment-14128176
]
Lars Hofhansl commented on HBASE-11805:
---
+1 on reverting this from 0.98 and adding
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129507#comment-14129507
]
Anoop Sam John commented on HBASE-11805:
Ping [~apurtell] . Can you review pls so
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126692#comment-14126692
]
Lars Hofhansl commented on HBASE-11805:
---
Looks like this potentially breaks Phoenix
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126701#comment-14126701
]
Lars Hofhansl commented on HBASE-11805:
---
Tried with 0.98 current build compared to
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126727#comment-14126727
]
Anoop Sam John commented on HBASE-11805:
Checking this [~lhofhansl]
Looks strange
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126739#comment-14126739
]
Anoop Sam John commented on HBASE-11805:
Reading the Phoenix code, I think I got
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127247#comment-14127247
]
Anoop Sam John commented on HBASE-11805:
I logged PHOENIX-1245 to handle the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127459#comment-14127459
]
Andrew Purtell commented on HBASE-11805:
bq. now as we return a new ArrayList
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128006#comment-14128006
]
Lars Hofhansl commented on HBASE-11805:
---
Yeah, that seems like a (implicit albeit)
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128017#comment-14128017
]
Anoop Sam John commented on HBASE-11805:
Even though it is a bit ugly way to deal
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128022#comment-14128022
]
Lars Hofhansl commented on HBASE-11805:
---
It's fine to return a KV as a KV is a
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128031#comment-14128031
]
Anoop Sam John commented on HBASE-11805:
As part of this change I changed the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128032#comment-14128032
]
ramkrishna.s.vasudevan commented on HBASE-11805:
I think we could
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128040#comment-14128040
]
Anoop Sam John commented on HBASE-11805:
In 0.99+ we have removed the old KV
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124878#comment-14124878
]
Hudson commented on HBASE-11805:
FAILURE: Integrated in HBase-0.98 #502 (See
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124886#comment-14124886
]
Hudson commented on HBASE-11805:
SUCCESS: Integrated in HBase-1.0 #160 (See
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124892#comment-14124892
]
Hudson commented on HBASE-11805:
FAILURE: Integrated in HBase-TRUNK #5475 (See
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124895#comment-14124895
]
Hudson commented on HBASE-11805:
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #476
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124406#comment-14124406
]
Anoop Sam John commented on HBASE-11805:
[~apurtell]
{code}
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124422#comment-14124422
]
Hadoop QA commented on HBASE-11805:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124543#comment-14124543
]
stack commented on HBASE-11805:
---
+1 on re-skim. Looks safe.
KeyValue to Cell Convert in
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122491#comment-14122491
]
ramkrishna.s.vasudevan commented on HBASE-11805:
bq.That is why the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121195#comment-14121195
]
Hadoop QA commented on HBASE-11805:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122039#comment-14122039
]
Andrew Purtell commented on HBASE-11805:
Looks good, except this:
{code}
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122453#comment-14122453
]
ramkrishna.s.vasudevan commented on HBASE-11805:
There are codes like
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122481#comment-14122481
]
Anoop Sam John commented on HBASE-11805:
My bad. I missed reading that code.
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119994#comment-14119994
]
Anoop Sam John commented on HBASE-11805:
Thanks Stack.
{quote}
{code}
Do we have
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120074#comment-14120074
]
stack commented on HBASE-11805:
---
Sounds reasonable. +1
KeyValue to Cell Convert in
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120475#comment-14120475
]
Hadoop QA commented on HBASE-11805:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118543#comment-14118543
]
Anoop Sam John commented on HBASE-11805:
[~enis] I would like to see this into
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118734#comment-14118734
]
Hadoop QA commented on HBASE-11805:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119067#comment-14119067
]
Enis Soztutar commented on HBASE-11805:
---
bq. I would like to see this into 0.99.0
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119294#comment-14119294
]
Anoop Sam John commented on HBASE-11805:
Thanks [~enis]. Pls have a look at the
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119368#comment-14119368
]
stack commented on HBASE-11805:
---
Do we have to do the below?
- for (KeyValue kv :
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117010#comment-14117010
]
Anoop Sam John commented on HBASE-11805:
Patch is ready with me but depends on
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110845#comment-14110845
]
stack commented on HBASE-11805:
---
You are right. heapsize != length. Need to add comment to
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110914#comment-14110914
]
ramkrishna.s.vasudevan commented on HBASE-11805:
Cells having
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110917#comment-14110917
]
ramkrishna.s.vasudevan commented on HBASE-11805:
Can we atleast implement
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110988#comment-14110988
]
stack commented on HBASE-11805:
---
What would length mean? If its prefix encoded or
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108974#comment-14108974
]
Anoop Sam John commented on HBASE-11805:
WALEdit implements HeapSize, and as Cell
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109009#comment-14109009
]
ramkrishna.s.vasudevan commented on HBASE-11805:
bq.In almost all other
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109023#comment-14109023
]
Anoop Sam John commented on HBASE-11805:
I mean in the Exposed APIs/Interfaces we
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110290#comment-14110290
]
stack commented on HBASE-11805:
---
bq. WALEdit implements HeapSize, and as Cell is not having
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110306#comment-14110306
]
ramkrishna.s.vasudevan commented on HBASE-11805:
bq.This is low-priority
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110307#comment-14110307
]
Anoop Sam John commented on HBASE-11805:
bq.Man. Its a pity. Cell is all getters.
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110310#comment-14110310
]
stack commented on HBASE-11805:
---
Agree.
We need the setter don't we?
KeyValue to Cell
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110312#comment-14110312
]
Anoop Sam John commented on HBASE-11805:
bq.CellUtil does heap size?
[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110318#comment-14110318
]
Anoop Sam John commented on HBASE-11805:
bq.We need the setter don't we?
Yes but
53 matches
Mail list logo
