[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1670#comment-1670
]
Hudson commented on HBASE-13346:
SUCCESS: Integrated in Jenkins build HBase-2.0 #754 (See
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1632#comment-1632
]
Hudson commented on HBASE-13346:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3954 (See
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221738#comment-16221738
]
Anoop Sam John commented on HBASE-13346:
+1. QA seems fine.
> Clean up Filter package for post
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221623#comment-16221623
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221332#comment-16221332
]
stack commented on HBASE-13346:
---
Appreciating the enthusiasm mighty [~elserj] Was figuring no harm in a
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221288#comment-16221288
]
Josh Elser commented on HBASE-13346:
Looks like TestScannersFromClientSide2 failed abnormally (time
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221267#comment-16221267
]
Tamas Penzes commented on HBASE-13346:
--
submitted version 12 to test, still has issues on my machine
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221226#comment-16221226
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219458#comment-16219458
]
Tamas Penzes commented on HBASE-13346:
--
hi [~openinx],
fixed. Also other places where I've added
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218835#comment-16218835
]
Zheng Hu commented on HBASE-13346:
--
We need to add *throws IOException* for filterKeyValue/filterCell in
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218778#comment-16218778
]
Tamas Penzes commented on HBASE-13346:
--
rebased, fix where it was needed
> Clean up Filter package
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218595#comment-16218595
]
Tamas Penzes commented on HBASE-13346:
--
HBASE-18410 merged, I start rebasing this now.
> Clean up
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217876#comment-16217876
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217511#comment-16217511
]
Tamas Penzes commented on HBASE-13346:
--
Rebased and FilterWrapper moved.
> Clean up Filter package
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217412#comment-16217412
]
Anoop Sam John commented on HBASE-13346:
Same package name. But the file to be moved from
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217387#comment-16217387
]
Tamas Penzes commented on HBASE-13346:
--
As I see, I can move the FilterWrapper tomorrow. Which
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215868#comment-16215868
]
stack commented on HBASE-13346:
---
Agree this goes in after HBASE-18410 merge. If [~tamaas] has no time, I
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208798#comment-16208798
]
Anoop Sam John commented on HBASE-13346:
Patch V8 LGTM.
FilterWrapper also non exposed private
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208682#comment-16208682
]
Mike Drob commented on HBASE-13346:
---
Skimmed it, patch makes sense and looks fine to me. Do we need to
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208310#comment-16208310
]
Josh Elser commented on HBASE-13346:
Looks like this one is ready to go? Any outstanding concerns
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206763#comment-16206763
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204389#comment-16204389
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203460#comment-16203460
]
Zheng Hu commented on HBASE-13346:
--
Do we need to wait util branch HBASE-18410 merged into master branch
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202704#comment-16202704
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199069#comment-16199069
]
stack commented on HBASE-13346:
---
Porting +1 from rb.
Chatting w/ [~psomogyi] , he suggests a rebase is
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195333#comment-16195333
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194964#comment-16194964
]
Tamas Penzes commented on HBASE-13346:
--
Thanks guys for the help, fixed the issue.
Now it looks like
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194391#comment-16194391
]
Abhishek Singh Chouhan commented on HBASE-13346:
Glanced at the patch. This might be
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192482#comment-16192482
]
Anoop Sam John commented on HBASE-13346:
Pls see test failures. Looks like there is some never
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192335#comment-16192335
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192191#comment-16192191
]
Tamas Penzes commented on HBASE-13346:
--
New patch created after carefully considered
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175269#comment-16175269
]
stack commented on HBASE-13346:
---
I just read HBASE-18797 My review was done BEFORE I read HBASE-18797 (In
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174783#comment-16174783
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174489#comment-16174489
]
Anoop Sam John commented on HBASE-13346:
Filter.java
Why new filterCell method missing from
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174282#comment-16174282
]
stack commented on HBASE-13346:
---
Some feedback on the patch [~tamaas]
You have filterCell calling
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170973#comment-16170973
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168722#comment-16168722
]
Hadoop QA commented on HBASE-13346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168476#comment-16168476
]
Tamas Penzes commented on HBASE-13346:
--
Second patch fixes backward compatibility issues. Should
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167894#comment-16167894
]
Hadoop QA commented on HBASE-13346:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167815#comment-16167815
]
Tamas Penzes commented on HBASE-13346:
--
[~abhishek.chouhan] You are right, my fault that I haven't
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167750#comment-16167750
]
Abhishek Singh Chouhan commented on HBASE-13346:
[~tamaas] There are a lot of references
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167688#comment-16167688
]
Tamas Penzes commented on HBASE-13346:
--
I don't see a reason to add a subtask which covers basically
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161470#comment-16161470
]
Anoop Sam John commented on HBASE-13346:
Sure.. Pls work on the patch when u have some time.
[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161246#comment-16161246
]
Abhishek Singh Chouhan commented on HBASE-13346:
Can probably start off by deprecating
44 matches
Mail list logo
