[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218712#comment-15218712
]
stack commented on HBASE-15265:
---
There I go asking for same stuff again... Thanks for filing HBASE-15536.
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217228#comment-15217228
]
Duo Zhang commented on HBASE-15265:
---
{quote}
File issue to make this the default?
{quote}
I have
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216662#comment-15216662
]
stack commented on HBASE-15265:
---
It took me a while but a 2B run on 9-node cluster passes with this enabled
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212976#comment-15212976
]
Hudson commented on HBASE-15265:
FAILURE: Integrated in HBase-Trunk_matrix #810 (See
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212780#comment-15212780
]
stack commented on HBASE-15265:
---
Go for it. In another issue we can work out if we should make it default.
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212675#comment-15212675
]
Duo Zhang commented on HBASE-15265:
---
The failing tests are unrelated. Can fix the checkstyle issue when
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212193#comment-15212193
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211675#comment-15211675
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210112#comment-15210112
]
Duo Zhang commented on HBASE-15265:
---
[~stack] This time we stopped at TestHFile...Let's wait for the
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210090#comment-15210090
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207967#comment-15207967
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207800#comment-15207800
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207562#comment-15207562
]
Duo Zhang commented on HBASE-15265:
---
Seems not related?
I do not change the default WAL implementation.
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206949#comment-15206949
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206376#comment-15206376
]
stack commented on HBASE-15265:
---
I owe you work testing this patch. We could file a blocker JIRA for the
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206231#comment-15206231
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206192#comment-15206192
]
Duo Zhang commented on HBASE-15265:
---
[~stack] Seems the timeout is gone. What's next?
> Implement an
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206134#comment-15206134
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205791#comment-15205791
]
stack commented on HBASE-15265:
---
Sorry [~Apache9] My cluster got reimaged so got set back a little (all for
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195263#comment-15195263
]
stack commented on HBASE-15265:
---
[~Apache9] none. I am trying to test it on a cluster before commit. If I
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195243#comment-15195243
]
Duo Zhang commented on HBASE-15265:
---
[~stack] Any other concerns on the v7 patch? Thanks.
> Implement
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195236#comment-15195236
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193616#comment-15193616
]
stack commented on HBASE-15265:
---
DLR never worked and is now deprecated and to be removed (HBASE-15020).
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193073#comment-15193073
]
Yu Li commented on HBASE-15265:
---
I see, thanks for the clarification. We're using DLS so I'm not familiar
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193023#comment-15193023
]
Yu Li commented on HBASE-15265:
---
Got your point, and I think these are two different ways of categorizing
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192848#comment-15192848
]
Duo Zhang commented on HBASE-15265:
---
{quote}
At a glance of HBASE-14949 and comments there, it seems
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192838#comment-15192838
]
Duo Zhang commented on HBASE-15265:
---
I mean that, the {{RegionGroupingProvider}} is an algorithm that
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192699#comment-15192699
]
Yu Li commented on HBASE-15265:
---
[~Apache9]
Good progress and great work sir!
bq. I think multiwal should
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192689#comment-15192689
]
Duo Zhang commented on HBASE-15265:
---
Seems there are some jobs that could run normally?
See this
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192681#comment-15192681
]
stack commented on HBASE-15265:
---
I think we've run into this before:
{code}
[0m[91mERROR: Error
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192676#comment-15192676
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192319#comment-15192319
]
Duo Zhang commented on HBASE-15265:
---
OK... Still failing... Will retry tomorrow...
> Implement an
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192318#comment-15192318
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192294#comment-15192294
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192292#comment-15192292
]
Duo Zhang commented on HBASE-15265:
---
{quote}
Would this be tough to put on branch-1?
{quote}
Not that
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190830#comment-15190830
]
Duo Zhang commented on HBASE-15265:
---
{quote}
Now asyncfs also coming in. So how to setup a WAL system
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190510#comment-15190510
]
Anoop Sam John commented on HBASE-15265:
{code}
* Configure which provider gets used with the
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190460#comment-15190460
]
stack commented on HBASE-15265:
---
ok
> Implement an asynchronous FSHLog
>
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190311#comment-15190311
]
Duo Zhang commented on HBASE-15265:
---
{quote}
On the name, yeah, default is 'filesystem' but next one is
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190162#comment-15190162
]
stack commented on HBASE-15265:
---
Though, I wish we could get an ITBLL run in that showed it basically
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190139#comment-15190139
]
stack commented on HBASE-15265:
---
Ok. Finished a review. I didn't go too deep. Looks good to me. +1.
How
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188835#comment-15188835
]
Duo Zhang commented on HBASE-15265:
---
{quote}
Why is this option called asyncfs and not something like
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188824#comment-15188824
]
Duo Zhang commented on HBASE-15265:
---
[~stack]
{code}
LOG.info("Instantiating WALProvider of type " +
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188788#comment-15188788
]
stack commented on HBASE-15265:
---
Would this be tough to put on branch-1 [~Apache9]? Would be good to get
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188782#comment-15188782
]
stack commented on HBASE-15265:
---
Needs a release note when you get a chance [~Apache9]
Why is this option
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184645#comment-15184645
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184500#comment-15184500
]
Duo Zhang commented on HBASE-15265:
---
Run WALPE with 5 threads
{noformat}
./bin/hbase
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184446#comment-15184446
]
stack commented on HBASE-15265:
---
Excellent.
I owe review and a run of ITBLL up on cluster to see that all
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184421#comment-15184421
]
Duo Zhang commented on HBASE-15265:
---
[~stack] I have run a WALPE on a 5 node cluster.
On master branch
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175224#comment-15175224
]
stack commented on HBASE-15265:
---
[~Apache9] Over on your /tmp patch, I see all jdk7 tests timed out... and
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175169#comment-15175169
]
Duo Zhang commented on HBASE-15265:
---
Fine, let me see why jdk8 is still failing.
> Implement an
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175165#comment-15175165
]
stack commented on HBASE-15265:
---
We should make this the default in master branch if it works.
> Implement
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175164#comment-15175164
]
stack commented on HBASE-15265:
---
Was waiting for tests to pass. It looks like just jdk8 that is failing?
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175142#comment-15175142
]
Duo Zhang commented on HBASE-15265:
---
[~stack] What do you think of the newest patch? Thanks.
>
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173350#comment-15173350
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172166#comment-15172166
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171886#comment-15171886
]
Duo Zhang commented on HBASE-15265:
---
The retry logic does not handle all the cases...
Let me fix it...
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171790#comment-15171790
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170633#comment-15170633
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169327#comment-15169327
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166739#comment-15166739
]
Hadoop QA commented on HBASE-15265:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155351#comment-15155351
]
Duo Zhang commented on HBASE-15265:
---
{quote}
The way you describe it, current WAL implementation could
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154485#comment-15154485
]
stack commented on HBASE-15265:
---
If creation is fail-fast, is presumption that we go try create again...
[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153676#comment-15153676
]
Duo Zhang commented on HBASE-15265:
---
There are two problems here, so the comments of this test file.
64 matches
Mail list logo
